1
0
mirror of synced 2026-01-08 12:01:53 -05:00
Commit Graph

237 Commits

Author SHA1 Message Date
Robert Mosolgo
aeedfac37e Add graphql tests to CI, move snapshots to fixures, use mockdate 2020-11-25 11:12:13 -05:00
Jason Etcovitch
1ec8c35e34 Refactor indented_data_reference to use Liquid internals (#16623)
* Refactor indented-data-reference

* Add spacing around referenced reusables

* Update expected test output

* Fail silently with empty valuer
2020-11-24 16:50:20 -05:00
Sarah Schneider
18d25f6129 update references to old helpers.js 2020-11-24 15:42:11 -05:00
Sarah Schneider
3121eae634 move tests/helpers.js into subdir and rename 2020-11-24 15:41:38 -05:00
Sarah Schneider
6662e027b0 let, not const and one more regex tweak 2020-11-23 13:04:11 -05:00
Sarah Schneider
10c7ba7855 include full content including frontmatter, and tweak some regexes 2020-11-23 12:51:15 -05:00
Robert Mosolgo
b87ca3b3e3 Fix lint errors 2020-11-23 08:55:05 -05:00
Robert Mosolgo
2400be9528 Merge branch 'main' into build-changelog 2020-11-23 08:44:32 -05:00
Robert Mosolgo
ab06aadf82 Add changelog creation to update-files.js 2020-11-23 08:42:12 -05:00
Robert Mosolgo
f2119bc619 Add a test for updating the changelog file on disk 2020-11-23 08:17:57 -05:00
Robert Mosolgo
360c517a7d Add upcoming changes to build-changelog 2020-11-23 08:08:00 -05:00
Robert Mosolgo
9d5af1f98d Create preview changes entries 2020-11-23 07:15:22 -05:00
Robert Mosolgo
96e4ea9499 Set up tests, start formatting messages 2020-11-20 17:02:21 -05:00
Kevin Heis
912ac50034 End AB test on moving helpfulness prompt to bottom (#16552)
* End AB test on moving helpfulness prompt to bottom

* Move helpfulness to bottom of page only

* Update helpfulness.js

Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2020-11-20 12:24:33 -08:00
Jason Etcovitch
cc719ffb6f Render Enterprise release notes on docs.github.com (#16367)
* Create basic layout

* Create stubbed out release note YAML

* Get a real implementation going

* Simplify using site-data

* Add a real page to send from render-page.js

* Use array of patches

* Render patches

* Add sidebar and breadcrumbs

* Reverse order

* Add date

* Tweak labels

* Redirect to entweb for missing versions

* Render patch.intro

* Move to separate files for patches

* Show support for RC versions

* Improve some comments

* Sticky headers!

* Remove a console log

* Improve example formatting

* Add a link on /admin

* Add a schema and test

* Move to /index.md, add version_num filter

* Improve layout

* Use <details>

* Placeholder more realistic notes

* Don't require links in index pages

* Remove admin/index link for now

* Remove unused frontmatter field

* Add a test for middleware

* Fix remaining YAML file to test CI

* Update 2-rc.yml

* Don't call it RC

* Just push

* Make a main a div

* Fix a borked class

* Lint YAML files

* Improve Download link

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>

* Improve check order

* Move to contextualizers

* Use alternative version thing

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>

* Move back to `release-notes.md`

* Use version for anchor IDs

* Undo category-pages test change

* Fix borked details layout in Chrome

* Improve mobile setup

* Render markdown in note tags

* Use allVersions[currentVersion] again

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>

* Undo change to extended-markdown

* Add whitespace so it renders markdown bits

* Remove 2-22 files

* Add check for any release notes

* Fix the failing tests

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>
2020-11-20 13:33:11 -05:00
Jason Etcovitch
52dbd92144 Rewrite links in Page.intro with language (#16550)
* Add defaultLanguage behavior

* Add a million logs because I'm confused

* Rewrite intro links

* Undo changes to detect-language

* Add a test
2020-11-19 15:53:35 -05:00
Sarah Schneider
0c3a46f205 update asset path for <2.13 CSS files 2020-11-18 12:53:39 -05:00
Sarah Schneider
84f0aac8f6 Merge branch 'main' of github.com:github/docs-internal into deprecate-2.19 2020-11-17 21:20:38 -05:00
James M. Greene
d402a60833 Merge branch 'main' into hidden-docs-alt 2020-11-17 17:56:25 -06:00
Jason Etcovitch
8f2b4eb450 Merge branch 'main' into repo-sync 2020-11-17 18:02:58 -05:00
James M. Greene
72d1265ebc Fix lint-files tests for Early Access to use newly established pattern 2020-11-17 16:30:08 -06:00
James M. Greene
b04f01d890 Ignore early-access as a product for the category-pages tests? 2020-11-17 16:22:44 -06:00
James M. Greene
1280f6f06c Fix rendering tests for /early-access 2020-11-17 16:18:54 -06:00
Sarah Schneider
a3559e12bd remove test that should have been removed in #16490 2020-11-17 16:34:20 -05:00
Nick Schonning
b6de7c6887 chore: Convert Standard to eslint-config-standard (#1328)
* chore: Move standard to ESLint config

* fix: auto-fix ESLint indent issues

* fix: ESLint prefer-regex-literals

* fix: ESLint array-callback-return

- .filter must return a boolean value
- .map replaced with forEach when the value isn't used

* fix: ESLint no-extra-semi
2020-11-17 16:18:18 -05:00
Kevin Heis
890e86cc46 Merge branch 'main' into hidden-docs-alt 2020-11-17 09:58:45 -08:00
James M. Greene
04dff854c2 Include other actions-only EA-cloning tests now 2020-11-17 11:50:18 -06:00
Sarah Schneider
8bb7120185 lint 2020-11-17 11:45:18 -05:00
Sarah Schneider
bed7ecc890 Update tests/routing/deprecated-enterprise-versions.js
Co-authored-by: Jason Etcovitch <jasonetco@github.com>
2020-11-17 11:37:54 -05:00
James M. Greene
a53255c8c9 Add tests for site-data-references within article metadata 2020-11-17 09:56:21 -06:00
James M. Greene
5c6f5bb351 Fix site-data-references tests by using uniqWith instead of uniqBy 2020-11-17 09:55:34 -06:00
Sarah Schneider
a895ef68ba update tests 2020-11-16 20:07:04 -05:00
Sarah Schneider
a8f16c63f7 Do not include feedback links in deprecated GHES versions (#16485)
* do not render if this is the oldest supported GHES release

* add tests
2020-11-16 17:09:19 -05:00
Kevin Heis
dd02bfa007 Merge main 2020-11-16 10:07:53 -08:00
Kevin Heis
714ca0263b Add hostname to events (#16419)
...so that its easier to filter out localhost and herokuapp domains
2020-11-16 09:49:12 -08:00
James M. Greene
510a0e3871 Add test to verify Early Access does not show up as a product in the sidebar 2020-11-13 15:48:10 -06:00
James M. Greene
272c4722d2 Add new content-linting tests for Early Access 2020-11-13 13:40:25 -06:00
jmarlena
45398e709c Password authentication and OAuth Authorizations API deprecation (#16375)
* Version password examples for GHES only

* Remove unnecessary note

* Versioned deprecation reusable for GHES only?

* Update troubleshooting article

* Version OAuthorizations REST API page for enterprise-only

* Remove deprecations reusable

* Add tentative note

* Rework two-factor authentication sections

* Fix double redirect reference

* versioning tweak

* Versioning tweaks

* adding back the endifs

* random link reformatting

* OAuth Authorization API versioned for 2.22

* /

* Fix internal docs links

* remove static redirect for dotcom

* Try deleting redirect

* Apply @martin389's suggested changes

Co-authored-by: Martin Lopes <54248166+martin389@users.noreply.github.com>

* Remove best practice assumptions

* Apply suggestions from code review

Co-authored-by: Martin Lopes <54248166+martin389@users.noreply.github.com>

* Add note

* restore redirects in content file and remove free-pro-team expected path from test fixture

* change note position

* handle path that was available on dotcom in developer site but is now GHES only

Co-authored-by: Martin Lopes <54248166+martin389@users.noreply.github.com>
Co-authored-by: Sarah Schneider <sarahs@github.com>
2020-11-13 11:01:17 -08:00
Sarah Schneider
5705d334ca Header notification updates (#16425)
* remove middleware that sets notification flags

* move all notification handling into includes/header-notification.html

* update tests
2020-11-12 16:27:29 -05:00
Jason Etcovitch
9e38a854b9 Filterable code examples on Actions landing page (#16276)
* Add custom hover shadows

* Support avatars

* Add guide-card include

* Use it in product-landing

* Add gradient styles

* Add guides frontmatter

* Use guideArticles instead of full objects

* Add support for authors

* Add support for category header

* Just pass the whole page

* Use it

* guide.url => guide.href

* Use `*.githubusercontent.com`

* Fix mobile card width

* Remove showDescription check

* Use featureLinks.guideCards

* Forgot an if

* Add contextualizers/actions-code-examples

* Use code-example-card include

* Tweak sizing/shadows

* Add a basic filterer

* Some visual tweaks

* labels => tags

* Cleanup some code

* Improve spacing on mobile

* Add "No results!" blurb

* Fix a boog

* Tweak spacing

* Remove support banner

* Improve "No results" state

* Just use login instead of name/avatarUrl

* Change card spacing

* Use circular avatars

* Add "Show more" button

* Add margin beneath "Guides"

* Use smaller font

* Assume github.com for code examples

* Show two columns at small screen

* Make "Show more" a btn

* Use the "repo" octicon

* Link to contributing guide

* Use a YAML file instead of a middleware

* Link straight to the file

* Fix some wonky markuip

* Fix a broken link

* Fix the borked test

* Allow variables that aren't strings

* Fix remaining tests
2020-11-12 11:35:43 -05:00
James M. Greene
b75cb104c2 Make Early Access tests only run on the docs-internal repo 2020-11-10 15:25:18 -06:00
James M. Greene
3e0d94ec91 Fix pathing on CrowdIn config tests 2020-11-09 23:05:42 -06:00
James M. Greene
4fac3decec Comment out premature tests 2020-11-09 23:04:24 -06:00
James M. Greene
e1f3f6457e Merge branch 'main' into hidden-docs-alt 2020-11-09 13:09:52 -06:00
James M. Greene
f410fd175c Mostly reverting github/docs-internal#15313 2020-11-09 13:07:04 -06:00
Sarah Schneider
dfb29cfb59 Remove no longer needed middleware (#16384)
* remove no longer needed middleware

* remove accompanying test
2020-11-06 14:14:28 -05:00
Nick Schonning
87e8d1b4b0 chore: Remove locales from docs.microsoft.com urls (#1011) 2020-11-04 14:43:27 -08:00
Sarah Schneider
c4b50183a2 update docs path in newly added robots test 2020-11-03 17:17:43 -05:00
Sarah Schneider
0cf94f26b7 Merge branch 'main' of https://github.com/github/docs-internal into hidden-docs-alt 2020-11-03 17:09:22 -05:00
Sarah Schneider
ba310bf991 Support GHAE in Algolia (#16315)
* add frontend search support for GHAE version

* add support for GHAE version to Algolia sync

* add browser tests for frontend search

* if a version can be derived from a path, but it is not a real version (like from a path that 404s), fall back to dotcom

* Update javascripts/search.js

* Update lib/algolia/sync.js
2020-11-03 15:35:56 -05:00