1
0
mirror of synced 2025-12-30 12:02:01 -05:00
Commit Graph

462 Commits

Author SHA1 Message Date
Rachael Sewell
e8acff555c refactor the enabled for apps page component (#29253) 2022-07-26 18:14:50 +00:00
Rachael Sewell
425e052816 remove nested markdown component (#29250) 2022-07-26 18:08:05 +00:00
Kevin Heis
bb3cb78dd1 Move events under api (#29298) 2022-07-26 18:00:58 +00:00
Peter Bengtsson
b1226676e7 Picker sends just the selected value (#29191) 2022-07-19 18:06:55 -04:00
Peter Bengtsson
8d1f41633a prevent whitespace-only searches (#29075) 2022-07-15 19:10:10 +00:00
Peter Bengtsson
08ffe45da7 add debounced search query string without anchor (#29073)
add debounched search query string without anchor
2022-07-15 18:41:14 +00:00
Peter Bengtsson
a37f023f40 search body for setting-up-your-project-for-codespaces (#29038) 2022-07-14 16:40:45 +00:00
Peter Bengtsson
37d3bded04 simplify Table of Contents (#28833)
* simplify table-of-contents

* key

* fix rendering tests

* Not so much top margin

* Map topic ToC links are spans

* use p tag

* Back to span for the article title

* Update comment to match markup

* remove hack

* use h2 instead

* fix tests

* fix use of key

* use regular className instead

Co-authored-by: Robert Sese <734194+rsese@users.noreply.github.com>
2022-07-14 14:28:41 +00:00
Rachael Sewell
26e4dbc4bf refactor rest context provider to be generic (#29021) 2022-07-14 14:09:38 +00:00
Peter Bengtsson
3a3cf7dd28 Home page has header accessibility order problem (#29022) 2022-07-14 13:55:06 +00:00
Grace Park
97212c5114 Fix reactions and search large rest pages (#29012)
* fix reactions and search large rest pages

* remove white space at the end
2022-07-13 21:08:21 +00:00
Hector Alfaro
fbf03bc2e6 Merge branch 'main' into repo-sync 2022-07-13 15:58:40 -04:00
Robert Sese
c9870c5418 Add 'About versions' link to search version dropdown (#29005)
* Add 'About versions' to search versions dropdown

* Fix search result list markup
2022-07-13 17:58:10 +00:00
Courtney Wilson
6071c0e5d9 Merge branch 'main' into patch-5 2022-07-12 19:53:26 -04:00
Kevin Heis
396c77f497 Update python.tsx 2022-07-12 07:57:12 -07:00
Grace Park
822fe2926b Megabranch: Upgrade primer/react (#28458)
* upgrade primer/react

* upgrade

* using deprecated

* remove lib"

* Upgrade primer/react: Upgrade Label (#28502)

update Label to primer/react 35.2.2

* fix merge conflicts

* primer/react v35: update ActionList (#28467)

* Update to v35 ActionList for LearningTrack

* Update to v35 ActionList for ArticleList

* Update to v35 ActionList for ProductArticleList

* Update to v35 ActionList for TableOfContents

* Update to v35 ActionList for ProductCollapsibleSection

* Update to v35 ActionList for RestCollapsibleSection

* Update to v35 ActionList for SidebarHomepage

* Update to v35 ActionList for MiniTocs

* Update to v35 ActionList for Search

* Extra div for rendering test

* One less div for rendering test

* All the style updates for v35 ActionList

* Works without setting as an li which is already the default (didn't before for some reason)

* Use deprecated ItemInput for now

* Picker update for primer/react (#28485)

* update picker

* inline picker for mobile

* set width to auto

* Update components/ui/Picker/Picker.tsx

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

* update

* Update Picker.tsx

* update onselect

* checking language code

* move language cookie setting to language picker

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

* Resolve package merge conflicts

* fresh npm install

* Primer update UnderlineNav (#28582)

* update underlinenav for primer/react update

* update tests

* update switches test

* update one last label

* update header test"

* remove href in underlinenav

* update rendering tests

* update cursor

* primer/react v35: update DropDownMenu to ActionMenu (#28576)

* Update to v35 ActionMenu for ArticleCards

* Update to v35 ActionMenu for Search

* Set button to inline-block

* Put the props on the overlay

* Update test for ActionMenu markup

* update package

* update package lock

* primer/react v35: CodeLanguagePicker update from SelectMenu to ActionMenu (#28625)

* Use octicon for menu down arrow

* Update to v35 ActionMenu for CodeLanguagePicker

* update to SubNav

Co-authored-by: Grace Park <gracepark@github.com>

* update package-lock

Co-authored-by: Robert Sese <734194+rsese@users.noreply.github.com>
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2022-07-11 11:51:18 -07:00
Paras
dfd4ad7183 kbd shortcuts updated 2022-07-04 03:26:53 -07:00
Tim Rogers
037d6328b8 Recommend an Accept header without V3 in it when documenting our REST API operations (#28477)
* Recommend an `Accept` header for REST API requests which doesn't mention V3

In the documentation for every REST API, in the "Headers"
section, we say for the `Accept` header that:

> Setting to `application/vnd.github.v3+json` is recommended.

Putting the V3 bit in doesn't actually do anything - in fact,
a high proportion of API consumers don't do it - and this
recommendation is going to be confusing once we launch our
new API versioning. This recommends that people use
`application/vnd.gitrhub+json` instead.

We could just recommend `application/json` - I'd be in favour
of that! - but I'm trying to make this change as small as
possible.

* Update cURL and GitHub CLI code examples to use an `Accept` header without V3

Co-authored-by: Sarah Edwards <skedwards88@github.com>
2022-06-29 15:50:07 +00:00
Peter Bengtsson
67dc3ac7cd remove need for styled-jsx construct (#28749)
* remove need for styled-jsx construct

* remove line that might not be needed
2022-06-28 11:53:35 +00:00
Peter Bengtsson
538566aebd remove js-print button GAHE release notes (#28745) 2022-06-27 13:04:49 -04:00
Mike Surowiec
20d10a8b80 fix: guides layout cards collapsing (#28570) 2022-06-16 18:39:38 +00:00
Peter Bengtsson
2f37efd633 minimize content in miniToc prop (#28522)
* make miniToc pure data and no html strings

* fixups

* minimize content in miniToc prop

* minimize content in miniToc prop

* some types refactoring

* fix tests
2022-06-15 21:04:54 +00:00
Peter Bengtsson
071c95a91c make miniToc pure data and no html strings (#28517)
* make miniToc pure data and no html strings

* fixups

* some types refactoring
2022-06-15 18:31:36 +00:00
Rachael Sewell
e15a73aaf5 rest default values for false not rendering (#28451) 2022-06-13 17:01:21 +00:00
Rachael Sewell
dd6e60242b add token to curl examples (#28357) 2022-06-09 15:36:57 +00:00
Grace Park
3a88ec5f1f Add curl -h authorization header to REST API Code Samples (#28332)
* add curl -h authorization header

* move to get-rest-code-samples
2022-06-08 20:06:48 +00:00
Robert Sese
748f2a1d0b Fix header overlap on release notes pages (#28202)
Apply class so we get the scroll-margin-top
2022-06-03 18:32:27 +00:00
Robert Sese
2339bef120 Don't skip code term wrapping with single anchor child (#28175)
Wrap for single anchor child
2022-06-02 16:56:55 +00:00
Peter Bengtsson
8e27bbac9a Remove contribution component from mobile temporarily (#27866)
* Remove contribution component from mobile temporarily

* Update components/page-footer/Contribution.tsx

Co-authored-by: Grace Park <gracepark@github.com>

* cleanup

Co-authored-by: Grace Park <gracepark@github.com>
2022-05-27 14:20:34 +00:00
Hector Alfaro
9b7d04edc6 Merge branch 'main' into hectorsector/consolidate-tool-picker 2022-05-25 10:04:58 -04:00
Peter Bengtsson
5b6852dffb rest reference pages should have body and lead in sync search (#27961)
* rest reference pages should have body and lead in sync-search

* tests passing
2022-05-24 16:10:03 -04:00
Peter Bengtsson
070ac1b823 fix more shorthand eslint warnings (#27952) 2022-05-24 13:23:11 -04:00
Hector Alfaro
4b27213cc6 Merge branch 'main' into hectorsector/consolidate-tool-picker 2022-05-24 11:01:46 -04:00
Hector Alfaro
91778790d8 clean up and comment tool picker stuff 2022-05-24 10:40:46 -04:00
Matt Pollard
ab1f8b0ee2 First responder bug fixes for 2022-05-20 (#27875) 2022-05-23 15:41:33 +00:00
Hector Alfaro
3b825a46d2 pull out tools from page.js and ToolPicker component 2022-05-23 10:48:49 -04:00
Peter Bengtsson
18504871b9 cache full rendering (#25424)
* cache full rendering

* still not working with gzip

* progress progress progress

* smaller

* hacky progress

* small fixes

* wip

* lock file

* wip

* wip

* package-lock updates

* wip

* search DOM in lowercase

* simplify

* with instrument

* improve test coverage

* mutateCheeriobodyByRequest

* fix

* remove renderContentCacheByContex

* disable render caching in sync-search

* diables things in github/github link checker

* gzip lru

* tidying up

* updated

* correct tests

* fix: move userLanguage to LanguagesContext

* Revert "fix: move userLanguage to LanguagesContext"

This reverts commit d7c05d958c71eaad496eb46764eb845d80b866ca.

* contexts ftw

* fixed rendering tests

* oops for got new file

* nits addressed

Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
2022-05-23 12:12:09 +00:00
Robert Sese
bd660da728 Show entire (long) mini-tocs (#27878)
* Show entire long mini-tocs

* Nudge top position

Co-authored-by: Joe Oak <41307427+joeoak@users.noreply.github.com>

* Use 'calc()` for max-height

Co-authored-by: Joe Oak <41307427+joeoak@users.noreply.github.com>

Co-authored-by: Joe Oak <41307427+joeoak@users.noreply.github.com>
2022-05-20 23:17:42 +00:00
Grace Park
10fea98af5 Search updates larger font (#27838)
* removing search from home page and adding to header

* remove homepage search

* adding description

* update to f5

* remove homepage search test

* removing homepage search rendering test

* showing preview of larger font

* update wording at breakpoint

* update to short description everywhere

* Update components/homepage/HomePageHero.tsx

Co-authored-by: Joe Oak <41307427+joeoak@users.noreply.github.com>

* remove unnecessary stylesheet

* Update data/ui.yml

Co-authored-by: Janice <janiceilene@github.com>

Co-authored-by: Joe Oak <41307427+joeoak@users.noreply.github.com>
Co-authored-by: Janice <janiceilene@github.com>
2022-05-20 12:12:36 -07:00
Peter Bengtsson
a8d45acea9 refactor getThemeProps to be available in JS (#27439)
* refactor getThemeProps to be available in JS

* wip

* mike's idea

* delete no longer used file
2022-05-18 18:47:27 +00:00
Lucas Costi
5cef9e2fe7 Remove Actions experimental articles (#27524) 2022-05-18 00:35:40 +00:00
Peter Bengtsson
67064b14c9 fix "Preview notice" anchor link (#27767) 2022-05-17 17:32:41 -04:00
Sarah Schneider
a9d3390c2f change hiddenNoBanner to noEarlyAccessBanner 2022-05-13 16:35:33 -04:00
Sarah Schneider
2962666b55 update banner component 2022-05-13 12:47:11 -04:00
Grace Park
2c56b5fdea Fix REST small bugs (#27484)
* fix lucas found bugs

* remove language-

* update getLanguageHighlight

* add back launch.json

* remove line break
2022-05-11 12:57:14 -07:00
Grace Park
2e821f52ff REST subcategory/category rendering test and refactor test-open-api-schema (#27138)
* first stage of test

* update test

* add rest test for categories and subcategories rendering

* update timeout back to original

* remove export

* remove testing

* refactor test-open-api-schema

* remove function

* remove check

* remove slash

* remove comment

* rearrange

* update getting the categories and maptopic levels

* update tests

* update copy

* add error message task
2022-05-10 17:09:47 +00:00
Grace Park
f5fa66c452 update to size 16 per design and add d-flex (#27450) 2022-05-04 04:15:35 +00:00
Rachael Sewell
97fe617e15 adding enums back to rest param table (#27448) 2022-05-03 23:47:06 +00:00
Grace Park
f1f96c6a3a update to design feedback (#27420) 2022-05-02 17:03:21 -07:00
Grace Park
982d596d28 REST Bug fixes: Guides/Overview useEffect, duplicate key (#27414)
* add conditional in useeffect

* fix duplicate key error

* consolidate conceptual article check

* remove unnecessary currentanchor

* revert consolidating variable

Co-authored-by: Rachael Sewell <rachmari@github.com>
2022-05-02 13:39:53 -07:00