1
0
mirror of synced 2026-01-04 09:06:46 -05:00
Commit Graph

182 Commits

Author SHA1 Message Date
Jason Etcovitch
42694f4355 Datadog on staging (#16982)
* Include Datadog buildpack

* Add heroku_app tag to statsd
2020-12-15 15:02:03 -05:00
Kevin Heis
85ddb82fe8 Avoid mixing sync and async during warmServer (#16940)
* Avoid mixing sync and async during warmServer

* Update data-directory.js

* Move more sync processing to later

* Update pages.js

* Update pages.js
2020-12-15 10:56:25 -08:00
Kevin Heis
122da9610c Move redirect calculation from loadPages to loadRedirects (#16918)
* Move redirect calculation from loadPages to loadRedirects

* Make buildredirects a method for tests

* Update redirects.js

Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2020-12-15 18:40:50 +00:00
Vanessa Yuen
bf383bfb87 Merge branch 'main' into repo-sync 2020-12-15 11:45:35 +01:00
Ivan Žužak
eca05af8f6 Account objects in marketplace purchase webhook event also have node_id (#16772)
* account objects in marketplace purchase event also have node_ud

* account objects in marketplace purchase event also have node_ud

* account objects in marketplace purchase event also have node_id

* account objects in marketplace purchase event also have node_id

Co-authored-by: jmarlena <6732600+jmarlena@users.noreply.github.com>
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
2020-12-15 07:19:09 +00:00
Nick Schonning
f1f7c95df2 fix: Links to localhost addresses (#1505)
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
2020-12-15 16:36:40 +10:00
Sarah Schneider
b38eec9964 Revert "sitetree optimizations" 2020-12-14 16:53:04 -05:00
Sarah Schneider
53e1ffdb4d Merge branch 'optimize-sitetree' of github.com:github/docs-internal into do-not-mutate-page-in-sitetree 2020-12-14 15:42:44 -05:00
Sarah Schneider
c412bd992a Merge branch 'main' into optimize-sitetree 2020-12-14 15:42:03 -05:00
Sarah Schneider
bc01b6c9f5 Merge branch 'main' into update-dates-script 2020-12-14 15:21:45 -05:00
Sarah Schneider
f1e595ba0e Merge branch 'optimize-sitetree' of github.com:github/docs-internal into do-not-mutate-page-in-sitetree 2020-12-14 15:17:11 -05:00
Sarah Schneider
cac0ccff0c Merge branch 'main' of github.com:github/docs-internal into optimize-sitetree 2020-12-14 15:16:16 -05:00
Sarah Schneider
471c6d1ecd fix typo 2020-12-14 15:13:17 -05:00
Leona B. Campbell
fc6af9d9a5 ran script/graphql/update-files.js (#16842) 2020-12-14 19:56:11 +00:00
Sarah Schneider
ab7cbda68d refactor how we get map topic content 2020-12-14 14:55:16 -05:00
Sarah Schneider
748a715988 add language code to paths in site tree so we can find the pages immediately and not look up versioned paths each time 2020-12-14 14:39:09 -05:00
Sarah Schneider
2ace9e8344 do an initial lookup in find-page before checking versioned pages 2020-12-14 14:35:48 -05:00
Kevin Heis
2538a79a7b In old path redirects, freeze up sets we iterate over (#16916) 2020-12-14 19:26:57 +00:00
Kevin Heis
7dfea2d0d6 Remove stat check from lib/pages per Node recommendations (#16920) 2020-12-14 16:44:09 +00:00
Kevin Heis
d9ab8f3b08 In path utils, speed up version lookups (#16915) 2020-12-14 16:07:44 +00:00
Kevin Heis
0fe0b456e0 Move data-directory to also mapLimit (#16921)
Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2020-12-14 15:56:05 +00:00
Kevin Heis
62590cc976 getPathWithoutLanguage, remove split-slice-join pattern (#16914)
Co-authored-by: Vanessa Yuen <6842965+vanessayuenn@users.noreply.github.com>
2020-12-14 15:45:45 +00:00
Jason Etcovitch
ca127e987e Change release notes colors (#16923)
* Use pastel colors

* Whit text

* Slugify/anchor section headings

* Use classes instead of style attributes

* Use fancy-pants SCSS

* Simplify a tad

* TIL text-inherit helper

Co-authored-by: Vanessa Yuen <6842965+vanessayuenn@users.noreply.github.com>

* Remove redundant `style` attr

Co-authored-by: Vanessa Yuen <6842965+vanessayuenn@users.noreply.github.com>

Co-authored-by: Vanessa Yuen <6842965+vanessayuenn@users.noreply.github.com>
2020-12-14 15:06:03 +00:00
Jason Etcovitch
92d5722103 Add 2.22 release notes (#16586)
* Add 2.22.0

* Add 2.22.1

* Add 2.22.2

* Add 2.22.3

* Add 2.22.4

* Lint YAML files

* intro shouldn't be required

* Align all notes

* Full height sidebar

* Make the sidebar full height properly

* Get the real layout going

* Include full name

* Move details > summary around

* Fix sticky sidebar

* Tweak bottom of page

* Add more label colors

* Change heading title

* Don't be <details>, change sticky header

* Include other releases' info

* Show prev/next links

* Change sidenav to show all releases

* Fix ordering of chevron

* Fix link underlines

* Collapsing minor versions

* Moar padding

* Setup schema for sub-sections

* Update a YAML file to match schema

* Redo rendering/sorting logic

* Update layout

* Convert remaining notes

* Improve schema

* Use proper min properties

* Custom bullet points

* Show details control for version picker

* Improve layout on small screens

* One more tiny fix

* Order by semver

* Use proper version in details

* Fix extra arrows showing up

* Change label colors

* Pass the reference check

* Add gradients

* Gradient all the things
2020-12-11 13:43:11 -05:00
github-openapi-bot
fead78930f Updating OpenAPI descriptions (#16778)
Co-authored-by: Sarah Edwards <skedwards88@github.com>
2020-12-11 09:10:45 -08:00
Sarah Schneider
d4140663c2 Merge branch 'main' into update-dates-script 2020-12-10 13:58:02 -05:00
Sarah Schneider
cada14981b Merge branch 'main' of github.com:github/docs-internal into list-of-deprecated-versions 2020-12-09 22:05:26 -05:00
Sarah Schneider
8f26df0aa0 Merge branch 'main' of github.com:github/docs-internal into update-dates-script 2020-12-09 21:08:37 -05:00
Sarah Schneider
bc6c0cc6be Merge branch 'main' of github.com:github/docs-internal into yank-outdated-redirect-code 2020-12-09 20:47:40 -05:00
Sarah Schneider
fa2b8b69dc ran script/update-enterprise-dates.js 2020-12-09 20:26:36 -05:00
Kevin Heis
33bd3e45d3 Instrument the subfunctions of warmServer with datadog (#16854)
Co-authored-by: James M. Greene <JamesMGreene@github.com>
2020-12-10 01:21:38 +00:00
James M. Greene
e6518ff9c3 Fix unresolved data lookups on GitHub Glossary page (#16815)
* Support [...] in data tag path

* Use forloop.index0 to get data tag path

* Commit whitespace change to not keep getting it

* Recursively render glossary terms as well

* Add tests to verify Liquid data tag can handle bracketed access

* Remove superfluous 'set' for context in tests

* Avoid the mystery guest anti-pattern... move the test data closer to the test

* Escape the `-` character in the data regex

Co-authored-by: Jason Etcovitch <jasonetco@github.com>
Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2020-12-09 18:58:00 -06:00
Rachael Sewell
6a3d326fcf add one-off cases for hooks and pre-receive-hooks (#16784)
* add one-off cases for hooks and pre-receive-hooks

* add forum redirect

* update redirect test

* update 2.19-2.22 fixutres

* revert 2.18/2.19 changes

* remove dotcom test

* update dotcom test
2020-12-09 19:50:46 +00:00
Kevin Heis
1b424dfdc4 Bring in data-directory, let's go async file reads (#16782)
* Bring in data-directory, let's go async file reads

* Lint fixes

* Update glossary.js
2020-12-09 11:20:24 -08:00
Sarah Schneider
b025ba2cf6 Merge branch 'main' into support-hardcoded-versions-in-links 2020-12-09 13:14:01 -05:00
Kevin Heis
62889986b6 Revert "Revert "Speed up warmServer by loading pages (and files) asyn… (#16837)
* Revert "Revert "Speed up warmServer by loading pages (and files) asynchronously (#16752)" (#16835)"

This reverts commit a14517115f.

* Move async to regular dependencies

* Update package-lock.json
2020-12-09 17:40:58 +00:00
Jason Etcovitch
a14517115f Revert "Speed up warmServer by loading pages (and files) asynchronously (#16752)" (#16835)
This reverts commit 1d5e216404.
2020-12-09 17:12:07 +00:00
Kevin Heis
1d5e216404 Speed up warmServer by loading pages (and files) asynchronously (#16752)
* Async `new Page`

* Update pages.js

* Update pages.js

* Update pages.js

* Update pages.js

* Update pages.js

* Using mapLimit

* Update pages.js

* Test updates

* Update pages.js

* Move exists to page class

* Test fixes

* Slightly faster localized paths process
2020-12-09 16:57:18 +00:00
Melanie Yarbrough
91d3857341 [DO NOT MERGE] Universe 2020 Day 1: December 8, 2020 (#16480)
* Update README

* [Universe] Dark mode (#16545)

* Dark mode updates (#16696)

* [Universe] Corporate sponsors (#16457)

* Dependency review beta (#16563)

* Add placeholder topic file

* Revert change I didn't make

I'm not sure where this change came from or why it's showing up in my PR here but I didn't make this change and it's not part of Dependency Review so I'm reverting it.

* Un-revert previous change

OK I see what happened there. I was comparing the PR to main rather than the Universe megabranch, hence it showed a change I didn't make.
This commit undoes the change I do not want to revert on the megabranch.

* Update image to add the Checks tab

* Finish updating topic to mention DR

* Fix check errors

* Fix another versioning error

* Add a sentence about supported ecosystems

* Add review changes

* Remove Further reading topics in same category

As suggested by James, I've removed the links to topics that are in the same `/collaborating-with-issues-and-pull-requests/` category as this topic.

* Update content/github/managing-security-vulnerabilities/about-managing-vulnerable-dependencies.md

Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>

* Update content/github/managing-security-vulnerabilities/about-managing-vulnerable-dependencies.md

Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>

* Update content/github/managing-security-vulnerabilities/about-managing-vulnerable-dependencies.md

Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>

* Update content/github/managing-security-vulnerabilities/about-managing-vulnerable-dependencies.md

* Updates in the light of Maya's review

* Remove use of "exploit" in description

* Change 'dependency review summary' to 'dependency review'

See PR review comment from Maya.

* Mention that the age of the dependency is given

* Update screenshots to latest GUI

* Add details of dependency ordering within a DR

* Update content/github/collaborating-with-issues-and-pull-requests/reviewing-dependency-changes-in-a-pull-request.md

Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>

* Update content/github/managing-security-vulnerabilities/about-managing-vulnerable-dependencies.md

Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>

* Update content/github/visualizing-repository-data-with-graphs/about-the-dependency-graph.md

Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>

Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>

* [Universe 2020] New audit log REST API endpoint (#16699)

* Minimal updates for preview

*  API previews 

* Update beta note

*  Update API previews 

*  Update previews 

* Add draft section for git events

* Clean API previews

* More fixes + API previews

* Address review comments + update API previews

* Mention cursor-based pagination

* Update content/rest/overview/resources-in-the-rest-api.md

Co-authored-by: Jeff Saracco <jeffsaracco@github.com>

* Temporarily revert API previews

* Small tweaks from review comments + API previews

* revert json schemas

* Updating OpenAPI descriptions (#16776)

* Updating OpenAPI descriptions

* Add decorated OpenAPI schema files

Co-authored-by: Jeff Saracco <jeffsaracco@github.com>
Co-authored-by: skedwards88 <skedwards88@github.com>
Co-authored-by: github-openapi-bot <69533958+github-openapi-bot@users.noreply.github.com>

* [Universe 2020] GitHub Actions: Workflow visualization (#16629)

* initial empty commit

* replace image used only for dotcom

* add new image and version usage

* add new image and version usage

* add new image and version usage

* add new image and version usage, delete unneeded image

* add new image and version usage, fix incorrect image

* add new image and version usage

* add new image and version usage

* add new image and version usage

* add new image and version usage

* update screenshot update

* add new image and version usage

* add new image and version usage

* update text

* update images and fix list numbering

* add step with graph

* Add missing versioning

* add overview of visualization

* fix title to match filename

* add beta note

* update wording

* Restructuring packages (#16731)

* restructuring packages

* moving more content

* moving more content

* fixing the toc for guides

* removing CR from the landing page

* adjusting qs

* updating npm

* enhancing guides

* Update updating-github-insights.md

* fixing link problems

* fixing link problems

* redirecting the redirects

* another change

* fixing the guides landing page

* add packages quickstart

* moving CR content

* adding some descriptive text

* add packages landing page

* adding guide content back

* update popular articles based on data

* fix caps on product name

* try removing product from front matter

* Update content/packages/quickstart.md

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* Update content/packages/quickstart.md

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* add node package instructions to quickstart

* fixing links and adding redirect

* fixing redirects

* renaming to container guides

* renaming to container guides and fixing reusables

* adding context and about section to CR

* removign landign page extra titles and descriptions

* reverting the packages

* updating link

* Apply suggestions from code review

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* updating

* update test to reflect redesigned product landing page

* Add private vs public clarification

* Fix borked test

* filter out standalone category files from test

Co-authored-by: Cynthia Rich <crichID@github.com>
Co-authored-by: Cynthia Rich <crichID@users.noreply.github.com>
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
Co-authored-by: Sarah Schneider <sarahs@github.com>
Co-authored-by: Jason Etcovitch <jasonetco@github.com>

* Add discussions video
See https://github.com/github/docs-internal/pull/16759

* Remove typos

* update article name in test

Co-authored-by: Laura Coursen <lecoursen@github.com>
Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>
Co-authored-by: hubwriter <hubwriter@github.com>
Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
Co-authored-by: Jeff Saracco <jeffsaracco@github.com>
Co-authored-by: skedwards88 <skedwards88@github.com>
Co-authored-by: github-openapi-bot <69533958+github-openapi-bot@users.noreply.github.com>
Co-authored-by: Meg Bird <megbird@github.com>
Co-authored-by: Leona B. Campbell <3880403+runleonarun@users.noreply.github.com>
Co-authored-by: Cynthia Rich <crichID@github.com>
Co-authored-by: Cynthia Rich <crichID@users.noreply.github.com>
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
Co-authored-by: Sarah Schneider <sarahs@github.com>
Co-authored-by: Jason Etcovitch <jasonetco@github.com>
2020-12-08 12:20:02 -05:00
Sarah Schneider
e2d114b96b lint 2020-12-08 11:47:14 -05:00
Sarah Schneider
3ca261ac82 add Developer deprecated docs to the list and also add a mini-toc 2020-12-08 10:38:39 -05:00
Sarah Schneider
5164fe95d3 yank outdated redirect code 2020-12-08 09:30:26 -05:00
Meg Bird
754ceda517 [Universe] Discussions Public Beta (#16547)
* Update README

* create structure for discussions landing page

* is everything broken

* [Universe] Dark mode (#16545)

* Fix title

* Add Discussions product

* Correct title

* Correct title

* Move quickstart article

* Move quickstart back out into article

* Add and incorporate reusables

* Move information about search

* Draft conceptual information

* Draft best practices

* Draft further reading

* Draft product introduction

* Draft introduction

* Add author metadata

* Pluralize

* Fix typos

* Add introduction

* Bump Octicons

* Add some reusables

* Add images

* Revise article

* Draft article

* Change word

* 🔪 the gerund

* Add reusable

* Revise introduction

* Revise list

* Simplify

* Revise reusable

* Fix reusable; add context

* Rename reusable

* Deduplicate conceptual information

* 🔪 gerund

* Add link to further reading

* Move link and dispose of tip

* Delete space

* Add images

* Add conceptual section

* Add word

* Delete newline

* Revert package.json to state on main

* Tweak images

* Draft article

* Add product name

* Remove beta note

* Use product name for future-proofing

* Begin adding search information

* Fix copypasta

* little edits

* build out a bit more of the guides content

* Don't mention integrations for now

* Escape quote

* Remove authorship information for new defaults

* Finish drafting article

* Replace encoded character to match description

* Revise away inline link

* Accommodate 'for more information' in reusable

* Fix links

* Fix one last bit of copypasta

* Update indices

* Temporarily remove heading

* Update introduction

* Add new article 💀

* Remove commits from universe-2020-megabranch

* Add article 💀

* update with a very rough draft

* Add content about collaboration options to "About repositories"

* Add content about discussions to "About issues"

* Reorder content

* Add is:discussion query

* update with a few mmore fleshed out sections

* update with more structure

* Add reusable

* Add screenshots

* Clear way for actual procedural

* Discussions landing page "Communities" section (#16692)

* Make button Overview-able

* Make card filtering more extensible

* Guard for missing attributes

* Use arbitrary dataset attributes

* Add section with discussions-community-card

* Tweak show more button behavior

* Conditionally show "Show more"

* Add beta_product frontmatter/label

* Remove beta callout note

* Hide changelog with no items

* Finish importing community info

* Fix borked markup

* Omit search abr

* Two columns should actually be two columns

* Use org image, change card layout

* Add two more examples

* Fix title

* Escape quote

* Escape another quote

* Draft article

* Lower case

* Relocate conceptual information

* Update qualifier name

* Draft article

* Add conceptual information and links

* Remove duplicative section

* Fix copypasta

* Revise reusable

* Update link

* Add content on categories

* Lint the discussions YAML file

* Update introduction and permissions

* 

* Reusablize; fix link

* more planning content stuff

* Escape quotes

* Align prerequisites

* Soften

* Clean up prerequisites

* Fix titles; version; add screenshot

* Fix links

* Actually fix links

* Use better variable

* Mention pinning

* Update screenshots

* Add screenshot

* forgot to committ

* update with reusable

* add that screenshot

* beef up landing page a bit

* remove extra space

* messed that up

* fix hardcoded linkks weirdo

* fix tests

* update with permissions content

* update with placeholder

* filter out standalone category files from test

* update

* update @becca's  feedback

* update with more feedback

* so many updates

* fix links

* fix some more tests

* flesh some more things out

* update with further reading blah blah

* fix some things

* remove the gate-features label for beta ship only

* Add discussions video to product landing page (#16759)

* Add discussions video placeholder

* This might work maybe

* fix tests

* apply all of @becca's and @lecoursen's  feedback ❤️

* rename to fix test

* Revert "Add discussions video to product landing page (#16759)"

This reverts commit 2247e5d0881ca6b36cee421218e8341a7cc12ac7.

* update with test fix

Co-authored-by: Melanie Yarbrough <11952755+myarb@users.noreply.github.com>
Co-authored-by: Laura Coursen <lecoursen@github.com>
Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>
Co-authored-by: Jason Etcovitch <jasonetco@github.com>
Co-authored-by: Sarah Schneider <sarahs@github.com>
2020-12-07 15:00:35 -07:00
Sarah Schneider
526c05f4ce support hardcoded versions in links 2020-12-07 11:32:39 -05:00
Sarah Schneider
17b21b6ec3 lint 2020-12-06 21:01:05 -05:00
Sarah Schneider
f966af7a15 add new arrays to exported module 2020-12-06 20:44:56 -05:00
mc
8025d9216d Secret scanning webhooks & APIs (#16608)
Co-authored-by: shati-patel <shati-patel@github.com>
Co-authored-by: Grey Baker <greysteil@github.com>
Co-authored-by: Prashanth Kannan <prashkan@github.com>
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
Co-authored-by: Melanie Yarbrough <11952755+myarb@users.noreply.github.com>
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
2020-12-04 09:39:29 +10:00
James M. Greene
fb30a0766f Unravel pages (the array + map object) (#16708)
* Revise the 'pages' module to export two methods: 'loadPages' and 'loadPageMap'

Update all existing references to use 'loadPages' for now

* Remove explicit Promise resolutions on loadPage* methods

* Condense reduction method into its now-singular usage spot

* Opt for for-of instead of forEach

* Make require of pages in warm-server more explicit

* Be more explicit about find-page using a pageMap

* Be more explicit about find-page-in-version using a pageMap

* Be more explicit about site-tree using a pageMap

* Extract the map creation from loadPageMap

* Be more explicit about using a pageMap

* Update redirects precompile to take two arguments: pageList, pageMap

* Rename internal loadPages method to loadPageList

* Clarify pageMap is what is stored in context.pages

* Use loadPageMap in tests and stuff
2020-12-03 22:31:10 +00:00
Jason Etcovitch
a7466b685b Actions video (#16744)
* Support video frontmatter

* Add CSP rule

* Actually put in the video
2020-12-03 21:18:42 +00:00
Octomerger Bot
218d08f38d Branch was updated using the 'autoupdate branch' Actions workflow. 2020-12-03 12:53:19 -08:00