Some tweaks to the verbiage around what is provided with Premium Support and GHAE.
Instead of the "Government notification box" indicating the TSAM will inform them of the difference, I propose a secondary article, similar to how we've setup Premium Support, with something like:
For more information, see "GitHub AE Support for Commercial and Government Cloud."
This new page should house all of the roles/responsibilities for each of the two respective services in a table format that's clear and defines the support offering better.
Also, while reviewing, this seems like it should be designated with "Cloud" to denote GHES and GHE**C**:
https://docs.github.com/en/enterprise-server@2.22/admin/enterprise-support/about-github-premium-support-for-github-enterprise
to "About GitHub Premium Support for GitHub Enterprise Cloud"
So we ultimately have:
About GitHub Premium Support for GitHub Enterprise Server
About GitHub Premium Support for GitHub Enterprise Cloud
About GitHub AE Support for Commercial and Government
The navigation would simply show the Commercial/Government Cloud page under "About GitHub Enterprise Support" in the navigation so the customers can see the differences in the two and we can better explain what we provide. Both of the "About Premium Support" pages expand on a lot of good information about Premium Support.
* first stab
* fix issues with liquid tags
* applied a few fixes and improvements
* rewrite options
* rewrite for GHES 2.21
* fix liquid versioning (again)
* I love liquid tags
* swap paragraphs for GHES 2.21
* add link to new article in 2 existing articles
* started major rework to avoid info duplication
* part of the reorg work
* starting the major reorg
* fix syntax
* rework Configuring notifications article
* reorganizing again
* more reorg
* add new reusable
* fix typo
* add correct variable
* link to correct article for GHES < 2.21
* Update content/github/managing-security-vulnerabilities/configuring-notifications-for-vulnerable-dependencies.md
Co-authored-by: Alex Mullans <infin8x@github.com>
* Apply suggestions from code review
Co-authored-by: Felicity Chapman <felicitymay@github.com>
* Update data/reusables/notifications/vulnerable-dependency-notification-options-detailed.md
Co-authored-by: Maya Kaczorowski <15946341+mayakacz@users.noreply.github.com>
* fix typo reported in #16036
* address comments from code review
* yet another commit
* polishing
* Update content/github/managing-security-vulnerabilities/configuring-notifications-for-vulnerable-dependencies.md
Co-authored-by: Maya Kaczorowski <15946341+mayakacz@users.noreply.github.com>
* use variables
* address more comments
* add condition to link as linked article is free-pro-team only
* fix condition
* remove reusable that had duplicated content
* remove incorrect info
* fix issue in GHES article
* added shortTitle
* Apply suggestions from code review
Co-authored-by: Maya Kaczorowski <15946341+mayakacz@users.noreply.github.com>
* reword for clarity
* add more detail
Co-authored-by: Alex Mullans <infin8x@github.com>
Co-authored-by: Felicity Chapman <felicitymay@github.com>
Co-authored-by: Maya Kaczorowski <15946341+mayakacz@users.noreply.github.com>
* specify ssh shell
Specify that the command should be run within the administrative SSH shell, and link to the relevant document for access.
* Link to SSH doc as a note
* note syntrax
* remove extra space
* Update content/admin/configuration/enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md
Co-authored-by: hubwriter <54933897+hubwriter@users.noreply.github.com>
* Update enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md
* Update enabling-alerts-for-vulnerable-dependencies-on-github-enterprise-server.md
* Indenting note box in markdown.
I should have spotted this in my previous review, so I'm going to go ahead and apply this change.
Co-authored-by: hubwriter <54933897+hubwriter@users.noreply.github.com>
* Run script/new-versioning/update-not-fpt-conditionals.js
* Fix a few things
* Remove outdated versioning
* Fix broken link
Co-authored-by: jmarlena <6732600+jmarlena@users.noreply.github.com>
* remove outdated and redundant context.enterpriseVersions and add new context.enterpriseServerVersions
* update references from context.enterpriseVersions -> context.enterpriseServerReleases
* add test
* also test oldest supported enterprise version in addition to the latest
* Script to update not-free-pro-team conditionals (#16060)
* script to update not-free-pro-team conditionals
* change string to regex so we can do replace all
* remove stray test.only
* Update middleware/context.js
Co-authored-by: James M. Greene <JamesMGreene@github.com>
* Update tests/unit/page.js
Co-authored-by: James M. Greene <JamesMGreene@github.com>
* Update tests/unit/page.js
Co-authored-by: James M. Greene <JamesMGreene@github.com>
* Update tests/fixtures/page-versioned-for-all-enterprise-releases.md
Co-authored-by: James M. Greene <JamesMGreene@github.com>
Co-authored-by: James M. Greene <JamesMGreene@github.com>
* Restructure files and change topic titles and file names
* Update links to files whose names have changed
* Finish restructuring work for runner topics
* Makes changes suggested by James
* ran script/remove-unused-assets.js (manually removed unused variables printed by the script)
* package-lock
* turn elsif into two ifs to prepare for running Liquid deprecation script
* ran script/remove-deprecated-enterprise-version-markup.js --release 2.14 (ONLY UPDATES LINE BREAKS ETC.)
* ran script/remove-deprecated-enterprise-version-markup.js --release 2.15
* ran script/remove-deprecated-enterprise-version-markup.js --release 2.17
* ran script/remove-deprecated-enterprise-version-markup.js --release 2.18
* update hardcoded test
* Update content/github/collaborating-with-issues-and-pull-requests/filtering-files-in-a-pull-request.md
Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>
* add currentVersion is NOT free-pro-team to conditional, to make sure the deprecation script does the right thing when it is time to deprecate 2.21
Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>
* Add back changes from prior to purge
* Manually fix some invalid Liquid
* Updoot render-content
* Improve test messages to show correct output
* Run el scripto
* Pass the remaining test
