jprdonnelly/docs
1
0
Fork 0
mirror of synced 2025-12-30 03:01:36 -05:00
Code Issues Projects Releases Wiki Activity
35,348 Commits 28 Branches 1 Tag
da13daeec98468d24f3de71edde628de52af165b
Commit Graph

142 Commits

Author SHA1 Message Date
Kevin Heis
b7d6ee0853 Cache language redirects (#33028) 2022-12-01 20:01:52 +00:00
Evan Bonsignori
b1a36fb7ff Revert "set max-age=0 when you want no cache (#31657)" 
This reverts commit 5dfca10bba.
 2022-10-12 13:10:34 -07:00
Peter Bengtsson
5dfca10bba set max-age=0 when you want no cache (#31657) 2022-10-12 19:54:28 +00:00
Peter Bengtsson
74103cd650 redirect /search to /api/search/legacy (#31566) 2022-10-10 19:23:54 +00:00
Peter Bengtsson
35e91423d0 404 on any /_next/image request (#31052) 2022-09-22 15:55:30 -04:00
Sarah Schneider
b7f48ea2c1 Support GHAE internal-only semantic versioning (#29178) 
Co-authored-by: Peter Bengtsson <mail@peterbe.com>
Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>
 2022-09-22 08:26:58 +02:00
github-openapi-bot
757066487d Update OpenAPI Descriptions (#30924) 
Co-authored-by: github-openapi-bot <github-openapi-bot@users.noreply.github.com>
Co-authored-by: Rachael Sewell <rachmari@github.com>
Co-authored-by: Grace Park <gracepark@github.com>
Co-authored-by: Grace Park <gracepark@Graces-MacBook-Pro-2.local>
Co-authored-by: Hector Alfaro <hectorsector@github.com>
Co-authored-by: Ashwin Jeyaseelan <8gitbrix@github.com>
Co-authored-by: hubwriter <hubwriter@github.com>
Co-authored-by: Sarita Iyer <66540150+saritai@users.noreply.github.com>
 2022-09-19 10:28:23 -07:00
Kevin Heis
7523a7c460 Prep for ts-node (#30587) 2022-09-08 15:45:13 +00:00
Peter Bengtsson
90b754fe3c Test JSON API without enabling dedicated search results page (#30542) 2022-09-06 17:05:22 +00:00
Kevin Heis
303d5190db Create a translations test suite (#30000) 
* Scaffold files for migration

* Move user-agent into unit suite

* Nothing to move from browser suite

* Migrate tests to translations/content

* Migrate existing translation test to meta

* No graphql tests to migrate

* Migrate lint-translation-reporter

* Migrate lint-translation-reporter

* Remove languages-schema, unused

* Restore languages-schema

* Restore languages-schema

* Migrate rendering

* Migrate routing

* Migrate most of unit

* Remove dead files, comment out tests that aren't expected to work yet

* Migrate from get-redirect

* Migrate page and pages

* Migrate linting code

* Fix lint issues

* Found a few more

* Run prettier

* Move crowdin-config test and helper

* Update crowdin-config.js

* Remove translation linting, crowdin config lint, reduce file count

* Remove test that's been skipped for a year

* Restore linting with note to remove later

* Update lint-translation-reporter.js

* Clean up rendering suite

* Update rendering.js

* Remove excessive describe blocks

* Redirect tests

* Clean up unit

* Remove test that's never called

* Don't compare early access

* Rename test suites

* Update "content" tests

* Update files.js

* Update search.js

* Update files.js

* Update files.js
 2022-08-25 12:38:03 -07:00
Peter Bengtsson
c9cc69ca21 Archived enterprise assets should be cached longer (#30165) 2022-08-23 02:02:31 +00:00
Peter Bengtsson
c260d9f04d only redirect to /$locale/search if ES is set (#30104) 
* only redirect to /$locale/search if ES is set

* only redirect to /$locale/search if ES is set
 2022-08-19 18:57:07 +00:00
Peter Bengtsson
8765c628ff dedicated search results page (redux) (#29902) 
* dedicated search results page (redux)

* Update SearchResults.tsx

* adding pagination

* fix pagination

* say something on NoQuery

* better Flash

* tidying link

* small fixes for results

* debug info

* l18n the meta info

* inDebugMode

* basic jest rendering of the skeleton page

* basic jest rendering test

* fix content tests

* better document title

* fix tests

* quote query in page title

* use home page sidebar

* something when nothing is found

* parseInt no longer needs the 10

* fix linting tests

* fix test

* prettier

* Update pages/search.tsx

Co-authored-by: Rachael Sewell <rachmari@github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Co-authored-by: Rachael Sewell <rachmari@github.com>
 2022-08-19 13:36:55 +00:00
Kevin Heis
688a274f1f Remove CSRF check (#29910) 
* Use color_mode for gating "sign up" button

* Remove csrf check

* Add `res.removeHeader('set-cookie')` to cache-control

* Update static-assets.js

* Remove package

* Remove tough-cookie

* Update cache-control.js

* Update cache-control.js

* Update cache-control.js
 2022-08-15 19:28:42 +00:00
Kevin Heis
101e7155c8 userLanguage in browser instead of XHR (#29782) 
* userLanguage in browser instead of XHR

* refactors on pr 29782 (#29798)

Co-authored-by: Peter Bengtsson <peterbe@github.com>
 2022-08-10 15:28:21 +00:00
Kevin Heis
bb3cb78dd1 Move events under api (#29298) 2022-07-26 18:00:58 +00:00
Kevin Heis
564e3a5e2a Move CSRF response back to XHR (Node.js prep) (#29179) 
* Move CSRF response back to XHR

* Update events.js

* Pass through cookieJar

* Enable session route test

* Skip next x csrf test

* Add other fields to endpoint for future issues

* Remove client side parts

* Revert test skip

* Use nested router pattern

* ugh forgot a file

* Update naming

* Update tests/rendering/session.js

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Updating to use cache control

* Use req.langauge and req.userLanguage

Co-authored-by: Peter Bengtsson <peterbe@github.com>
 2022-07-22 18:17:22 +00:00
Sarah Schneider
7dc8d11fed reorder imports to be more standard 2022-07-22 12:12:33 -04:00
Sarah Schneider
4cbbf22fbd Merge branch 'main' of github.com:github/docs-internal into versioned-redirects 2022-07-21 09:04:04 -04:00
Peter Bengtsson
9dce4cd96d redirect to language url for ghes 3.0 and 3.1 (#29136) 
Co-authored-by: Hector Alfaro <hectorsector@github.com>
 2022-07-19 15:22:48 +00:00
Peter Bengtsson
4bff926c7e inject language for legact admin/release-notes URLs (#29082) 2022-07-15 20:28:31 +00:00
Peter Bengtsson
e0a20add31 //en/some/path should redirect to /en/some/path (#29077) 
* //en/some/path should redirect to /en/some/path

* remove debugging
 2022-07-15 19:16:42 +00:00
Peter Bengtsson
ef5406ae9a rest reference redirects with free-pro-team@latest (#28838) 2022-06-29 20:42:58 +00:00
Peter Bengtsson
ee1f20f4fb jest 28.1.1 (#28797) 
* got 28.1.1

* wip

* force upgrade nth-check

* legacyFakeTimers
 2022-06-29 11:55:03 +00:00
Sarah Schneider
aed1f595c6 remove no longer needed test 2022-06-24 13:05:00 -04:00
Sarah Schneider
f6f43cd353 make the exceptions redirects function accept filename as a param so we can reuse it 2022-06-24 12:25:37 -04:00
Sarah Schneider
d77727ec7a re-add exceptions redirects file and handler... we can continue to use these for true exceptions 2022-06-24 12:23:58 -04:00
Sarah Schneider
10b7d41e36 fix conflicts 2022-06-24 09:21:18 -04:00
Kevin Heis
f948c81038 Upgrade got (#28617) 
* Upgrade got

* Update e2etest.js

* Skip following redirects on redirect tests

* Update deprecated-enterprise-versions.js
 2022-06-21 16:23:51 +00:00
Robert Sese
beefde480e Use issues product for homepage redirect tests 2022-06-08 11:37:44 -05:00
Matt Pollard
0984f7dae6 Fix tests 2022-06-08 14:47:15 +02:00
Matt Pollard
e4877b8517 Fix two tests for deleted product 2022-06-08 14:44:13 +02:00
Peter Bengtsson
0504d968c6 stop mocking hydro calls with supertest (#28179) 
* stop mocking hydro calls with supertest

* wip

* fix the tests

* nock.cleanAll()
 2022-06-03 15:17:12 +00:00
Peter Bengtsson
d014f36222 fix external redirects (#28063) 
* fix external redirects

* oops

* feedbacked
 2022-06-02 02:06:29 +00:00
Peter Bengtsson
75c0ec5cab /en/ permanent redirects to /en should be CDN cacheable (#27976) 2022-05-25 13:51:16 +00:00
Sarah Schneider
b2db816d66 update test 2022-04-28 16:27:07 -04:00
Sarah Schneider
1c02d01554 move the redirect exceptions into test fixtures and tests 2022-04-27 17:57:28 -04:00
Grace Park
b98c83e924 REST operations sidebar (#26225) 
* testing out a rest operations sidebar

* cleanup

* renamed 5 files

* renamed 5 files

* set redirect_from on 5 files

* renamed 1 files

* renamed 1 files

* renamed 3 files

* renamed 1 files

* renamed 1 files

* renamed 3 files

* renamed 1 files

* renamed 2 files

* renamed 1 files

* renamed 4 files

* renamed 15 files

* renamed 2 files

* renamed 6 files

* renamed 1 files

* renamed 4 files

* renamed 7 files

* renamed 1 files

* renamed 3 files

* renamed 3 files

* renamed 1 files

* renamed 5 files

* renamed 1 files

* renamed 1 files

* renamed 3 files

* renamed 4 files

* renamed 1 files

* renamed 1 files

* renamed 2 files

* renamed 4 files

* renamed 1 files

* renamed 1 files

* renamed 1 files

* renamed 6 files

* renamed 6 files

* renamed 4 files

* move files

* adding more

* updating to add restcontext and start of removing data/reusables/rest-reference

* removed data/reusables

* add a RestMiniTocItem and updating the filtering to add a subcategory so all manually added H3s are in mini tocs in addition to operations

* remove console log

* [WIP]: REST New Proposal Sidebar (#26471)

* saving

* update sidebar

* remove console log

* update guides and overview

* import Category for category level rest pages

* update undefined restOperations

* update restOperationData category and subcategory levels"

* minor updates

* update get mini toc items function

* updating REST context for sidebar

* updating rest data

* remove console logs

* WIP: mini-toc-ing the sidebar

Co-authored-by: Robert Sese <rsese@github.com>

* A little cleanup

* Fix first subcategory link and add some comments

* updating anchor links in sidebar

* adding updates

* remove standalone

* update product and maptopic pages using article context

* add conditional link wrapper

* fix sidebar toggle and versions for enterprise admin

* update versions per subcategory

* Highlight sidebar link for current page

* Update miniToc hash links and hash change tracking

* fix unique key in CollapsibleSection

* Fix list markup

* remove title

* update permissions

* Hide minitocs on landing (#26594)

* hide minitocs on landing page

* simplify page components and remove minitoc from sidebar for guides/overview

* fix carats and category fix

* remove id

Co-authored-by: Grace Park <gracepark@github.com>

* updating content based on versions script check with the OpenAPI

* update script and content files

* update script and content/rest files

* update to add TocLanding

* update script

* update index files

* add codespaces repository-secrets

* remove openapi schema check script

* remove minitocs at the top

* add h2 about the {title} api

* fix tests/unit/openapi-schema.js

* Fix linting tests

* fix search/topics test

* fix tests/unit/pages test

* update rest/reference links in components

* run prettier

* Update components/rest/RestReferencePage.tsx

Co-authored-by: Rachael Sewell <rachmari@github.com>

* Update components/rest/RestReferencePage.tsx

Co-authored-by: Rachael Sewell <rachmari@github.com>

* Update pages/[versionId]/rest/[category]/[subcategory].tsx

Co-authored-by: Rachael Sewell <rachmari@github.com>

* Update pages/[versionId]/rest/[category]/[subcategory].tsx

Co-authored-by: Rachael Sewell <rachmari@github.com>

* Update pages/[versionId]/rest/[category]/[subcategory].tsx

Co-authored-by: Rachael Sewell <rachmari@github.com>

* Update pages/[versionId]/rest/[category]/[subcategory].tsx

Co-authored-by: Rachael Sewell <rachmari@github.com>

* Update tests/unit/openapi-schema.js

Co-authored-by: Rachael Sewell <rachmari@github.com>

* updating comment location

* remove dependabot override

* remove path-utils current product update for rest

* run linter

* remove dependabot.md and remove h2 heading on restreference

* update the correct product to rest for rest pages

* adding comments for updates to path-utils

* remove console log

* REST sidebar: handle legacy v3 redirects (#26686)

* Add script to handle legacy v3 REST redirects

* Run the script

* Handle a redirect to a redirect

* Update REST test URLs

* 'await' and test runs subcategory of checks

* Update REST URLs for routing/developer-site-redirects tests

* Update developer-redirects fixture with new REST URLs

* Resolve merge conflicts

* Update rest-redirects fixture with new REST URLs

* Fix broken links with REST pages re-org

* redirectTo could be undefined

* Fix script for posterity, can't redirect paths with hashes

* Remove invalid hash redirects

* Typically don't need to save one-off scripts

* Undo redirect changes (not necessary for handling v3 redirects)

* Remove script-added redirects

* Update old v3 redirects with new REST URLs

* No more GHES search indexing page

* 'org' not 'organization'

* Update fixture data for new REST URLs

* revert any content directory changes

Co-authored-by: Grace Park <gracepark@github.com>
Co-authored-by: Rachael Sewell <rachmari@github.com>

* Adding test rest (#26750)

* add test to check openapi schema versions and content rest frontmatter versions

* update lib/redirects

* fix test and add error messages

* adding repository secrets

* adding repository-secrets.md

* Revert "update lib/redirects"

This reverts commit 3aafe28265764d5bc09c0c478c8e0ca099c8fbcf.

* remove lib/redirects changes and console logs

* Update lib/rest/index.js

Co-authored-by: Rachael Sewell <rachmari@github.com>

* update unique key

* Rest client side redirects (#26754)

* adding tags subcategory for the rest content repos category

* run prettier

* bug fix for anchor scrolls" (#26892)

* updating width size for rest reference page

* Rest sidebar consolidation (#26862)

* refactor sidebar

* fix articlecontext provider issue on rest product landing page for all versions

* fix a bug, create new component

* revert change to create new component and fix bug

Co-authored-by: Rachael Sewell <rachmari@github.com>

* Set currentAnchor with a hashchange handler (#26923)

* Rest sidebar design tweaks (#26807)

* Rest sidebar design tweaks

* tweak color to subtle

* use muted color and margin for line

* update to design feedback

Co-authored-by: Grace Park <gracepark@github.com>

* Remove cheerio from rest-collapsible (#26948)

* remove cheerio from rest-collapsible

* update type

* adding endswith instead

* use productId instead

* one off edge case for secret-scanning

* Reorganize subcategory and category, Update pre -> div, Add RestContext (#26950)

* reorganize subcategory and category

* add RestContext

* update comment

* update for endpoints page

* add comment

* move object to restcontext

* remove effectiveDate in restcontext

* remove width calculation for rest reference page

* fix adding manual writer's minitocs to sidebar

* update with feedback

* update comment

* update isRestReferencePage

* remove page component and fix bug

* adding back rest/index.tsx

Co-authored-by: Rachael Sewell <rachmari@github.com>

* update content/rest"

* add back design tweak

* update to div

* update margins on rest api reference

* remove page component

* adding tests

* separate product from rest sidebar (#27065)

* separate product from rest sidebar

* Use ProductCollapsibleSections for product pages

* fix tests

Co-authored-by: Robert Sese <rsese@github.com>
Co-authored-by: Grace Park <gracepark@github.com>

* Rest sidebar translations (#27052)

* update translations

* remove general test

Co-authored-by: Robert Sese <rsese@github.com>
Co-authored-by: Rachael Sewell <rachmari@github.com>
 2022-04-20 10:19:48 -07:00
Peter Bengtsson
8362602503 do rendering end-to-end tests with a real server (#26169) 
* reinstate

* start server manually

* routing tests too

* skip more

* sleep more and fail if not 200

* use e2etest for content/ too

* feedbacked
 2022-03-18 17:06:12 -04:00
Peter Bengtsson
fcda086e13 make enterprise 3.0 redirects work (#26041) 
* make enterprise 3.0 redirects work

* improve tests and better variable name
 2022-03-09 16:32:05 +00:00
Peter Bengtsson
9d4b913bdc language redirects without cache (#25872) 
* redirect to your preferred language (#25664)

* redirect to your preferred language

* refactorings

* use js-cookies

* make sure no cache when language is involved in the redirect

* fix tests
 2022-03-07 16:25:22 +00:00
Peter Bengtsson
881a6d2212 Revert "redirect to your preferred language (#25664)" (#25869) 
This reverts commit a9947c086c.
 2022-03-04 21:56:57 +00:00
Peter Bengtsson
a9947c086c redirect to your preferred language (#25664) 
* redirect to your preferred language

* refactorings

* use js-cookies
 2022-03-04 16:29:11 +00:00
Robert Sese
79c48070c4 Deprecate 3.0 (#25646) 
* Deprecate 3.0

* 3.0 deprecation: remove 3.0 markup (#25647)

* Remove liquid conditionals and content for 3.0 deprecation

* Remove manually, no longer versioned in a supported version

* Remove translations manually, no longer versioned in a supported version

* Remove 'if', now in all supported versions

* Remove dangling 'elseif', now in all supported versions

* Remove dangling 'elseif' and 3.0 screenshot reference, now in all supported versions

* Nudge to latest supported GHES version

* Nudge to latest supported release GHES version

* Bump all the version for the liquid tests

* Bump first deprecated version for linting tests

* Prefer double quotes

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Prefer double quotes

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Prefer double quotes

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Prefer double quotes

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Prefer double quotes

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Prefer double quotes

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Prefer double quotes

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Prefer double quotes

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Prefer double quotes

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Remove extra newline

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Remove extra newline

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Remove extra newline

Co-authored-by: Laura Coursen <lecoursen@github.com>

* One reusable per line

Co-authored-by: Laura Coursen <lecoursen@github.com>

* One reusable per line

Co-authored-by: Laura Coursen <lecoursen@github.com>

* One reusable per line

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Version check not needed anymore

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Version check not needed anymore

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Version check not needed anymore

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Version check not needed anymore

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Version check not needed anymore

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Version check not needed anymore

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Version check not needed anymore

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Stray whitespace ✂️

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Stray whitespace ✂️

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Stray whitespace ✂️

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Stray whitespace ✂️

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Stray whitespace ✂️

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Stray whitespace ✂️

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Stray whitespace ✂️

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Stray whitespace ✂️

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Version check not needed anymore

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Version check not needed anymore

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Just 'ghes' since we're deprecating 3.0

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Just 'ghes' since we're deprecating 3.0

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Just 'ghes' since we're deprecating 3.0

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Just 'ghes' since we're deprecating 3.0

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Just 'ghes' since we're deprecating 3.0

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Just 'ghes' since we're deprecating 3.0

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Just 'ghes' since we're deprecating 3.0

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Just 'ghes' since we're deprecating 3.0

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Don't depend on hardcoded versions

Co-authored-by: Laura Coursen <lecoursen@github.com>

* Remove static files for 3.0 deprecation (#25649)

Co-authored-by: Laura Coursen <lecoursen@github.com>
 2022-03-03 13:08:24 -06:00
Peter Bengtsson
d0524e5124 make sure req.ip becomes correct (#25628) 
* make sure req.ip becomes correct

* feedbacked
 2022-02-24 17:54:09 +00:00
Peter Bengtsson
c976b9da6a formate /_ip with JSON instead (#25574) 2022-02-23 17:58:39 +00:00
Peter Bengtsson
177e197d8d soft rate limit all requests (#25556) 
* rate limit all requests

* set IP in tags to statsd

* expose _ip route for assuring we get the right IP

* remove old unit test

* nit
 2022-02-23 16:46:29 +00:00
Peter Bengtsson
0d01c5b7b6 refactor developer-site-redirects test code (#25376) 2022-02-15 21:22:50 +00:00
Grace Park
d3cb224cc9 Testing moving the setTimeout outside describe block (#25362) 
* testing moving the setTimeout outside describe block

* Revert "testing moving the setTimeout outside describe block"

This reverts commit 60ddb42ce6f27b729f4db70d2dece39b1d71d59a.

* update setTimeout

* increase timeout

* move settimeout
 2022-02-15 20:38:46 +00:00
Peter Bengtsson
07c8fc3c2a Decouple redirects from language (#24597) 
* experimenting with redirects

* cleanup developer.json

* wip

* clean console.log

* progress

* some progress

* progress

* much progress

* debugging tests

* hacky progress

* ditch latest -> number redirects

* minor

* hacky progress

* lots of progress

* some small fixes

* fix rendering tests

* small fixes

* progress

* undo debugging

* better

* routing tests OK

* more cleaning

* unit tests

* undoing lineending edit

* undoing temporary debugging

* don't ever set this.redirects on Page

* cope with archived version redirects

* adding code comments on the major if statements

* address all feedback

* update README about redirects

* delete invalid test

* fix feedback
 2022-02-14 20:19:10 +00:00