1
0
mirror of synced 2026-01-03 15:05:54 -05:00
Commit Graph

135 Commits

Author SHA1 Message Date
Grace Park
784e937b85 Remove code examples on code security and codespaces landing pages (#36496) 2023-04-20 15:14:07 +00:00
Kevin Heis
cc5a0e9613 Aria labelledby (#36370) 2023-04-13 16:35:30 +00:00
Kevin Heis
022c8b03e6 Add aria-label to external site icons (#36269) 2023-04-07 17:12:11 +00:00
Hector Alfaro
4898d71f8c Show all articles in product landing pages (#36253) 2023-04-07 01:22:06 +00:00
Robert Sese
56db3d6f20 add code examples playwright tests (#36153) 2023-04-04 21:16:42 +00:00
Hector Alfaro
6468744872 Display full title on product landing pages (#35473)
Co-authored-by: Peter Bengtsson <peterbe@github.com>
2023-03-10 15:47:23 +00:00
Evan Bonsignori
3f9651fbdf react page translation audit fixes (#35071) 2023-03-01 07:28:26 +00:00
Grace Park
999690674e Remove breadcrumbs from landing pages (#35177) 2023-02-28 19:36:19 +00:00
Grace Park
5f8f335ad8 Bug fix: shortTitle being undefined (#34741) 2023-02-14 17:57:30 +00:00
Robert Sese
e5370a5990 Feature Branch: Global Nav Phase 2 (#34359)
Co-authored-by: Grace Park <gracepark@github.com>
Co-authored-by: Joe Oak <41307427+joeoak@users.noreply.github.com>
2023-02-13 17:37:47 +00:00
Hector Alfaro
add2b833be Add support for video transcripts in top-level pages (#34528)
Co-authored-by: Rachael Sewell <rachmari@github.com>
2023-02-09 22:21:32 +00:00
Grace Park
ae197983aa Fix double breadcrumbs (#34494) 2023-02-07 00:02:17 +00:00
Robert Sese
9c57e8a298 rename Guides featured links to Start here (#34425) 2023-02-06 18:14:35 +00:00
Grace Park
ef2efb0636 Feature Branch: Global Nav Phase 1 (#33465)
Co-authored-by: Robert Sese <734194+rsese@users.noreply.github.com>
Co-authored-by: Joe Oak <41307427+joeoak@users.noreply.github.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
2023-01-31 17:49:50 +00:00
Peter Bengtsson
2896bd1099 remove encodeEntities on featured link cards (#33935) 2023-01-17 13:19:28 +00:00
Peter Bengtsson
35cf066d00 ToC landing pages should display HTML in intro (#33916) 2023-01-12 17:01:59 +00:00
Grace Park
e3f8f71c42 Rest api versioning redo (#33011)
Co-authored-by: Rachael Sewell <rachmari@github.com>
Co-authored-by: Sarah Edwards <skedwards88@github.com>
Co-authored-by: Grace Park <gracepark@Graces-MacBook-Pro-2.local>
Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>
Co-authored-by: Sarah Schneider <sarahs@github.com>
2022-11-28 11:55:02 -08:00
Peter Bengtsson
8f3df18dba render markdown in intro on map-topic pages (#32421) 2022-11-07 20:28:23 +00:00
Peter Bengtsson
64ee6b2f09 optimize the getCurrentProductTree function (#31620) 2022-10-27 20:13:00 +00:00
Peter Bengtsson
97cc0eb572 only render product_video when needed (#32048) 2022-10-25 20:05:50 +00:00
Peter Bengtsson
bf4873c87b simplify 'items' in TableOfContents prop (#31683) 2022-10-17 12:26:45 +00:00
Peter Bengtsson
e94d5e78ef hide some navigational elements from search text (#31607) 2022-10-13 17:02:05 +00:00
Peter Bengtsson
9897635b8b Scraping product landing pages should have a content body (#31431) 2022-10-10 12:00:41 +00:00
Sarah Schneider
b7f48ea2c1 Support GHAE internal-only semantic versioning (#29178)
Co-authored-by: Peter Bengtsson <mail@peterbe.com>
Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>
2022-09-22 08:26:58 +02:00
Kevin Heis
3cb36aa99f Remove airgap mode (#29964) 2022-08-15 21:05:21 +00:00
Peter Bengtsson
f966792fb5 refactor ClientSideRedirectExceptions (#29737) 2022-08-08 20:42:59 -04:00
Grace Park
cf8150fc9a Fix margin issue and use ActionList.LinkItem (#29639)
fix margin issue and use ActionList.LinkItem'
2022-08-05 00:23:36 +00:00
Peter Bengtsson
37d3bded04 simplify Table of Contents (#28833)
* simplify table-of-contents

* key

* fix rendering tests

* Not so much top margin

* Map topic ToC links are spans

* use p tag

* Back to span for the article title

* Update comment to match markup

* remove hack

* use h2 instead

* fix tests

* fix use of key

* use regular className instead

Co-authored-by: Robert Sese <734194+rsese@users.noreply.github.com>
2022-07-14 14:28:41 +00:00
Grace Park
822fe2926b Megabranch: Upgrade primer/react (#28458)
* upgrade primer/react

* upgrade

* using deprecated

* remove lib"

* Upgrade primer/react: Upgrade Label (#28502)

update Label to primer/react 35.2.2

* fix merge conflicts

* primer/react v35: update ActionList (#28467)

* Update to v35 ActionList for LearningTrack

* Update to v35 ActionList for ArticleList

* Update to v35 ActionList for ProductArticleList

* Update to v35 ActionList for TableOfContents

* Update to v35 ActionList for ProductCollapsibleSection

* Update to v35 ActionList for RestCollapsibleSection

* Update to v35 ActionList for SidebarHomepage

* Update to v35 ActionList for MiniTocs

* Update to v35 ActionList for Search

* Extra div for rendering test

* One less div for rendering test

* All the style updates for v35 ActionList

* Works without setting as an li which is already the default (didn't before for some reason)

* Use deprecated ItemInput for now

* Picker update for primer/react (#28485)

* update picker

* inline picker for mobile

* set width to auto

* Update components/ui/Picker/Picker.tsx

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

* update

* Update Picker.tsx

* update onselect

* checking language code

* move language cookie setting to language picker

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

* Resolve package merge conflicts

* fresh npm install

* Primer update UnderlineNav (#28582)

* update underlinenav for primer/react update

* update tests

* update switches test

* update one last label

* update header test"

* remove href in underlinenav

* update rendering tests

* update cursor

* primer/react v35: update DropDownMenu to ActionMenu (#28576)

* Update to v35 ActionMenu for ArticleCards

* Update to v35 ActionMenu for Search

* Set button to inline-block

* Put the props on the overlay

* Update test for ActionMenu markup

* update package

* update package lock

* primer/react v35: CodeLanguagePicker update from SelectMenu to ActionMenu (#28625)

* Use octicon for menu down arrow

* Update to v35 ActionMenu for CodeLanguagePicker

* update to SubNav

Co-authored-by: Grace Park <gracepark@github.com>

* update package-lock

Co-authored-by: Robert Sese <734194+rsese@users.noreply.github.com>
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2022-07-11 11:51:18 -07:00
Mike Surowiec
20d10a8b80 fix: guides layout cards collapsing (#28570) 2022-06-16 18:39:38 +00:00
Peter Bengtsson
070ac1b823 fix more shorthand eslint warnings (#27952) 2022-05-24 13:23:11 -04:00
Grace Park
b98c83e924 REST operations sidebar (#26225)
* testing out a rest operations sidebar

* cleanup

* renamed 5 files

* renamed 5 files

* set redirect_from on 5 files

* renamed 1 files

* renamed 1 files

* renamed 3 files

* renamed 1 files

* renamed 1 files

* renamed 3 files

* renamed 1 files

* renamed 2 files

* renamed 1 files

* renamed 4 files

* renamed 15 files

* renamed 2 files

* renamed 6 files

* renamed 1 files

* renamed 4 files

* renamed 7 files

* renamed 1 files

* renamed 3 files

* renamed 3 files

* renamed 1 files

* renamed 5 files

* renamed 1 files

* renamed 1 files

* renamed 3 files

* renamed 4 files

* renamed 1 files

* renamed 1 files

* renamed 2 files

* renamed 4 files

* renamed 1 files

* renamed 1 files

* renamed 1 files

* renamed 6 files

* renamed 6 files

* renamed 4 files

* move files

* adding more

* updating to add restcontext and start of removing data/reusables/rest-reference

* removed data/reusables

* add a RestMiniTocItem and updating the filtering to add a subcategory so all manually added H3s are in mini tocs in addition to operations

* remove console log

* [WIP]: REST New Proposal Sidebar (#26471)

* saving

* update sidebar

* remove console log

* update guides and overview

* import Category for category level rest pages

* update undefined restOperations

* update restOperationData category and subcategory levels"

* minor updates

* update get mini toc items function

* updating REST context for sidebar

* updating rest data

* remove console logs

* WIP: mini-toc-ing the sidebar

Co-authored-by: Robert Sese <rsese@github.com>

* A little cleanup

* Fix first subcategory link and add some comments

* updating anchor links in sidebar

* adding updates

* remove standalone

* update product and maptopic pages using article context

* add conditional link wrapper

* fix sidebar toggle and versions for enterprise admin

* update versions per subcategory

* Highlight sidebar link for current page

* Update miniToc hash links and hash change tracking

* fix unique key in CollapsibleSection

* Fix list markup

* remove title

* update permissions

* Hide minitocs on landing (#26594)

* hide minitocs on landing page

* simplify page components and remove minitoc from sidebar for guides/overview

* fix carats and category fix

* remove id

Co-authored-by: Grace Park <gracepark@github.com>

* updating content based on versions script check with the OpenAPI

* update script and content files

* update script and content/rest files

* update to add TocLanding

* update script

* update index files

* add codespaces repository-secrets

* remove openapi schema check script

* remove minitocs at the top

* add h2 about the {title} api

* fix tests/unit/openapi-schema.js

* Fix linting tests

* fix search/topics test

* fix tests/unit/pages test

* update rest/reference links in components

* run prettier

* Update components/rest/RestReferencePage.tsx

Co-authored-by: Rachael Sewell <rachmari@github.com>

* Update components/rest/RestReferencePage.tsx

Co-authored-by: Rachael Sewell <rachmari@github.com>

* Update pages/[versionId]/rest/[category]/[subcategory].tsx

Co-authored-by: Rachael Sewell <rachmari@github.com>

* Update pages/[versionId]/rest/[category]/[subcategory].tsx

Co-authored-by: Rachael Sewell <rachmari@github.com>

* Update pages/[versionId]/rest/[category]/[subcategory].tsx

Co-authored-by: Rachael Sewell <rachmari@github.com>

* Update pages/[versionId]/rest/[category]/[subcategory].tsx

Co-authored-by: Rachael Sewell <rachmari@github.com>

* Update tests/unit/openapi-schema.js

Co-authored-by: Rachael Sewell <rachmari@github.com>

* updating comment location

* remove dependabot override

* remove path-utils current product update for rest

* run linter

* remove dependabot.md and remove h2 heading on restreference

* update the correct product to rest for rest pages

* adding comments for updates to path-utils

* remove console log

* REST sidebar: handle legacy v3 redirects (#26686)

* Add script to handle legacy v3 REST redirects

* Run the script

* Handle a redirect to a redirect

* Update REST test URLs

* 'await' and test runs subcategory of checks

* Update REST URLs for routing/developer-site-redirects tests

* Update developer-redirects fixture with new REST URLs

* Resolve merge conflicts

* Update rest-redirects fixture with new REST URLs

* Fix broken links with REST pages re-org

* redirectTo could be undefined

* Fix script for posterity, can't redirect paths with hashes

* Remove invalid hash redirects

* Typically don't need to save one-off scripts

* Undo redirect changes (not necessary for handling v3 redirects)

* Remove script-added redirects

* Update old v3 redirects with new REST URLs

* No more GHES search indexing page

* 'org' not 'organization'

* Update fixture data for new REST URLs

* revert any content directory changes

Co-authored-by: Grace Park <gracepark@github.com>
Co-authored-by: Rachael Sewell <rachmari@github.com>

* Adding test rest (#26750)

* add test to check openapi schema versions and content rest frontmatter versions

* update lib/redirects

* fix test and add error messages

* adding repository secrets

* adding repository-secrets.md

* Revert "update lib/redirects"

This reverts commit 3aafe28265764d5bc09c0c478c8e0ca099c8fbcf.

* remove lib/redirects changes and console logs

* Update lib/rest/index.js

Co-authored-by: Rachael Sewell <rachmari@github.com>

* update unique key

* Rest client side redirects (#26754)

* adding tags subcategory for the rest content repos category

* run prettier

* bug fix for anchor scrolls" (#26892)

* updating width size for rest reference page

* Rest sidebar consolidation (#26862)

* refactor sidebar

* fix articlecontext provider issue on rest product landing page for all versions

* fix a bug, create new component

* revert change to create new component and fix bug

Co-authored-by: Rachael Sewell <rachmari@github.com>

* Set currentAnchor with a hashchange handler (#26923)

* Rest sidebar design tweaks (#26807)

* Rest sidebar design tweaks

* tweak color to subtle

* use muted color and margin for line

* update to design feedback

Co-authored-by: Grace Park <gracepark@github.com>

* Remove cheerio from rest-collapsible (#26948)

* remove cheerio from rest-collapsible

* update type

* adding endswith instead

* use productId instead

* one off edge case for secret-scanning

* Reorganize subcategory and category, Update pre -> div, Add RestContext (#26950)

* reorganize subcategory and category

* add RestContext

* update comment

* update for endpoints page

* add comment

* move object to restcontext

* remove effectiveDate in restcontext

* remove width calculation for rest reference page

* fix adding manual writer's minitocs to sidebar

* update with feedback

* update comment

* update isRestReferencePage

* remove page component and fix bug

* adding back rest/index.tsx

Co-authored-by: Rachael Sewell <rachmari@github.com>

* update content/rest"

* add back design tweak

* update to div

* update margins on rest api reference

* remove page component

* adding tests

* separate product from rest sidebar (#27065)

* separate product from rest sidebar

* Use ProductCollapsibleSections for product pages

* fix tests

Co-authored-by: Robert Sese <rsese@github.com>
Co-authored-by: Grace Park <gracepark@github.com>

* Rest sidebar translations (#27052)

* update translations

* remove general test

Co-authored-by: Robert Sese <rsese@github.com>
Co-authored-by: Rachael Sewell <rachmari@github.com>
2022-04-20 10:19:48 -07:00
Mike Surowiec
dce7f676ec fix(content): apostrophe in title renders incorrectly in production only (#26859)
* fix(content): apostrophe in title renders incorrectly in production only

* fix(ProductArticlesList): use renderedFullTitle to display childNodes

* fix(lint): run prettier
2022-04-11 18:29:08 -05:00
Ramya Parimi
52889940a8 Merge branch 'main' into fix/#16313 2022-04-08 07:42:29 -05:00
Ritesh Patil
a739577639 fix: code examples searc componenth toescape special characters in regex formattion 2022-04-03 19:26:19 +00:00
Robert Sese
33c05d81ce Change product landing page introLinks to a general map of link titles to links (#26360)
* Add cta button to frontmatter and context

* Add cta to Page

* Render cta button in product landing hero

* Handle external links

* Add simple unit test for cta link

* Address feedback

Co-authored-by: Peter Bengtsson <mail@peterbe.com>

* Actually push condition update

* Show it's an external link

* Refactor FullLink so we use Link once

Co-authored-by: Peter Bengtsson <mail@peterbe.com>

* Custom link can also be null

* Rename 'cta' to 'custom' and make it the last introLink

* Update tests with 'cta' to 'custom' change

* Filter once

* Revert "Filter once"

This reverts commit a3f9a8a06b505d77fed47ca96a66c187c86c3c91.

* Update introLinks to a map of titles and URLs

* No more custom introLink in LandingHero

* Simplify introLinks processing

* introLinks can also be null

Co-authored-by: Peter Bengtsson <mail@peterbe.com>

* more concise

Co-authored-by: Peter Bengtsson <mail@peterbe.com>

* No longer necessary with the a plain introLinks map

Co-authored-by: Peter Bengtsson <mail@peterbe.com>

* '.entries()` is simpler

Co-authored-by: Peter Bengtsson <mail@peterbe.com>

* 'link' could be false depending on what version you're on

* Update test for new introLinks

Co-authored-by: Peter Bengtsson <mail@peterbe.com>
2022-04-01 11:01:37 -05:00
Mike Surowiec
f3fc80cf05 Upgrade primer/components -> primer/react (#25591)
* upgrade primer/components -> primer/react

* fix jest failure
2022-02-24 00:30:14 +00:00
Lucas Costi
a7860a720f Change code-example test to not use Actions (#24979)
* Change code-example test to not use Actions

* Use discussions instead

* Use code-security, but make the 'more' test not an exact number

* Removed references to actions/code-examples.yml

* Update tests/browser/browser.js

Co-authored-by: Robert Sese <robert.sese@gmail.com>

Co-authored-by: Martin Lopes <martin389@github.com>
Co-authored-by: Robert Sese <robert.sese@gmail.com>
2022-02-02 22:32:39 -06:00
Rachael Sewell
bd0cc83d73 use accessible text for view all links (#24747) 2022-01-31 22:02:29 +00:00
Rachael Sewell
845de4f29d add underline to categories in all docs section (#24818) 2022-01-31 18:22:49 +00:00
Robert Sese
60aa8347f5 Bold-ify supported release card links (#24736) 2022-01-27 15:46:32 -06:00
Peter Bengtsson
b32df3dfb9 display title if no shortTitle on product landing pages (#24657)
* display 'title' if no 'shortTitle' on product landing pages

* remove pointless shortTitles

* Revert "Fix search sync (#24620)"

This reverts commit 16c9fc3ec5.

* undo

* undo sample changes
2022-01-26 16:30:45 +00:00
Grace Park
eb776f64e4 Small accessibility changes - adding ul to li (#24449)
* adding ul to li

* move ul for just the mobile picker
2022-01-20 17:54:49 +00:00
Robert Sese
54af81acd5 a11y: update code example search (#24226)
* Search on submit

* Should be a ul

* Fix broken link

* No search on change event

* Add translation strings

* Add role for the 0 results message

* Update test with new search behavior

* Make search input a controlled component

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Trim whitespace in search text

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Better variable names

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Update visible results count in useEffect

* Control the input's value with the typed state

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Inline the submit handler

Co-authored-by: Peter Bengtsson <peterbe@github.com>

Co-authored-by: Peter Bengtsson <peterbe@github.com>
2022-01-19 12:53:50 +00:00
Robert Sese
1c768fe9a0 a11y: even more headings adjustments (#24315)
* Adjust Enterprise supported release card heading

* Adjust learning track headings

* Adjust guide list card headings
2022-01-14 20:08:55 +00:00
Robert Sese
cc69799558 a11y: landing page headings adjustments (#24295)
* Adjust heading level and only heading with intro text

* Adjust heading level

* Adjust code example and guide card heading levels

* Adjust tests for new heading levels

* Adjust rendering test for new heading levels
2022-01-14 17:23:05 +00:00
Grace Park
d5097397c8 underline links on toc pages (#24217) 2022-01-11 20:48:35 +00:00
Grace Park
f5c615cbd0 Guides List markup and Link Icon in Permalink Headings (#24211)
* list markup for article cards and learning paths

* adding link icon to section permalinks
2022-01-11 11:38:57 -08:00
Robert Sese
d31d6a5b4e a11y: add title text for view all links (#24193)
* Add optional 'view all' title text in the context

* Use viewAllTitleText in ArticleList

* Set viewAllTitleText for sections with 'view all' links
2022-01-11 01:30:10 +00:00
Grace Park
65db364ef1 remove avatar for accessibility (#23706) 2021-12-16 17:09:35 +00:00