1
0
mirror of synced 2026-01-05 12:07:35 -05:00
Commit Graph

50 Commits

Author SHA1 Message Date
Sarah Schneider
6662e027b0 let, not const and one more regex tweak 2020-11-23 13:04:11 -05:00
Sarah Schneider
10c7ba7855 include full content including frontmatter, and tweak some regexes 2020-11-23 12:51:15 -05:00
Kevin Heis
912ac50034 End AB test on moving helpfulness prompt to bottom (#16552)
* End AB test on moving helpfulness prompt to bottom

* Move helpfulness to bottom of page only

* Update helpfulness.js

Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2020-11-20 12:24:33 -08:00
Jason Etcovitch
cc719ffb6f Render Enterprise release notes on docs.github.com (#16367)
* Create basic layout

* Create stubbed out release note YAML

* Get a real implementation going

* Simplify using site-data

* Add a real page to send from render-page.js

* Use array of patches

* Render patches

* Add sidebar and breadcrumbs

* Reverse order

* Add date

* Tweak labels

* Redirect to entweb for missing versions

* Render patch.intro

* Move to separate files for patches

* Show support for RC versions

* Improve some comments

* Sticky headers!

* Remove a console log

* Improve example formatting

* Add a link on /admin

* Add a schema and test

* Move to /index.md, add version_num filter

* Improve layout

* Use <details>

* Placeholder more realistic notes

* Don't require links in index pages

* Remove admin/index link for now

* Remove unused frontmatter field

* Add a test for middleware

* Fix remaining YAML file to test CI

* Update 2-rc.yml

* Don't call it RC

* Just push

* Make a main a div

* Fix a borked class

* Lint YAML files

* Improve Download link

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>

* Improve check order

* Move to contextualizers

* Use alternative version thing

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>

* Move back to `release-notes.md`

* Use version for anchor IDs

* Undo category-pages test change

* Fix borked details layout in Chrome

* Improve mobile setup

* Render markdown in note tags

* Use allVersions[currentVersion] again

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>

* Undo change to extended-markdown

* Add whitespace so it renders markdown bits

* Remove 2-22 files

* Add check for any release notes

* Fix the failing tests

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>
2020-11-20 13:33:11 -05:00
Jason Etcovitch
52dbd92144 Rewrite links in Page.intro with language (#16550)
* Add defaultLanguage behavior

* Add a million logs because I'm confused

* Rewrite intro links

* Undo changes to detect-language

* Add a test
2020-11-19 15:53:35 -05:00
Sarah Schneider
0c3a46f205 update asset path for <2.13 CSS files 2020-11-18 12:53:39 -05:00
Sarah Schneider
84f0aac8f6 Merge branch 'main' of github.com:github/docs-internal into deprecate-2.19 2020-11-17 21:20:38 -05:00
Jason Etcovitch
8f2b4eb450 Merge branch 'main' into repo-sync 2020-11-17 18:02:58 -05:00
Sarah Schneider
a3559e12bd remove test that should have been removed in #16490 2020-11-17 16:34:20 -05:00
Nick Schonning
b6de7c6887 chore: Convert Standard to eslint-config-standard (#1328)
* chore: Move standard to ESLint config

* fix: auto-fix ESLint indent issues

* fix: ESLint prefer-regex-literals

* fix: ESLint array-callback-return

- .filter must return a boolean value
- .map replaced with forEach when the value isn't used

* fix: ESLint no-extra-semi
2020-11-17 16:18:18 -05:00
Sarah Schneider
8bb7120185 lint 2020-11-17 11:45:18 -05:00
Sarah Schneider
bed7ecc890 Update tests/routing/deprecated-enterprise-versions.js
Co-authored-by: Jason Etcovitch <jasonetco@github.com>
2020-11-17 11:37:54 -05:00
Sarah Schneider
a895ef68ba update tests 2020-11-16 20:07:04 -05:00
Sarah Schneider
a8f16c63f7 Do not include feedback links in deprecated GHES versions (#16485)
* do not render if this is the oldest supported GHES release

* add tests
2020-11-16 17:09:19 -05:00
Kevin Heis
714ca0263b Add hostname to events (#16419)
...so that its easier to filter out localhost and herokuapp domains
2020-11-16 09:49:12 -08:00
jmarlena
45398e709c Password authentication and OAuth Authorizations API deprecation (#16375)
* Version password examples for GHES only

* Remove unnecessary note

* Versioned deprecation reusable for GHES only?

* Update troubleshooting article

* Version OAuthorizations REST API page for enterprise-only

* Remove deprecations reusable

* Add tentative note

* Rework two-factor authentication sections

* Fix double redirect reference

* versioning tweak

* Versioning tweaks

* adding back the endifs

* random link reformatting

* OAuth Authorization API versioned for 2.22

* /

* Fix internal docs links

* remove static redirect for dotcom

* Try deleting redirect

* Apply @martin389's suggested changes

Co-authored-by: Martin Lopes <54248166+martin389@users.noreply.github.com>

* Remove best practice assumptions

* Apply suggestions from code review

Co-authored-by: Martin Lopes <54248166+martin389@users.noreply.github.com>

* Add note

* restore redirects in content file and remove free-pro-team expected path from test fixture

* change note position

* handle path that was available on dotcom in developer site but is now GHES only

Co-authored-by: Martin Lopes <54248166+martin389@users.noreply.github.com>
Co-authored-by: Sarah Schneider <sarahs@github.com>
2020-11-13 11:01:17 -08:00
Sarah Schneider
5705d334ca Header notification updates (#16425)
* remove middleware that sets notification flags

* move all notification handling into includes/header-notification.html

* update tests
2020-11-12 16:27:29 -05:00
Jason Etcovitch
9e38a854b9 Filterable code examples on Actions landing page (#16276)
* Add custom hover shadows

* Support avatars

* Add guide-card include

* Use it in product-landing

* Add gradient styles

* Add guides frontmatter

* Use guideArticles instead of full objects

* Add support for authors

* Add support for category header

* Just pass the whole page

* Use it

* guide.url => guide.href

* Use `*.githubusercontent.com`

* Fix mobile card width

* Remove showDescription check

* Use featureLinks.guideCards

* Forgot an if

* Add contextualizers/actions-code-examples

* Use code-example-card include

* Tweak sizing/shadows

* Add a basic filterer

* Some visual tweaks

* labels => tags

* Cleanup some code

* Improve spacing on mobile

* Add "No results!" blurb

* Fix a boog

* Tweak spacing

* Remove support banner

* Improve "No results" state

* Just use login instead of name/avatarUrl

* Change card spacing

* Use circular avatars

* Add "Show more" button

* Add margin beneath "Guides"

* Use smaller font

* Assume github.com for code examples

* Show two columns at small screen

* Make "Show more" a btn

* Use the "repo" octicon

* Link to contributing guide

* Use a YAML file instead of a middleware

* Link straight to the file

* Fix some wonky markuip

* Fix a broken link

* Fix the borked test

* Allow variables that aren't strings

* Fix remaining tests
2020-11-12 11:35:43 -05:00
Sarah Schneider
dfb29cfb59 Remove no longer needed middleware (#16384)
* remove no longer needed middleware

* remove accompanying test
2020-11-06 14:14:28 -05:00
Nick Schonning
87e8d1b4b0 chore: Remove locales from docs.microsoft.com urls (#1011) 2020-11-04 14:43:27 -08:00
Sarah Schneider
ba310bf991 Support GHAE in Algolia (#16315)
* add frontend search support for GHAE version

* add support for GHAE version to Algolia sync

* add browser tests for frontend search

* if a version can be derived from a path, but it is not a real version (like from a path that 404s), fall back to dotcom

* Update javascripts/search.js

* Update lib/algolia/sync.js
2020-11-03 15:35:56 -05:00
Jason Etcovitch
5d09adb106 Add/use small-footer for Actions landing page (#16265)
* Add/use small-footer

* Fix borked HTML

* Extract scripts to new include

* Add spacing

* Fix some padding

* Fix a test that uses /actions

* Fix old links

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>

* Update /developers in general footer

* Don't hard code free-pro-team

* Use the small-footer everywhere

* Tweak border

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>
2020-11-03 13:12:25 -05:00
Chiedo John
7924aea2f8 Instruct search engines to not crawl archived versions (#16292)
* Instruct search engines to not crawl archived versions

* Update middleware/robots.js

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>

* Add test

* Fix spooky bug

Co-authored-by: Chiedo <chiedo@users.noreply.github.com>
Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>
2020-11-03 08:23:22 -05:00
Matt Pollard
2484cd3f16 Add external GitHub CLI product (#16277) 2020-11-03 08:11:49 +01:00
Laura Coursen
a3e1733aa1 GitHub AE (GHAE) (#16090) 2020-11-02 15:12:44 -06:00
Jason Etcovitch
174d8539c6 Support arbitrary keys in new featuredLinks frontmatter (#16239)
* Add featuredLinks to frontmatter

* Parse them in featured-links.js

* Remove old raw setup

* Use them

* Missed a couple

* Update translation files

* Fix frontmatter schema

* Loop over the right object

* Also update translations' usage

* Update docs and tests

* Better README comment

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>

* Return next()

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>
2020-10-27 13:53:10 -04:00
Rachael Sewell
f22a82fcfb translate openapi versioning (#16202) 2020-10-26 14:38:30 -07:00
Kevin Heis
d743ff9512 Remove more Google Analytics references (#16194) 2020-10-26 14:17:49 -07:00
Sarah Schneider
e122f8c706 give link checker access to enterpriseServerVersions (#16198)
Co-authored-by: James M. Greene <JamesMGreene@github.com>
2020-10-23 16:19:28 -05:00
Kevin Heis
3daacd9a6b Add new schemas for redirect, copy, print (#16175)
* Add new schemas for redirect, copy, print

* Update schema-event.js

* Update events.js

* Copy -> Clipboard

* Update events.js
2020-10-23 09:31:58 -07:00
Sarah Schneider
095410dcb0 Throw error on mismatched versioning (#16191)
* throw an error if a page is available in a version that its parent product is not available in

* add tests

* fix one Insights content file versioned for FPT when Insights is only available in GHES currently
2020-10-23 11:13:05 -04:00
Kevin Heis
8940279c82 Remove Google Analytics (#16158) 2020-10-22 15:41:46 -07:00
Kevin Heis
c56065784a Create a user agent parser for analytics (#15915)
* Create a user agent parser for analytics

* Update user-agent.js

* Update user-agent.js

* Update user-agent.js

* Use user agent parser and remove test code

* Add some tests for user agents

* Add regeneratorRuntime

* Add babel-preset

* Just guessing at this point

* Update package.json

* Revert package changes
2020-10-21 07:43:09 -07:00
Kevin Heis
8982d200cc Migrate experiments and helpfulness to Hydro (#16059)
* Migrate experiments and helpfulness to Hydro

* Clean out old tests

* ...and more old tests to delete
2020-10-19 14:31:54 -07:00
Sarah Schneider
da60aa51e1 Support enterpriseServerVersions in Liquid statements (#16058)
* remove outdated and redundant context.enterpriseVersions and add new context.enterpriseServerVersions

* update references from context.enterpriseVersions -> context.enterpriseServerReleases

* add test

* also test oldest supported enterprise version in addition to the latest

* Script to update not-free-pro-team conditionals (#16060)

* script to update not-free-pro-team conditionals

* change string to regex so we can do replace all

* remove stray test.only

* Update middleware/context.js

Co-authored-by: James M. Greene <JamesMGreene@github.com>

* Update tests/unit/page.js

Co-authored-by: James M. Greene <JamesMGreene@github.com>

* Update tests/unit/page.js

Co-authored-by: James M. Greene <JamesMGreene@github.com>

* Update tests/fixtures/page-versioned-for-all-enterprise-releases.md

Co-authored-by: James M. Greene <JamesMGreene@github.com>

Co-authored-by: James M. Greene <JamesMGreene@github.com>
2020-10-15 16:20:41 -04:00
Sarah Schneider
f42530c35d Support redirects to /v3 and /v4 links that have the new version format (#16037)
* add temporary redirect support

* add temporary redirect tests

* add ENDYANK comments per @zeke suggestion
2020-10-15 09:20:27 -04:00
Jeff McAffer
0c7b877763 add slash() calls to fix windows paths 2020-10-08 19:57:09 -07:00
Zeke Sikelianos
03e728f184 fix endpoints-available-for-github-apps page (#15933)
* fix endpoints-available-for-github-apps page

* lint
2020-10-08 14:11:43 -07:00
Zeke Sikelianos
01f53f2f7a Fix tests for Actions AllowList (#180)
* fix tests for Actions AllowList

* add more allowed actions

* Update tests/unit/actions-workflows.js

Co-authored-by: Tom Jenkinson <tjenkinson@users.noreply.github.com>

* Update allowed-actions.js

Co-authored-by: Tom Jenkinson <tjenkinson@users.noreply.github.com>
2020-10-08 11:55:09 -07:00
Kevin Heis
7c0c493c35 Sending events to POST /events endpoint (#15796) 2020-10-08 09:24:41 -07:00
Zeke Sikelianos
716d974faf test for allowed Actions (#15850)
* test for allowed actions

* lint

* empty commit
2020-10-05 10:54:16 -07:00
Sarah Schneider
d7d5513024 Make homepage available in all versions (#15846)
* make homepage available in all versions by default

* update hardcoded test
2020-10-01 16:51:44 -04:00
Sarah Schneider
f272eec944 Remove deprecated GHES versions from content and data (#15830)
* ran script/remove-unused-assets.js (manually removed unused variables printed by the script)

* package-lock

* turn elsif into two ifs to prepare for running Liquid deprecation script

* ran script/remove-deprecated-enterprise-version-markup.js --release 2.14 (ONLY UPDATES LINE BREAKS ETC.)

* ran script/remove-deprecated-enterprise-version-markup.js --release 2.15

* ran script/remove-deprecated-enterprise-version-markup.js --release 2.17

* ran script/remove-deprecated-enterprise-version-markup.js --release 2.18

* update hardcoded test

* Update content/github/collaborating-with-issues-and-pull-requests/filtering-files-in-a-pull-request.md

Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>

* add currentVersion is NOT free-pro-team to conditional, to make sure the deprecation script does the right thing when it is time to deprecate 2.21

Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>
2020-10-01 10:55:34 -04:00
Sarah Schneider
0b1c7ad466 Update Enterprise Liquid deprecation handling to use new versions (#15818)
* update Liquid deprecation fixtures to use new versions

* update module that removes deprecated GHES frontmatter for new versions

* update module that removes deprecated GHES conditionals for new versions

* update script to use new versions and also remove internal-developer checkout option

* update deprecated Liquid tests to use new versions

* remove unnecessary leading slash in getEnterpriseServerNumber pattern

* include a step that runs script/remove-unused-assets.js

* Update script/remove-deprecated-enterprise-version-markup.js

Co-authored-by: Jason Etcovitch <jasonetco@github.com>

* require script instead of execSync

Co-authored-by: Jason Etcovitch <jasonetco@github.com>
2020-09-30 19:29:08 -04:00
Jason Etcovitch
239643b094 Add basic Hydro SDK (#15725)
* Add back changes from prior to purge

* Add back in updates since main change

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2020-09-30 12:49:27 -04:00
Vanessa Yuen
566d1a7708 Add analyticsTags to Algolia search queries (#15719) 2020-09-30 18:31:04 +02:00
Jason Etcovitch
caaee7a124 Update all files to use {% data %} (#15253)
* Add back changes from prior to purge

* Manually fix some invalid Liquid

* Updoot render-content

* Improve test messages to show correct output

* Run el scripto

* Pass the remaining test
2020-09-29 16:01:04 -04:00
Sarah Schneider
aa5a62d49d Remove versions feature flag code (#15793)
* remove FEATURE_NEW_VERSIONS from feature-flags.json

* remove process.env.FEATURE_NEW_VERSIONS from include files

* remove process.env.FEATURE_NEW_VERSIONS from lib files

* remove process.env.FEATURE_NEW_VERSIONS from middleware files

* remove process.env.FEATURE_NEW_VERSIONS from script files

* remove process.env.FEATURE_NEW_VERSIONS from test files

* update test fixtures to use new versions as canonical fixtures
2020-09-29 13:36:07 -04:00
Kevin Heis
c450d8d555 Send CSRF tokens over XHR (#15778)
* Send CSRF tokens over XHR

* Update events.js

* Update browser.js
2020-09-28 09:44:14 -07:00
Vanessa Yuen
3df90fc9b8 Hello git history spelunker!
Are you looking for something? Here is all of the GitHub Docs history in one single commit. Enjoy! 🎉
2020-09-27 14:10:11 +02:00