jprdonnelly/docs
1
0
Fork 0
mirror of synced 2026-01-04 09:06:46 -05:00
Code Issues Projects Releases Wiki Activity
3,941 Commits 28 Branches 1 Tag
e2e3fac554fa4fce03ea7304993e888c0e2b7d28
Commit Graph

145 Commits

Author SHA1 Message Date
Jason Etcovitch
591e22d8b1 Rename release notes for 3.0.0-rc to 3.0.0.rc (#17510) 
* Change -rc versions to .rc\d*

* Fix the download link

* Rename to 3.0.0.rc1
 2021-01-27 15:27:48 +00:00
Sarah Schneider
35e430c96d Merge branch 'main' into make-developer-redirects-static 2021-01-26 11:30:16 -05:00
Sarah Schneider
9f3e2b6017 handle edge case 2021-01-25 16:35:15 -05:00
Sarah Schneider
87bc25d7ca Merge branch 'main' of github.com:github/docs-internal into make-developer-redirects-static 2021-01-25 12:31:23 -05:00
Vanessa Yuen
9bc90cd932 Learning Track navigation banner (#17440) 
* add middleware to handle `learn` query param

* add exception to query-less cache key

* add querystring to learning track guides
 2021-01-25 16:57:32 +00:00
Kevin Heis
6ae96188f2 Move 404 and 500 images to local (#17432) 2021-01-22 21:49:45 +00:00
Sarah Schneider
3aed23bdc9 Merge branch 'main' into make-developer-redirects-static 2021-01-21 14:14:57 -05:00
Kevin Heis
c51f5390d4 Move search results to use relative urls (#17411) 
* Move search results to use relative urls

* ..and now we have real mark tags instead of em tags

Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
 2021-01-21 17:23:16 +00:00
Sarah Schneider
8198dd4ce7 Merge branch 'main' of github.com:github/docs-internal into make-developer-redirects-static 2021-01-20 15:08:35 -05:00
Kevin Heis
c21a738e95 Make browser search tests green (#17385) 
* Make browser search tests green

* Okay... lodash get then _Linter_ ugh
 2021-01-20 16:20:32 +00:00
Kevin Heis
2fb2e962bc Move site search to use an endpoint (#17359) 
* Move site search to use an endpoint

* Update browser.js

* Update search.js

* Update lib/search/versions.js

Co-authored-by: James M. Greene <JamesMGreene@github.com>

* Fix URLs

Co-authored-by: James M. Greene <JamesMGreene@github.com>
 2021-01-20 15:37:42 +00:00
James M. Greene
9724f763f5 Implement discount fingerprinting without webpack (#17337) 2021-01-19 23:00:54 -06:00
Sarah Schneider
a54c3ffd5a use new static file instead of searching live set of pages 2021-01-19 17:43:55 -05:00
Sarah Schneider
752edcfc53 use new static redirects file instead of precompiling on every server restart 2021-01-19 10:46:32 -05:00
Vanessa Yuen
b46da8dfc7 Sublanding page all guides section (#16869) 
* get link liquid tag to accept variables as param

* new liquid tag `link_as_article_card`

* refactor link liquid tag slightly so we can control what props get rendered

* generalize filterCodeExample to use in all guides section

* pass in `js-filter-card-max` instead of hardcode max

* tweaks and add `data` to CSP for images

* add liquid tag tests

* add some browser tests for card filters

* we still need to rely on `getPathWithLanguage` for hrefs that already have the language code embedded


Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
 2021-01-18 12:23:23 +00:00
Sarah Schneider
3bf432e656 refactor 2021-01-15 11:21:52 -05:00
Sarah Schneider
3ff1bfca5a account for early access 2021-01-15 10:49:12 -05:00
Sarah Schneider
a394190ad6 Merge branch 'remove-fpt' of github.com:github/docs-internal into remove-fpt-helper 2021-01-14 17:13:06 -05:00
Sarah Schneider
ecaec6e78e Merge branch 'main' of github.com:github/docs-internal into remove-fpt 2021-01-14 17:12:27 -05:00
Sarah Schneider
a66268cc83 add helper to middleware/breadcrumbs 2021-01-14 17:07:09 -05:00
Rachael Sewell
81a9415ff4 fix GraphQL exception (#17274) 2021-01-14 11:17:43 -08:00
Sarah Schneider
7c1ab5929e Merge branch 'remove-fpt' of github.com:github/docs-internal into remove-fpt-helper 2021-01-14 13:44:10 -05:00
Sarah Schneider
2b31096312 Merge branch 'main' into remove-fpt 2021-01-14 13:44:02 -05:00
Sarah Schneider
b511758057 add remove-fpt helper function 2021-01-14 13:34:32 -05:00
Sarah Schneider
ed8b46267c Merge branch 'main' of github.com:github/docs-internal into remove-fpt 2021-01-14 12:08:27 -05:00
Sarah Schneider
b6032f285c remove helper from this branch (to be re-added in child branch for easier reviewing) 2021-01-14 12:07:49 -05:00
Sarah Schneider
c0973a7a36 Merge branch 'main' into support-ga-in-deprecated-versions 2021-01-14 09:00:41 -05:00
Melanie Yarbrough
c2336bb11e [DO NOT MERGE] GitHub Enterprise Server 3.0 release candidate megabranch (#16479) 2021-01-13 19:16:05 -08:00
Sarah Schneider
79a7a7972f Merge branch 'main' of github.com:github/docs-internal into remove-fpt 2021-01-13 16:58:05 -05:00
Sarah Schneider
d752732b16 update refs to reinstated findPage() 2021-01-13 16:49:35 -05:00
Sarah Schneider
d0b89fb593 update csp 2021-01-13 14:31:39 -05:00
Sarah Schneider
73bc187171 update csp 2021-01-13 14:28:11 -05:00
Sarah Schneider
f31aa9c75a fix csp errors on older versions 2021-01-13 13:32:47 -05:00
Vanessa Yuen
641ed02e81 Actions Guides sublanding page (#16740) 
Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
Co-authored-by: Cynthia Rich <crichID@github.com>
 2021-01-11 18:30:57 +01:00
Sarah Schneider
9d318e0380 Merge branch 'main' of github.com:github/docs-internal into remove-fpt 2021-01-08 11:06:27 -05:00
Rachael Sewell
3194a2db0b fix exception with unsupported version (#17088) 
Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
 2021-01-08 14:08:05 +00:00
Sarah Schneider
1dd9f3cbf1 account for homepage version 2021-01-07 15:21:22 -05:00
Sarah Schneider
ead1dc202c Merge branch 'main' of github.com:github/docs-internal into remove-fpt 2021-01-07 14:43:50 -05:00
Sarah Schneider
33f93e39c7 remove overloaded helper functions and move code directly where it is used 2021-01-07 13:14:44 -05:00
Chiedo John
29be6be5c9 Make rate limiter configuration verbose (#17184) 
Make rate limiter configuration verbose to prevent confusion in the
future.

Co-authored-by: chiedo <chiedo@users.noreply.github.com>
Co-authored-by: James M. Greene <JamesMGreene@github.com>
 2021-01-07 16:40:50 +00:00
James M. Greene
9171d17d23 Ignore query strings and fragment identifiers for Redis cache keys (#17205) 
* Ignore query strings and fragment identifiers for Redis cache keys

* Don't serve cached responses if developer is requesting JSON debugging info
 2021-01-07 09:42:53 -06:00
James M. Greene
ae20d046c5 Pass the Redis database number as an option rather than in the URL (#17194) 
* Pass the Redis database number as an option rather than in the URL

* Remove rogue 'console.log'
 2021-01-06 18:48:21 -06:00
James M. Greene
068c472084 Cache rendered pages in Redis (#17106) 
* Explicitly set the Redis database number used for rate limiting

* Switch to using ioredis as the Redis client for rate limiting

* Install ioredis-mock as a primary dependency

* Create a Redis BasicAccessor class and tests

* Switch rendered page caching to use Redis for storage

* Add support for additional Redis SET options like TTLs

* Remove currently unused methods

* Rename redis-accessors/basic to redis-accessor and remove extra fluff

* Change default behavior for cache setting to throw if an error occurs

Add option allowSetFailures to facilitate graceful failures

* Allow SET failures to fail gracefully for the rendered page cache

* Remove as-yet unneeded serialization options from RedisAccessor

* Move Redis client construction into RedisAccessor constructor, just pass in databaseNumber as option

* Remove rendered-page-cache in favor of direct RedisAccessor use

* Add tests for RedisAccessor constructor param validations

* Eliminate one roundtrip to Redis for the cached HTML existence check

Are we fast yet?

* Set a rendered page cache TTL of 24 hours
 2021-01-06 15:30:51 -06:00
Kevin Heis
d7eb248a10 Fix a bunch of random typos (#17129) 
Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
 2021-01-05 16:07:27 +00:00
Kevin Heis
c62f49aa0e Block indexing not crawling (#17044) 
* Block indexing instead of crawling

* Lint

* Update deprecated-enterprise-versions.js

* Combine loops
 2020-12-17 11:57:18 -08:00
Chiedo John
9ab71614fc Merge branch 'main' into revert-16952-revert-16947-optimize-sitetree 2020-12-16 15:03:20 -05:00
Chiedo John
5fbd6f2173 Make the breadcrum middleware fail safely (#17009) 
Make the breadcrumb middleware fail safely

Co-authored-by: chiedo <chiedo@users.noreply.github.com>
Co-authored-by: Vanessa Yuen <6842965+vanessayuenn@users.noreply.github.com>
Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>
 2020-12-16 14:42:45 +00:00
Sarah Schneider
dca55a0257 Revert "Revert "sitetree optimizations"" 2020-12-14 20:25:01 -05:00
Sarah Schneider
b38eec9964 Revert "sitetree optimizations" 2020-12-14 16:53:04 -05:00
Sarah Schneider
7c15750124 account for lang code now being part of siteTree paths 2020-12-14 15:39:57 -05:00