1
0
mirror of synced 2026-01-04 00:06:20 -05:00
Commit Graph

104 Commits

Author SHA1 Message Date
Jason Etcovitch
4a761418a9 Add a test for the WIP language banner link change (#17480)
* Add a test

* Try adding de

* Let's try all languages
2021-01-26 20:06:58 -05:00
Jason Etcovitch
b4171bf0d5 Use AST parsing for lint file checking (#17471)
* Add markdown parsing dependencies

* Use it for the link test

* Use ast tests for hard-coded language

* Dedupe visiting for links

* Add new mdast utils to check-deps exclusions
2021-01-26 17:45:23 +00:00
Kevin Heis
99a85ff4ef Push query string when searching (#17417)
* Push query string when searching

* Update search.js

* Fix browser test, remove querystring dependency (new shiny!)

* Remove language and version from visible URL

* Avoid casting event interface

* Update search.js

* Update browser.js
2021-01-25 11:52:55 -08:00
Sarah Schneider
6bbd10838d we do not need this env var anymore 2021-01-22 10:07:13 -05:00
Sarah Schneider
b0677b2442 use script instead of jest, much faster 2021-01-22 09:28:06 -05:00
Sarah Schneider
0c5b78ee3b use linkinator for internal link checking 2021-01-21 16:36:22 -05:00
Kevin Heis
2fb2e962bc Move site search to use an endpoint (#17359)
* Move site search to use an endpoint

* Update browser.js

* Update search.js

* Update lib/search/versions.js

Co-authored-by: James M. Greene <JamesMGreene@github.com>

* Fix URLs

Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-01-20 15:37:42 +00:00
Sarah Schneider
03d7260abb update linkinator 2021-01-12 10:02:59 -05:00
James M. Greene
068c472084 Cache rendered pages in Redis (#17106)
* Explicitly set the Redis database number used for rate limiting

* Switch to using ioredis as the Redis client for rate limiting

* Install ioredis-mock as a primary dependency

* Create a Redis BasicAccessor class and tests

* Switch rendered page caching to use Redis for storage

* Add support for additional Redis SET options like TTLs

* Remove currently unused methods

* Rename redis-accessors/basic to redis-accessor and remove extra fluff

* Change default behavior for cache setting to throw if an error occurs

Add option allowSetFailures to facilitate graceful failures

* Allow SET failures to fail gracefully for the rendered page cache

* Remove as-yet unneeded serialization options from RedisAccessor

* Move Redis client construction into RedisAccessor constructor, just pass in databaseNumber as option

* Remove rendered-page-cache in favor of direct RedisAccessor use

* Add tests for RedisAccessor constructor param validations

* Eliminate one roundtrip to Redis for the cached HTML existence check

Are we fast yet?

* Set a rendered page cache TTL of 24 hours
2021-01-06 15:30:51 -06:00
Kevin Heis
59f375ab1d Merge branch 'main' into default-platform 2020-12-16 14:36:46 -08:00
Kevin Heis
0f685115f7 Revert file reads from async to sync (#16979)
* Revert file reads from async to sync

* Async funness

* Fix warm server timers

Co-authored-by: Chiedo John <chiedo@chiedosbmacbook.lan>
2020-12-15 22:04:41 +00:00
Jason Etcovitch
eaf2a67fa1 Use connectDatadog(e) (#16888)
* npm i connect-datadog

* Add connectDatadog middleware

* Add comments

* Use DD_API_KEY to gate

Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2020-12-11 13:13:18 -05:00
Simran Spiller
4afc7d4035 Merge remote-tracking branch 'upstream/main' into default-platform 2020-12-11 01:13:32 +01:00
Vanessa Yuen
f44d5aa648 Add VS Code debugger config (#16819)
* add config for using vscode debugger

reference: https://github.com/Microsoft/vscode-recipes/tree/master/nodemon

* some docs

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2020-12-10 18:37:06 +00:00
Kevin Heis
e7406b7336 Merge branch 'main' into default-platform 2020-12-09 15:06:30 -08:00
Kevin Heis
1b424dfdc4 Bring in data-directory, let's go async file reads (#16782)
* Bring in data-directory, let's go async file reads

* Lint fixes

* Update glossary.js
2020-12-09 11:20:24 -08:00
Kevin Heis
62889986b6 Revert "Revert "Speed up warmServer by loading pages (and files) asyn… (#16837)
* Revert "Revert "Speed up warmServer by loading pages (and files) asynchronously (#16752)" (#16835)"

This reverts commit a14517115f.

* Move async to regular dependencies

* Update package-lock.json
2020-12-09 17:40:58 +00:00
Simran
2a3fdd43ac Merge branch 'main' into default-platform 2020-12-09 02:06:46 +01:00
Simran Spiller
5522b58b4d Use cross-env for package script 'browser-test-tests'
Fixes 'npm run browser-test' for Windows
2020-12-09 01:26:18 +01:00
Meg Bird
754ceda517 [Universe] Discussions Public Beta (#16547)
* Update README

* create structure for discussions landing page

* is everything broken

* [Universe] Dark mode (#16545)

* Fix title

* Add Discussions product

* Correct title

* Correct title

* Move quickstart article

* Move quickstart back out into article

* Add and incorporate reusables

* Move information about search

* Draft conceptual information

* Draft best practices

* Draft further reading

* Draft product introduction

* Draft introduction

* Add author metadata

* Pluralize

* Fix typos

* Add introduction

* Bump Octicons

* Add some reusables

* Add images

* Revise article

* Draft article

* Change word

* 🔪 the gerund

* Add reusable

* Revise introduction

* Revise list

* Simplify

* Revise reusable

* Fix reusable; add context

* Rename reusable

* Deduplicate conceptual information

* 🔪 gerund

* Add link to further reading

* Move link and dispose of tip

* Delete space

* Add images

* Add conceptual section

* Add word

* Delete newline

* Revert package.json to state on main

* Tweak images

* Draft article

* Add product name

* Remove beta note

* Use product name for future-proofing

* Begin adding search information

* Fix copypasta

* little edits

* build out a bit more of the guides content

* Don't mention integrations for now

* Escape quote

* Remove authorship information for new defaults

* Finish drafting article

* Replace encoded character to match description

* Revise away inline link

* Accommodate 'for more information' in reusable

* Fix links

* Fix one last bit of copypasta

* Update indices

* Temporarily remove heading

* Update introduction

* Add new article 💀

* Remove commits from universe-2020-megabranch

* Add article 💀

* update with a very rough draft

* Add content about collaboration options to "About repositories"

* Add content about discussions to "About issues"

* Reorder content

* Add is:discussion query

* update with a few mmore fleshed out sections

* update with more structure

* Add reusable

* Add screenshots

* Clear way for actual procedural

* Discussions landing page "Communities" section (#16692)

* Make button Overview-able

* Make card filtering more extensible

* Guard for missing attributes

* Use arbitrary dataset attributes

* Add section with discussions-community-card

* Tweak show more button behavior

* Conditionally show "Show more"

* Add beta_product frontmatter/label

* Remove beta callout note

* Hide changelog with no items

* Finish importing community info

* Fix borked markup

* Omit search abr

* Two columns should actually be two columns

* Use org image, change card layout

* Add two more examples

* Fix title

* Escape quote

* Escape another quote

* Draft article

* Lower case

* Relocate conceptual information

* Update qualifier name

* Draft article

* Add conceptual information and links

* Remove duplicative section

* Fix copypasta

* Revise reusable

* Update link

* Add content on categories

* Lint the discussions YAML file

* Update introduction and permissions

* 

* Reusablize; fix link

* more planning content stuff

* Escape quotes

* Align prerequisites

* Soften

* Clean up prerequisites

* Fix titles; version; add screenshot

* Fix links

* Actually fix links

* Use better variable

* Mention pinning

* Update screenshots

* Add screenshot

* forgot to committ

* update with reusable

* add that screenshot

* beef up landing page a bit

* remove extra space

* messed that up

* fix hardcoded linkks weirdo

* fix tests

* update with permissions content

* update with placeholder

* filter out standalone category files from test

* update

* update @becca's  feedback

* update with more feedback

* so many updates

* fix links

* fix some more tests

* flesh some more things out

* update with further reading blah blah

* fix some things

* remove the gate-features label for beta ship only

* Add discussions video to product landing page (#16759)

* Add discussions video placeholder

* This might work maybe

* fix tests

* apply all of @becca's and @lecoursen's  feedback ❤️

* rename to fix test

* Revert "Add discussions video to product landing page (#16759)"

This reverts commit 2247e5d0881ca6b36cee421218e8341a7cc12ac7.

* update with test fix

Co-authored-by: Melanie Yarbrough <11952755+myarb@users.noreply.github.com>
Co-authored-by: Laura Coursen <lecoursen@github.com>
Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>
Co-authored-by: Jason Etcovitch <jasonetco@github.com>
Co-authored-by: Sarah Schneider <sarahs@github.com>
2020-12-07 15:00:35 -07:00
Octomerger Bot
218d08f38d Branch was updated using the 'autoupdate branch' Actions workflow. 2020-12-03 12:53:19 -08:00
Kevin Heis
d8302841a9 Readd new packages 2020-12-02 14:13:08 -08:00
Kevin Heis
0c3309d66e Reset package.json and package-lock.json 2020-12-02 14:10:47 -08:00
Sarah Schneider
1258092a41 Merge branch 'main' of github.com:github/docs-internal into hidden-docs-alt 2020-12-02 14:22:10 -05:00
Robert Mosolgo
a7d042a898 Merge branch 'main' into build-changelog 2020-12-02 13:56:50 -05:00
Sarah Schneider
7628caa417 Merge branch 'main' of github.com:github/docs-internal into hidden-docs-alt 2020-12-02 12:47:54 -05:00
James M. Greene
684a72077f Fix the browser tests by using a newer version of Puppeteer (#16707)
Improve 2 async-callback-based tests by counting their assertions
2020-12-01 19:17:05 -06:00
Sarah Schneider
b244d447dd Merge branch 'main' of github.com:github/docs-internal into hidden-docs-alt 2020-12-01 12:38:48 -05:00
Robert Mosolgo
caf4add9a5 Move mockdate to devdependencies 2020-11-25 16:44:48 -05:00
Robert Mosolgo
9e5d72eb42 Merge branch 'main' into build-changelog 2020-11-25 16:32:10 -05:00
Jason Etcovitch
4484068e01 Move render-content code to this repo (#16544)
* Move render-content files in here

* Replace existing file with nested index.js

* Copy in tests and jest-ify

* Update docs

* Uninstall @github-docs/render-content

* Bring over README

* Add missing dependencies

* Fix require paths
2020-11-25 11:20:23 -05:00
Robert Mosolgo
aeedfac37e Add graphql tests to CI, move snapshots to fixures, use mockdate 2020-11-25 11:12:13 -05:00
Sarah Schneider
8f0093c63a OpenAPI tooling updates (#16320) 2020-11-24 12:20:10 -08:00
Sarah Schneider
c14ab26e40 ran npm i @actions/core --save-dev 2020-11-24 12:10:15 -05:00
Robert Mosolgo
3ad453e28b remove needless package 2020-11-23 08:45:07 -05:00
Robert Mosolgo
2400be9528 Merge branch 'main' into build-changelog 2020-11-23 08:44:32 -05:00
Lucas Costi
fa4cfe0a9f Bump rest-api-operations (#16584) 2020-11-23 14:19:32 +10:00
Jason Etcovitch
9332c62195 Sm0ller webpack output (#16543)
* Install friendly-errors-webpack-plugin

* Use it
2020-11-19 13:06:20 -05:00
Robert Mosolgo
7e07c1c831 Add build-changelog script, load schemas and create a diff 2020-11-18 17:08:56 -05:00
James M. Greene
d402a60833 Merge branch 'main' into hidden-docs-alt 2020-11-17 17:56:25 -06:00
Jason Etcovitch
8f2b4eb450 Merge branch 'main' into repo-sync 2020-11-17 18:02:58 -05:00
Nick Schonning
b6de7c6887 chore: Convert Standard to eslint-config-standard (#1328)
* chore: Move standard to ESLint config

* fix: auto-fix ESLint indent issues

* fix: ESLint prefer-regex-literals

* fix: ESLint array-callback-return

- .filter must return a boolean value
- .map replaced with forEach when the value isn't used

* fix: ESLint no-extra-semi
2020-11-17 16:18:18 -05:00
Kevin Heis
890e86cc46 Merge branch 'main' into hidden-docs-alt 2020-11-17 09:58:45 -08:00
Kevin Heis
4d2e25b429 Use Redis Store for rate limiting when available (#16484) 2020-11-16 15:55:07 -08:00
Nick Schonning
92740f68d7 chore: Add Prettier for Yaml formatting
Related to #128
- Prettier to fix indenting/quoting across files
- Manually adjust list styles to "-" style
- Ignore all translated files from automated formatting
- Drop redundant CI env variable
2020-11-16 16:12:49 -05:00
Kevin Heis
dd02bfa007 Merge main 2020-11-16 10:07:53 -08:00
Jason Etcovitch
0730158918 Datadoge (#16464)
* Install hot-shots

* Add statsd client

* Add some metrics

* Add a comment

* Comment typo fix

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2020-11-13 15:49:50 -05:00
Shati Patel
ef9bb5556a Code scanning: Bump API version (#16456)
Fix description (see https://github.com/github/github/pull/162415)
2020-11-13 11:25:48 +00:00
Martin Lopes
5555a01405 [Nov 4] Adds updates to Interaction Limits API (#16290)
Co-authored-by: skedwards88 <skedwards88@github.com>
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
2020-11-12 18:05:51 -08:00
James M. Greene
5b6d704db7 Rename clone-early-access script 2020-11-10 16:01:35 -06:00