1
0
mirror of synced 2025-12-25 11:03:37 -05:00
Commit Graph

125 Commits

Author SHA1 Message Date
Mike Surowiec
a24d01f78a Fix NextJS 500s (#20048)
* feat: allow server to contextualize request when on a /_next/data path

* add client side routing test, run lint

* enable nextjs client side routing
2021-06-22 17:30:40 +00:00
Mike Surowiec
e377d74419 React: import necessary javascripts directly (#20001)
* import javascript files directly

* move globally required js to _app

* fix: js initialization

* set next env for tests
2021-06-21 21:55:49 +00:00
hubwriter
287a857511 Update Packages docs for Container registry GA (#19987)
* Update packages landing page

* Docs updates for Container reg GA

* Update billing note

* Delete CR feature preview files

* Fix broken link

* Remove github.ref from workflows

See https://github.com/github/docs-internal/pull/19953

* Put 3rd party action message in a reusable

* Update content/billing/managing-billing-for-github-packages/about-billing-for-github-packages.md

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* Update content/packages/learn-github-packages/deleting-and-restoring-a-package.md

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* Update content/packages/working-with-a-github-packages-registry/migrating-to-the-container-registry-from-the-docker-registry.md

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* Update content/packages/working-with-a-github-packages-registry/migrating-to-the-container-registry-from-the-docker-registry.md

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* Update content/packages/working-with-a-github-packages-registry/working-with-the-container-registry.md

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* Update content/packages/managing-github-packages-using-github-actions-workflows/publishing-and-installing-a-package-with-github-actions.md

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* fix bug with wbr breaking a link inside a code tag inside a table

* Make revisions suggested by Nilofer

See https://github.com/github/docs-internal/pull/19987/files#r655014673

* Mention that migration is happening gradually

* Reapply change suggested by Shayne

* Fix punctuation

* Remove bad link

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
Co-authored-by: Sarah Schneider <sarahs@github.com>
Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>
Co-authored-by: Melanie Yarbrough <11952755+myarb@users.noreply.github.com>
2021-06-21 15:10:12 -04:00
Mike Surowiec
5396f5f9e4 React: All landing pages (#19943)
* default all remaining landing pages to react, update tests
2021-06-17 10:04:53 -07:00
Sarah Edwards
c594dff941 fix ts bug (#19945) 2021-06-15 22:44:02 +00:00
Mike Surowiec
e26a3446a7 SubLanding page filter (#19918)
* sub-landing: implement filtering in react, other cleanup
2021-06-15 18:16:24 +00:00
Rachael Sewell
f0a083d0c9 set default platform when content doesnt include the os platform (#19827)
* set default platform when content doesnt include the os platform

* update source array

* extract detect platforms into separate function

* rename set to get

* align names

* add comments

* Update display-platform-specific-content.ts

* Update display-platform-specific-content.ts

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-06-14 20:28:36 +00:00
Kevin Heis
75f90c9487 Update current JavaScripts to use Typescript (#19824)
* Update index to make it clear what has hasn't updated to Next/React yet

* Typescriptify events and experiments

* Typescript the old JS for easier integration

* Update release-notes.ts

* Lint

* Run npm i

* Fix a few lint issues

* Update airgap-links.ts

* Update airgap-links.ts

* Update set-next-env to ts

* Update airgap-links.ts

* Update package-lock.json

* Update set-next-env.ts

* Update package-lock.json

* Revert "Update package-lock.json"

This reverts commit b45e8250beeb700719d3b44e1092b0bbd093baba.

* readd fsevents

* Revert "readd fsevents"

This reverts commit 419f3c35080ac4a9072f0b4e8e291e1712ce3639.

* Update openapi-schema-check.yml

* Revert "Update openapi-schema-check.yml"

This reverts commit 5e9f4a29ea11ee343ca17291a40a751920c5b923.

* Update package-lock.json

* Update package-lock.json
2021-06-14 18:07:39 +00:00
Sarah Edwards
f710813a92 prevent jumping when select application (#19789) 2021-06-11 18:21:09 +00:00
Kevin Heis
ef48759cb0 React: remove expose (#19771)
* React: remove expose

* Update context.js

* More changes

* fix: scripts check for IS_NEXTJS_PAGE so there's no timing issue

* run lint

Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
2021-06-10 16:53:43 +00:00
Mike Surowiec
a88e99c83a Reactify: release notes (#19799)
* reactify release-notes pages

* update GHAE/ES react release notes to not rely on javascripts/release-notes.js
2021-06-09 20:44:32 +00:00
Kevin Heis
26a8e61d3a Update survey to use React/TS (#19728)
* Update survey to use React/TS

* Working survey form in react land

* A little cleanup

* Update Search.tsx

* Update Survey.tsx

* Remove token field from schema entirely, just let it fail validation

* Update events.js

* Update survey.html

* use Link component

* Use enum for state

* Update old to match new
2021-06-08 17:34:45 +00:00
Kevin Heis
5b5354d02f React search component (#19659)
* React search component

* Update Search.tsx

* Update Search.tsx

* Standalone mode, start on search with your keyboard

* Update Search.tsx

* Update Search.tsx

* Yay typescript

* Update search.js

* Update events.js
2021-06-04 19:48:56 +00:00
Kevin Heis
516106b7c5 Rename "helpfulness" to survey (#19727) 2021-06-04 12:22:31 -07:00
Sarah Edwards
340f663243 Add support for cURL in application selector (#19645) 2021-06-03 14:18:19 -07:00
Sarah Edwards
7e4db83ead Add event tracking for application selector (#19533)
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-05-26 14:11:55 -07:00
Tom Schmelzer
a09efda1be fix: add rel noopener to aitgap-links.js 2021-05-11 08:52:09 +02:00
Kevin Heis
57e1a1b9c1 End Lunr AB test (#19155)
* Revert "Start an AB test with Lunr search results as treatment (#18993)"

This reverts commit 3d621ba715.

* Update lunr-search.js
2021-05-06 18:04:28 +00:00
Sarah Edwards
be8aa2bccb Add tabs for cli/desktop/ui (#19071) 2021-05-04 16:53:52 +00:00
Kevin Heis
3d621ba715 Start an AB test with Lunr search results as treatment (#18993)
* Start search_lunr AB test

* Towards prewarming

* Towards prewarming

* Warm only english/dotcom index

* Update warm-server.js
2021-05-04 16:24:19 +00:00
Sarah Schneider
9722f2e8eb Update javascripts/toggle-images.js 2021-04-29 15:20:09 -04:00
Sarah Schneider
cb54ce72ef Update javascripts/toggle-images.js 2021-04-29 15:20:01 -04:00
Sarah Schneider
f770a5b9a2 Revert "Image toggle button AB test" 2021-04-29 12:16:12 -04:00
Sarah Schneider
afea41a43d fix logic of treatment bucket vs. cookie preference 2021-04-29 11:07:45 -04:00
Sarah Schneider
0d08b8c78f tidy up the code, var names, etc 2021-04-29 11:07:08 -04:00
Sarah Schneider
8cdef3997f allow force treatment with env variable 2021-04-28 15:26:34 -04:00
Sarah Schneider
cc500a4602 lint 2021-04-27 13:10:44 -04:00
Sarah Schneider
297cf047f9 AB test! 2021-04-27 12:56:14 -04:00
Sarah Schneider
ee96655f64 Update javascripts/toggle-images.js 2021-04-27 10:40:43 -04:00
Sarah Schneider
d976323089 remove individual image toggle code 2021-04-27 10:29:03 -04:00
Sarah Schneider
a9cef6b2b5 fix the blur 2021-04-23 11:14:39 -04:00
Sarah Schneider
2dcdc8a2f1 filter out images in tables from the getgo instead of using continue in the loop 2021-04-23 10:36:59 -04:00
Sarah Schneider
c09705448d skip images in tables 2021-04-23 10:22:13 -04:00
Sarah Schneider
bf70a00b8f use relevant styles from the procedural-image-wrapper 2021-04-22 14:30:27 -04:00
Sarah Schneider
7a66493a12 fix comment formatting 2021-04-22 12:20:28 -04:00
Sarah Schneider
f5514113d5 update default state 2021-04-22 12:17:53 -04:00
Sarah Schneider
75d2dcf136 Merge branch 'main' of github.com:github/docs-internal into toggle-images 2021-04-22 11:16:51 -04:00
Sarah Schneider
5caf712ffa respect user defaults on button icon text 2021-04-22 11:16:32 -04:00
jmarlena
1fc4c3f68b Article restructuring for Sponsors landing page (#18772)
* Move article from github directory as a top-level product

* Update article titles

* Remove old -ing article titles

* Use older format for this PR

* Finish updating links for retitled articles

* Remove sponsors topic

* Add sponsors to index.md

* Create folder for map topic for sponsors

* Add integrating folder/category with super basic graphql article

* Add get started category/folder

* Update index.md

* Add articles to category folders and update all the links and check it out locally 🙏

* Fix space

* Fix set of broken links

* Update link in resuable

* Add the quickstart

* Add USD

* Add matching donations caveat

* fix ci failures

* Bringing back `-ing` to Sponsors titles, categories, & links (#18817)

* Bringing back -ing

* The one that got away

* Apply @ethanpalm's input

Co-authored-by: Ethan Palm <56270045+ethanpalm@users.noreply.github.com>

Co-authored-by: Ethan Palm <56270045+ethanpalm@users.noreply.github.com>

* Apply product input

* Apply suggestions from code review

Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>

* Apply @emilyistoofunky's input

* Sponsors landing page design (#18774)

* Add sponsors to index.md as a top-level product

* Revamp the GitHub Sponsors landing page with article links

* remove merge tags

* add community section

* add sponsor descriptions

* swap repo for user

* remove prefix tag

* lint

* remove topic fix landing page

* Tweak articles on landing page

* Drop "account"

* Add quickstart

* Bigger, brighter, and shorter intro

* Possibly too long of an intro?

* fix quickstart link

* add guides page

* fix error for mismatch between title and filename

* use link over guid

* remove HTML from layout file (aligns to #18811)

* use variable for section title

* Add intro

* Remove beta

* Apply suggestions from code review

Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>

* Apply suggestions from code review

* Integrate article changes and remove old TOC

* Fixing the commented out text to match other landing pages 👓

* Apply suggestions from code review

Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>

* Switch up order of sidebar categories

* Add new text to landing page button

* Add topics and types

* Add the underscore

* Add some more topics

* fix `type:`

* Fix topics

* plural ftw

* hide learning paths when not defined

* lint

* Add quickstart to guides page

* remove unused sidebar links

* hide subsection title when learning tracks are not present

* Apply @emilyistoofunky's topics input

* Remove duplicated topics

* Events ftw

* typo

* Remove obsolete topics for now

* add some temporary duplicate topics

* Resolve Linter error

Co-authored-by: Rachael Sewell <rachmari@github.com>
Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>

Co-authored-by: Rachael Sewell <rachmari@github.com>
Co-authored-by: Ethan Palm <56270045+ethanpalm@users.noreply.github.com>
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
2021-04-21 11:48:19 -07:00
Sarah Schneider
5f67b5d204 use cookies to track image visibility preference 2021-04-16 18:44:34 -04:00
Sarah Schneider
098dda53e8 make it easier to swap out placeholder icon 2021-04-16 15:25:56 -04:00
Sarah Schneider
da2c13cc5c use .blur() to remove focus from image buttons after click 2021-04-16 15:14:54 -04:00
Sarah Schneider
6a708b9a49 wrap images in a button so they can be individually toggled 2021-04-16 14:55:16 -04:00
Sarah Schneider
eccbe33f64 insert a placeholder img 2021-04-16 12:17:34 -04:00
Sarah Schneider
fc8b7152ef per @janiceilene: make the button outlined for the default and solid once pressed to help differentiate the two modes 2021-04-16 10:12:47 -04:00
Sarah Schneider
0dde2aeed7 take the button text toggle out of the for loop, and hide the button if no images 2021-04-16 09:56:51 -04:00
Sarah Schneider
f860ff34e2 add an image toggler button 2021-04-13 15:54:39 -04:00
Kevin Heis
46c16001c3 Upgrade Primer with translation shim for trashcan icon (#18735)
* Revert "Revert "Upgrade Primer CSS to 16 (#18713)""

This reverts commit c01d3e302e.

* Add a hack to handle trashcan icon in translated content
2021-04-13 18:38:04 +00:00
Mike Surowiec
c01d3e302e Revert "Upgrade Primer CSS to 16 (#18713)"
This reverts commit 49377f9096.
2021-04-13 09:19:28 -07:00
Kevin Heis
49377f9096 Upgrade Primer CSS to 16 (#18713)
* Upgrade primer to 16

* Upgrade colors in scss

* Get SCSS to build

* Initial dark mode support

* trashcan -> trash

* More specific search browser test

* Fix link color on homepage

* Update overrides.scss

* Upgrade some colors to primer variables

* Hide dark mode support for now

* Apply suggestions from code review

* Update overrides.scss
2021-04-13 16:00:46 +00:00