1
0
mirror of synced 2025-12-22 11:26:57 -05:00
Commit Graph

218 Commits

Author SHA1 Message Date
Ramya Parimi
9dff265cfd Merge branch 'main' into i11236-fix-workflow-path 2021-11-11 07:05:52 -06:00
Rachael Sewell
0244fda807 search improvements (#22443) 2021-11-10 11:11:28 -08:00
Peter Bengtsson
0d13379462 fix TS usage around VersionPicker (#22739) 2021-11-10 11:00:34 -08:00
Kevin Heis
6ec20638b5 Version picker combo (#22694)
* Move version picker next to product picker

* Always render in header

* Inline variant

* Remove topper-sidebar

* Handle breadcrumb length

* Have breadcrumbs use Primer breakpoint

* Make a breadcrumbs scss module

* Update Breadcrumbs.tsx

* Update Breadcrumbs.module.scss

* Update Breadcrumbs.module.scss

* Update server.js

* Use responsive classes for hide/show breadcrumb
2021-11-10 16:20:34 +00:00
ftnext
b987ffd10a fix typo in workflow paths 2021-11-10 22:53:34 +09:00
Grace Park
d75bd265eb Flash updates for deprecation and header notifications (#22632)
* flash updates for deprecation and header notifications

* adding import and updating position
2021-11-09 19:52:20 +00:00
Grace Park
240f5fbafe Updating breadcrumbs (#22626)
* updating breadcrumbs

* fix tests

* one more
2021-11-08 17:53:19 +00:00
Robert Sese
ad40e86796 Add release notes label and heading colors (#22585) 2021-11-03 22:47:55 +00:00
Ramya Parimi
7db55a6a7e Merge branch 'main' into main 2021-11-03 06:04:00 -05:00
Kevin Heis
9d53e40612 Make individual learning paths linkable (#22545)
* Make individual learning paths linkable

* Update learning-tracks.js

* Update LearningTrack.module.scss
2021-11-02 21:32:04 +00:00
Grace Park
2969394991 have header span the entire page (#22543) 2021-11-02 13:08:27 -07:00
Grace Park
b211776b85 Updating to scroll past header notifications and keep header sticky (#22539)
* updating to scroll past notification and keep header sticky

* Update components/page-header/Header.tsx

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-11-02 18:50:31 +00:00
Grace Park
f684e7fe82 adding margin top to anchor links (#22515) 2021-11-01 13:57:00 -07:00
Grace Park
3957ffeb1c fix so mobile menu is sticky when open (#22498) 2021-10-30 09:34:27 -07:00
Grace Park
75d41076a7 Article Layout Improvements (#22424)
* moving breadcrumbs to sticky header

* update scroll

* update color-bg-primary to color-bg-default

* change back to primary since were on primer 17

* add effect dependency

* not changing

* clip left box shadow of header and unmount

* update to default

* update breadcrumbs tests

* sticky editor
2021-10-29 19:57:07 +00:00
Peter Bengtsson
453e6340a7 reset survey after route navigation (#22488)
Part of #1115
2021-10-29 15:19:54 +00:00
Grace Park
596207f743 update to color-bg-default (#22482)
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-10-29 15:05:48 +00:00
Kevin Heis
567652b0e3 Primer 18 b (#22462)
* Create migrate-colors-primer-18.js

* Update colors round 1

* upgrade primer packages

* Update index.scss

* Replace auto colors

* remove btn-primary-matte

* Turns out the class names and variables names DONT LINE UP... ugh....

* Check for allowed var colors
2021-10-28 19:17:23 +00:00
Grace Park
d2b50026b4 Minor sidebar updates (#22403)
* minor sidebar updates batch

* Update components/sidebar/SidebarNav.tsx

Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>

* Update components/sidebar/SidebarProduct.tsx

Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>

* changing back to bg-primary since we are on primer 17

Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>
2021-10-28 17:07:10 +00:00
Mike Surowiec
b223df9a8d fix: includeGuides should always include topics array (#22455) 2021-10-28 16:14:30 +00:00
Mike Surowiec
3fbda10305 fix html encoded entity in code example and article cards (#22328) 2021-10-25 20:40:02 +00:00
Edward Thomson
0fee9aedcd Landing page: groups of features (#22313)
* homepage: reduce padding below search area

Bring as much useful content up "above the fold".

* homepage: add groups for the front page sections

Group the homepage links into sections that map to the GitHub features
page (`/features`) plus two groups that are bespoke to the docs ("Get
started" and "Developers").

* homepage: update group design

Group the feature list area using the design exploration work by
@arisacoba.  Remove the description.

* homepage: remove ungrouped items from main area

Remove ungrouped items (like the external links) from the main feature
area.  Users can still navigate to ungrouped items in the sidebar.

* fix tsc error, use Link component

* homepage: support empty icon in group

Don't assume that we have icons everywhere on the landing page groups.

* homepage: drop octocat/invertocat

Looks weird with the modern icons, looks bad in dark mode.  Drop them
for now.

* homepage: document the childGroups frontmatter property

* homepage: don't test that sidebar == main content

We're reducing the links on the homepage in the main content area, but
the sidebar should be the complete list of products.  Remove the tests
that ensure that the main content area has all the sidebar content.  But
keep the tests that ensure that the sidebar content has all the links in
the main content area.

* homepage: remove "GitHub" doc set

The "GitHub" doc set "will be removed soon as we keep moving more content
out of it, so let's not include it here to keep the page more
evergreen."

* homepage: don't test that `/github` is linked on the main page

We're removing the `/github` doc set, and it's now not in the main page
grouped links.  Remove the test that `/github` exists, now look for
`/get-started`.

* homepage: use octicons instead of images

The images from https://github.com/features will be updated 🔜 - in
the meantime, let's use octicons which are consistent and give visual
interest.

* homepage: use octicons from @primer/octicons-react

Using the react components adds `<svg>` elements instead of `<img>`
elements, which lets the element use the current fill color, supporting
both light and dark themes.

Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
2021-10-22 17:58:16 +00:00
Mike Surowiec
567879365f fix: grid blowout due to missing min width (#22352) 2021-10-21 20:25:23 +00:00
Kevin Heis
83804c7114 Create search result event (#22307)
* Create search result event

* Update Search.tsx

* actually send it

* remove comment

* Apply suggestions from code review

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

* add 'required' to schema

Co-authored-by: Peter Bengtsson <mail@peterbe.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
2021-10-21 00:37:39 +00:00
Grace Park
884556eb02 Adding effectiveDate frontmatter property (#22317)
* adding effectiveDate frontmatter property

* Update components/article/ArticlePage.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* adding validation for correct date

* update to dateTime

* update to year month day

* update error date validation

* moving validation to getArticleContextFromRequest and moving id to div

* remove enteredDate

* Update content/README.md

Co-authored-by: Laura Coursen <lecoursen@github.com>

Co-authored-by: Peter Bengtsson <peterbe@github.com>
Co-authored-by: Laura Coursen <lecoursen@github.com>
2021-10-20 19:40:13 +00:00
Peter Bengtsson
3994797e81 indicate 0 search results as a result (#22262)
* indicate 0 search results as a result

fixes https://github.com/github/docs-engineering/issues/955

* correct logic

* refactored into own component
2021-10-19 22:23:36 +00:00
Anil Seervi
c183d07491 Update footer help link 2021-10-19 03:07:24 +00:00
Anil Seervi
4fcd2b4d1c use Link tag and relative url 2021-10-19 02:13:46 +00:00
Anil Seervi
8189f38035 Make internal footer links dynamic to language picker : Fixes #11274 2021-10-18 15:13:47 +00:00
Anil Seervi
06a3a7b91c Link to developers page 2021-10-17 11:10:01 +05:30
Grace Park
4727433baa Community redirect update to camel case and adding documentation (#21979)
* update to camel case

* add documentation on communityRedirect
2021-10-07 15:02:58 -07:00
Grace Park
9dd8ed7398 Bring back community redirect (#21971)
* add back

* adding community_redirect to page context based on parent

* update to use parentProduct

* bring back the link-secondary and text-bold
2021-10-07 18:58:31 +00:00
Amy Burns
e82f64f642 Add vscode as an option for the application selector (#21798)
* adding switcher to creating a codespace guide

* adding additional switcher for vscode and updating codespaces name

* using webui in codespaces coontext

* updating internal documentation

* remove default tool

Co-authored-by: hubwriter <hubwriter@github.com>
2021-10-07 14:57:45 +01:00
Jennie Steshenko
3938d02687 New DPA and SCCs (#21838) 2021-10-07 13:51:25 +00:00
Mike Surowiec
b279482cf9 Footer styling (#21877) 2021-10-06 18:09:11 +00:00
Steve Guntrip
32f59ee7b0 add ShieldLockIcon octicon to permissions statement (#21829) 2021-10-06 09:07:58 +00:00
Jeroen Rietveld
24e4c3407b Make guide filter accessible (#21380)
* Make guide filter accessible

Explain that the fields will filter a list.
Display a status message indicating the number of results found.

* update no guides found display, fix yaml issue

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
2021-10-04 18:11:11 +00:00
Mike Surowiec
85f6a43502 Mini TOC semantic rendering (#21836)
* semantic rendering of miniTocItems

* feat: create nested mini toc structure to simplify semantic rendering

* remove className usage of indentationLevel in miniToc rendering

* manually run script/graphql/update-files.js to update pre-rendered files

* use less brittle regex method to extract number
2021-10-04 10:48:42 -04:00
Grace Park
1211a3a92c Remove community_redirect and update all footer links for Codespaces, Discussions, and Sponsors (#21815)
* remove community_redirect and update all footer links to redirect to discussions for Codespaces, Sponsors, and Discussions

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect
2021-09-30 23:07:51 +00:00
Grace Park
bfe529c40a Fixing index page body text rendering (#21811)
* fixing index page body text rendering

* always use renderedPage
2021-09-30 21:37:49 +00:00
Robert Sese
000799df17 Handle learning track paths from a different product (#21776)
* Add trackProduct property

* Fall back to learning track product URL param

* Add product URL param to learning track banner

* Add product URL param to featured track links

* Fix typo :(

* Add product URL param to learning track

* Add multi-product learning track tests

* Re-enable tests with a Code Security learning track

* Re-enable more tests with Code Security learning tracks

* Add more multi-product testing

* Update components/sublanding/LearningTrack.tsx

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-09-30 21:17:02 +00:00
Mike Surowiec
d81f51ebf7 Picker improvements (#21765)
* close Language and ArticleVersion pickers after click

* cleanup ArticleGridLayout due to VersionPicker changes

* fix tsc errors resulting from primer upgrade

* fix / update tests

* cleanup mobile pickers visual consistency

* use btn-sm on VersionPicker

* update translation and close on click for enterprise releases

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-09-30 20:22:13 +00:00
Rachael Sewell
f346096897 move playground loading indicator image (#21816) 2021-09-29 22:00:37 +00:00
Kevin Heis
12356c5bbb More client routing fixes (#21793)
* More client routing fixes

* Update index.tsx

Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-09-29 16:08:31 -05:00
Mike Surowiec
3125579983 remove currentLanguage from mainContext, use router.locale instead (#21716) 2021-09-27 14:40:43 +00:00
Kevin Heis
5fb28d1c9a Skip tracking page events when searching (#21726)
* Skip tracking page events when searching

* Update events.ts
2021-09-27 13:46:36 +00:00
Kevin Heis
ceb2106cab Update analytics to handle client side routing (#21719)
* Update analytics to handle client side routing

* Update events.ts
2021-09-24 17:21:52 +00:00
Martin Lopes
83dc407ada Restructure Actions guides (#21577)
Co-authored-by: Sarah Edwards <skedwards88@github.com>
Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
2021-09-22 16:49:41 +10:00
Robert Sese
2f6af3fe20 Render learning track banner on ToC landing page (#21634)
* Add learning track info to ToC landing page context

* Render learning track banner on ToC landing page
2021-09-22 01:02:29 -05:00
Mike Surowiec
d2199e3deb Use Doctocat link header style (#21615)
* update autolinkHeadings to use Doctocat link header style

* fix header link test

* update graphql/rest rendering to use doctocat header link

* fix: miniToc issue with stray anchor

Co-authored-by: Rachael Sewell <rachmari@github.com>
2021-09-21 18:14:38 -04:00