1
0
mirror of synced 2025-12-21 02:46:50 -05:00
Commit Graph

84 Commits

Author SHA1 Message Date
Grace Park
75d41076a7 Article Layout Improvements (#22424)
* moving breadcrumbs to sticky header

* update scroll

* update color-bg-primary to color-bg-default

* change back to primary since were on primer 17

* add effect dependency

* not changing

* clip left box shadow of header and unmount

* update to default

* update breadcrumbs tests

* sticky editor
2021-10-29 19:57:07 +00:00
Mike Surowiec
b223df9a8d fix: includeGuides should always include topics array (#22455) 2021-10-28 16:14:30 +00:00
Edward Thomson
0fee9aedcd Landing page: groups of features (#22313)
* homepage: reduce padding below search area

Bring as much useful content up "above the fold".

* homepage: add groups for the front page sections

Group the homepage links into sections that map to the GitHub features
page (`/features`) plus two groups that are bespoke to the docs ("Get
started" and "Developers").

* homepage: update group design

Group the feature list area using the design exploration work by
@arisacoba.  Remove the description.

* homepage: remove ungrouped items from main area

Remove ungrouped items (like the external links) from the main feature
area.  Users can still navigate to ungrouped items in the sidebar.

* fix tsc error, use Link component

* homepage: support empty icon in group

Don't assume that we have icons everywhere on the landing page groups.

* homepage: drop octocat/invertocat

Looks weird with the modern icons, looks bad in dark mode.  Drop them
for now.

* homepage: document the childGroups frontmatter property

* homepage: don't test that sidebar == main content

We're reducing the links on the homepage in the main content area, but
the sidebar should be the complete list of products.  Remove the tests
that ensure that the main content area has all the sidebar content.  But
keep the tests that ensure that the sidebar content has all the links in
the main content area.

* homepage: remove "GitHub" doc set

The "GitHub" doc set "will be removed soon as we keep moving more content
out of it, so let's not include it here to keep the page more
evergreen."

* homepage: don't test that `/github` is linked on the main page

We're removing the `/github` doc set, and it's now not in the main page
grouped links.  Remove the test that `/github` exists, now look for
`/get-started`.

* homepage: use octicons instead of images

The images from https://github.com/features will be updated 🔜 - in
the meantime, let's use octicons which are consistent and give visual
interest.

* homepage: use octicons from @primer/octicons-react

Using the react components adds `<svg>` elements instead of `<img>`
elements, which lets the element use the current fill color, supporting
both light and dark themes.

Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
2021-10-22 17:58:16 +00:00
Grace Park
884556eb02 Adding effectiveDate frontmatter property (#22317)
* adding effectiveDate frontmatter property

* Update components/article/ArticlePage.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* adding validation for correct date

* update to dateTime

* update to year month day

* update error date validation

* moving validation to getArticleContextFromRequest and moving id to div

* remove enteredDate

* Update content/README.md

Co-authored-by: Laura Coursen <lecoursen@github.com>

Co-authored-by: Peter Bengtsson <peterbe@github.com>
Co-authored-by: Laura Coursen <lecoursen@github.com>
2021-10-20 19:40:13 +00:00
Grace Park
4727433baa Community redirect update to camel case and adding documentation (#21979)
* update to camel case

* add documentation on communityRedirect
2021-10-07 15:02:58 -07:00
Grace Park
9dd8ed7398 Bring back community redirect (#21971)
* add back

* adding community_redirect to page context based on parent

* update to use parentProduct

* bring back the link-secondary and text-bold
2021-10-07 18:58:31 +00:00
Mike Surowiec
85f6a43502 Mini TOC semantic rendering (#21836)
* semantic rendering of miniTocItems

* feat: create nested mini toc structure to simplify semantic rendering

* remove className usage of indentationLevel in miniToc rendering

* manually run script/graphql/update-files.js to update pre-rendered files

* use less brittle regex method to extract number
2021-10-04 10:48:42 -04:00
Grace Park
1211a3a92c Remove community_redirect and update all footer links for Codespaces, Discussions, and Sponsors (#21815)
* remove community_redirect and update all footer links to redirect to discussions for Codespaces, Sponsors, and Discussions

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect
2021-09-30 23:07:51 +00:00
Grace Park
bfe529c40a Fixing index page body text rendering (#21811)
* fixing index page body text rendering

* always use renderedPage
2021-09-30 21:37:49 +00:00
Robert Sese
000799df17 Handle learning track paths from a different product (#21776)
* Add trackProduct property

* Fall back to learning track product URL param

* Add product URL param to learning track banner

* Add product URL param to featured track links

* Fix typo :(

* Add product URL param to learning track

* Add multi-product learning track tests

* Re-enable tests with a Code Security learning track

* Re-enable more tests with Code Security learning tracks

* Add more multi-product testing

* Update components/sublanding/LearningTrack.tsx

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-09-30 21:17:02 +00:00
Mike Surowiec
3125579983 remove currentLanguage from mainContext, use router.locale instead (#21716) 2021-09-27 14:40:43 +00:00
Robert Sese
2f6af3fe20 Render learning track banner on ToC landing page (#21634)
* Add learning track info to ToC landing page context

* Render learning track banner on ToC landing page
2021-09-22 01:02:29 -05:00
Kevin Heis
cdbbc63219 Send new analytics fields for path_language, path_version, path_product, path_article (#21562)
* Send new analytics fields for path_language, path_version, path_product, path_article

* Update DefaultLayout.tsx

* Update events.js
2021-09-17 19:22:54 +00:00
Lee Dohm
b500fd07d0 Use titlePlainText attribute since the title will be used for rendered text 2021-09-09 13:50:54 -07:00
Kevin Heis
4d0e9c70a3 Add new fields to analytics event context: status, page_type, page_document_type (#21115)
* Add new fields to analytics event context: status, page-type, page-document-type

* Update schema-event.js

* Typescript

* Add status meta to error pages

* Update DefaultLayout.tsx

* Update DefaultLayout.tsx

* Update building-and-testing-nodejs-or-python.tsx
2021-08-26 14:58:45 -07:00
Mike Surowiec
06d8f81401 Two-pane Experiment (#21092)
* pull changes from docs-playground

* cleanup, add callout banner

* cleanup linting and test fixes

* add discussion link

Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-08-26 14:19:40 -04:00
Kevin Heis
1cb2da024d Add opengraph tags to articles (#21089)
* Add opengraph tags to articles

* Update MainContext.tsx

* Update DefaultLayout.tsx
2021-08-26 14:18:58 +00:00
Rachael Sewell
c7ac98304a allow use of full titles on landing page (#20327) 2021-08-25 12:31:16 -07:00
Grace Park
5b59619d68 Adding Product feedback redirect (#20785)
* adding product feedback redirect for community on sponsors, discussions, and actions community link

* remove community redirect from actions and add to codespaces and add tests

* update wording for these links

* updating to add name of the button to frontmatter
2021-08-11 10:37:41 -07:00
Mike Surowiec
a511c95c7f SCSS and Component cleanup (pt 1) (#20572)
* turn article.scss into a module + componentized

* Update Survey to use only component styles, add cancel button

* Update GenericError + 404 page to use only standard classes

* update LearningTrack to not use markdown-body

* remove / consolidate stylesheets

* cleanup Graphiql explorer page and scss

* Componentize Breadcrumb styles

* Componentize DeprecationBanner styles

* scope h2 a link style to markdown-body

* cleanup nav, organize page-header and page-footer components

* remove unused scroll-button.scss

* organize LanguagePicker and ProductPicker

* add declarations file

* remove featured-links.scss, update tests

* update list utility and toc test

* fix bad merge resolution

* update breadcrumbs test
2021-07-29 17:27:20 +00:00
Mike Surowiec
a9a19ef6da Move languages out of MainContext (#20503)
* move languages off of MainContext

* load languages from request to workaround sharing the languages file
2021-07-29 13:36:11 +00:00
Mike Surowiec
9386571aa4 fix: use named export for all-versions (#20478)
* fix: use named export for all-versions

* run prettier
2021-07-22 19:29:00 +00:00
Mike Surowiec
6bc50f7e30 fix: filter hidden pages from the currentProductTree (SidebarProduct) (#20404)
* fix some async test things

* allow eslint to parse top-level awaits

* fix: filter out hidden pages closer to SidebarProduct usage
2021-07-20 12:32:35 -04:00
Grace Park
27aa5d92ea Remove FEATURE_NEXTJS Flag Part 1 (#20176)
* cleanup FEATURE_NEXTJS

* fixing some server tests

* updating article a for server tests

* update h2 to h4 map topic tests

* data off on TOCs

* updating dropdown article versions links

* Update so markdown renders in intros

* updating typo and all server tests are now passing

* remove nextjs feature flag

* head.js tests pass

* updating article-version-picker

* remove nextjs feature flag browser test

* update header.js tests

* fix page-titles.js test

* fix deprecated-enterprise versions

* adding early access

* testing

* getting childTocItem

* fixing table of contents to show child toc items

* updated to 2 because the sidebar article also has the same link

* remove comment

* updating pick

* Update TocLandingContext.tsx

* update package.json and change className to h4 for h2

* updating with mikes feedback

* remove a.active test

* React clean up: Delete unnecessary layouts/includes Part 2 (#20143)

* Delete unnecessary layouts

* setting back tests failing :(

* update layouts

* delete unnecessary includes

* remove github-ae-release-notes and updating layouts

* remove a.active test
2021-07-16 14:54:25 -07:00
Grace Park
d3cc64a6bc adding rendered page to early access index 2021-06-29 12:04:34 -07:00
Sarah Schneider
118747974e fix bugs in React 2021-06-23 12:54:17 -04:00
Sarah Schneider
15e33f05e7 Revert "Revert "Fix homepage versions dropdown" (#20087)"
This reverts commit f9f0b2ce86.
2021-06-23 10:12:36 -04:00
Matt Pollard
f9f0b2ce86 Revert "Fix homepage versions dropdown" (#20087) 2021-06-23 09:11:51 +02:00
Sarah Schneider
43c04966e5 update React components that use the homepage version 2021-06-22 15:16:01 -04:00
Mike Surowiec
a24d01f78a Fix NextJS 500s (#20048)
* feat: allow server to contextualize request when on a /_next/data path

* add client side routing test, run lint

* enable nextjs client side routing
2021-06-22 17:30:40 +00:00
Mike Surowiec
e377d74419 React: import necessary javascripts directly (#20001)
* import javascript files directly

* move globally required js to _app

* fix: js initialization

* set next env for tests
2021-06-21 21:55:49 +00:00
Mike Surowiec
b084dbc23d React: Enable all remaining pages (#20012)
* enable all remaining pages

* update tests for survey, filter card dropdowns

* fix search test

* fix: mobile search layout

* update sidebar test

* fix: learning track page is optional

* fix broken links
2021-06-21 19:52:58 +00:00
Mike Surowiec
f19d695cef fix: enterprise guide type was sometimes undefined (#20015) 2021-06-18 12:31:22 -07:00
Mike Surowiec
5396f5f9e4 React: All landing pages (#19943)
* default all remaining landing pages to react, update tests
2021-06-17 10:04:53 -07:00
Mike Surowiec
5635c2dba4 fix codespaces (#19941) 2021-06-15 14:05:33 -07:00
Mike Surowiec
306f6fc75e Enable more react pages (#19935)
* enable more react landing pages

* move nextjs page logic to separate middleware

* enable codespaces landing page + fixes

* enable /education

* enable /admin

* use pathToRegexp to match routes for react rendering

* run lint

* fix: typo in url

* update sidebar test
2021-06-15 13:31:17 -07:00
Mike Surowiec
ae3d8916c6 Cleanup featuredLinks usage, fix insights page, better ArticleList (#19872)
* cleanup featuredLinks usage, fix insights page, better ArticleList component
2021-06-15 18:22:43 +00:00
Mike Surowiec
e26a3446a7 SubLanding page filter (#19918)
* sub-landing: implement filtering in react, other cleanup
2021-06-15 18:16:24 +00:00
Mike Surowiec
6172262be7 fix: sometimes the page doesn't have children (#19919) 2021-06-15 01:06:58 +00:00
Sarah Edwards
9344d3ed9a Landing pages only shows "view all" and "expore all" buttons if a guides page exists (#19914)
Co-authored-by: Sarah Schneider <sarahs@github.com>
Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
2021-06-14 23:59:28 +00:00
Grace Park
0d90f48f22 React Sublanding Fixes (#19894)
* fixing a couple issue with the sublanding - nulls and page.type

* learning track null error fix

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-06-14 20:35:03 +00:00
Mike Surowiec
ae33dae11f More react default pages (#19863)
* turn on more default react landing pages
2021-06-11 18:35:41 +00:00
Mike Surowiec
5a95aac281 fix: rename CurrentProductTree to ProductTreeNode, fix article list title rendering (#19858) 2021-06-11 17:53:48 +00:00
Grace Park
d635ee5cf4 fix lint errors 2021-06-10 14:32:36 -07:00
Grace Park
2d289bdabc fixed conflict 2021-06-10 14:25:07 -07:00
Grace Park
2e30d1cc46 fixing json context and ran lint 2021-06-10 14:14:23 -07:00
Felicity Chapman
23b0b84111 Add Code security landing and guides pages (#19650) 2021-06-10 20:14:56 +00:00
Mike Surowiec
732b5fa554 Fix Product sidebar (react) (#19843)
* fix sidebar product rendering logic to match existing sidebar
2021-06-10 19:23:47 +00:00
Kevin Heis
ef48759cb0 React: remove expose (#19771)
* React: remove expose

* Update context.js

* More changes

* fix: scripts check for IS_NEXTJS_PAGE so there's no timing issue

* run lint

Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
2021-06-10 16:53:43 +00:00
Grace Park
857fce6c47 add number for learning tracks 2021-06-09 21:39:17 -07:00