1
0
mirror of synced 2025-12-21 10:57:10 -05:00
Commit Graph

39 Commits

Author SHA1 Message Date
Grace Park
75d41076a7 Article Layout Improvements (#22424)
* moving breadcrumbs to sticky header

* update scroll

* update color-bg-primary to color-bg-default

* change back to primary since were on primer 17

* add effect dependency

* not changing

* clip left box shadow of header and unmount

* update to default

* update breadcrumbs tests

* sticky editor
2021-10-29 19:57:07 +00:00
Edward Thomson
0fee9aedcd Landing page: groups of features (#22313)
* homepage: reduce padding below search area

Bring as much useful content up "above the fold".

* homepage: add groups for the front page sections

Group the homepage links into sections that map to the GitHub features
page (`/features`) plus two groups that are bespoke to the docs ("Get
started" and "Developers").

* homepage: update group design

Group the feature list area using the design exploration work by
@arisacoba.  Remove the description.

* homepage: remove ungrouped items from main area

Remove ungrouped items (like the external links) from the main feature
area.  Users can still navigate to ungrouped items in the sidebar.

* fix tsc error, use Link component

* homepage: support empty icon in group

Don't assume that we have icons everywhere on the landing page groups.

* homepage: drop octocat/invertocat

Looks weird with the modern icons, looks bad in dark mode.  Drop them
for now.

* homepage: document the childGroups frontmatter property

* homepage: don't test that sidebar == main content

We're reducing the links on the homepage in the main content area, but
the sidebar should be the complete list of products.  Remove the tests
that ensure that the main content area has all the sidebar content.  But
keep the tests that ensure that the sidebar content has all the links in
the main content area.

* homepage: remove "GitHub" doc set

The "GitHub" doc set "will be removed soon as we keep moving more content
out of it, so let's not include it here to keep the page more
evergreen."

* homepage: don't test that `/github` is linked on the main page

We're removing the `/github` doc set, and it's now not in the main page
grouped links.  Remove the test that `/github` exists, now look for
`/get-started`.

* homepage: use octicons instead of images

The images from https://github.com/features will be updated 🔜 - in
the meantime, let's use octicons which are consistent and give visual
interest.

* homepage: use octicons from @primer/octicons-react

Using the react components adds `<svg>` elements instead of `<img>`
elements, which lets the element use the current fill color, supporting
both light and dark themes.

Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
2021-10-22 17:58:16 +00:00
Grace Park
4727433baa Community redirect update to camel case and adding documentation (#21979)
* update to camel case

* add documentation on communityRedirect
2021-10-07 15:02:58 -07:00
Grace Park
9dd8ed7398 Bring back community redirect (#21971)
* add back

* adding community_redirect to page context based on parent

* update to use parentProduct

* bring back the link-secondary and text-bold
2021-10-07 18:58:31 +00:00
Grace Park
1211a3a92c Remove community_redirect and update all footer links for Codespaces, Discussions, and Sponsors (#21815)
* remove community_redirect and update all footer links to redirect to discussions for Codespaces, Sponsors, and Discussions

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect
2021-09-30 23:07:51 +00:00
Mike Surowiec
3125579983 remove currentLanguage from mainContext, use router.locale instead (#21716) 2021-09-27 14:40:43 +00:00
Kevin Heis
cdbbc63219 Send new analytics fields for path_language, path_version, path_product, path_article (#21562)
* Send new analytics fields for path_language, path_version, path_product, path_article

* Update DefaultLayout.tsx

* Update events.js
2021-09-17 19:22:54 +00:00
Kevin Heis
4d0e9c70a3 Add new fields to analytics event context: status, page_type, page_document_type (#21115)
* Add new fields to analytics event context: status, page-type, page-document-type

* Update schema-event.js

* Typescript

* Add status meta to error pages

* Update DefaultLayout.tsx

* Update DefaultLayout.tsx

* Update building-and-testing-nodejs-or-python.tsx
2021-08-26 14:58:45 -07:00
Kevin Heis
1cb2da024d Add opengraph tags to articles (#21089)
* Add opengraph tags to articles

* Update MainContext.tsx

* Update DefaultLayout.tsx
2021-08-26 14:18:58 +00:00
Grace Park
5b59619d68 Adding Product feedback redirect (#20785)
* adding product feedback redirect for community on sponsors, discussions, and actions community link

* remove community redirect from actions and add to codespaces and add tests

* update wording for these links

* updating to add name of the button to frontmatter
2021-08-11 10:37:41 -07:00
Mike Surowiec
a9a19ef6da Move languages out of MainContext (#20503)
* move languages off of MainContext

* load languages from request to workaround sharing the languages file
2021-07-29 13:36:11 +00:00
Mike Surowiec
6bc50f7e30 fix: filter hidden pages from the currentProductTree (SidebarProduct) (#20404)
* fix some async test things

* allow eslint to parse top-level awaits

* fix: filter out hidden pages closer to SidebarProduct usage
2021-07-20 12:32:35 -04:00
Sarah Schneider
118747974e fix bugs in React 2021-06-23 12:54:17 -04:00
Sarah Schneider
15e33f05e7 Revert "Revert "Fix homepage versions dropdown" (#20087)"
This reverts commit f9f0b2ce86.
2021-06-23 10:12:36 -04:00
Matt Pollard
f9f0b2ce86 Revert "Fix homepage versions dropdown" (#20087) 2021-06-23 09:11:51 +02:00
Sarah Schneider
43c04966e5 update React components that use the homepage version 2021-06-22 15:16:01 -04:00
Mike Surowiec
e377d74419 React: import necessary javascripts directly (#20001)
* import javascript files directly

* move globally required js to _app

* fix: js initialization

* set next env for tests
2021-06-21 21:55:49 +00:00
Mike Surowiec
5396f5f9e4 React: All landing pages (#19943)
* default all remaining landing pages to react, update tests
2021-06-17 10:04:53 -07:00
Mike Surowiec
5a95aac281 fix: rename CurrentProductTree to ProductTreeNode, fix article list title rendering (#19858) 2021-06-11 17:53:48 +00:00
Kevin Heis
ef48759cb0 React: remove expose (#19771)
* React: remove expose

* Update context.js

* More changes

* fix: scripts check for IS_NEXTJS_PAGE so there's no timing issue

* run lint

Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
2021-06-10 16:53:43 +00:00
Mike Surowiec
4fa725c404 Reactify: ProductReleases component on landing page (#19808) 2021-06-09 20:39:21 +00:00
Grace Park
e8c6d272d0 Merge branch 'main' into localization-grace 2021-06-07 13:19:03 -07:00
Mike Surowiec
349fa8edbe feat: add react graphql explorer page (#19704) 2021-06-07 12:26:16 -07:00
Mike Surowiec
75e5d2e2e1 Reactify: main landing page (#19724)
* update Search to allow mounting input and results in different places
2021-06-07 15:56:09 +00:00
Mike Surowiec
f8f72fc1d8 fix: nextjs stylesheet usage (#19693)
* fix: nextjs stylesheet usage

* remove builtAssets css from react context
2021-06-03 17:55:01 +00:00
Mike Surowiec
e0d9a061a3 React category / sub-landing page (#19635)
Re-work routes to use GlobalPage, implements TocLanding, bundle of minor cleanup / fixes
2021-06-02 16:28:39 +00:00
Grace Park
a3e36c0d6a Merge branch 'main' into localization-grace 2021-06-01 15:45:42 -07:00
Mike Surowiec
2de358187c Performance testing NextJS / React (#19540)
* Remove json.parse(json.stringify( usage to improve performance
* Fix missing / duplicate keys in some renders
* Fix missing react-is dependency (only seemed to cause problems from pruning on the heroku deploy)
* Add nextjs tag to datadog-connect config when nextjs is a query param
* Fix router.asPath usage to exclude query param
* Fix styling inconsistencies noticed when testing
* Add a few tests
2021-05-27 15:17:27 -07:00
Grace Park
d674299496 Adding React for the header notifications with mike 2021-05-26 12:47:03 -07:00
Rachael Sewell
cf965e0892 Convert to new site tree (#19450) 2021-05-20 11:35:02 -07:00
Mike Surowiec
2fc3e7e403 feat: wire up remaining head data, csrf token 2021-05-19 08:27:34 -07:00
Mike Surowiec
e8b7d3b9fc Product landing page react (pt 4) (#19336)
* start SidebarNav, enable dark mode

* wip: sidebarnav, fix primer components theme rendering

* feat: ProductSiteTree, useFeatureFlag

* feat: add new product site tree (untested)

* wire up HomepageVersionPicker, run lint

* fix: remove re-render logic, fix homepage version picker to be natural width

* fix: support css + primer/components color modes

* fix: rename categoryId -> productId

* feat: ProductSiteTree and AllArticlesProduct

* fix: cleanup warnings

* fix: use next links on ProductSiteTreeNew

* fix: use next Link on AllArticlesProduct

* fix: add tooltip to ScrollButton, remove stylesheet dependency

* feat: ProductArticlesList component

* fix: convert color_mode value from cookie when necessary

* remove comments

* replace liquid with jsx

Co-authored-by: Rachael Sewell <rachmari@github.com>
2021-05-19 02:49:51 +00:00
Mike Surowiec
da2384c7a5 cleanup for PR 2021-05-07 08:47:22 -07:00
Mike Surowiec
fcd921d54b feat: add VersionPicker and LanguagePicker 2021-05-06 15:07:15 -07:00
Mike Surowiec
419e738aca wip: Header, HeaderNotifications 2021-05-06 15:07:15 -07:00
Mike Surowiec
35e624facd fix: cleanup Breadcrumbs.tsx 2021-05-06 14:03:59 -07:00
Mike Surowiec
7620a8edfa cleanup types 2021-05-05 16:02:32 -07:00
Mike Surowiec
f3a029b6dd feat: add SupportSection 2021-05-05 15:58:21 -07:00
Mike Surowiec
34dcba51f1 feat: add DefaultLayout, add to sponsors landing page 2021-05-05 14:54:49 -07:00