1
0
mirror of synced 2025-12-30 03:01:36 -05:00
Commit Graph

158 Commits

Author SHA1 Message Date
James M. Greene
4dea2779f3 More explicit terminations of middleware (#17666)
* Be more explicit about next/res.send ending middleware functions

* Add note explaining the one exception
2021-02-03 16:38:41 -06:00
James M. Greene
a40ff31b4b Cache more assets both in browser + Fastly (#17663)
* Cache archived asset JS/CSS for a day

* Don't waste time with ETag calculations

* Add a comment about the expiration length

* Cache images and fonts for a day

* Cache GraphQL data files for a week

* Set Fastly surrogate-key header on all responses

* Update test to account for new response header
2021-02-03 22:16:54 +00:00
Rachael Sewell
fc430896cb add azure to content security policy (#17649) 2021-02-03 10:49:40 -08:00
James M. Greene
0e729d9a75 Cleanup the testing and old code related to Fastly headers (#17643) 2021-02-03 10:43:00 -06:00
James M. Greene
8f133cbf54 Disallow both Fastly AND the browser from caching HTML pages (#17641) 2021-02-02 21:37:41 +00:00
James M. Greene
e53d1b7982 Set cache control for our JS/CSS assets to be kept for 28 days (#17636) 2021-02-02 13:34:37 -06:00
James M. Greene
42b5a90260 Bypass Fastly for all product families EXCEPT GitHub core (#17627) 2021-02-02 17:12:14 +00:00
James M. Greene
6957a4a830 Test bypassing Fastly for the Discussions, Packages, and Actions product families (#17611)
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-02-02 09:43:53 -06:00
Jason Etcovitch
5cabf531da Convert .rc* versions to proper semver, then compare (#17600) 2021-02-01 19:13:35 +00:00
Jason Etcovitch
1bf93673ec Add release notes for GHES 3.0.0.rc2 (#17547)
* Add 0-rc2

* Started adding release notes

* added more line items

* finished initial draft of enterprise 2 fix notes

* some more line items added

* updated known issues and took out rc1 fixes

* added download link bug fix

* added new known issues identified in rc2

* Fix a typo

* Lint YAML

* Tweak sorting for new version schem

* Use today's date

* removed links to PRs and reduced notes to most important ones

* Fix indentation

* bug_fixes => bugs

* spruce it up

* typo

* update without changes

Co-authored-by: Amulya Raja <53104849+amulyaraja@users.noreply.github.com>
Co-authored-by: Maya <maya-ross@github.com>
Co-authored-by: Meg Bird <megbird@github.com>
2021-01-29 15:25:50 -07:00
Kevin Heis
8b86fd8fef Reduce minified JS bundle size from 189kb to 73kb (#17552) 2021-01-28 22:12:04 +00:00
Kevin Heis
d9d61f42ef Add Lunr as a site search option (#17388)
* Add Lunr as a site search option

* Use a class like the Algolia option does

* Lint

* Working on showing real content, prep for highlighting

* Move searching to their own files

* Split out ridiculous fn

* Add highlighting

* Less lunr search code

* A little more tidy

* Then chain on write too

* Mark from server too

* Write a batch of indices

* Update compress.js

* Highlighting with fewer calls

* Update lunr-search.js

* Update lunr-search.js

* Update lunr-search.js

* Update lunr-search.js

* Update lunr-search.js

* Update lunr-search.js
2021-01-28 19:38:22 +00:00
Jason Etcovitch
58319a221c Instrument all of our middleware (#17527)
* Add instrument-middleware.js

* Make it do some fancy require-ing

* Use it

* Prefix names

* dot prefix

* Improve async detection

* Add some comments

* Can't instrument error handler
2021-01-27 17:29:30 -05:00
Jason Etcovitch
591e22d8b1 Rename release notes for 3.0.0-rc to 3.0.0.rc (#17510)
* Change -rc versions to .rc\d*

* Fix the download link

* Rename to 3.0.0.rc1
2021-01-27 15:27:48 +00:00
Sarah Schneider
35e430c96d Merge branch 'main' into make-developer-redirects-static 2021-01-26 11:30:16 -05:00
Sarah Schneider
9f3e2b6017 handle edge case 2021-01-25 16:35:15 -05:00
Sarah Schneider
87bc25d7ca Merge branch 'main' of github.com:github/docs-internal into make-developer-redirects-static 2021-01-25 12:31:23 -05:00
Vanessa Yuen
9bc90cd932 Learning Track navigation banner (#17440)
* add middleware to handle `learn` query param

* add exception to query-less cache key

* add querystring to learning track guides
2021-01-25 16:57:32 +00:00
Kevin Heis
6ae96188f2 Move 404 and 500 images to local (#17432) 2021-01-22 21:49:45 +00:00
Sarah Schneider
3aed23bdc9 Merge branch 'main' into make-developer-redirects-static 2021-01-21 14:14:57 -05:00
Kevin Heis
c51f5390d4 Move search results to use relative urls (#17411)
* Move search results to use relative urls

* ..and now we have real mark tags instead of em tags

Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2021-01-21 17:23:16 +00:00
Sarah Schneider
8198dd4ce7 Merge branch 'main' of github.com:github/docs-internal into make-developer-redirects-static 2021-01-20 15:08:35 -05:00
Kevin Heis
c21a738e95 Make browser search tests green (#17385)
* Make browser search tests green

* Okay... lodash get then _Linter_ ugh
2021-01-20 16:20:32 +00:00
Kevin Heis
2fb2e962bc Move site search to use an endpoint (#17359)
* Move site search to use an endpoint

* Update browser.js

* Update search.js

* Update lib/search/versions.js

Co-authored-by: James M. Greene <JamesMGreene@github.com>

* Fix URLs

Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-01-20 15:37:42 +00:00
James M. Greene
9724f763f5 Implement discount fingerprinting without webpack (#17337) 2021-01-19 23:00:54 -06:00
Sarah Schneider
a54c3ffd5a use new static file instead of searching live set of pages 2021-01-19 17:43:55 -05:00
Sarah Schneider
752edcfc53 use new static redirects file instead of precompiling on every server restart 2021-01-19 10:46:32 -05:00
Vanessa Yuen
b46da8dfc7 Sublanding page all guides section (#16869)
* get link liquid tag to accept variables as param

* new liquid tag `link_as_article_card`

* refactor link liquid tag slightly so we can control what props get rendered

* generalize filterCodeExample to use in all guides section

* pass in `js-filter-card-max` instead of hardcode max

* tweaks and add `data` to CSP for images

* add liquid tag tests

* add some browser tests for card filters

* we still need to rely on `getPathWithLanguage` for hrefs that already have the language code embedded


Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
2021-01-18 12:23:23 +00:00
Sarah Schneider
3bf432e656 refactor 2021-01-15 11:21:52 -05:00
Sarah Schneider
3ff1bfca5a account for early access 2021-01-15 10:49:12 -05:00
Sarah Schneider
a394190ad6 Merge branch 'remove-fpt' of github.com:github/docs-internal into remove-fpt-helper 2021-01-14 17:13:06 -05:00
Sarah Schneider
ecaec6e78e Merge branch 'main' of github.com:github/docs-internal into remove-fpt 2021-01-14 17:12:27 -05:00
Sarah Schneider
a66268cc83 add helper to middleware/breadcrumbs 2021-01-14 17:07:09 -05:00
Rachael Sewell
81a9415ff4 fix GraphQL exception (#17274) 2021-01-14 11:17:43 -08:00
Sarah Schneider
7c1ab5929e Merge branch 'remove-fpt' of github.com:github/docs-internal into remove-fpt-helper 2021-01-14 13:44:10 -05:00
Sarah Schneider
2b31096312 Merge branch 'main' into remove-fpt 2021-01-14 13:44:02 -05:00
Sarah Schneider
b511758057 add remove-fpt helper function 2021-01-14 13:34:32 -05:00
Sarah Schneider
ed8b46267c Merge branch 'main' of github.com:github/docs-internal into remove-fpt 2021-01-14 12:08:27 -05:00
Sarah Schneider
b6032f285c remove helper from this branch (to be re-added in child branch for easier reviewing) 2021-01-14 12:07:49 -05:00
Sarah Schneider
c0973a7a36 Merge branch 'main' into support-ga-in-deprecated-versions 2021-01-14 09:00:41 -05:00
Melanie Yarbrough
c2336bb11e [DO NOT MERGE] GitHub Enterprise Server 3.0 release candidate megabranch (#16479) 2021-01-13 19:16:05 -08:00
Sarah Schneider
79a7a7972f Merge branch 'main' of github.com:github/docs-internal into remove-fpt 2021-01-13 16:58:05 -05:00
Sarah Schneider
d752732b16 update refs to reinstated findPage() 2021-01-13 16:49:35 -05:00
Sarah Schneider
d0b89fb593 update csp 2021-01-13 14:31:39 -05:00
Sarah Schneider
73bc187171 update csp 2021-01-13 14:28:11 -05:00
Sarah Schneider
f31aa9c75a fix csp errors on older versions 2021-01-13 13:32:47 -05:00
Vanessa Yuen
641ed02e81 Actions Guides sublanding page (#16740)
Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
Co-authored-by: Cynthia Rich <crichID@github.com>
2021-01-11 18:30:57 +01:00
Sarah Schneider
9d318e0380 Merge branch 'main' of github.com:github/docs-internal into remove-fpt 2021-01-08 11:06:27 -05:00
Rachael Sewell
3194a2db0b fix exception with unsupported version (#17088)
Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2021-01-08 14:08:05 +00:00
Sarah Schneider
1dd9f3cbf1 account for homepage version 2021-01-07 15:21:22 -05:00