1
0
mirror of synced 2025-12-30 03:01:36 -05:00
Commit Graph

96 Commits

Author SHA1 Message Date
dependabot[bot]
02c4df5ab6 Bump ini from 1.3.5 to 1.3.8 (#17742)
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](https://github.com/isaacs/ini/compare/v1.3.5...v1.3.8)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-02-08 18:29:32 +00:00
Jason Etcovitch
39e0e0dda1 Use Liquidjs instead of Liquid (#16743)
* Install liquidjs, uninstall liquid

* Comment a bunch of stuff out to get going

* Fix invalid includes

* Fix all includes (path => 'path')

* Get the homepage to render

* Do link-in-list kinda

* Revert "Fix all includes (path => 'path')"

This reverts commit d6fead646353aa5041d9229470a62a1d487456b9.

* Support non-dynamic partials

* Extract getTemplate helper

* Do remaining custom Liquid tags

* Fix some custom tag bugs

* Moar bugs

* Re-add link tag

* Cleaner diff

* Actually fix extended markdown tags

* Fully comment out version matchers

* Smaller diff

* Rely only on Liquid internals for conditionals

* Use new operators option in Liquid engine

* Fix link.js

* Don't need options

* Updoot to the right doot

* Fix some bugs

* Fix another bug

* Pass a test

* Fix the translate bits

* Adjust a test

* Fix another invalid Liquid bug

* Two more borked translations

* Found some more

* Don't need this change

* Revert "Don't need this change"

This reverts commit a916d619747f0492865a69c3e237c97c4d4e7fad.

* This should fix the broken links

* Missed one

* Revert "This should fix the broken links"

This reverts commit e6c2cc0d9055d958706260d57edbe293281c150e.

* Revert "Missed one"

This reverts commit bbe1f23baf16e020f6f7931589decb1afc75dfbd.

* Updoot liquidjs
2021-02-08 12:58:51 -05:00
James M. Greene
f7ec320b64 npm audit fix (#17675) 2021-02-06 23:57:14 +00:00
Kevin Heis
e07c603b7d Remove html-truncate, truncate with CSS instead (#17630)
* Remove html-truncate, truncate with CSS instead

* Update search.js
2021-02-02 17:55:05 +00:00
Jason Etcovitch
bd63f47636 Remove cheerio from Page#render (#17566)
* Write our plugin

* Include it

* Move the RegEx

* Don't rewriteLocalLinks with cheerio anymore

* Process after HTML ast is generated

* Use the same logic as before, just to see if it'll pass

* Don't require languageCode/version

* Only work on local links

* Needs an href

* Only update href if there's a new one to use

* Check for node.properties

* Some links are just mean

* Move use-english-headings to be a plugin

* Bail if no englishHeadings were passed

* Install rehype-wrap

* Wrap ol > li img in div.procedural-image-wrapper

* Test for platform without cheerio

* Use a plugin for rewriteAssetPathsToS3

* Remove cheerio from page.render

* Fix require paths

* SImplify

* Fix some 🐛s

* Use our own rehype-wrap

* Move rewriteAssetPathsToS3 after HTML AST

* Remove some console logs

* Fix check for includesPlatformSpecificContent

* Rename ast => tree
2021-01-29 15:44:50 -05:00
Kevin Heis
8b86fd8fef Reduce minified JS bundle size from 189kb to 73kb (#17552) 2021-01-28 22:12:04 +00:00
Jason Etcovitch
2572d7bb85 Remove hubdown and use our own markdown pipeline (#17551)
* Uninstall hubdown, install unified deps

* Create create-processor

* Use it

* Update a doc

* Tweak the language

* Use the same versions that hubdown used
2021-01-28 17:06:19 -05:00
Kevin Heis
d9d61f42ef Add Lunr as a site search option (#17388)
* Add Lunr as a site search option

* Use a class like the Algolia option does

* Lint

* Working on showing real content, prep for highlighting

* Move searching to their own files

* Split out ridiculous fn

* Add highlighting

* Less lunr search code

* A little more tidy

* Then chain on write too

* Mark from server too

* Write a batch of indices

* Update compress.js

* Highlighting with fewer calls

* Update lunr-search.js

* Update lunr-search.js

* Update lunr-search.js

* Update lunr-search.js

* Update lunr-search.js

* Update lunr-search.js
2021-01-28 19:38:22 +00:00
Jason Etcovitch
b4171bf0d5 Use AST parsing for lint file checking (#17471)
* Add markdown parsing dependencies

* Use it for the link test

* Use ast tests for hard-coded language

* Dedupe visiting for links

* Add new mdast utils to check-deps exclusions
2021-01-26 17:45:23 +00:00
Chiedo John
5d7ae36559 Fix package json (#17427)
Co-authored-by: chiedo <chiedo@users.noreply.github.com>
2021-01-21 19:05:41 +00:00
Rachael Sewell
80575a2983 move deprecated site policy content to new directory (#17270) 2021-01-14 11:41:38 -08:00
Sarah Schneider
626b453178 Merge branch 'main' into update-linkinator 2021-01-14 11:40:08 -05:00
Laura Coursen
4baf1216e4 Make public projects boards and gists internal for AE (#17247) 2021-01-14 08:36:05 -06:00
Sarah Schneider
03d7260abb update linkinator 2021-01-12 10:02:59 -05:00
James M. Greene
068c472084 Cache rendered pages in Redis (#17106)
* Explicitly set the Redis database number used for rate limiting

* Switch to using ioredis as the Redis client for rate limiting

* Install ioredis-mock as a primary dependency

* Create a Redis BasicAccessor class and tests

* Switch rendered page caching to use Redis for storage

* Add support for additional Redis SET options like TTLs

* Remove currently unused methods

* Rename redis-accessors/basic to redis-accessor and remove extra fluff

* Change default behavior for cache setting to throw if an error occurs

Add option allowSetFailures to facilitate graceful failures

* Allow SET failures to fail gracefully for the rendered page cache

* Remove as-yet unneeded serialization options from RedisAccessor

* Move Redis client construction into RedisAccessor constructor, just pass in databaseNumber as option

* Remove rendered-page-cache in favor of direct RedisAccessor use

* Add tests for RedisAccessor constructor param validations

* Eliminate one roundtrip to Redis for the cached HTML existence check

Are we fast yet?

* Set a rendered page cache TTL of 24 hours
2021-01-06 15:30:51 -06:00
Kevin Heis
0f685115f7 Revert file reads from async to sync (#16979)
* Revert file reads from async to sync

* Async funness

* Fix warm server timers

Co-authored-by: Chiedo John <chiedo@chiedosbmacbook.lan>
2020-12-15 22:04:41 +00:00
Jason Etcovitch
eaf2a67fa1 Use connectDatadog(e) (#16888)
* npm i connect-datadog

* Add connectDatadog middleware

* Add comments

* Use DD_API_KEY to gate

Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2020-12-11 13:13:18 -05:00
dependabot[bot]
e520e4cef8 Bump ini from 1.3.5 to 1.3.7 (#16870)
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](https://github.com/isaacs/ini/compare/v1.3.5...v1.3.7)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: James M. Greene <JamesMGreene@github.com>
2020-12-10 19:55:19 +00:00
Kevin Heis
1b424dfdc4 Bring in data-directory, let's go async file reads (#16782)
* Bring in data-directory, let's go async file reads

* Lint fixes

* Update glossary.js
2020-12-09 11:20:24 -08:00
Kevin Heis
62889986b6 Revert "Revert "Speed up warmServer by loading pages (and files) asyn… (#16837)
* Revert "Revert "Speed up warmServer by loading pages (and files) asynchronously (#16752)" (#16835)"

This reverts commit a14517115f.

* Move async to regular dependencies

* Update package-lock.json
2020-12-09 17:40:58 +00:00
Octomerger Bot
218d08f38d Branch was updated using the 'autoupdate branch' Actions workflow. 2020-12-03 12:53:19 -08:00
Kevin Heis
d8302841a9 Readd new packages 2020-12-02 14:13:08 -08:00
Kevin Heis
0c3309d66e Reset package.json and package-lock.json 2020-12-02 14:10:47 -08:00
Sarah Schneider
1258092a41 Merge branch 'main' of github.com:github/docs-internal into hidden-docs-alt 2020-12-02 14:22:10 -05:00
Robert Mosolgo
a7d042a898 Merge branch 'main' into build-changelog 2020-12-02 13:56:50 -05:00
Sarah Schneider
7628caa417 Merge branch 'main' of github.com:github/docs-internal into hidden-docs-alt 2020-12-02 12:47:54 -05:00
James M. Greene
684a72077f Fix the browser tests by using a newer version of Puppeteer (#16707)
Improve 2 async-callback-based tests by counting their assertions
2020-12-01 19:17:05 -06:00
Sarah Schneider
b244d447dd Merge branch 'main' of github.com:github/docs-internal into hidden-docs-alt 2020-12-01 12:38:48 -05:00
Robert Mosolgo
caf4add9a5 Move mockdate to devdependencies 2020-11-25 16:44:48 -05:00
Robert Mosolgo
9e5d72eb42 Merge branch 'main' into build-changelog 2020-11-25 16:32:10 -05:00
Jason Etcovitch
4484068e01 Move render-content code to this repo (#16544)
* Move render-content files in here

* Replace existing file with nested index.js

* Copy in tests and jest-ify

* Update docs

* Uninstall @github-docs/render-content

* Bring over README

* Add missing dependencies

* Fix require paths
2020-11-25 11:20:23 -05:00
Robert Mosolgo
aeedfac37e Add graphql tests to CI, move snapshots to fixures, use mockdate 2020-11-25 11:12:13 -05:00
Sarah Schneider
8f0093c63a OpenAPI tooling updates (#16320) 2020-11-24 12:20:10 -08:00
Robert Mosolgo
615561cb56 oops, update lockfile 2020-11-23 08:45:52 -05:00
Robert Mosolgo
2400be9528 Merge branch 'main' into build-changelog 2020-11-23 08:44:32 -05:00
Lucas Costi
fa4cfe0a9f Bump rest-api-operations (#16584) 2020-11-23 14:19:32 +10:00
Jason Etcovitch
9332c62195 Sm0ller webpack output (#16543)
* Install friendly-errors-webpack-plugin

* Use it
2020-11-19 13:06:20 -05:00
Robert Mosolgo
7e07c1c831 Add build-changelog script, load schemas and create a diff 2020-11-18 17:08:56 -05:00
James M. Greene
d402a60833 Merge branch 'main' into hidden-docs-alt 2020-11-17 17:56:25 -06:00
Jason Etcovitch
8f2b4eb450 Merge branch 'main' into repo-sync 2020-11-17 18:02:58 -05:00
Rachael Sewell
82407992d2 remove inactive sidebar links (#16500) 2020-11-17 14:26:14 -08:00
Nick Schonning
b6de7c6887 chore: Convert Standard to eslint-config-standard (#1328)
* chore: Move standard to ESLint config

* fix: auto-fix ESLint indent issues

* fix: ESLint prefer-regex-literals

* fix: ESLint array-callback-return

- .filter must return a boolean value
- .map replaced with forEach when the value isn't used

* fix: ESLint no-extra-semi
2020-11-17 16:18:18 -05:00
Kevin Heis
890e86cc46 Merge branch 'main' into hidden-docs-alt 2020-11-17 09:58:45 -08:00
Kevin Heis
4d2e25b429 Use Redis Store for rate limiting when available (#16484) 2020-11-16 15:55:07 -08:00
Nick Schonning
92740f68d7 chore: Add Prettier for Yaml formatting
Related to #128
- Prettier to fix indenting/quoting across files
- Manually adjust list styles to "-" style
- Ignore all translated files from automated formatting
- Drop redundant CI env variable
2020-11-16 16:12:49 -05:00
Kevin Heis
bfb4a0def2 Update package-lock.json 2020-11-16 10:10:05 -08:00
Jason Etcovitch
0730158918 Datadoge (#16464)
* Install hot-shots

* Add statsd client

* Add some metrics

* Add a comment

* Comment typo fix

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2020-11-13 15:49:50 -05:00
Shati Patel
ef9bb5556a Code scanning: Bump API version (#16456)
Fix description (see https://github.com/github/github/pull/162415)
2020-11-13 11:25:48 +00:00
Martin Lopes
5555a01405 [Nov 4] Adds updates to Interaction Limits API (#16290)
Co-authored-by: skedwards88 <skedwards88@github.com>
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
2020-11-12 18:05:51 -08:00
Sarah Schneider
ce33df1cd3 New broken link report (#16412)
* add linkinator npm package

* add new script that uses Linkinator

* reorg the excluded links file and update comments

* replace blc artifacts with linkinator artifacts in .gitignore

* update the scheduled workflow to use the new script

* dismantle BLC scripts

* add workflow_dispatch event so we can test this manually

* npm uninstall broken-link-checker

* use different exit codes depending on whether broken links are found
2020-11-10 15:28:44 -05:00