1
0
mirror of synced 2025-12-22 19:34:15 -05:00
Commit Graph

30 Commits

Author SHA1 Message Date
Grace Park
e0e2ed3de3 adding observer disconnect (#26228) 2022-03-15 16:54:32 -07:00
Grace Park
21b59b5805 Move mini tocs rest + collapsible (#26069)
* starting minitocs change

* moving rest mini tocs and adding functionality to collapse

* adding some comments

* update margins

* minor updates: fix scroll to top button add padding to resthttpmethod verbs and background color for nested arrows in minitocs

* Update components/rest/RestReferencePage.tsx

Co-authored-by: Rachael Sewell <rachmari@github.com>

* Update components/rest/RestReferencePage.tsx

Co-authored-by: Rachael Sewell <rachmari@github.com>

* fix comment

* fix wording and z index

* bring back articlegridlayout

* updating margins for lg and xl

Co-authored-by: Rachael Sewell <rachmari@github.com>
2022-03-14 10:50:53 -07:00
Grace Park
1a6bee4601 Refactor to add RestReferencePage (#25781)
* refactor to add RestReferencePage

* remove structured data from article page

* add back clientsidehightlight js and remove structuredcontent

* update endpoint available for github apps page to use RestReferencePage

* check for minitocs

* use children for ArticlePage for overview endpoints page and move category data to RestReferencePage

* create MiniTocs component

* add MiniTocs

* fix unique key issue

* break into out into own div

* remove some unnecessary ts

* refactor looping section

* simplify markdown component usage

* add key prop

* add key prop

* add unique key

Co-authored-by: Rachael Sewell <rachmari@github.com>
2022-03-08 18:00:38 +00:00
Mike Surowiec
f3fc80cf05 Upgrade primer/components -> primer/react (#25591)
* upgrade primer/components -> primer/react

* fix jest failure
2022-02-24 00:30:14 +00:00
Grace Park
934b255119 add keyboard focus to scroll top and remove wording to keep one button (#24817) 2022-01-31 17:45:44 +00:00
Robert Sese
abe3881aa3 a11y: link style updates (#24680)
* Remove opacity classes on REST pages

* Underline links in article page content

* Typo 🔨

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2022-01-28 11:11:23 -06:00
Grace Park
eb776f64e4 Small accessibility changes - adding ul to li (#24449)
* adding ul to li

* move ul for just the mobile picker
2022-01-20 17:54:49 +00:00
Robert Sese
d0db00cd98 a11y: match picker label with current selection (#24321)
* Match label with selection

* defaultText is a better default

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* No longer used

* Also no longer used

* No longer used in the dropdown pickers

* Add translation strings for pickers

* Use translated strings in picker components

Co-authored-by: Peter Bengtsson <peterbe@github.com>
2022-01-19 18:43:31 +00:00
Grace Park
47de433865 Accessibility Search updates and additional minor changes (#24136)
* update to use heading markup

* updating to h3 for accessibility

* increase opactiy to meet 5.5:1 color contrast ratio

* update opacity to meet color contrast ratio

* update styling to match original but use heading markup

* remove aria-hidden for accessibility

* add h1 title search results and update scroll tip colors

* add number of matches

* remove no results since we are showing 0 results

* add overflow to fix border bottom on version search

* Update components/Search.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Update components/Search.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* incorporating feedback and update padding

Co-authored-by: Peter Bengtsson <peterbe@github.com>
2022-01-07 21:29:49 +00:00
Grace Park
124f54eb0c Accessibility changes for Nav Menu (#24099)
* updating to nav landmark

* support keyboard esc to close mobile menu

* update to ChevronDown to remove nested div
2022-01-06 17:34:19 +00:00
Robert Sese
bcb1b3c8bc Use lang attribute and translate picker aria-label (#24096)
* Translate picker aria-label

* Use lang attribute
2022-01-05 23:28:05 +00:00
Grace Park
3ce46b9172 move custom tool tip to remain permanent next to scroll to top button (#23551) 2021-12-13 17:40:48 +00:00
Grace Park
078fdc9a71 Remove bumplink symbol (#23539)
* run prettier

* removing space

* run prettier again
2021-12-09 18:41:35 +00:00
Kevin Heis
58fbe1edf5 Move px to rem in scss files (#23009)
Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
2021-11-19 21:06:45 +00:00
Kevin Heis
308aa9cb0c Fix heading sizes (#22968)
* Align heading sizes with Primer

* Make the headings on other pages match normal pages
2021-11-18 19:45:13 +00:00
Grace Park
f5008425ba Updating ordered lists numbering border (#22972)
* updating ordered lists numbering border

* moving 8px away
2021-11-18 11:12:55 -08:00
Grace Park
75577663e9 bringing back i - thanks rsese (#22969) 2021-11-18 17:41:20 +00:00
Kevin Heis
329a8c664e Create a shared picker component (#22836)
* Unified picker component

* Add picker to storybook

* TS fixes

* Simplify "mobile" header spacing

* Fix a few testid

* Update Picker.tsx

* Update Picker.tsx

* Update Picker.tsx

* Fix unit test

* Fix rendering tests
2021-11-16 19:10:28 +00:00
Grace Park
f684e7fe82 adding margin top to anchor links (#22515) 2021-11-01 13:57:00 -07:00
Kevin Heis
567652b0e3 Primer 18 b (#22462)
* Create migrate-colors-primer-18.js

* Update colors round 1

* upgrade primer packages

* Update index.scss

* Replace auto colors

* remove btn-primary-matte

* Turns out the class names and variables names DONT LINE UP... ugh....

* Check for allowed var colors
2021-10-28 19:17:23 +00:00
Jennie Steshenko
3938d02687 New DPA and SCCs (#21838) 2021-10-07 13:51:25 +00:00
Mike Surowiec
d2199e3deb Use Doctocat link header style (#21615)
* update autolinkHeadings to use Doctocat link header style

* fix header link test

* update graphql/rest rendering to use doctocat header link

* fix: miniToc issue with stray anchor

Co-authored-by: Rachael Sewell <rachmari@github.com>
2021-09-21 18:14:38 -04:00
Kevin Heis
29ebc555cb Add btn-primary-matte, ScrollButton, TruncateLines to storybook (#21611)
* Update create-processor.js

* Use built in semibold

* Preparing articlelist

* Add blue button to storybook

* Scope fade styles

* Add truncate component

* Add scroll button to storybook

* Update storybook.tsx

* Update DefaultLayout.tsx
2021-09-20 23:21:29 +00:00
Kevin Heis
504155926d Create a lead component (#21311)
* Create a lead component

* Update to remove markdown-body from Lead, copy over <code> styles

* ...so I can read the test output

* Update Lead.tsx

* Update Lead.tsx
2021-09-16 19:02:56 +00:00
Kevin Heis
6eec270335 Add MarkdownContent to storybook (#21222)
* Add MarkdownContent to storybook

* Update MarkdownContent.tsx

* Update storybook.tsx
2021-09-01 15:10:47 +00:00
Kevin Heis
9f7c20dae8 Upgrade Primer CSS to version 17, removing marketing styles (#20965)
* Package updates

* Fix up things that look broken

* Add to utils

* Lead now just sets font size, just use f3 where needed

* Update package-lock.json

* Update index.tsx

* Delete bump-link.scss

* Update trigger-error.js

* Update components/GenericError.tsx

Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>

* Update ArticlePage.tsx

* Update ActionBar.tsx

* Changes from meeting

* Found a few more monos

* Fix from a merge conflict

* Missed a few f3s

* Update SubLandingHero.tsx

* Bye gradients

* Match up breadcrumbs

* Update SubLandingHero.tsx

* Update lists.scss

Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>
2021-08-31 14:49:39 -07:00
Kevin Heis
d431e86dec Storybook lite (#21040)
* Remove storybook

* Update index.js

* Start a storybook outline

* Start a storybook outline

* Start showing errors

* Update storybook.tsx

* Typescript lint

* Name field

* Responsive

* Update storybook.tsx

* Update storybook.tsx

* Update storybook.tsx

* Add BumpLink to storybook

* Update storybook.tsx
2021-08-30 20:34:14 +00:00
Mike Surowiec
d76c16da19 Scope markdown body (#21082)
* update article content to markdown ui component

* decouple lunr indexing from class name

* remove summary outline none rule, apply utility class instead

* improve typing

* scope more styles down to markdown-body/extended-markdown

* move all markdown-body style overrides to MarkdownContent component

* fix class targeting within css module

* clean up MarkdownContent header style

* rename data-lunr to data-search

* fix: inline code color issue

* fix: update article markdown to work with MarkdownContent
2021-08-30 14:24:49 +00:00
Mike Surowiec
5f5aa0b0d1 BumpLink component (#21033)
* create BumpLink component, re-org components/ui
2021-08-24 11:25:38 -04:00
Mike Surowiec
23f4681b42 Scope product-callout and contributor-callout css to component (#20801)
* remove custom css for product-callout and contributor-callout

* create callout component, update existing test

* use Callout in more places
2021-08-11 17:50:20 +00:00