1
0
mirror of synced 2025-12-21 19:06:49 -05:00
Commit Graph

192 Commits

Author SHA1 Message Date
Mike Surowiec
567879365f fix: grid blowout due to missing min width (#22352) 2021-10-21 20:25:23 +00:00
Kevin Heis
83804c7114 Create search result event (#22307)
* Create search result event

* Update Search.tsx

* actually send it

* remove comment

* Apply suggestions from code review

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

* add 'required' to schema

Co-authored-by: Peter Bengtsson <mail@peterbe.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
2021-10-21 00:37:39 +00:00
Grace Park
884556eb02 Adding effectiveDate frontmatter property (#22317)
* adding effectiveDate frontmatter property

* Update components/article/ArticlePage.tsx

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* adding validation for correct date

* update to dateTime

* update to year month day

* update error date validation

* moving validation to getArticleContextFromRequest and moving id to div

* remove enteredDate

* Update content/README.md

Co-authored-by: Laura Coursen <lecoursen@github.com>

Co-authored-by: Peter Bengtsson <peterbe@github.com>
Co-authored-by: Laura Coursen <lecoursen@github.com>
2021-10-20 19:40:13 +00:00
Peter Bengtsson
3994797e81 indicate 0 search results as a result (#22262)
* indicate 0 search results as a result

fixes https://github.com/github/docs-engineering/issues/955

* correct logic

* refactored into own component
2021-10-19 22:23:36 +00:00
Grace Park
4727433baa Community redirect update to camel case and adding documentation (#21979)
* update to camel case

* add documentation on communityRedirect
2021-10-07 15:02:58 -07:00
Grace Park
9dd8ed7398 Bring back community redirect (#21971)
* add back

* adding community_redirect to page context based on parent

* update to use parentProduct

* bring back the link-secondary and text-bold
2021-10-07 18:58:31 +00:00
Amy Burns
e82f64f642 Add vscode as an option for the application selector (#21798)
* adding switcher to creating a codespace guide

* adding additional switcher for vscode and updating codespaces name

* using webui in codespaces coontext

* updating internal documentation

* remove default tool

Co-authored-by: hubwriter <hubwriter@github.com>
2021-10-07 14:57:45 +01:00
Jennie Steshenko
3938d02687 New DPA and SCCs (#21838) 2021-10-07 13:51:25 +00:00
Mike Surowiec
b279482cf9 Footer styling (#21877) 2021-10-06 18:09:11 +00:00
Steve Guntrip
32f59ee7b0 add ShieldLockIcon octicon to permissions statement (#21829) 2021-10-06 09:07:58 +00:00
Jeroen Rietveld
24e4c3407b Make guide filter accessible (#21380)
* Make guide filter accessible

Explain that the fields will filter a list.
Display a status message indicating the number of results found.

* update no guides found display, fix yaml issue

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
2021-10-04 18:11:11 +00:00
Mike Surowiec
85f6a43502 Mini TOC semantic rendering (#21836)
* semantic rendering of miniTocItems

* feat: create nested mini toc structure to simplify semantic rendering

* remove className usage of indentationLevel in miniToc rendering

* manually run script/graphql/update-files.js to update pre-rendered files

* use less brittle regex method to extract number
2021-10-04 10:48:42 -04:00
Grace Park
1211a3a92c Remove community_redirect and update all footer links for Codespaces, Discussions, and Sponsors (#21815)
* remove community_redirect and update all footer links to redirect to discussions for Codespaces, Sponsors, and Discussions

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect

* Remove community_redirect
2021-09-30 23:07:51 +00:00
Grace Park
bfe529c40a Fixing index page body text rendering (#21811)
* fixing index page body text rendering

* always use renderedPage
2021-09-30 21:37:49 +00:00
Robert Sese
000799df17 Handle learning track paths from a different product (#21776)
* Add trackProduct property

* Fall back to learning track product URL param

* Add product URL param to learning track banner

* Add product URL param to featured track links

* Fix typo :(

* Add product URL param to learning track

* Add multi-product learning track tests

* Re-enable tests with a Code Security learning track

* Re-enable more tests with Code Security learning tracks

* Add more multi-product testing

* Update components/sublanding/LearningTrack.tsx

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-09-30 21:17:02 +00:00
Mike Surowiec
d81f51ebf7 Picker improvements (#21765)
* close Language and ArticleVersion pickers after click

* cleanup ArticleGridLayout due to VersionPicker changes

* fix tsc errors resulting from primer upgrade

* fix / update tests

* cleanup mobile pickers visual consistency

* use btn-sm on VersionPicker

* update translation and close on click for enterprise releases

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2021-09-30 20:22:13 +00:00
Rachael Sewell
f346096897 move playground loading indicator image (#21816) 2021-09-29 22:00:37 +00:00
Kevin Heis
12356c5bbb More client routing fixes (#21793)
* More client routing fixes

* Update index.tsx

Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-09-29 16:08:31 -05:00
Mike Surowiec
3125579983 remove currentLanguage from mainContext, use router.locale instead (#21716) 2021-09-27 14:40:43 +00:00
Kevin Heis
5fb28d1c9a Skip tracking page events when searching (#21726)
* Skip tracking page events when searching

* Update events.ts
2021-09-27 13:46:36 +00:00
Kevin Heis
ceb2106cab Update analytics to handle client side routing (#21719)
* Update analytics to handle client side routing

* Update events.ts
2021-09-24 17:21:52 +00:00
Martin Lopes
83dc407ada Restructure Actions guides (#21577)
Co-authored-by: Sarah Edwards <skedwards88@github.com>
Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
2021-09-22 16:49:41 +10:00
Robert Sese
2f6af3fe20 Render learning track banner on ToC landing page (#21634)
* Add learning track info to ToC landing page context

* Render learning track banner on ToC landing page
2021-09-22 01:02:29 -05:00
Mike Surowiec
d2199e3deb Use Doctocat link header style (#21615)
* update autolinkHeadings to use Doctocat link header style

* fix header link test

* update graphql/rest rendering to use doctocat header link

* fix: miniToc issue with stray anchor

Co-authored-by: Rachael Sewell <rachmari@github.com>
2021-09-21 18:14:38 -04:00
Kevin Heis
29ebc555cb Add btn-primary-matte, ScrollButton, TruncateLines to storybook (#21611)
* Update create-processor.js

* Use built in semibold

* Preparing articlelist

* Add blue button to storybook

* Scope fade styles

* Add truncate component

* Add scroll button to storybook

* Update storybook.tsx

* Update DefaultLayout.tsx
2021-09-20 23:21:29 +00:00
Mike Surowiec
5eb5f7650c enable client-side routing by default (#21593)
* enable client-side routing by default

* add prefetchSrc 'self' to csp
2021-09-17 19:38:20 +00:00
Kevin Heis
cdbbc63219 Send new analytics fields for path_language, path_version, path_product, path_article (#21562)
* Send new analytics fields for path_language, path_version, path_product, path_article

* Update DefaultLayout.tsx

* Update events.js
2021-09-17 19:22:54 +00:00
Mike Surowiec
046a586c06 fix: primer/components use resolvedColorMode (#21569) 2021-09-16 20:00:26 +00:00
Kevin Heis
504155926d Create a lead component (#21311)
* Create a lead component

* Update to remove markdown-body from Lead, copy over <code> styles

* ...so I can read the test output

* Update Lead.tsx

* Update Lead.tsx
2021-09-16 19:02:56 +00:00
Kevin Heis
498f02c6ef (bottom|top|right|left)-\d (#21505) 2021-09-14 17:27:52 +00:00
Lee Dohm
b500fd07d0 Use titlePlainText attribute since the title will be used for rendered text 2021-09-09 13:50:54 -07:00
Mike Surowiec
d8b4383dc6 Improve Search styling (#21295)
* fix: improve search highlight contrast
2021-09-03 16:20:23 +00:00
Ramya Parimi
1c478ca75c Merge branch 'main' into ramyaparimi/survey-cancel-bug 2021-09-03 07:35:02 -05:00
Kevin Heis
57621df550 Rm print button (#21237)
* Remove print button

* Found another print button
2021-09-01 18:20:42 +00:00
Kevin Heis
6eec270335 Add MarkdownContent to storybook (#21222)
* Add MarkdownContent to storybook

* Update MarkdownContent.tsx

* Update storybook.tsx
2021-09-01 15:10:47 +00:00
Kevin Heis
9f7c20dae8 Upgrade Primer CSS to version 17, removing marketing styles (#20965)
* Package updates

* Fix up things that look broken

* Add to utils

* Lead now just sets font size, just use f3 where needed

* Update package-lock.json

* Update index.tsx

* Delete bump-link.scss

* Update trigger-error.js

* Update components/GenericError.tsx

Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>

* Update ArticlePage.tsx

* Update ActionBar.tsx

* Changes from meeting

* Found a few more monos

* Fix from a merge conflict

* Missed a few f3s

* Update SubLandingHero.tsx

* Bye gradients

* Match up breadcrumbs

* Update SubLandingHero.tsx

* Update lists.scss

Co-authored-by: Ash Guillaume <10384315+ashygee@users.noreply.github.com>
2021-08-31 14:49:39 -07:00
Ramya Parimi
fa1ace2395 fixed radio check overwrite 2021-08-31 13:25:34 -05:00
Kevin Heis
aef81ac477 Readd print tracking (#21180)
* Readd print button tracking

* Record all print events, not just button ones
2021-08-30 21:27:10 +00:00
Kevin Heis
d431e86dec Storybook lite (#21040)
* Remove storybook

* Update index.js

* Start a storybook outline

* Start a storybook outline

* Start showing errors

* Update storybook.tsx

* Typescript lint

* Name field

* Responsive

* Update storybook.tsx

* Update storybook.tsx

* Update storybook.tsx

* Add BumpLink to storybook

* Update storybook.tsx
2021-08-30 20:34:14 +00:00
Grace Park
d4e3614676 same minWidth as you scroll down article (#21182) 2021-08-30 16:44:59 +00:00
Mike Surowiec
d76c16da19 Scope markdown body (#21082)
* update article content to markdown ui component

* decouple lunr indexing from class name

* remove summary outline none rule, apply utility class instead

* improve typing

* scope more styles down to markdown-body/extended-markdown

* move all markdown-body style overrides to MarkdownContent component

* fix class targeting within css module

* clean up MarkdownContent header style

* rename data-lunr to data-search

* fix: inline code color issue

* fix: update article markdown to work with MarkdownContent
2021-08-30 14:24:49 +00:00
Kevin Heis
4d0e9c70a3 Add new fields to analytics event context: status, page_type, page_document_type (#21115)
* Add new fields to analytics event context: status, page-type, page-document-type

* Update schema-event.js

* Typescript

* Add status meta to error pages

* Update DefaultLayout.tsx

* Update DefaultLayout.tsx

* Update building-and-testing-nodejs-or-python.tsx
2021-08-26 14:58:45 -07:00
Mike Surowiec
529629ddec Fix: editor border and theme (#21172)
* fix: set theme based on colorMode

* fix border issue
2021-08-26 15:35:32 -04:00
Mike Surowiec
06d8f81401 Two-pane Experiment (#21092)
* pull changes from docs-playground

* cleanup, add callout banner

* cleanup linting and test fixes

* add discussion link

Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-08-26 14:19:40 -04:00
Kevin Heis
1cb2da024d Add opengraph tags to articles (#21089)
* Add opengraph tags to articles

* Update MainContext.tsx

* Update DefaultLayout.tsx
2021-08-26 14:18:58 +00:00
Rachael Sewell
c7ac98304a allow use of full titles on landing page (#20327) 2021-08-25 12:31:16 -07:00
Mike Surowiec
5f5aa0b0d1 BumpLink component (#21033)
* create BumpLink component, re-org components/ui
2021-08-24 11:25:38 -04:00
Grace Park
80c979c228 removing codespaces temporary banner (#21050) 2021-08-24 04:06:50 +00:00
Robert Sese
f2106f33c3 Apply markdown-body styles to intros (#21046) 2021-08-23 21:28:43 +00:00
Kevin Heis
86b6b1ad6f Remove storybook (#21037)
* Remove storybook

* Update index.js
2021-08-23 12:07:54 -07:00