* experimenting with redirects * cleanup developer.json * wip * clean console.log * progress * some progress * progress * much progress * debugging tests * hacky progress * ditch latest -> number redirects * minor * hacky progress * lots of progress * some small fixes * fix rendering tests * small fixes * progress * undo debugging * better * routing tests OK * more cleaning * unit tests * undoing lineending edit * undoing temporary debugging * don't ever set this.redirects on Page * cope with archived version redirects * adding code comments on the major if statements * address all feedback * update README about redirects * delete invalid test * fix feedback
152 lines
5.3 KiB
JavaScript
152 lines
5.3 KiB
JavaScript
import getRedirect from '../../lib/get-redirect.js'
|
|
import { latest } from '../../lib/enterprise-server-releases.js'
|
|
|
|
describe('getRedirect basics', () => {
|
|
it('should sometimes not correct the version prefix', () => {
|
|
// This essentially tests legacy entries that come from the
|
|
// `developer.json` file. Normally, we would have first
|
|
// rewritten `/enterprise/3.0` to `/enterprise-server@3.0`
|
|
// and then, from there, worried about the remaining `/foo/bar`
|
|
// part.
|
|
// But some redirects from `developer.json` as old and static.
|
|
const uri = '/enterprise/3.0/foo/bar'
|
|
const ctx = {
|
|
pages: {},
|
|
redirects: {
|
|
'/enterprise/3.0/foo/bar': '/something/else',
|
|
},
|
|
}
|
|
expect(getRedirect(uri, ctx)).toBe('/en/something/else')
|
|
})
|
|
|
|
it('should return undefined if nothing could be found', () => {
|
|
const ctx = {
|
|
pages: {},
|
|
redirects: {},
|
|
}
|
|
expect(getRedirect('/foo/pizza', ctx)).toBeUndefined()
|
|
})
|
|
|
|
it('should just inject language on version "home pages"', () => {
|
|
const ctx = {
|
|
pages: {},
|
|
redirects: {},
|
|
}
|
|
expect(getRedirect('/github-ae@latest', ctx)).toBe('/en/github-ae@latest')
|
|
|
|
expect(getRedirect('/enterprise-cloud@latest', ctx)).toBe('/en/enterprise-cloud@latest')
|
|
|
|
expect(getRedirect('/enterprise-server@3.3', ctx)).toBe('/en/enterprise-server@3.3')
|
|
|
|
expect(getRedirect('/enterprise-server@latest', ctx)).toBe(`/en/enterprise-server@${latest}`)
|
|
expect(getRedirect('/enterprise-server', ctx)).toBe(`/en/enterprise-server@${latest}`)
|
|
})
|
|
|
|
it('should always "remove" the free-pro-team prefix', () => {
|
|
const ctx = {
|
|
pages: {},
|
|
redirects: {
|
|
'/foo': '/bar',
|
|
},
|
|
}
|
|
expect(getRedirect('/free-pro-team@latest', ctx)).toBe('/en')
|
|
// Language is fine, but the version needs to be "removed"
|
|
expect(getRedirect('/en/free-pro-team@latest', ctx)).toBe('/en')
|
|
expect(getRedirect('/free-pro-team@latest/pizza', ctx)).toBe('/en/pizza')
|
|
expect(getRedirect('/free-pro-team@latest/foo', ctx)).toBe('/en/bar')
|
|
expect(getRedirect('/free-pro-team@latest/github', ctx)).toBe('/en/github')
|
|
})
|
|
|
|
it('should handle some odd exceptions', () => {
|
|
const ctx = {
|
|
pages: {},
|
|
redirects: {},
|
|
}
|
|
expect(getRedirect('/desktop/guides/foo/bar', ctx)).toBe('/en/desktop/foo/bar')
|
|
expect(getRedirect('/admin/guides/foo/bar', ctx)).toBe(
|
|
`/en/enterprise-server@${latest}/admin/foo/bar`
|
|
)
|
|
expect(getRedirect('/admin/something/else', ctx)).toBe(
|
|
`/en/enterprise-server@${latest}/admin/something/else`
|
|
)
|
|
expect(getRedirect('/insights/stuff', ctx)).toBe(
|
|
`/en/enterprise-server@${latest}/insights/stuff`
|
|
)
|
|
})
|
|
|
|
it('should figure out redirect based on presence of pages in certain cases', () => {
|
|
const ctx = {
|
|
pages: {
|
|
'/en/enterprise-server@3.2/foo/bar': null,
|
|
'/en/enterprise-server@3.2/admin/github-management': null,
|
|
},
|
|
redirects: {},
|
|
}
|
|
// Replacing `/user` with `` worked because there exits a page of such name.
|
|
expect(getRedirect('/enterprise-server@3.2/user/foo/bar', ctx)).toBe(
|
|
'/en/enterprise-server@3.2/foo/bar'
|
|
)
|
|
expect(getRedirect('/enterprise-server@3.2/admin/guides/user-management', ctx)).toBe(
|
|
'/en/enterprise-server@3.2/admin/github-management'
|
|
)
|
|
})
|
|
|
|
it('should always correct the old enterprise prefix', () => {
|
|
const ctx = {
|
|
pages: {},
|
|
redirects: {
|
|
'/enterprise-server@3.3/foo': '/enterprise-server@3.3/bar',
|
|
},
|
|
}
|
|
expect(getRedirect('/enterprise', ctx)).toBe(`/en/enterprise-server@${latest}`)
|
|
expect(getRedirect('/enterprise/3.3', ctx)).toBe('/en/enterprise-server@3.3')
|
|
expect(getRedirect('/enterprise/3.3/something', ctx)).toBe(
|
|
'/en/enterprise-server@3.3/something'
|
|
)
|
|
// but also respect redirects if there are some
|
|
expect(getRedirect('/enterprise/3.3/foo', ctx)).toBe('/en/enterprise-server@3.3/bar')
|
|
|
|
// Unique snowflake pattern
|
|
expect(getRedirect('/enterprise/github/admin/foo', ctx)).toBe(
|
|
`/en/enterprise-server@${latest}/github/admin/foo`
|
|
)
|
|
})
|
|
|
|
it('should not do anything on some prefixes', () => {
|
|
const ctx = {
|
|
pages: {},
|
|
redirects: {},
|
|
}
|
|
// Nothing's needed here because it's not /admin/guides and
|
|
// it already has the enterprise-server prefix.
|
|
expect(getRedirect(`/en/enterprise-server@${latest}/admin/something/else`, ctx)).toBeUndefined()
|
|
expect(getRedirect(`/en/enterprise-cloud@latest/user/foo`, ctx)).toBeUndefined()
|
|
})
|
|
|
|
it('should only inject language sometimes', () => {
|
|
const ctx = {
|
|
pages: {},
|
|
redirects: {
|
|
'/foo': '/bar',
|
|
},
|
|
}
|
|
// Nothing's needed here because it's not /admin/guides and
|
|
// it already has the enterprise-server prefix.
|
|
expect(getRedirect('/foo', ctx)).toBe('/en/bar')
|
|
expect(getRedirect('/en/foo', ctx)).toBe('/en/bar')
|
|
expect(getRedirect('/ja/foo', ctx)).toBe('/ja/bar')
|
|
})
|
|
|
|
it('should redirect both the prefix and the path needs to change', () => {
|
|
const ctx = {
|
|
pages: {},
|
|
redirects: {
|
|
[`/enterprise-server@${latest}/foo`]: `/enterprise-server@${latest}/bar`,
|
|
},
|
|
}
|
|
// Nothing's needed here because it's not /admin/guides and
|
|
// it already has the enterprise-server prefix.
|
|
expect(getRedirect('/enterprise-server/foo', ctx)).toBe(`/en/enterprise-server@${latest}/bar`)
|
|
})
|
|
})
|