cde40f4847
* Issue template stuff for creating megabranch * Fix placeholder YAML * update search indexes * update search indexes * update search indexes * update search indexes * update search indexes * update search indexes * update search indexes * update search indexes * update search indexes * update search indexes * update search indexes * update search indexes * update search indexes * Add release candidate banner * update search indexes * update search indexes * update search indexes * update search indexes * [GHES 3.2]: Remove final notes about machine man preview (GA) (#20939) * update search indexes * update search indexes * Add GHES versioning to "Managing your theme settings" (#20950) * update search indexes * [GHES 3.2]: Fix versioning for security alerts (#20761) * made a start * rework * move image to an enterprise 3.1 folder * forgot to commit * simplify reusable * update search indexes * update search indexes * update search indexes * Updated basic 3.2 REST fiels after package change These will be overwritten before release by the new description files when the 3.2 description is properly published * update search indexes * GHAE feature flag for `security alerts` custom notification option (#20979) * made a start * rework * move image to an enterprise 3.1 folder * forgot to commit * simplify reusable * add GHAE feature flag * remove spurious spaces I had added * update search indexes * update search indexes * update search indexes * update search indexes * update search indexes * update search indexes * update search indexes * Update versioning (#21121) Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com> * update search indexes * Add the new service (#21060) * update search indexes * update search indexes * update search indexes * Fix parent category index versioning for security overview * update search indexes * [GHES 3.2] Add documentation for GHES Referrer Policy Admin setting (#20910) Co-authored-by: jmarlena <6732600+jmarlena@users.noreply.github.com> Co-authored-by: Jules Parker <19994093+jules-p@users.noreply.github.com> Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com> * update search indexes * update search indexes * Update "Review hardware considerations" table (#21208) Performance improvements resulted in higher maximum job throughput and the new benchmarks need to be shared with current and potential customers. * update search indexes * Version new GHES 3.2 Actions tested performance (#21212) * update search indexes * Update "Review hardware considerations" table v2 Feedback from additional reviewers requires an update to the benchmarks previously merged. * update search indexes * update search indexes * [GHES 3.2] - Dependency Graph: Simplified enablement in GHES (GA) (#21078) * document UI button for dependency graph GHES 3.2 * update search indexes * Update getting-started-with-github-actions-for-github-enterprise-server.md * update search indexes * update search indexes * update search indexes * update search indexes * update search indexes * update search indexes * [GHES 3.2] Release candidate 1 release notes (#20799) Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com> Co-authored-by: bwestover <bwestover@github.com> Co-authored-by: Martin Lopes <martin389@github.com> Co-authored-by: Laura Coursen <lecoursen@github.com> Co-authored-by: Grey Baker <greysteil@github.com> Co-authored-by: Bas van Schaik <5082246+sj@users.noreply.github.com> Co-authored-by: William Bartholomew <iamwillbar@github.com> * update search indexes * update search indexes * update search indexes * update search indexes * update search indexes * Update OpenAPI Descriptions for GHES 3.2 (#21377) Also contains a rollup of other unmerged OpenAPI changes Co-authored-by: github-openapi-bot <github-openapi-bot@users.noreply.github.com> Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com> * update search indexes Co-authored-by: Rachael Sewell <rachmari@github.com> Co-authored-by: GitHub Actions <action@github.com> Co-authored-by: Docubot <67483024+docubot@users.noreply.github.com> Co-authored-by: Laura Coursen <lecoursen@github.com> Co-authored-by: Ethan Palm <56270045+ethanpalm@users.noreply.github.com> Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com> Co-authored-by: Felicity Chapman <felicitymay@github.com> Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com> Co-authored-by: Matthias Wenz <matthiaswenz@github.com> Co-authored-by: jmarlena <6732600+jmarlena@users.noreply.github.com> Co-authored-by: Jules Parker <19994093+jules-p@users.noreply.github.com> Co-authored-by: Steve-Glass <84886334+Steve-Glass@users.noreply.github.com> Co-authored-by: Meg Bird <megbird@github.com> Co-authored-by: bwestover <bwestover@github.com> Co-authored-by: Martin Lopes <martin389@github.com> Co-authored-by: Grey Baker <greysteil@github.com> Co-authored-by: Bas van Schaik <5082246+sj@users.noreply.github.com> Co-authored-by: William Bartholomew <iamwillbar@github.com> Co-authored-by: github-openapi-bot <69533958+github-openapi-bot@users.noreply.github.com> Co-authored-by: github-openapi-bot <github-openapi-bot@users.noreply.github.com>
5.1 KiB
title, intro, redirect_from, versions, topics, shortTitle
| title | intro | redirect_from | versions | topics | shortTitle | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Reviewing proposed changes in a pull request | In a pull request, you can review and discuss commits, changed files, and the differences (or "diff") between the files in the base and compare branches. |
|
|
|
Review proposed changes |
About reviewing pull requests
You can review changes in a pull request one file at a time. While reviewing the files in a pull request, you can leave individual comments on specific changes. After you finish reviewing each file, you can mark the file as viewed. This collapses the file, helping you identify the files you still need to review. A progress bar in the pull request header shows the number of files you've viewed. After reviewing as many files as you want, you can approve the pull request or request additional changes by submitting your review with a summary comment.
{% data reusables.search.requested_reviews_search_tip %}
Starting a review
{% include tool-switcher %}
{% webui %}
{% data reusables.repositories.sidebar-pr %}
{% data reusables.repositories.choose-pr-review %}
{% data reusables.repositories.changed-files %}
{% data reusables.repositories.start-line-comment %}
{% data reusables.repositories.type-line-comment %}
{% data reusables.repositories.suggest-changes %}
5. When you're done, click Start a review. If you have already started a review, you can click Add review comment.
Before you submit your review, your line comments are pending and only visible to you. You can edit pending comments anytime before you submit your review. To cancel a pending review, including all of its pending comments, scroll down to the end of the timeline on the Conversation tab, then click Cancel review.
{% endwebui %}
{% ifversion fpt %}
{% codespaces %}
You can use {% data variables.product.prodname_codespaces %} to test, run, and review pull requests.
{% data reusables.codespaces.review-pr %}
For more information on reviewing pull requests in {% data variables.product.prodname_codespaces %}, see "Using Codespaces for pull requests."
{% endcodespaces %} {% endif %}
{% ifversion fpt or ghes > 3.1 %}
Reviewing dependency changes
{% data reusables.dependency-review.beta %}
If the pull request contains changes to dependencies you can use the dependency review for a manifest or lock file to see what has changed and check whether the changes introduce security vulnerabilities. For more information, see "Reviewing dependency changes in a pull request."
{% data reusables.repositories.changed-files %}
-
On the right of the header for a manifest or lock file, display the dependency review by clicking the {% octicon "file" aria-label="The rich diff icon" %} rich diff button.
{% data reusables.repositories.return-to-source-diff %} {% endif %}
Marking a file as viewed
After you finish reviewing a file, you can mark the file as viewed, and the file will collapse. If the file changes after you view the file, it will be unmarked as viewed.
{% data reusables.repositories.changed-files %}
2. On the right of the header of the file you've finished reviewing, select Viewed.
Submitting your review
After you've finished reviewing all the files you want in the pull request, submit your review.
{% data reusables.repositories.changed-files %}
{% data reusables.repositories.review-changes %}
{% data reusables.repositories.review-summary-comment %}
4. Select the type of review you'd like to leave:
- Select Comment to leave general feedback without explicitly approving the changes or requesting additional changes.
- Select Approve to submit your feedback and approve merging the changes proposed in the pull request.
- Select Request changes to submit feedback that must be addressed before the pull request can be merged.
{% data reusables.repositories.submit-review %}
{% data reusables.repositories.request-changes-tips %}