jprdonnelly/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2026-04-04 20:00:43 -04:00
Code Issues Packages Projects Releases Wiki Activity

AudioPane: Fix WASAPI default device combo selection

Browse Source 
Set the default value of `Config::MAIN_WASAPI_DEVICE` to `default`
instead of `Default`. This fixes an issue where `AudioPane`'s `Output
Device` combo would be blank if `WASAPI` was selected and the user had
never changed the value of `Output Device`.

We don't have to worry about backward compatibility with users who have
`Default` in their config because config values aren't written unless
they've been changed at some point from the default, and the combo has
always saved `default` instead of `Default`.

Audio still worked during emulation in this situation because the
fallback for an unrecognized device name is the default device.

To help prevent similar situations in the future references to
`MAIN_WASAPI_DEVICE`'s default value now call `GetDefaultValue` instead
of hardcoding the expected default, or use the new helper function
`Config::IsDefaultValue`.
This commit is contained in:
Dentomologist
2026-03-21 13:37:22 -07:00
parent 0e92a14703
commit 6b2a8eff15
5 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Source/Core/AudioCommon/WASAPIStream.cpp
View File

@@ -176,7 +176,7 @@ bool WASAPIStream::SetRunning(bool running)
HRESULT result;
if (Config::Get(Config::MAIN_WASAPI_DEVICE) == "default")
if (Config::IsDefaultValue(Config::MAIN_WASAPI_DEVICE))
{
result = m_enumerator->GetDefaultAudioEndpoint(eRender, eConsole, &device);
}