mirror of
https://github.com/dolphin-emu/dolphin.git
synced 2026-05-06 03:01:10 -04:00
Improve usage of std::move and const references parameters
Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`. Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move. Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.
This commit is contained in:
@@ -9,6 +9,7 @@
|
||||
#include <sstream>
|
||||
#include <string>
|
||||
#include <tuple>
|
||||
#include <utility>
|
||||
|
||||
#include <fmt/format.h>
|
||||
|
||||
@@ -25,7 +26,8 @@ class CombinedInput final : public Device::Input
|
||||
public:
|
||||
using Inputs = std::pair<Device::Input*, Device::Input*>;
|
||||
|
||||
CombinedInput(std::string name, const Inputs& inputs) : m_name(std::move(name)), m_inputs(inputs)
|
||||
CombinedInput(std::string name, Inputs inputs)
|
||||
: m_name(std::move(name)), m_inputs(std::move(inputs))
|
||||
{
|
||||
}
|
||||
ControlState GetState() const override
|
||||
|
||||
Reference in New Issue
Block a user