jprdonnelly/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2026-05-05 18:01:15 -04:00
Code Issues Packages Projects Releases Wiki Activity

Improve usage of std::move and const references parameters

Browse Source 
Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`.

Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move.

Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.
This commit is contained in:
Martino Fontana
2026-04-06 11:37:26 +02:00
parent 33f62b0f9f
commit 95dec13203
140 changed files with 318 additions and 277 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
Source/Core/InputCommon/InputConfig.cpp
View File

@@ -3,6 +3,7 @@
#include "InputCommon/InputConfig.h"
#include <utility>
#include <vector>
#include "Common/FileUtil.h"
@@ -16,10 +17,11 @@
#include "InputCommon/ControllerInterface/ControllerInterface.h"
#include "InputCommon/InputProfile.h"
InputConfig::InputConfig(const std::string& ini_name, const std::string& gui_name,
const std::string& profile_directory_name, const std::string& profile_key)
: m_ini_name(ini_name), m_gui_name(gui_name), m_profile_directory_name(profile_directory_name),
m_profile_key(profile_key)
InputConfig::InputConfig(std::string ini_name, std::string gui_name,
std::string profile_directory_name, std::string profile_key)
: m_ini_name(std::move(ini_name)), m_gui_name(std::move(gui_name)),
m_profile_directory_name(std::move(profile_directory_name)),
m_profile_key(std::move(profile_key))
{
}