dolphin

mirror of https://github.com/dolphin-emu/dolphin.git synced 2026-04-01 02:00:49 -04:00

Files

Dentomologist 6b2a8eff15 AudioPane: Fix WASAPI default device combo selection

Set the default value of `Config::MAIN_WASAPI_DEVICE` to `default`
instead of `Default`. This fixes an issue where `AudioPane`'s `Output
Device` combo would be blank if `WASAPI` was selected and the user had
never changed the value of `Output Device`.

We don't have to worry about backward compatibility with users who have
`Default` in their config because config values aren't written unless
they've been changed at some point from the default, and the combo has
always saved `default` instead of `Default`.

Audio still worked during emulation in this situation because the
fallback for an unrecognized device name is the default device.

To help prevent similar situations in the future references to
`MAIN_WASAPI_DEVICE`'s default value now call `GetDefaultValue` instead
of hardcoding the expected default, or use the new helper function
`Config::IsDefaultValue`.

2026-03-21 15:07:42 -07:00

Config.cpp

Config: Make s_callbacks_lock recursive to fix hardcore mode deadlock.

2025-05-30 17:33:01 -05:00

Config.h

AudioPane: Fix WASAPI default device combo selection

2026-03-21 15:07:42 -07:00

ConfigInfo.cpp

C++20: Synthesize operator!= From operator==

2024-10-10 20:23:55 -07:00

ConfigInfo.h

Config: Make ConfigInfo use Common::SpinLock to protect the CachedValue. These locks are nearly always uncontested and this makes Config::Get faster.