jprdonnelly/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2026-05-05 18:01:15 -04:00
Code Issues Packages Projects Releases Wiki Activity
Files
95dec132030e72b74da6bc46966e4fe5e4e239c0
dolphin/Source/Core/Common
History
Martino Fontana 95dec13203 Improve usage of std::move and const references parameters 
Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`.

Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move.

Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.
2026-04-17 12:39:46 +02:00
..
Assembler
Improve usage of std::move and const references parameters
2026-04-17 12:39:46 +02:00
Config
AudioPane: Fix WASAPI default device combo selection
2026-03-21 15:07:42 -07:00
Crypto
Improve usage of std::move and const references parameters
2026-04-17 12:39:46 +02:00
Debug
Use more std::span arguments
2026-03-23 23:55:09 +01:00
GL
Merge pull request #14212 from cscd98/cast-func
2026-02-21 18:27:50 +01:00
Logging
LogManager: Remove redundant "(HSP)" in High-Speed Port's log type descritpion.
2026-03-27 11:24:14 -05:00
Align.h
Common: Better AlignUp implementation
2023-06-29 02:35:44 -05:00
Analytics.cpp
Treewide: Adjust order of includes
2021-12-10 14:49:57 -08:00
Analytics.h
treewide: convert GPLv2+ license info to SPDX tags
2021-07-05 04:35:56 +02:00
Arm64Emitter.cpp
Jit: Implement error-free transformation for single-precision FMA
2026-01-18 20:02:49 +01:00
Arm64Emitter.h
Jit: Implement error-free transformation for single-precision FMA
2026-01-18 20:02:49 +01:00
ArmCommon.h
treewide: convert GPLv2+ license info to SPDX tags
2021-07-05 04:35:56 +02:00
ArmCPUDetect.cpp
ArmCPUDetect: Add OpenBSD support for elf_aux_info
2025-01-22 22:58:00 -05:00
ArmFPURoundMode.cpp
Common: Move FPU-related helpers into Common namespace
2023-03-21 10:58:13 -04:00
Assert.h
Logging: Don't overwrite LDEBUG verbosity in Release builds
2025-09-19 13:25:42 -07:00
BitField.h
Common/BitField: Silence two warnings:
2025-11-15 20:32:14 -06:00
BitField.natvis
Improve BitField natvis
2022-01-02 14:39:34 -08:00
BitSet.h
Merge pull request #12473 from Dentomologist/bitset64_fix_iterator_incrementation
2024-01-01 22:03:11 +01:00
BitUtils.h
Common/BitUtils: Make SetBit constexpr.
2026-02-15 20:14:15 -06:00
BlockingLoop.h
Common: Convert BlockingLoop::StopMode to enum class
2023-06-12 17:12:25 -07:00
Buffer.h
Fix various typos and spelling mistakes
2026-01-17 20:11:38 +01:00
build_info.txt.in
Update min win10 version from 1703/15063 to 1903/18362
2025-03-16 00:59:45 -05:00
ChunkFile.h
ChunkFile: Add void* version of DoPointer.
2026-03-30 19:02:11 -05:00
CMakeLists.txt
CommonFuncsObjC: Make function to fetch the current macOS version common
2026-03-21 11:16:14 -04:00
CodeBlock.h
Cached Interpreter 2.0
2024-07-23 14:06:21 -07:00
ColorUtil.cpp
linter: Apply clang-format 19.1 formatting
2025-04-23 11:19:20 +02:00
ColorUtil.h
treewide: convert GPLv2+ license info to SPDX tags
2021-07-05 04:35:56 +02:00
Common.h
Common/MsgHandler: Remove non-format variants of PanicAlert
2022-01-09 12:44:14 -08:00
CommonFuncs.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
CommonFuncs.h
CommonFuncsObjC: Make function to fetch the current macOS version common
2026-03-21 11:16:14 -04:00
CommonFuncsObjC.mm
CommonFuncsObjC: Make function to fetch the current macOS version common
2026-03-21 11:16:14 -04:00
CommonPaths.h
Added Triforce support
2026-02-15 20:14:14 -06:00
CommonTypes.h
New FrameTime/VBlank Analyzer + Graph
2022-12-23 19:52:53 -05:00
CompatPatches.cpp
Misc: fix compiler warning: implicit declaration of function
2026-02-08 00:37:29 +01:00
Contains.h
Common: Replace Contains and ContainsSubrange with C++23 std::ranges equivalents
2025-06-05 19:18:08 -04:00
CPUDetect.h
CPUDetect: improve win/arm64 support
2022-07-25 21:21:11 -07:00
DirectIOFile.cpp
Windows/DirectIOFile: Don't request DELETE access for read-only Open
2025-11-29 14:02:24 -08:00
DirectIOFile.h
Common: Add a DirectIOFile class that allows for copies which are entirely thread safe.
2025-11-09 03:08:14 -06:00
DynamicLibrary.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
DynamicLibrary.h
VideoBackends:Vulkan: Allow loading custom drivers on Android
2023-06-11 13:52:34 +02:00
ENet.cpp
Netplay: Fix building on clang 17.
2023-11-03 16:15:04 +01:00
ENet.h
Netplay: Fix building on clang 17.
2023-11-03 16:15:04 +01:00
EnumFormatter.h
Common: Replace enable_if with concepts and other minor modernizations.
2025-05-05 19:34:24 -05:00
EnumMap.h
Common: Replace enable_if with concepts and other minor modernizations.
2025-05-05 19:34:24 -05:00
EnumMap.natvis
Create EnumMap natvis
2022-01-02 15:36:47 -08:00
Event.h
IOS: Only have one USBScanner
2025-04-21 21:57:49 +02:00
FatFsUtil.cpp
Improve usage of std::move and const references parameters
2026-04-17 12:39:46 +02:00
FatFsUtil.h
Common: Make SD pack/unpack strings translatable
2025-02-23 23:09:24 +01:00
FileSearch.cpp
Improve usage of std::move and const references parameters
2026-04-17 12:39:46 +02:00
FileSearch.h
Common/FileSearch: Refactor DoFileSearch
2026-01-24 16:50:10 +01:00
FilesystemWatcher.cpp
Fix various warnings
2025-07-12 12:47:30 +02:00
FilesystemWatcher.h
Common: Add class 'FilesystemWatcher' that is used to watch paths and receive callbacks about filesystem level events for anything under that path
2025-06-06 23:03:02 -05:00
FileUtil.cpp
Improve usage of std::move and const references parameters
2026-04-17 12:39:46 +02:00
FileUtil.h
Improve usage of std::move and const references parameters
2026-04-17 12:39:46 +02:00
FixedSizeQueue.h
Common: Move FixedSizeQueue into Common namespace
2023-03-22 01:23:15 -04:00
Flag.h
treewide: convert GPLv2+ license info to SPDX tags
2021-07-05 04:35:56 +02:00
FloatUtils.cpp
FloatUtils: Replace quieting SNaNs via 0.0 + x with MakeQuiet
2025-08-17 11:24:38 -04:00
FloatUtils.h
FloatUtils: Move MakeQuiet function here from Interpreter_FPUtils
2025-08-17 11:23:12 -04:00
FormatUtil.h
treewide: convert GPLv2+ license info to SPDX tags
2021-07-05 04:35:56 +02:00
FPURoundMode.h
Common: Move FPU-related helpers into Common namespace
2023-03-21 10:58:13 -04:00
Functional.h
Common/Functional: Add InvokerOf template which can convert function pointers to functor types.
2025-11-18 14:19:21 -06:00
GekkoDisassembler.cpp
GekkoDisassembler: drop unsupported opcodes
2025-12-12 01:37:19 +00:00
GekkoDisassembler.h
GekkoDisassembler: Remove unused parameter dmode from fdabc function
2023-07-27 10:47:46 -07:00
GenericCPUDetect.cpp
treewide: convert GPLv2+ license info to SPDX tags
2021-07-05 04:35:56 +02:00
GenericFPURoundMode.cpp
Common: Move FPU-related helpers into Common namespace
2023-03-21 10:58:13 -04:00
Hash.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
Hash.h
Common/Hash: use zlib-ng for adler32. small cleanups.
2022-08-01 10:07:27 -07:00
HookableEvent.h
HookableEvent: Allow hooks to be added and removed from within a Trigger callback. This fixes a deadlock in FIFOFifoRecorder.
2025-11-21 16:58:20 -06:00
HostDisassembler.cpp
Make overriding explicit and remove redundant virtual specifiers on overriding destructors - Core & UnitTests
2025-05-01 15:00:37 +02:00
HostDisassembler.h
DolphinQt: JIT Widget Refresh
2024-10-19 02:30:44 -07:00
HRWrap.cpp
fmt 10.0.0-10.1.1 compile fixes
2023-09-21 01:19:23 +02:00
HRWrap.h
fmt 10.0.0-10.1.1 compile fixes
2023-09-21 01:19:23 +02:00
HttpRequest.cpp
Use more std::span arguments
2026-03-23 23:55:09 +01:00
HttpRequest.h
Use more std::span arguments
2026-03-23 23:55:09 +01:00
Image.cpp
Common and VideoCommon: Change texture data from std::vector to Common::UniqueBuffer.
2025-05-03 18:32:30 -05:00
Image.h
Common and VideoCommon: Change texture data from std::vector to Common::UniqueBuffer.
2025-05-03 18:32:30 -05:00
IniFile.cpp
Common/IniFile: Fix case sensitivity mismatch in IniFile::Section::Delete()
2025-01-08 05:30:39 +01:00
IniFile.h
Remove unused imports
2026-01-25 16:12:15 +01:00
Inline.h
Change _WIN32 check to a _MSC_VER check in Inline.h
2022-05-02 01:57:36 -05:00
Intrinsics.h
Core/Common: Fix typos
2025-03-11 19:48:45 -04:00
IOFile.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
IOFile.h
Common/IOFile: Remove the Duplicate function. The duplicate handles shared a read/write position making them effectively not thread-safe.
2025-11-09 03:08:14 -06:00
JitRegister.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
JitRegister.h
JitRegister: Check IsEnabled before constructing string
2026-01-11 21:01:49 +01:00
JsonUtil.cpp
Common: add file serialization/deserialization functions for JSON
2024-05-31 22:36:12 -05:00
JsonUtil.h
Common: update json util function for converting to numeric value to use a static_cast. As discussed, a Saturating cast doesn't make sense when converting a double to a float
2024-05-31 23:08:05 -05:00
Lazy.h
treewide: convert GPLv2+ license info to SPDX tags
2021-07-05 04:35:56 +02:00
LdrWatcher.cpp
Remove redundant semicolons
2024-08-20 14:59:54 +02:00
LdrWatcher.h
treewide: convert GPLv2+ license info to SPDX tags
2021-07-05 04:35:56 +02:00
LinearDiskCache.h
LinearDiskCache: Use make_unique_for_overwrite.
2025-04-19 17:13:40 -05:00
make_scmrev.h.js
ScmRevGen: Set commits ahead to zero when on a tag
2024-06-29 22:59:40 -04:00
MathUtil.h
MathUtil: Simplify SaturatingCast implementation with std::cmp_less/cmp_greater and fix a floating point edge case.
2025-08-27 21:24:46 -05:00
Matrix.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
Matrix.h
Common: add transpose function to Matrix class
2025-09-17 11:14:09 -05:00
MemArena.h
Core: Don't create page table mappings before R/C bits are set
2026-02-04 21:35:22 +01:00
MemArenaAndroid.cpp
Core: Don't create page table mappings before R/C bits are set
2026-02-04 21:35:22 +01:00
MemArenaDarwin.cpp
Core: Don't create page table mappings before R/C bits are set
2026-02-04 21:35:22 +01:00
MemArenaUnix.cpp
Core: Don't create page table mappings before R/C bits are set
2026-02-04 21:35:22 +01:00
MemArenaWin.cpp
mingw: replace static_cast with reinterpret_cast as not permitted between void* and function params
2026-02-16 13:28:11 +00:00
MemoryUtil.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
MemoryUtil.h
Jit: Add more error checking to ProtectStack
2023-08-29 22:46:50 +02:00
MinizipUtil.h
minizip-ng: Stop using compatibility mode
2025-05-22 12:51:55 +02:00
MsgHandler.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
MsgHandler.h
Remove unused imports
2026-01-25 16:12:15 +01:00
Mutex.h
Common: Add AtomicMutex and SpinMutex classes as faster alternatives to std::mutex.
2025-11-02 20:45:55 -06:00
NandPaths.cpp
WiiSaveBanner: fall back to $userdir/Load/WiiBanners
2025-07-04 23:15:50 +01:00
NandPaths.h
WiiSaveBanner: fall back to $userdir/Load/WiiBanners
2025-07-04 23:15:50 +01:00
Network.cpp
Use more std::span arguments
2026-03-23 23:55:09 +01:00
Network.h
Use more std::span arguments
2026-03-23 23:55:09 +01:00
OneShotEvent.h
Common: Introduce a OneShotEvent class. Unlike Common::Event, OneShotEvent is safe in situations when being immediately destructed.
2025-11-18 14:19:21 -06:00
PcapFile.cpp
BBA/HLE: Fix random PCAP file corruption
2023-11-23 22:07:44 +04:00
PcapFile.h
treewide: convert GPLv2+ license info to SPDX tags
2021-07-05 04:35:56 +02:00
Profiler.cpp
Improve usage of std::move and const references parameters
2026-04-17 12:39:46 +02:00
Profiler.h
Improve usage of std::move and const references parameters
2026-04-17 12:39:46 +02:00
Projection.h
Common: Create Range Projections For std::pair
2025-03-09 13:19:41 -07:00
QoSSession.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
QoSSession.h
treewide: convert GPLv2+ license info to SPDX tags
2021-07-05 04:35:56 +02:00
Random.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
Random.h
Remove unused imports
2026-01-25 16:12:15 +01:00
RangeSet.h
Jit: Use RangeSet for physical_addresses
2026-02-23 23:01:49 +01:00
RangeSizeSet.h
Jit: Use RangeSet for physical_addresses
2026-02-23 23:01:49 +01:00
scmrev.h.in
Replace SCM_IS_MASTER with SCM_COMMITS_AHEAD_MASTER
2024-03-23 16:48:52 -05:00
SCMRevGen.vcxproj
msbuild: simplify lang/scm projects a bit
2022-04-27 15:06:04 -07:00
ScopeGuard.h
Common/ScopeGuard: Fix move constructor.
2025-11-18 14:19:21 -06:00
SDCardUtil.cpp
msvc: remove warning disables which no longer fire
2021-07-17 18:24:36 -07:00
SDCardUtil.h
treewide: convert GPLv2+ license info to SPDX tags
2021-07-05 04:35:56 +02:00
Semaphore.h
treewide: convert GPLv2+ license info to SPDX tags
2021-07-05 04:35:56 +02:00
SettingsHandler.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
SettingsHandler.h
Split SettingsHandler into separate reader and writer classes
2024-10-21 20:20:15 -07:00
SFMLHelper.cpp
Migrate to SFML>=3.0.0
2025-02-25 06:42:13 +01:00
SFMLHelper.h
c++23: Replace Common::ToUnderlying with std::to_underlying
2026-01-09 23:49:10 +01:00
SmallVector.h
Common: Move some duplicate container element construction logic into a ManuallyConstructedValue template.
2025-04-30 14:56:07 -05:00
SocketContext.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
SocketContext.h
rewrite tapserver interface for better error handling
2024-03-17 18:37:55 -07:00
SpanUtils.h
Remove unused imports
2026-01-25 16:12:15 +01:00
SPSCQueue.h
Common: Move some duplicate container element construction logic into a ManuallyConstructedValue template.
2025-04-30 14:56:07 -05:00
StringLiteral.h
Apply suggestions from code review
2023-02-09 18:36:20 +13:00
StringUtil.cpp
StringUtils: Drop TabsToSpaces
2025-12-15 13:41:54 +01:00
StringUtil.h
MagneticCardReader: Minor fixup to writing card data.
2026-02-21 01:01:57 -06:00
Swap.h
UnitTests: Add PageTableHostMappingTest
2026-02-04 21:35:22 +01:00
SymbolDB.cpp
PPCSymbolDB: Don't return non-const pointers
2025-07-27 17:03:57 +02:00
SymbolDB.h
PPCSymbolDB: Don't return non-const pointers
2025-07-27 17:03:57 +02:00
Thread.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
Thread.h
Jit: Don't use a second stack
2023-02-28 20:29:46 +01:00
Timer.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
Timer.h
Common/Timer: Add a SteadyAwakeClock class which counts non-suspended system running time.
2025-07-24 23:56:10 -05:00
TimeUtil.cpp
fmt: Replace deprecated fmt::localtime usage with Common::LocalTime
2025-06-04 13:32:12 +02:00
TimeUtil.h
fmt: Replace deprecated fmt::localtime usage with Common::LocalTime
2025-06-04 13:32:12 +02:00
TransferableSharedMutex.h
Common: Add TransferableSharedMutex class and unit tests.
2026-01-19 21:56:59 -06:00
TraversalClient.cpp
Improve usage of std::move and const references parameters
2026-04-17 12:39:46 +02:00
TraversalClient.h
Improve usage of std::move and const references parameters
2026-04-17 12:39:46 +02:00
TraversalProto.h
Core/Common: Fix typos
2025-03-11 19:48:45 -04:00
TraversalServer.cpp
fmt: change use of fmt/base.h to fmt/format.h as not provided until fmt>=11.0
2026-03-15 08:37:00 +00:00
TypeUtils.h
MMU: Use templates for Read/Write functions
2025-10-08 11:27:06 +02:00
UnixUtil.h
Common/UnixUtil: Only define CreateEventFD on Linux.
2026-02-15 20:14:15 -06:00
UPnP.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
UPnP.h
Common/UPnP: Move interface into Common namespace
2023-04-12 14:15:58 -04:00
VariantUtil.h
VariantUtil: Introduce WithVariantAlternative to dynamically construct and visit a variant alternative.
2025-02-25 17:22:59 -06:00
Version.cpp
Add user agent to headers for all RetroAchievements server calls
2024-06-03 00:24:43 -04:00
Version.h
Add user agent to headers for all RetroAchievements server calls
2024-06-03 00:24:43 -04:00
WaitableFlag.h
IOS: Only have one USBScanner
2025-04-21 21:57:49 +02:00
WindowsDevice.cpp
WindowsDevice: Add DeviceChangeNotification class.
2025-12-23 00:02:36 -06:00
WindowsDevice.h
WindowsDevice: Add DeviceChangeNotification class.
2025-12-23 00:02:36 -06:00
WindowsRegistry.cpp
mingw: move ReadValue instantiations in cpp for compatibility
2026-01-04 21:16:30 +00:00
WindowsRegistry.h
mingw: move ReadValue instantiations in cpp for compatibility
2026-01-04 21:16:30 +00:00
WindowSystemInfo.h
Core/Common: Fix typos
2025-03-11 19:48:45 -04:00
WorkQueueThread.h
Common/WorkQueueThread: Make IsRunning function public.
2026-03-26 16:03:59 -05:00
x64ABI.cpp
Common:X64ABI: Work around clang-format being dumb
2022-08-11 23:57:28 -05:00
x64ABI.h
Core/Common: Fix typos
2025-03-11 19:48:45 -04:00
x64CPUDetect.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
x64Emitter.cpp
Jit: Implement error-free transformation for single-precision FMA
2026-01-18 20:02:49 +01:00
x64Emitter.h
Jit: Implement error-free transformation for single-precision FMA
2026-01-18 20:02:49 +01:00
x64FPURoundMode.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
x64Reg.h
x64Emitter: Support YMM registers
2025-09-02 22:15:16 +02:00