jprdonnelly/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2026-05-05 18:01:15 -04:00
Code Issues Packages Projects Releases Wiki Activity
Files
ff57599e67fd759b5fbd645d443c51d668286dd3
dolphin/Source/Core/VideoCommon
History
cristian64 6059045c59 Core: Address -Wrange-loop-construct warning. 
The warning can be seen since 1f72403ec7 when GCC 13.3.0 is used:

```counterexample
[1540/1898] Building CXX object Source/Core/VideoCommon/CMakeFiles/videocommon.dir/TextureCacheBase.cpp.o
/w/dolphin/Source/Core/VideoCommon/TextureCacheBase.cpp: In member function 'void TextureCacheBase::ApplyMaterialToCacheEntry(const VideoCommon::MaterialResource&, TCacheEntry*)':
/w/dolphin/Source/Core/VideoCommon/TextureCacheBase.cpp:3136:19: warning: loop variable 'texture' creates a copy from type 'const VideoCommon::MaterialResource::TextureLikeReference' [-Wrange-loop-construct]
 3136 |   for (const auto texture : material_data->GetTextures())
      |                   ^~~~~~~
/w/dolphin/Source/Core/VideoCommon/TextureCacheBase.cpp:3136:19: note: use reference type to prevent copying
 3136 |   for (const auto texture : material_data->GetTextures())
      |                   ^~~~~~~
      |                   &
```
2026-04-18 10:23:55 +01:00
..
Assets
Remove unused imports
2026-01-25 16:12:15 +01:00
GraphicsModSystem
VideoCommon: allow graphics mods to be added to sub folders
2026-03-26 20:13:16 -05:00
Resources
VideoCommon: enhance 'CustomResourceManager' for post processing
2026-03-26 20:13:16 -05:00
AbstractFramebuffer.cpp
Adjust order and spacing of various #includes
2024-07-26 14:28:34 -07:00
AbstractFramebuffer.h
AbstractFramebuffer: Fix Android reorder-ctor warning
2023-08-12 20:48:47 -07:00
AbstractGfx.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
AbstractGfx.h
VideoCommon: initialize stored viewport to 0, fixes a crash in debug mode for d3d
2025-12-24 15:23:25 -06:00
AbstractPipeline.h
C++20: Synthesize operator!= From operator==
2024-10-10 20:23:55 -07:00
AbstractShader.h
VideoBackends / VideoCommon: add support for specifying include files in shader code
2025-10-26 22:47:23 -05:00
AbstractStagingTexture.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
AbstractStagingTexture.h
treewide: convert GPLv2+ license info to SPDX tags
2021-07-05 04:35:56 +02:00
AbstractTexture.cpp
Update code to work with new version of ImGui.
2025-08-18 05:38:14 -07:00
AbstractTexture.h
Update code to work with new version of ImGui.
2025-08-18 05:38:14 -07:00
AsyncRequests.cpp
VideoCommon: Clean up and eliminate the mutex in AsyncRequests using WaitableSPSCQueue.
2025-10-28 17:22:04 -05:00
AsyncRequests.h
VideoCommon: Clean up and eliminate the mutex in AsyncRequests using WaitableSPSCQueue.
2025-10-28 17:22:04 -05:00
AsyncShaderCompiler.cpp
VideoCommon: remove template parameter from lock guards in AsyncShaderCompiler, let type deduction do its thing and improve readability
2025-11-21 01:18:35 -06:00
AsyncShaderCompiler.h
VideoCommon: add method to async shader compiler to clear pending/completed work (used on shutdown), this will in turn clear up any resources that the worker items may have held onto
2025-11-21 01:17:45 -06:00
BoundingBox.cpp
VideoCommon: Move backend_info out of VideoConfig struct.
2025-03-09 01:42:45 -06:00
BoundingBox.h
VideoCommon: Use std::span for BoundingBox::Write()
2023-12-09 16:33:21 -05:00
BPFunctions.cpp
VideoCommon: avoid assuming global state exists for 'EndUtilityDrawing', use last stored viewport/scissor rect instead
2025-11-20 00:35:01 -06:00
BPFunctions.h
VideoCommon: rename ScissorResult 'm_result' to 'rectangles' to better reflect what the member is
2025-10-31 13:28:14 -05:00
BPMemory.cpp
VideoBackends / VideoCommon: rename member variables in RenderState to be consistent
2025-08-23 13:50:22 -05:00
BPMemory.h
VideoBackends / VideoCommon: rename member variables in RenderState to be consistent
2025-08-23 13:50:22 -05:00
BPStructs.cpp
VideoCommon: ignore zero-stride EFB/XFB copies
2026-03-28 03:05:08 +00:00
BPStructs.h
treewide: convert GPLv2+ license info to SPDX tags
2021-07-05 04:35:56 +02:00
CMakeLists.txt
VideoCommon: update resource manager with a material/shader/and texture(+sampler) resource to show the complexities that warrant the resource manager system
2025-11-23 11:08:50 -06:00
CommandProcessor.cpp
Remove "please report it to the developers" from unknown opcode message
2026-03-22 14:23:46 +01:00
CommandProcessor.h
VideoCommon: remove unused struct fields
2025-06-24 19:38:45 +01:00
ConstantManager.h
Cache normals in addition to binormals and tangents
2024-10-12 10:32:41 -07:00
Constants.h
Revert "VideoCommon: revert max pixel shader samplers back to 8 for Android devices."
2024-01-03 18:43:44 -06:00
CPMemory.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
CPMemory.h
Fix out of bounds accesses for invalid vertex component formats
2024-04-04 12:50:34 -07:00
CPUCull.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
CPUCull.h
Fix uninitialized variable warnings (C26495)
2023-02-15 19:18:39 -08:00
CPUCullImpl.h
VideoCommon: Add class for quickly transforming and culling vertices on the CPU
2023-01-25 02:21:56 -06:00
DataReader.h
treewide: convert GPLv2+ license info to SPDX tags
2021-07-05 04:35:56 +02:00
DriverDetails.cpp
DriverDetails: Mark BUG_BROKEN_DISCARD_WITH_EARLY_Z as fixed in macOS 14.0+
2026-03-21 11:16:15 -04:00
DriverDetails.h
Fix various typos and spelling mistakes
2026-01-17 20:11:38 +01:00
EFBInterface.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
EFBInterface.h
VideoCommon: Fix out-of-bounds and disabled EFB access.
2025-03-26 01:23:16 -05:00
Fifo.cpp
Merge pull request #14035 from Dentomologist/pauseandlock_refactoring
2025-11-01 10:06:08 +01:00
Fifo.h
FifoManager: Remove redundant PauseAndLock parameters
2025-10-26 18:01:51 -07:00
FramebufferManager.cpp
Merge pull request #14071 from iwubcode/avoid_config_framebuffer_manager
2025-11-11 20:58:35 -05:00
FramebufferManager.h
VideoCommon/FramebufferManager: Silence warning:
2025-11-15 20:32:10 -06:00
FramebufferShaderGen.cpp
VideoCommon: Move backend_info out of VideoConfig struct.
2025-03-09 01:42:45 -06:00
FramebufferShaderGen.h
Video: implement color correction to match the NTSC and PAL color spaces (and gamma) that GC and Wii targeted.
2023-06-19 01:34:42 +03:00
FrameDumper.cpp
Common: Remove the string parameters from the HookableEvent interface.
2025-11-06 22:34:40 -06:00
FrameDumper.h
Video: remove enforced resolution least common multiple of 4 when dumping screenshots and not videos (only videos encoders have this limit).
2024-04-08 22:54:45 +03:00
FrameDumpFFMpeg.cpp
VideoCommon: Make Presenter aware of the next swap time to eliminate unsafe usage of GetTicks() with ImmediateXFB + DualCore.
2025-11-11 20:01:52 -06:00
FrameDumpFFMpeg.h
VideoCommon: Limit maximum denominator for MPEG4
2025-05-12 18:54:42 +02:00
FreeLookCamera.cpp
Core: Eliminate FreeLookConfig by putting the "active config" within FreeLookCamera.
2025-11-12 18:01:53 -06:00
FreeLookCamera.h
Core: Eliminate FreeLookConfig by putting the "active config" within FreeLookCamera.
2025-11-12 18:01:53 -06:00
GeometryShaderGen.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
GeometryShaderGen.h
Fix ambiguous uses of format_to
2022-01-13 11:11:08 -08:00
GeometryShaderManager.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
GeometryShaderManager.h
VideoCommon: De-globalize GeometryShaderManager class.
2022-12-29 15:33:19 +01:00
GXPipelineTypes.h
C++20: Synthesize operator!= From operator==
2024-10-10 20:23:55 -07:00
HiresTextures.cpp
Clean includes
2026-01-24 16:50:10 +01:00
HiresTextures.h
VideoCommon: separate the concept of a 'resource' from an 'asset'. A resource is potentially multiple assets that are chained together but represent one type of data to the rest of the system. An example is a 'material'. A 'material' is a collection of textures, a custom shader, and some metadata that all comes together to form what the concept of the material is. There will be a 'material' resource. For now, start small by introducing the interface and change our texture loading which used assets from the old resource manager, to an actual resource.
2025-11-23 11:04:24 -06:00
IndexGenerator.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
IndexGenerator.h
VideoCommon: Add vertex shader point and line expansion
2022-10-22 20:13:24 -05:00
LightingShaderGen.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
LightingShaderGen.h
VideoCommon: move to a 'process_fragment()' function to simplify custom shaders and provide a direct override of the tev stage logic
2025-03-22 15:22:00 -05:00
LookUpTables.h
treewide: convert GPLv2+ license info to SPDX tags
2021-07-05 04:35:56 +02:00
NativeVertexFormat.h
NativeVertexFormat: Collapse std namespace and mark hash noexcept
2024-01-31 12:37:44 -05:00
NetPlayChatUI.cpp
mingw: replace SendMessage usage as clashes with existing function
2025-12-10 21:07:33 +00:00
NetPlayChatUI.h
mingw: replace SendMessage usage as clashes with existing function
2025-12-10 21:07:33 +00:00
NetPlayGolfUI.cpp
treewide: convert GPLv2+ license info to SPDX tags
2021-07-05 04:35:56 +02:00
NetPlayGolfUI.h
treewide: convert GPLv2+ license info to SPDX tags
2021-07-05 04:35:56 +02:00
OnScreenDisplay.cpp
Externals / VideoCommon: update imgui to 1.91.7 and implot to v0.16; imgui changed types for ImTextureId, which was addressed by using an implicit cast
2025-01-20 14:47:14 -06:00
OnScreenDisplay.h
Remove redundant semicolons
2024-08-20 14:59:54 +02:00
OnScreenUI.cpp
Move PerformanceMetrics from global variable to System
2026-03-14 16:42:21 +02:00
OnScreenUI.h
VideoCommon: fix -Wmismatched-tags warning
2025-08-23 03:05:04 +01:00
OnScreenUIKeyMap.h
Insert a more solid abstraction between Qt and Imgui
2023-02-09 18:36:20 +13:00
OpcodeDecoding.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
OpcodeDecoding.h
VideoCommon/OpcodeDecoding: Replace enable_if with concepts.
2025-09-13 19:05:33 -05:00
PerformanceMetrics.cpp
Move PerformanceMetrics from global variable to System
2026-03-14 16:42:21 +02:00
PerformanceMetrics.h
Move PerformanceMetrics from global variable to System
2026-03-14 16:42:21 +02:00
PerformanceTracker.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
PerformanceTracker.h
Core, VideoCommon: Fix crash at shutdown due to destructor ordering
2025-04-28 07:11:53 +03:00
PerfQueryBase.cpp
Adjust order and spacing of various #includes
2024-07-26 14:28:34 -07:00
PerfQueryBase.h
Add virtual Initialize() to PerfQueryBase
2023-01-31 19:41:24 +13:00
PipelineUtils.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
PipelineUtils.h
VideoCommon: move ApplyDriverBugs for the normal pipeline out into a utility function, add a way to hash the pipeline (using the vertex declaration instead of the native vertex format)
2025-11-23 11:04:24 -06:00
PixelEngine.cpp
VideoCommon/PixelEngine: Generify lock guards
2023-12-22 14:19:29 -05:00
PixelEngine.h
VideoCommon/PixelEngine: Passthrough system instance in constructor
2023-12-22 14:19:26 -05:00
PixelShaderGen.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
PixelShaderGen.h
VideoCommon: move to a 'process_fragment()' function to simplify custom shaders and provide a direct override of the tev stage logic
2025-03-22 15:22:00 -05:00
PixelShaderManager.cpp
Fix various typos and spelling mistakes
2026-01-17 20:11:38 +01:00
PixelShaderManager.h
VideoCommon: add custom pixel shader constants as a buffer of data to be passed to all backends
2023-10-05 21:20:16 -05:00
PostProcessing.cpp
Clean includes
2026-01-24 16:50:10 +01:00
PostProcessing.h
VideoBackends / VideoCommon: add support for specifying include files in shader code
2025-10-26 22:47:23 -05:00
Present.cpp
Fix various typos and spelling mistakes
2026-01-17 20:11:38 +01:00
Present.h
VideoCommon: Add a hidden setting to cap immediate XFB swaps to one per VI.
2025-11-25 00:15:32 -06:00
RenderState.cpp
Fix various typos and spelling mistakes
2026-01-17 20:11:38 +01:00
RenderState.h
VideoBackends / VideoCommon: rename member variables in RenderState to be consistent
2025-08-23 13:50:22 -05:00
sfont.inc
Use fmt::to_string for texture format overlay
2022-07-15 12:29:40 -07:00
ShaderCache.cpp
Merge pull request #14043 from iwubcode/custom_resource
2025-12-22 17:08:02 -05:00
ShaderCache.h
Common/LinearDiskCache: Move interface into Common namespace
2023-04-19 09:14:39 -04:00
ShaderCompileUtils.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
ShaderCompileUtils.h
VideoCommon: fix wrong path to glslang include
2025-11-02 14:29:14 -06:00
ShaderGenCommon.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
ShaderGenCommon.h
VideoCommon: move to a 'process_fragment()' function to simplify custom shaders and provide a direct override of the tev stage logic
2025-03-22 15:22:00 -05:00
Spirv.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
Spirv.h
Merge pull request #13975 from iwubcode/shader_includes
2025-11-02 13:17:28 -05:00
Statistics.cpp
Common: Remove the string parameters from the HookableEvent interface.
2025-11-06 22:34:40 -06:00
Statistics.h
Common: Make HookableEvent use non-static data.
2025-11-02 17:30:43 -06:00
TextureCacheBase.cpp
Core: Address -Wrange-loop-construct warning.
2026-04-18 10:23:55 +01:00
TextureCacheBase.h
VideoCommon: optionally apply materials to EFBs
2026-03-26 20:13:16 -05:00
TextureConfig.cpp
C++20: Synthesize operator!= From operator==
2024-10-10 20:23:55 -07:00
TextureConfig.h
VideoCommon: add formatter for AbstractTextureType
2025-01-20 14:24:54 -06:00
TextureConversionShader.cpp
VideoCommon: Move backend_info out of VideoConfig struct.
2025-03-09 01:42:45 -06:00
TextureConversionShader.h
VideoCommon: Reduce duplicates of non-palette-requiring texture decode shaders
2022-06-16 02:08:45 -05:00
TextureConverterShaderGen.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
TextureConverterShaderGen.h
Restructure parameters to TetxureConverterShaderGen/TextureConversionShader
2022-07-16 00:07:10 -07:00
TextureDecoder_Common.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
TextureDecoder_Generic.cpp
linter: Apply clang-format 19.1 formatting
2025-04-23 11:19:20 +02:00
TextureDecoder_Util.h
treewide: convert GPLv2+ license info to SPDX tags
2021-07-05 04:35:56 +02:00
TextureDecoder_x64.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
TextureDecoder.h
VideoCommon: Use GetSpanForAddress safely in texture decoding
2024-04-20 18:31:08 +02:00
TextureInfo.cpp
VideoCommon: Move TextureInfo getters to header
2026-01-19 19:46:21 +01:00
TextureInfo.h
VideoCommon: Move TextureInfo getters to header
2026-01-19 19:46:21 +01:00
TextureUtils.cpp
Common/FileSearch: Refactor DoFileSearch
2026-01-24 16:50:10 +01:00
TextureUtils.h
VideoCommon: Scan texture dumping directory + subdirectories to not re-dump existing files.
2024-03-21 20:27:34 -05:00
TMEM.cpp
Treewide: Adjust order of includes
2021-12-10 14:49:57 -08:00
TMEM.h
Treewide: Adjust order of includes
2021-12-10 14:49:57 -08:00
UberShaderCommon.cpp
c++23: Replace Common::ToUnderlying with std::to_underlying
2026-01-09 23:49:10 +01:00
UberShaderCommon.h
VideoCommon: Allow BitfieldExtract in specialized shaders
2021-11-17 20:04:33 -08:00
UberShaderPixel.cpp
UberShaderPixel: Fix missing check for framebuffer fetch for BUG_BROKEN_DISCARD_WITH_EARLY_Z workaround
2026-03-21 11:16:15 -04:00
UberShaderPixel.h
VideoCommon: move to a 'process_fragment()' function to simplify custom shaders and provide a direct override of the tev stage logic
2025-03-22 15:22:00 -05:00
UberShaderVertex.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
UberShaderVertex.h
VideoCommon: Name ubershaders
2022-06-16 02:08:45 -05:00
VertexLoader_Color.cpp
VertexLoader: Fix wrong array being used if color 1 is present but color 0 isn't
2023-12-02 15:54:52 -08:00
VertexLoader_Color.h
linter: Apply clang-format 19.1 formatting
2025-04-23 11:19:20 +02:00
VertexLoader_Normal.cpp
Cache normals in addition to binormals and tangents
2024-10-12 10:32:41 -07:00
VertexLoader_Normal.h
linter: Apply clang-format 19.1 formatting
2025-04-23 11:19:20 +02:00
VertexLoader_Position.cpp
Fix out of bounds accesses for invalid vertex component formats
2024-04-04 12:50:34 -07:00
VertexLoader_Position.h
linter: Apply clang-format 19.1 formatting
2025-04-23 11:19:20 +02:00
VertexLoader_TextCoord.cpp
Fix out of bounds accesses for invalid vertex component formats
2024-04-04 12:50:34 -07:00
VertexLoader_TextCoord.h
linter: Apply clang-format 19.1 formatting
2025-04-23 11:19:20 +02:00
VertexLoader.cpp
VertexLoader: Use Common::SmallVector
2023-12-02 15:54:52 -08:00
VertexLoader.h
VertexLoader: Use Common::SmallVector
2023-12-02 15:54:52 -08:00
VertexLoaderARM64.cpp
Cache normals in addition to binormals and tangents
2024-10-12 10:32:41 -07:00
VertexLoaderARM64.h
VertexLoader: Eliminate use of DataReader
2022-11-22 17:17:11 -08:00
VertexLoaderBase.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
VertexLoaderBase.h
linter: Apply clang-format 19.1 formatting
2025-04-23 11:19:20 +02:00
VertexLoaderManager.cpp
VertexLoaderManager: Fix crash caused by invalid array base
2026-03-02 13:02:51 -08:00
VertexLoaderManager.h
Cache normals in addition to binormals and tangents
2024-10-12 10:32:41 -07:00
VertexLoaderUtils.h
VertexLoader: Eliminate use of DataReader
2022-11-22 17:17:11 -08:00
VertexLoaderX64.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
VertexLoaderX64.h
VertexLoader: Eliminate use of DataReader
2022-11-22 17:17:11 -08:00
VertexManagerBase.cpp
VideoCommon: Defer creating TextureInfo
2026-01-18 13:04:06 +01:00
VertexManagerBase.h
Cache normals in addition to binormals and tangents
2024-10-12 10:32:41 -07:00
VertexShaderGen.cpp
Fix various typos and spelling mistakes
2026-01-17 20:11:38 +01:00
VertexShaderGen.h
VideoCommon: move vertex shader gen logic to a 'process_vertex()' function, to eventually allow for custom shaders to override vertex logic
2025-05-24 01:27:58 -05:00
VertexShaderManager.cpp
Use more std::span arguments
2026-03-23 23:55:09 +01:00
VertexShaderManager.h
Use more std::span arguments
2026-03-23 23:55:09 +01:00
VideoBackendBase.cpp
VideoCommon: separate the concept of a 'resource' from an 'asset'. A resource is potentially multiple assets that are chained together but represent one type of data to the rest of the system. An example is a 'material'. A 'material' is a collection of textures, a custom shader, and some metadata that all comes together to form what the concept of the material is. There will be a 'material' resource. For now, start small by introducing the interface and change our texture loading which used assets from the old resource manager, to an actual resource.
2025-11-23 11:04:24 -06:00
VideoBackendBase.h
VideoBackend: Rename GetName to GetConfigName
2025-10-13 17:38:20 -07:00
VideoCommon.h
Vulkan: Add support for unrestricted depth range.
2025-07-21 14:07:26 +09:00
VideoConfig.cpp
Core: Eliminate FreeLookConfig by putting the "active config" within FreeLookCamera.
2025-11-12 18:01:53 -06:00
VideoConfig.h
VideoCommon: Invert interaction between Arbitrary Mipmap Detection and GPU Texture Decoding (the former disables the latter)
2026-02-13 13:57:43 +01:00
VideoEvents.h
VideoCommon: Add "Smooth Early Presentation" setting to improve frame pacing with ImmediateXFB and/or RushFramePresentation.
2025-11-11 20:01:52 -06:00
VideoState.cpp
Remove unused imports
2026-01-25 16:12:15 +01:00
VideoState.h
treewide: convert GPLv2+ license info to SPDX tags
2021-07-05 04:35:56 +02:00
Widescreen.cpp
Common: Remove the string parameters from the HookableEvent interface.
2025-11-06 22:34:40 -06:00
Widescreen.h
Video: update widescreen heuristic code to never get stuck to specific old values when changing settings
2024-02-20 22:26:19 +02:00
XFMemory.cpp
treewide: convert GPLv2+ license info to SPDX tags
2021-07-05 04:35:56 +02:00
XFMemory.h
VideoCommon: drop unused XF enumerators
2025-07-30 19:56:30 +01:00
XFStateManager.cpp
VideoCommon: move xf state management to its own class, so changes can be detected in places other than VertexShaderManager
2023-11-26 16:27:26 -06:00
XFStateManager.h
VideoCommon: move xf state management to its own class, so changes can be detected in places other than VertexShaderManager
2023-11-26 16:27:26 -06:00
XFStructs.cpp
DolphinAnalytics: Use Pascal case for GameQuirk enum
2025-08-14 13:54:23 -07:00
XFStructs.h
Refactor OpcodeDecoding and FIFO analyzer to use callbacks
2021-12-18 15:21:36 -08:00