refactor: only use dasherized superBlock (#41067)

This commit is contained in:
Oliver Eyton-Williams
2021-02-13 06:06:04 +01:00
committed by GitHub
parent 73f8377d68
commit 97fcaa693f
22 changed files with 68 additions and 87 deletions

View File

@@ -8,7 +8,6 @@ import { withTranslation } from 'react-i18next';
import CertificationIcon from '../../../assets/icons/CertificationIcon';
import GreenPass from '../../../assets/icons/GreenPass';
import GreenNotCompleted from '../../../assets/icons/GreenNotCompleted';
import { dasherize } from '../../../../../utils/slugs';
import { userSelector } from '../../../redux';
import { User } from '../../../redux/propTypes';
@@ -48,23 +47,22 @@ export class CertChallenge extends Component {
} = this.props;
const userCertificates = {
'Responsive Web Design': isRespWebDesignCert,
'JavaScript Algorithms and Data Structures': isJsAlgoDataStructCert,
'Front End Libraries': isFrontEndLibsCert,
'Data Visualization': is2018DataVisCert,
'APIs and Microservices': isApisMicroservicesCert,
'Quality Assurance': isQaCertV7,
'Information Security': isInfosecCertV7,
'Scientific Computing with Python': isSciCompPyCertV7,
'Data Analysis with Python': isDataAnalysisPyCertV7,
'Machine Learning with Python': isMachineLearningPyCertV7
'responsive-web-design': isRespWebDesignCert,
'javascript-algorithms-and-data-structures': isJsAlgoDataStructCert,
'front-end-libraries': isFrontEndLibsCert,
'data-visualization': is2018DataVisCert,
'apis-and-microservices': isApisMicroservicesCert,
'quality-assurance': isQaCertV7,
'information-security': isInfosecCertV7,
'scientific-computing-with-python': isSciCompPyCertV7,
'data-analysis-with-python': isDataAnalysisPyCertV7,
'machine-learning-with-python': isMachineLearningPyCertV7
};
const isCertified = userCertificates[superBlock];
const superBlockDashedName = dasherize(superBlock);
const certLocation = `/certification/${username}/${superBlockDashedName}`;
const certLocation = `/certification/${username}/${superBlock}`;
const certCheckmarkStyle = { height: '40px', width: '40px' };
const i18nSuperBlock = t(`intro:${superBlockDashedName}.title`);
const i18nSuperBlock = t(`intro:${superBlock}.title`);
const i18nCertText = t(`intro:misc-text.certification`, {
cert: i18nSuperBlock
});

View File

@@ -2,7 +2,6 @@ import React from 'react';
import PropTypes from 'prop-types';
import { useTranslation } from 'react-i18next';
import { dasherize } from '../../../../../utils/slugs';
import { Spacer } from '../../../components/helpers';
import { generateIconComponent } from '../../../assets/icons';
@@ -13,9 +12,8 @@ const propTypes = {
function SuperBlockIntro(props) {
const { t } = useTranslation();
const { superBlock } = props;
const superBlockDashedName = dasherize(superBlock);
const superBlockIntroObj = t(`intro:${superBlockDashedName}`);
const superBlockIntroObj = t(`intro:${superBlock}`);
const {
title: i18nSuperBlock,
intro: superBlockIntroText