From 9e31e53ec72d09b417300fbc3795307df113a40d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lasse=20J=C3=B8rgensen?= <28780271+lasjorg@users.noreply.github.com> Date: Tue, 9 Jul 2024 08:05:29 +0200 Subject: [PATCH] fix(curriculum): use checkVisibility for visibility tests (#55407) Co-authored-by: Oliver Eyton-Williams --- .../657a19e477dc04e36a86dffc.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/review-algorithmic-thinking-by-building-a-dice-game/657a19e477dc04e36a86dffc.md b/curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/review-algorithmic-thinking-by-building-a-dice-game/657a19e477dc04e36a86dffc.md index 94baa269f7f..ff8f6c9b57f 100644 --- a/curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/review-algorithmic-thinking-by-building-a-dice-game/657a19e477dc04e36a86dffc.md +++ b/curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/review-algorithmic-thinking-by-building-a-dice-game/657a19e477dc04e36a86dffc.md @@ -16,7 +16,7 @@ Use an event listener to invert the value of the `isModalShowing` variable, togg Your `rulesContainer` should not be visible initially. ```js -assert.strictEqual(rulesContainer.style.display, ""); +assert.isFalse(rulesContainer.checkVisibility()); ``` When your `rulesBtn` is clicked, your `isModalShowing` should be `true`. @@ -29,7 +29,7 @@ assert.isTrue(isModalShowing); When your `rulesBtn` is clicked, your `rulesContainer` should be visible. ```js -assert.include(["block", "inline", "inherit", "initial"], rulesContainer.style.display); +assert.isTrue(rulesContainer.checkVisibility()); ``` When your `rulesBtn` is clicked, your `rulesBtn` should say `Hide Rules`. @@ -48,7 +48,7 @@ assert.isFalse(isModalShowing); When your `rulesBtn` is clicked again, your `rulesContainer` should not be visible. ```js -assert.include(["hidden", "none", ""], rulesContainer.style.display); +assert.isFalse(rulesContainer.checkVisibility()); ``` When your `rulesBtn` is clicked again, your `rulesBtn` should say `Show Rules`.