From bcc38caa465735ea6d97e33733f05ec6453bad24 Mon Sep 17 00:00:00 2001 From: Tom <20648924+moT01@users.noreply.github.com> Date: Tue, 19 Dec 2023 06:57:29 -0600 Subject: [PATCH] fix(curriculum): english 1.1 - add review suggestions (#52594) --- .../meta.json | 46 ++++--- .../651dd5296ffb500e3f2ce479.md | 2 +- .../651dd5386ffb500e3f2ce47a.md | 4 +- .../656a4f714165773059ce7ad4.md | 2 +- .../656a509eeac7e030e2a16bab.md | 2 +- .../656a575febfa2c333c495c2f.md | 2 +- .../656a584f57a1a9338e3cb347.md | 6 +- .../656a58b31bc9f233debc2bc9.md | 6 +- .../656ab4205a4054486ef3b691.md | 2 +- .../656ab50005c38348b94da7a3.md | 4 +- .../656caddea3aba304c6172571.md | 2 +- .../656cc6981cbf2711196a284f.md | 2 +- .../656ccfb763eddb149831854d.md | 2 +- .../656d1b4a3be31305a9c3ee35.md | 116 ------------------ .../656d1becadf67d05d5b27bab.md | 4 +- .../656d1c98a6bd5505fd346b50.md | 4 +- .../656d1d1f46bc820629aecc0d.md | 4 +- .../656d25e0c5d5aa11ade33754.md | 4 +- .../656d2600b0ffa811dac3853f.md | 4 +- .../656d266537ff53120d194ae8.md | 4 +- .../656d26bc907ce0123546288a.md | 4 +- .../656d27271410d4125ee2ad5a.md | 4 +- .../656d27a603926f1288bafcc0.md | 4 +- .../656d283b7ba56912bb2ceb06.md | 4 +- .../656d2914e7cfc312ea00c864.md | 4 +- .../656d299e9d0027131875568f.md | 4 +- .../656d2a2ed95bfa1345fd9fd1.md | 4 +- .../656d2aee945ce2137bd8b8b8.md | 4 +- .../656d2b6aaad95013a86cea6c.md | 4 +- .../656d2bc10f29b413d1a843d5.md | 4 +- .../656d2c2fedbd5f14055b7e7b.md | 4 +- .../656d2c94279eb6143485eac6.md | 4 +- .../656d2d19c570e2146b5e8835.md | 4 +- .../656d2d814b60b6149a03c699.md | 4 +- .../656d2f31f23860155477ca7b.md | 4 +- 35 files changed, 81 insertions(+), 201 deletions(-) delete mode 100644 curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656d1b4a3be31305a9c3ee35.md diff --git a/curriculum/challenges/_meta/learn-greetings-in-your-first-day-at-the-office/meta.json b/curriculum/challenges/_meta/learn-greetings-in-your-first-day-at-the-office/meta.json index 6df0e0bcd7e..cfd4bca2d71 100644 --- a/curriculum/challenges/_meta/learn-greetings-in-your-first-day-at-the-office/meta.json +++ b/curriculum/challenges/_meta/learn-greetings-in-your-first-day-at-the-office/meta.json @@ -606,20 +606,16 @@ "title": "Task 145" }, { - "id": "656d1b4a3be31305a9c3ee35", + "id": "656d1becadf67d05d5b27bab", "title": "Task 146" }, { - "id": "656d1becadf67d05d5b27bab", + "id": "656d1c98a6bd5505fd346b50", "title": "Task 147" }, - { - "id": "656d1c98a6bd5505fd346b50", - "title": "Task 148" - }, { "id": "656d1d1f46bc820629aecc0d", - "title": "Task 149" + "title": "Task 148" }, { "id": "656d23d22a488510bca0e418", @@ -627,75 +623,75 @@ }, { "id": "656d25e0c5d5aa11ade33754", - "title": "Task 150" + "title": "Task 149" }, { "id": "656d2600b0ffa811dac3853f", - "title": "Task 151" + "title": "Task 150" }, { "id": "656d266537ff53120d194ae8", - "title": "Task 152" + "title": "Task 151" }, { "id": "656d26bc907ce0123546288a", - "title": "Task 153" + "title": "Task 152" }, { "id": "656d27271410d4125ee2ad5a", - "title": "Task 154" + "title": "Task 153" }, { "id": "656d27a603926f1288bafcc0", - "title": "Task 155" + "title": "Task 154" }, { "id": "656d283b7ba56912bb2ceb06", - "title": "Task 156" + "title": "Task 155" }, { "id": "656d2914e7cfc312ea00c864", - "title": "Task 157" + "title": "Task 156" }, { "id": "656d299e9d0027131875568f", - "title": "Task 158" + "title": "Task 157" }, { "id": "656d2a2ed95bfa1345fd9fd1", - "title": "Task 159" + "title": "Task 158" }, { "id": "656d2aee945ce2137bd8b8b8", - "title": "Task 160" + "title": "Task 159" }, { "id": "656d2b6aaad95013a86cea6c", - "title": "Task 161" + "title": "Task 160" }, { "id": "656d2bc10f29b413d1a843d5", - "title": "Task 162" + "title": "Task 161" }, { "id": "656d2c2fedbd5f14055b7e7b", - "title": "Task 163" + "title": "Task 162" }, { "id": "656d2c94279eb6143485eac6", - "title": "Task 164" + "title": "Task 163" }, { "id": "656d2d19c570e2146b5e8835", - "title": "Task 165" + "title": "Task 164" }, { "id": "656d2d814b60b6149a03c699", - "title": "Task 166" + "title": "Task 165" }, { "id": "656d2f31f23860155477ca7b", - "title": "Task 167" + "title": "Task 166" } ], "helpCategory": "HTML-CSS" diff --git a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/651dd5296ffb500e3f2ce479.md b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/651dd5296ffb500e3f2ce479.md index 75e0ac42236..149d209bc6c 100644 --- a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/651dd5296ffb500e3f2ce479.md +++ b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/651dd5296ffb500e3f2ce479.md @@ -20,7 +20,7 @@ This contraction is a combination of the pronoun `you` and the verb `are`, which ## --sentence-- -`Hello, You_ the new graphic designer, right?` +`Hello. You_ the new graphic designer, right?` ## --blanks-- diff --git a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/651dd5386ffb500e3f2ce47a.md b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/651dd5386ffb500e3f2ce47a.md index 94fec07fd64..109894a1ad0 100644 --- a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/651dd5386ffb500e3f2ce47a.md +++ b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/651dd5386ffb500e3f2ce47a.md @@ -18,7 +18,7 @@ In English, to check or confirm something people sometimes use tag questions. Fo ## --sentence-- -`Hello, You're the new graphic designer, _?` +`Hello. You're the new graphic designer, _?` ## --blanks-- @@ -26,7 +26,7 @@ In English, to check or confirm something people sometimes use tag questions. Fo ### --feedback-- -Pay attention to the verb in the sentence. +Pay attention to the last word Maria says. # --scene-- diff --git a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656a4f714165773059ce7ad4.md b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656a4f714165773059ce7ad4.md index 8addbd43556..3ef0bd47cee 100644 --- a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656a4f714165773059ce7ad4.md +++ b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656a4f714165773059ce7ad4.md @@ -20,7 +20,7 @@ In the context of the dialogue, `here` refers to the location of the speaker, po ## --sentence-- -`I'm from _, California. Welcome aboard.` +`I'm from _ in California. Welcome aboard.` ## --blanks-- diff --git a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656a509eeac7e030e2a16bab.md b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656a509eeac7e030e2a16bab.md index 7470ac75a52..a573a77945f 100644 --- a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656a509eeac7e030e2a16bab.md +++ b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656a509eeac7e030e2a16bab.md @@ -18,7 +18,7 @@ Demonstrative pronouns like `this` and `those` help to point to specific items, ## --sentence-- -`Hey, is _ this one of _ standing desks?` +`Hey, is _ one of _ standing desks?` ## --blanks-- diff --git a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656a575febfa2c333c495c2f.md b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656a575febfa2c333c495c2f.md index a35fc189745..163122dc180 100644 --- a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656a575febfa2c333c495c2f.md +++ b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656a575febfa2c333c495c2f.md @@ -12,7 +12,7 @@ Sophie: This is a good alternative for me. # --description-- -When faced with a situation or habit that is not ideal, people often look for alternatives. In this context, Sophie is discussing a better option for her compared to her usual routine. +When faced with a situation or habit that is not ideal, people often look for an `alternative`. In this context, Sophie is discussing a better option for her compared to her usual routine. # --fillInTheBlank-- diff --git a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656a584f57a1a9338e3cb347.md b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656a584f57a1a9338e3cb347.md index 30e457f4b85..3052b61e024 100644 --- a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656a584f57a1a9338e3cb347.md +++ b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656a584f57a1a9338e3cb347.md @@ -7,17 +7,17 @@ dashedName: task-61 # --description-- -Words like `your` and `my` are used to show possession. `Your` refers to something belonging to the person you are speaking to, while `my` refers to something that belongs to the speaker. +Words like `your` and `my` are used to show possession. `Your` refers to something belonging to the person you are speaking to, while `my` refers to something that belongs to you. # --fillInTheBlank-- ## --sentence-- -`But hey, _ desk is just like _ desk.` +`But hey, now _ desk is just like _ desk.` ## --blanks-- -`Your` +`your` ### --feedback-- diff --git a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656a58b31bc9f233debc2bc9.md b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656a58b31bc9f233debc2bc9.md index 7497f01f5e7..4c6672d4b53 100644 --- a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656a58b31bc9f233debc2bc9.md +++ b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656a58b31bc9f233debc2bc9.md @@ -12,18 +12,18 @@ Sophie: But hey, your desk is just like my desk. You are in luck. # --description-- -Certain expressions in English convey meanings that are not immediately clear from the individual words. `You are in luck` is one such expression. +Certain expressions in English convey meanings that are not immediately clear from the individual words. `You're in luck` is one such expression. It expresses that someone is fortunate or has good luck in a situation. Sophie uses such a phrase when talking to Tom. # --fillInTheBlank-- ## --sentence-- -`You _ in _.` +`_ in _.` ## --blanks-- -`are` +`You're` ### --feedback-- diff --git a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656ab4205a4054486ef3b691.md b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656ab4205a4054486ef3b691.md index 43583d78985..8bde9e54678 100644 --- a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656ab4205a4054486ef3b691.md +++ b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656ab4205a4054486ef3b691.md @@ -18,7 +18,7 @@ Tom is saying that he likes his things. He uses words to show he's happy with th ## --sentence-- -`Oh, awesome. My computer and drawing tablet _ _, too.` +`Awesome. My computer and drawing tablet _ _, too.` ## --blanks-- diff --git a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656ab50005c38348b94da7a3.md b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656ab50005c38348b94da7a3.md index d6d014ed3ed..bcd35c55924 100644 --- a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656ab50005c38348b94da7a3.md +++ b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656ab50005c38348b94da7a3.md @@ -17,7 +17,7 @@ When referring to a group of people or things, we often use `they` as the subjec ## --blanks-- -`they` +`They` ### --feedback-- @@ -33,7 +33,7 @@ Consider which pronoun you'd use to represent a group or multiple items and matc --- -`they` +`They` ### --feedback-- diff --git a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656caddea3aba304c6172571.md b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656caddea3aba304c6172571.md index a6bc63c86a4..35ccbc1bef7 100644 --- a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656caddea3aba304c6172571.md +++ b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656caddea3aba304c6172571.md @@ -18,7 +18,7 @@ Tom: This is so cool. A standing Desk, an ergonomic chair and an ergonomic mouse ## --sentence-- -`A standing Desk, an _ chair and an _ mouse.` +`A standing desk, an _ chair and an _ mouse.` ## --blanks-- diff --git a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656cc6981cbf2711196a284f.md b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656cc6981cbf2711196a284f.md index 049eb6d6531..69320f1dd01 100644 --- a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656cc6981cbf2711196a284f.md +++ b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656cc6981cbf2711196a284f.md @@ -22,7 +22,7 @@ To ask about someone's actions or plans in the present with the verb `to be`, yo ## --blanks-- -`are` +`Are` ### --feedback-- diff --git a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656ccfb763eddb149831854d.md b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656ccfb763eddb149831854d.md index 762c9a6f38f..143cfed94f4 100644 --- a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656ccfb763eddb149831854d.md +++ b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656ccfb763eddb149831854d.md @@ -26,7 +26,7 @@ What does Tom say in the dialogue? ## --blanks-- -`sounds` +`Sounds` ### --feedback-- diff --git a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656d1b4a3be31305a9c3ee35.md b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656d1b4a3be31305a9c3ee35.md deleted file mode 100644 index 5f67a237778..00000000000 --- a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656d1b4a3be31305a9c3ee35.md +++ /dev/null @@ -1,116 +0,0 @@ ---- -id: 656d1b4a3be31305a9c3ee35 -title: Task 146 -challengeType: 19 -dashedName: task-146 ---- - -# --description-- - -In the dialogue, the phrase `it is true` is Brian's way of confirming or agreeing with what he said earlier. When someone says `it is true`, they are indicating that they believe what they said is correct or factual. Brian uses this phrase to show that he stands by his earlier statement about Sophie, even after she reacts with `Oh, come on`. - -# --question-- - -## --text-- - -In the dialogue, how does Brian respond when Sophie says, `Oh, come on, Brian!`? - -## --answers-- - -He confirms what he said. - -### --feedback-- - -Brian doesn't show any sign of disagreement. - ---- - -He disagrees. - ---- - -He says Sophie is wrong. - -### --feedback-- - -Brian doesn't say Sophie is incorrect. - ---- - -He changes the topic. - -### --feedback-- - -Brian continues discussing Sophie's qualities, staying on the same topic. - -## --video-solution-- - -1 - -# --scene-- - -```json -{ - "setup": { - "background": "cafe.png", - "characters": [ - { - "character": "Sophie", - "position": { "x": 25, "y": 0, "z": 1.3 }, - "opacity": 0 - }, - { - "character": "Brian", - "position": { "x": 75, "y": 15, "z": 1.2 }, - "opacity": 0 - } - ], - "audio": { - "filename": "1.1-4.mp3", - "startTime": 1, - "startTimestamp": 22.6, - "finishTimestamp": 28.16 - } - }, - "commands": [ - { - "character": "Sophie", - "opacity": 1, - "startTime": 0 - }, - { - "character": "Brian", - "opacity": 1, - "startTime": 0 - }, - { - "character": "Sophie", - "startTime": 1, - "finishTime": 2.4, - "dialogue": { - "text": "Oh, come on, Brian.", - "align": "left" - } - }, - { - "character": "Brian", - "startTime": 3.3, - "finishTime": 6.35, - "dialogue": { - "text": "But it's true. She's the person to go to if you need help.", - "align": "right" - } - }, - { - "character": "Sophie", - "opacity": 0, - "startTime": 6.85 - }, - { - "character": "Brian", - "opacity": 0, - "startTime": 6.85 - } - ] -} -``` diff --git a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656d1becadf67d05d5b27bab.md b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656d1becadf67d05d5b27bab.md index 689ca9b5e86..cc2e40b3912 100644 --- a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656d1becadf67d05d5b27bab.md +++ b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656d1becadf67d05d5b27bab.md @@ -1,8 +1,8 @@ --- id: 656d1becadf67d05d5b27bab -title: Task 147 +title: Task 146 challengeType: 19 -dashedName: task-147 +dashedName: task-146 --- # --description-- diff --git a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656d1c98a6bd5505fd346b50.md b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656d1c98a6bd5505fd346b50.md index 3afbf14c1e0..772007e28eb 100644 --- a/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656d1c98a6bd5505fd346b50.md +++ b/curriculum/challenges/english/21-a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/656d1c98a6bd5505fd346b50.md @@ -1,8 +1,8 @@ --- id: 656d1c98a6bd5505fd346b50 -title: Task 148 +title: Task 147 challengeType: 19 -dashedName: task-148 +dashedName: task-147 ---