feat: store sound settings in local storage (#51374)

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

api-server/src/common/models/user.json

@@ -343,10 +343,6 @@
       "type": "string",
       "default": "default"
     },
-    "sound": {
-      "type": "boolean",
-      "default": false
-    },
     "keyboardShortcuts": {
       "type": "boolean",
       "default": false

api-server/src/server/boot/settings.js

@@ -44,7 +44,6 @@ export default function settingsController(app) {
   api.put('/update-my-username', ifNoUser401, updateMyUsername);
   api.put('/update-user-flag', ifNoUser401, updateUserFlag);
   api.put('/update-my-socials', ifNoUser401, updateMySocials);
-  api.put('/update-my-sound', ifNoUser401, updateMySound);
   api.put(
     '/update-my-keyboard-shortcuts',
     ifNoUser401,
@@ -288,16 +287,6 @@ function updateMyTheme(...args) {
   )(...args);
 }
 
-function updateMySound(...args) {
-  const buildUpdate = body => _.pick(body, 'sound');
-  const validate = ({ sound }) => typeof sound === 'boolean';
-  createUpdateUserProperties(
-    buildUpdate,
-    validate,
-    'flash.updated-sound'
-  )(...args);
-}
-
 function updateMyKeyboardShortcuts(...args) {
   const buildUpdate = body => _.pick(body, 'keyboardShortcuts');
   const validate = ({ keyboardShortcuts }) =>

api-server/src/server/utils/publicUserProps.js

@@ -50,7 +50,6 @@ export const userPropsForSession = [
   'id',
   'sendQuincyEmail',
   'theme',
-  'sound',
   'keyboardShortcuts',
   'completedChallengeCount',
   'acceptedPrivacyTerms'