jprdonnelly/freeCodeCamp
1
0
Fork 0
mirror of https://github.com/freeCodeCamp/freeCodeCamp.git synced 2025-12-30 03:03:06 -05:00
Code Issues Projects Releases Wiki Activity

refactor(api): delete dead code (#58577)

Browse Source
This commit is contained in:
Oliver Eyton-Williams
2025-02-05 14:36:58 +01:00
committed by GitHub
parent 38d2e7d112
commit e048e903c3
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
api/src/routes/protected/challenge.ts
View File

@@ -698,19 +698,16 @@ export const challengeRoutes: FastifyPluginCallbackTypebox = (
] as CompletedChallenge;
const oldResults = oldChallenge?.examResults as ExamResults;
const newChallenge = oldChallenge;
newChallenge ? (newChallenge.examResults = examResults) : null;
// only update if it's a better result
if (percentCorrect > oldResults.percentCorrect) {
const updatedChallege = {
const updatedChallenge = {
id,
challengeType: oldChallenge.challengeType,
completedDate: oldChallenge.completedDate,
examResults
};
newCompletedChallenges[alreadyCompletedIndex] = updatedChallege;
newCompletedChallenges[alreadyCompletedIndex] = updatedChallenge;
// TODO(Post-MVP): Try to DRY the updates.
// updateUserChallengeData, for all its faults, handles the