Commit Graph

2039 Commits

Author SHA1 Message Date
Ahmad Abdolsaheb
72a9e76ce5 feat: remove the mention of recurring donations. (#46948)
feat: remove the mention of ongoing donations
2022-07-19 08:39:45 -05:00
Radi Totev
8f19b1926b chore(client): typescript migration - utils/build.js (#46761)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Luke Steinmann <92131626+lulululu12345@users.noreply.github.com>
Co-authored-by: Mrugesh Mohapatra <hi@mrugesh.dev>
2022-07-19 11:54:38 +05:30
Oliver Eyton-Williams
0e8113b4af fix: allow users to submit after editing (#46939)
If a user runs the tests and they pass, the multifile editor will show a
submit button.  If the user then edited the page, it would no longer be
possible to submit.

This ensures the redux store keeps the original, passing, tests and lets
the user submit
2022-07-18 14:57:53 +02:00
Oliver Eyton-Williams
9421aa6041 fix: expand projects on map (#46937) 2022-07-18 11:34:19 +02:00
Bruce Blaser
0345244c43 fix(a11y): change headings in footer to h2 (#46932)
fix: change headings in footer to h2
2022-07-17 09:59:15 -07:00
renovate[bot]
f6f252eba8 chore(deps): update dependency eslint-plugin-react to v7.30.1 (#46664)
* chore(deps): update dependency eslint-plugin-react to v7.30.1

* fix: prettier

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2022-07-14 21:07:56 +05:30
Ilenia
0a2d0733a2 feat: simplify client logic (#46870)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-07-14 14:11:20 +05:30
sidemt
eea6f5195c fix(i18n): configure search Japanese publication (#46888) 2022-07-14 14:02:01 +05:30
Oliver Eyton-Williams
2f6eef61d4 fix: save project to redux on submit (#46791) 2022-07-13 15:20:02 +05:30
Ilenia
1a8899bfb8 feat: remove random id from forum topic title (#46869)
feat/remove random id from forum topic title

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
2022-07-12 16:46:11 -07:00
Moshe
67cf5d63f2 fix(client): prevent navigating on failed submissions (#46734)
* fix(37615): avoid navigate to next challenge api fails

* fix: elsint errors

* fix: more elsint errors

* fix: make 'navigate' call conditional

* chore: removed async prefix from naigateTo method

* refactor: compare types with constants

* chore: remove unused closeChallengeModal

* fix: restore call to closeModal

* refactor: use setTimeout inside map block

* fix: requested changes according the comments

* fix:remove !request.ok block
2022-07-12 10:17:08 -05:00
Moshe
8d4d4d79e8 fix(ui): "sign in" button hidden at small devices (#46561)
* fix(UI): missing sign-in button at small devices

* feat: replace menu and sign-in buttons text with images

* refactor: svg icons replaced by fortawesome ones

* test: fix e2e test of navigation menu button

* feat: display sign in button and hide all

* feat: display sign in icon on nav for small screens

* feat: add accessibility span for menu icon

* fix: lint errors

Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com>
2022-07-12 08:15:52 -05:00
Ilenia
f61b227665 chore: rename project type from bonfire to jsProject (#46823)
* change bonfire in index.js

* change bonfire in build.js

* change bonfire in challenge-types.js

* change bonfire in test-challenges.js

* add jsProject to constants.js
2022-07-11 07:28:29 -05:00
alpox
e3fe5d0a9b feat: add title to "ask for help" forum requests (#46777)
* feat: add title to "ask for help" forum requests

* fix: remove need for translation

* fix: remove dangling comma

* fix: no email-fallback but remove user part if no username is available

* fix: fallback to username if no name is set

* Use nanoid instead of username

* Add block title to challenge description
2022-07-08 13:48:09 -07:00
Radi Totev
e17e57aba5 feat: update keyboard shortcuts client endpoint (#46378)
* feat: update keyboard shortcuts client endpoint

* Update client/src/redux/settings/settings-sagas.js

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update putUpdateMyKeyboardShortcuts return type

* Use new saga in shortcuts-modal

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-07-01 11:38:06 -07:00
Tom
a02db52800 fix: caching issues (#46716) 2022-07-01 15:24:29 +02:00
Ilenia
ac6f9fc95d fix: collapse rosetta (#46714) 2022-07-01 12:32:01 +02:00
Caden Parker
85f3ecbb0a Change Link Regex Tests to DOM queries (#45890)
* Change link regex tests to DOM queries

* Keep injection of style tag

Co-authored-by: Florencia <sicref001@gmail.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-06-27 10:37:23 +02:00
Oliver Eyton-Williams
8bc5b0a310 fix: show completion modal (#46589)
* fix: make ctrl/cmd + enter trigger modal

Multifile projects should be handled like legacy challenges in this
regard.

* test: check modal appears

* refactor: ignore additional solutions

* test: fix ctrl + enter tests

* fix: only run on electron

* fix: remove log

* fix: show completion modal if instructions focused

* fix: handle undefined challengeType
2022-06-26 12:23:46 -05:00
Naomi Carrigan
74a03ce0e5 feat: only 3 attempts before showing buttons (#46641)
* feat: only 3 attempts before showing buttons

* fix: linter
2022-06-24 08:27:18 +03:00
Oliver Eyton-Williams
44b1a3dab5 fix(client): inject user's script.js contents correctly (#46627)
With this change the preview should function as if the user had written
a script with script.js's contents.  <script src="script.js"> is
replaced, so the script element's position in the html matters.
2022-06-23 16:34:29 +01:00
Oliver Eyton-Williams
9046d70b67 fix: use certification hours consistently (#46442)
* fix: use certification hours consistently

Since the value appearing on the /learn map was hardcoded, it could have
gone out of sync with the certifications, which were relying on
certification-settings.

Also, for simplicity (and because it's hard to estimate accurately), all
the certifications are set to 300 hours.  Fullstack being the exception,
as it is a set of certifications.

* feat: remove the hours from the map
2022-06-23 14:24:33 +03:00
Shaun Hamilton
7a91407184 fix(client): handle verification of full-stack cert once (#46588) 2022-06-20 13:14:22 -07:00
Bruce Blaser
bcb048a93b fix(a11y): improve RWD challege grid accessibility (#45957)
* fix: improve RWD challege grid accessibility

* fix: change wording from challenge to step

* fix: improve keyboard focus indicator on step links

* fix: style jump link as button

* fix: accessible background color for completed steps

* refactor: make steps a nav region

* refactor: remove duplicate selector

* fix: enhance focus indicator on jump link

* fix: TS type

* refactor: remove unneeded CSS

* chore: resolve conflict

* chore: translate accessible name on nav

* fix: remove h4 from button

* fix: add course name to toggle button

* fix: improve accessibility of course stats on toggle button

* fix: prefix step links with sr-only "Step"

* fix: add start project button

* refactor: remove unnecessary spaces

* fix: clean up styles

* Update client/src/templates/Introduction/intro.css

Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com>
2022-06-17 15:45:40 +03:00
Radi Totev
9e51b59584 feat: show sign in button for unauthenticated users (#46401) 2022-06-16 13:47:30 +02:00
Bruce Blaser
46450b802c fix(a11y): improve challenge test suite results accessibility (#45802)
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2022-06-14 12:09:25 +05:30
Oliver Eyton-Williams
55e71cb599 fix: slightly improve logging from promises (#46422) 2022-06-10 22:28:38 +05:30
Radi Totev
c0e0dcfef9 chore: improve spelling (#46421) 2022-06-09 16:18:35 +02:00
Bruce Blaser
4f54125e76 fix:enable default mouse/touch events on monaco content widget (#46217)
* fix:enable default mouse events on monaco content widget

* add touch event handling

* initial test of scroll gutter

* disable scroll gutter

* re-enable gutter scroll as content widget

* move scroll gutter over line numbers

* fix: bug in moving scroll gutter over line numbers

* CSS adjustments to put scroll gutter over line numbers

* fix: scroll gutter height

* fix: make scroll gutter width responsive

* refactor: consolidate event handlers

* refactor: simplify args to createWidget
2022-06-09 12:07:40 +05:30
Prathamesh Gawas
f803d60be1 fix: multiple redirects after account deletion (#46350) 2022-06-08 07:48:17 -07:00
Oliver Eyton-Williams
f0f44ca315 feat(client): re-enable failed update re-submission (#46064)
* refactor: return response with data from ajax

Because we still need to manipulate the data coming back from the server
(files -> challengeFiles) and we want to keep ajax.ts as the interface
between client and server we need to return the manipulated data with
the response.

* feat: re-enable failed updates flushing

* test: failed updates get resubmitted and flushed

* fix: convert settings requests to use { data }

* refactor: use preserveSession
2022-06-07 17:52:23 +03:00
Jordan Moore
fcf2dd7254 fix(UI): Remove 'CTRL + Enter' on CTA for mobile (#46239)
Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com>
2022-06-07 18:20:16 +05:30
Muhammed Mustafa
e7d7702e25 fix(client-UI): view button takes full width (#45964)
* added class to td so it takes full width

* added width 100% to dropbox components

* removed excessive code

* limit the max space dropdown takes

* `view` takes the same size as `show-solution`

* undo previous change

* view takes the same size as show-solution

* fix: static width for buttons on small screen

* fix: remove max-width cause iocd

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2022-06-06 08:43:48 +02:00
Radi Totev
e581bd9081 feat(client): shortcuts legend modal available on pressing the ? key (#45530)
* Add modal texts in translations.json file

* Add shortcuts modal state in redux

* Create shortcuts modal

* Integrate shortcuts modal

* Resolve codefactor.io issues

* Extend list of shortcuts

Based on this comment:
https://github.com/freeCodeCamp/freeCodeCamp/issues/36841#issuecomment-933310078

* Remove temporary placeholder for modal title

* Open modal fom Hotkeys instead of learn.tsx

As suggested in this comment:
https://github.com/freeCodeCamp/freeCodeCamp/pull/45530#issuecomment-1101224993

* Complete list in transaltions

* Change shortcut presentation fo better a11y

Use table instead of list items as suggestedin this comment:
https://github.com/freeCodeCamp/freeCodeCamp/pull/45530#issuecomment-1101796368

* Add aria-labelledby

* Remove GAnalytics

* Remove leftover style

* Remove table caption

* autofocus on modal close button

* Improve modal a11y

- Add requested changes from https://github.com/freeCodeCamp/freeCodeCamp/pull/45530#issuecomment-1104764766
- Leave autofocus and parent div role=dialog changes for later. (https://github.com/freeCodeCamp/freeCodeCamp/pull/45530#issuecomment-1107754148)

* [WIP] Alllow users to turn off keyboard shortcuts

* Add keyboard shortcuts switch in settings

* Disable shortcuts

* Remove toggle switch description

* Refactor and cleanup

* Remove close button from modal header

Suggested by bbsmooth:
https://github.com/freeCodeCamp/freeCodeCamp/pull/45530#issuecomment-1107861091

* Fix lint issues

* Disable shortcuts

* Disable shortcuts by default

* Update challenge output test

* Update challenge-hot-keys test

* Disable shortcuts from inside handlers

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2022-06-03 09:57:52 -07:00
Sem Bauke
345268019c fix(client): reduce line number bar width (#46309) 2022-06-03 15:01:08 +02:00
SadmanSyfe
12d742a4f0 fix(client): prevent lower jaw breaking on code evaluation (#46154)
* Fix(issue:#46062)

* feat: render based on earliest available lower jaw conditions

* fix: persist challenge completion properly

Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com>
2022-06-03 12:10:49 +02:00
Oliver Eyton-Williams
f55a4c48db test: tighten up two more cypress tests (#46273)
* test: tighten up user-token

This should be faster and a little more reliable.  before should have
worked, but beforeEach seems more reliable, so I'm trying it.

* test: use a single test for intro-page

Should be more robust as well as a lot faster.
2022-06-03 11:44:20 +03:00
Ahmad Abdolsaheb
78090c76ca feat(client): contextually show reset step button (#46272)
* feat: show reset step button contexually

* feat: rename render function

* fix:clean up

* feat: open a reset step modal
2022-06-02 19:34:31 +02:00
Ahmad Abdolsaheb
aead146554 feat(client): center login button (#46287)
* feat(client): center login button

* feat: remove unused file
2022-06-02 17:34:29 +03:00
Shaun Hamilton
b2da57881c chore(client): remove console log (#46275) 2022-06-01 20:16:45 +02:00
Shaun Hamilton
33e0bb79d7 fix(client): add mathjax to intermediate-algorithm-scripting (#46270) 2022-06-01 20:01:22 +05:30
Bruce Blaser
d2332093f6 fix(a11y): main menu a11y updates (#45137)
* fix: main menu a11y updates

* update font menu

* fix: sign in button text alignment

* fix: disabled button font

* fix: language menu font

* remove sign-in from main menu

* fix: add section dividers to menu

* fix: height on language selector menu

* fix: alignment of Menu button text

* fix: language globe icon

* refactor: remove dup selector

* update language menu colors

* refactor: clearer name for language menu display state

* fix: don't close onBlur if Menu button is clicked

* refactor: move globe icon styling to CSS

* refactor: get rid of switch statements

* refactor: remove try catch block

* fix: translate Change language button

* fix: move search into nav menu for mobile layout

* fix: forgot a merge

* refactor: updates for changes in i18n/all-langs

* fix: prevent menu from collapsing when focus is on change language button and user clicks into search

* fix: translate cancel change option in language picker

* feat: add cypress tests

* feat: display the complete language list

* fix: fix TS typing

* fix: force scrollbar on lang menu

* fix: remove scroll bar from lang menu

* fix: close menu when user tabs away from last menu item

* add list role to navigation list to appease Safari

* chore: capitalize Change Language/remove CSS comment

* fix: right side search box alignment in narrow view

* remove extraneous list role

* fix: cypress

Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com>
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2022-06-01 10:39:26 +03:00
Lasse Jørgensen
6d89576b6c fix(curriculum): don't block fragment links (#46246) 2022-06-01 12:56:19 +05:30
Oliver Eyton-Williams
ed865269a6 test: fix donate page for existing donors (#46255) 2022-05-31 23:06:35 +01:00
Niraj Nandish
d67a617e47 fix(client): prevent code duplication when using help button (#46232)
* fix(client): prevent code duplication when using help button

* feat(client): comment file name when opening issue in forum

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2022-05-30 22:29:28 +05:30
Sem Bauke
2790362df8 feat: instruction hiding with button (#46086)
Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com>
2022-05-30 18:50:32 +05:30
renovate[bot]
4a1d223429 fix(deps): update dependency react-reflex to v4.0.9 (#46206)
* fix(deps): update dependency react-reflex to v4.0.9

* fix(deps): update dependency react-reflex to v4.0.9

* fix(client): chore to remove unneeded ts comment

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2022-05-30 18:50:01 +05:30
Jordan Moore
5f7d87daf0 feat: add project name on timeline for challenges completed RWD (#46181) 2022-05-28 10:45:03 +05:30
Bruce B
8d90c02747 fix(a11y):add main landmark to super block intro (#46168) 2022-05-27 10:52:49 +02:00
Tom
658b48ba62 fix: third-party cookie issues with CodeAlly login (#46090) 2022-05-26 21:44:10 +05:30