Commit Graph

96 Commits

Author SHA1 Message Date
Oliver Eyton-Williams
881dfd8f78 refactor: client jest -> vitest (#62177) 2025-09-16 08:30:06 +02:00
Josue Igiraneza
f648dac32f fix(client): Improve navigation search bar clarity (#59140)
Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>
2025-03-13 06:29:45 +01:00
Oliver Eyton-Williams
62cdd77e8a chore(client): migrate to React 17 (#58355)
Co-authored-by: Sem Bauke <semboot699@gmail.com>
2025-02-13 13:51:03 -08:00
Oliver Eyton-Williams
e621e5fcb2 fix(tools): enable type checking for the client (#58579) 2025-02-04 11:51:25 -08:00
Oliver Eyton-Williams
795838496b fix(client): make search bar only highlight footer when it is selectd. (#58506) 2025-01-31 11:25:19 +01:00
Anna
1e12fc4059 feat: add a css linter (#56823)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2025-01-13 15:50:17 +00:00
Anna
149b9e1754 chore: remove unused CSS rule (#57999) 2025-01-08 12:54:08 -08:00
Sem Bauke
03558f7814 fix: separate footer from hits (#57130) 2024-12-04 12:21:07 +01:00
Sem Bauke
228c2316ee chore: update react-instancesearch to v7 (#57020)
Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2024-11-08 14:20:13 +01:00
RGHANILOO
d981a2044e fix(learn): 404 re-rendering on-click (#56819) 2024-11-07 23:38:00 +05:30
Kristofer Koishigawa
a378208d4d feat: dynamically generate search placeholder (#56276)
Co-authored-by: Naomi Carrigan <commits@nhcarrigan.com>
2024-10-04 16:42:45 +00:00
Huyen Nguyen
2c308aed62 fix(a11y): remove textbox role from search bar wrapper (#55406) 2024-07-18 09:48:39 -05:00
Sem Bauke
eb84dce6ca chore: remove Cypress (#55056) 2024-06-14 10:09:40 -07:00
Huyen Nguyen
8f14c7e9f8 test(e2e): migrate search-bar.ts to Playwright (#55157) 2024-06-13 10:23:06 -07:00
Huyen Nguyen
68902644c0 chore(client): remove bootstrap.min.css (#55068) 2024-06-13 09:56:28 +02:00
Huyen Nguyen
3367454af5 fix(playwright): correct assertions of search input on mobile (#53261) 2024-02-17 10:31:15 +05:30
Asif khan
55dcecdb4e fix: Clear search input of home page on search (#52353) 2023-11-21 15:36:29 +03:00
Huyen Nguyen
e037c3cbe2 fix: failing Playwright tests (#52138) 2023-10-27 14:30:57 +00:00
Josh Alling
dd0274bad9 test(e2e,playwright): Search (#52034) 2023-10-27 10:23:57 +02:00
Gerard Hynes
417e5580de test(e2e,playwright): Header (#52005) 2023-10-26 16:28:10 +07:00
Manabu Matsumoto
53000a1420 fix(ui): change the button style in searchbar (#51328)
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
Co-authored-by: Muhammed Mustafa <MuhammedElruby@gmail.com>
2023-10-03 10:27:28 -07:00
Victor Duarte
869fb4fc9f fix: improve universal navbar UI (#51108) 2023-09-19 14:50:20 +03:00
Oliver Eyton-Williams
391fc2e34d refactor: create shared workspace (#51454) 2023-09-07 23:06:01 +05:30
Bruce Blaser
72fde26843 fix(a11y): search input (#51329) 2023-08-21 23:50:46 +05:30
Muhammed Mustafa
e9b86f9a22 feat(client): remove legacy search page logic (#50879) 2023-07-11 12:39:05 -05:00
Jacques Metevier
4a9c0a4886 chore: remove unused code (#50507) 2023-05-25 22:14:42 +03:00
Muhammed Mustafa
2123b447bc feat(client): hide the outline instead of removing it (#49716)
* feat(client): hide the outline instead of removing it

* remove the old :focus outline values

Co-authored-by: Bruce B <bbsmooth@gmail.com>

---------

Co-authored-by: Bruce B <bbsmooth@gmail.com>
2023-04-20 10:02:15 -05:00
Muhammed Mustafa
47944110b0 refactor(client): wrong TFunction type in searchBar (#49859)
refactor(client): mis aligned types in searchbar
2023-03-30 14:01:33 -05:00
Muhammed Mustafa
b67a82ff0a fix(client): import TFunction from i18next in profile componenets (#49814)
* fix(client): import TFunction from i18next

* Import Tfunction as type

* swap tFuntion with the hook when possilbe
2023-03-30 10:28:14 -05:00
Slieptsov Denys
e64bac9a3f fix(learn): progress bar label alignment (#49659)
Co-authored-by: Denys Slieptsov <denys.slieptsov@leaseplan.com>
2023-03-15 13:15:39 +00:00
Mrugesh Mohapatra
96a5699c39 chore: rename icons (#49319) 2023-02-10 13:11:16 +00:00
Manabu Matsumoto
4aa3b4d6ad fix(UI): refactor the searchbar from flex to grid (#48944)
* fix: refactor the searchbar from flex to grid

* fix: refactor the way of displaying searchbar input outline

* chore: remove unnecessary border settings

* fix: follow the RTL support best practice

* fix: follow the RTL support best practice

* fix: remove unnecessary grid gap and refactor for RTL

* fix: refactor the padding setting with padding block

Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>

* fix: refactor the padding setting with padding inline

Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>

* fix: refactor the positioning of reset button in searchbar

Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>
2023-01-10 16:19:55 +09:00
YMatsuda
2a473098b4 chore(i18n): small fixes in translations.json (#48894) 2023-01-02 22:32:52 +05:30
Manabu Matsumoto
95b724a3a2 feat(UI): visualize input clear button (#48702)
* feat: visualize search bar inputs clear button

* chore: remove redundant empty lines

* fix: make search bar input horizontally responsive

* fix: make search bar input width follow suggestion items

* fix: moving clear button to right of the searchbar

* feat: add search bar clear button in LP

* fix: add a bigger spacing between the icons and the text

* fix: make the clear button show visible focus indicator

* chore: refactor the css code to avoid redundancy

* fix: make the buttons in search bar accessible for screen reader

* fix: make the buttons and input in search bar more accessible
2022-12-23 17:00:38 -06:00
Muhammed Mustafa
8cc575c9b9 feat: swap to logical properties for spacing (#48769) 2022-12-22 10:51:19 +05:30
Muhammed Mustafa
b5371f56ce refactor(client): searchbar - remove float values (#48292)
* feat(client): refactor searchbar by removing float values

* polish the style by adding border radius and removing padding

* Polish the style and account for donation text

* WIP: remove float values

* Revert "WIP: remove float values"

This reverts commit c1c32aa9d1.

* adjust magic numbers

* Adjust spacing to account and add position absolute

* revert the deletion of ais hits values

* move the padding value to searchbar file

* Remove RTL Values

* feat: allow for hint expansions

* Remove the left value on submit icon

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

* add display none and remove their values

Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com>
2022-12-08 14:31:05 +01:00
Anubhav Jain
88c54192b9 fix(client): remove unused files (#47974)
* removed unused files

Removed unused files as per comments for issue #47971

* fix: removed duplicate exports from 4 files

* Build fix

* made changes for build fix

* made changes for build fix
2022-10-14 18:54:09 +05:30
Oliver Eyton-Williams
01b354f0d1 refactor: mollify TypeScript 2021-12-02 19:57:47 +05:30
Oliver Eyton-Williams
efba2e777d chore: simplify eslint configuration (#44347)
* chore: extend import/recommended

* chore: use recommended lint rules

* refactor: apply lint rules

* chore: drop used config
2021-12-02 00:01:12 +00:00
Nicolas Ramirez
c8ba3e9316 chore(client): rename test.tsx files to kebab-case (#44261) 2021-11-24 22:16:46 +00:00
Oliver Eyton-Williams
89c94e54e7 chore(client): add and apply naming convention (#44110)
* refactor: remove unused types

* chore: add naming-convention lint rule

* refactor: rename redux proptypes

* chore: remove Type suffix from prop-types

* chore: apply conventions to ajax

* chore: apply convention to create-types

* chore: apply convention to show-project-links

* chore: search-bar

* chore: Hotkeys

* chore: privacy

* chore: portfolio

* chore: search-page-hits

* chore: search-suggestion

* chore: search-hits

* chore: no-hits-suggestion

* chore: timeline-pagination

* chore: various profile files

* chore: heat-map

* chore: portfolio

* chore: certifications

* chore: landing-top

* chore: certifications

* chore: campers-image

* chore: big-call-to-action

* chore: paypal related files

* chore: show-user

* chore: show-settings

* chore: show-certification

* test: rename profile snap

* fix: ignore snake case for stripe card form

* refactor: remove duplicate type declarations

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: handle null solutions in Timeline

* test: add remaining Profile props

* refactor: revert accidental rename

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2021-11-11 10:09:50 -08:00
Noor Fakhry
8518079316 fix(client):make menu bar disappear after user chooses item from it on landing page (#43458)
* removed serachBarRef

* removed serachBarRef

* Revert "removed serachBarRef"

This reverts commit 6a5c2f4cb3.

* Revert "removed serachBarRef"

This reverts commit 67710b3d18.

* added innerRef as ref to SearchBarOptimized component

* Update client/src/components/Header/index.tsx

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update client/src/components/search/searchBar/search-bar-optimized.tsx

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update client/src/components/search/searchBar/search-bar-optimized.tsx

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-10-06 16:42:54 +02:00
awu43
4134404bfd feat(client): ts-migrate WithInstantSearch.js (#42923)
* rename to TS

* update import

* migrate with-instant-search

* change falsy values to empty string

* update import order

Finish resolving conflict from #41824

* update import order for search-bar

* update setTimeout() type
2021-08-05 21:00:30 +01:00
Oliver Eyton-Williams
e118dda13a fix: order imports and remove circular dependencies (#41824)
* fix: remove circular dependency

redux depended on templates/Challenges/redux and vice versa.  This
meant that import order mattered and confusing bugs could arise.

(cherry picked from commit 7d67a4e70922bbb3051f2f9982dcc69e240d43dc)

* feat: require imports to be in alphabetical order

Import order generally does not matter, but there are edge cases
(circular  imports and css imports, for example) where changing order
changes behaviour

(cherry picked from commit b8d1393a91ec6e068caf8e8498a5c95df68c2b2c)

* chore: order imports

* fix: lift up challenge description + title comps

This brings the classic Show closer to the others as they
now all create the description and title components

* fix: remove donation-saga/index circular import

(cherry picked from commit 51a44ca668a700786d2744feffeae4fdba5fd207)

* refactor: extract action-types from settings

(cherry picked from commit 25e26124d691c84a0d0827d41dafb761c686fadd)

* fix: lint errors

* feat: prevent useless renames
2021-08-02 08:39:40 -05:00
Anirudh Modi
ef3b7ec955 chore(eslint): enables recommended eslint rules for testing-library and jest-dom (#42817) 2021-07-20 21:21:16 +07:00
awu43
e1d8f4be3a feat(client): ts-migrate client/src/utils (#42666)
* rename js files to ts

* start migrating ajax

* finish migrating ajax

* migrate algolia-locale-setup

* migrate format

* migrate format.test

* migrate get-words

* install axios for types in handled-error

* migrate handled-error

* migrate handled-error.test

* migrate report-error

* migrate script-loaders

* migrate to-learn-path

* correct renamed imports

* remove unnecessary type assertions in searchBar

* remove unnecessary global comment

* remove unnecessary max-len enable/disable

* change axios imports to type imports

* revert to .then() from await

* use UserType from redux/prop-types

* replace assertion with generic type

* revert format to JS

* remove unused getArticleById()

* update putUpdateUserFlag() to use Record

* remove unnecessary envData cast

* update algolia-locale-setup types

* remove invalid key property
2021-07-12 11:17:58 +02:00
Moshe
63f26db336 refactor(client): Replace <Fragment> tags to <> (#42796)
* refactor(40115): Replace <Fragment> tags to <>
2021-07-09 09:50:11 +02:00
Nicholas Carrigan (he/him)
592a2846d3 chore: pass CI (#42635)
* chore: eslint on icons

* chore: eslint spacer element

* chore: remove more eslint

* fix: existing lint issues

* fix: misnamed import

* fix: client now builds!

* fix: tsc errors

* fix: more linting issues
2021-06-30 20:52:17 +05:30
krishna-saurav
5ad374cc1a feat(client): ts-migrate for files under client/src/component/search folder (#42327)
* typescript migration for files under search folder

* fixing few more eslint errors and warnings

* reverting changes for redux/index.js

* fixing merge conflicts with next

* deleting redux/index.ts
2021-06-30 20:52:17 +05:30
Ahmad Abdolsaheb
b3f2c64de8 fix(client): remove algolia and hot keys modules from landing pages (#42394)
* fix(client): remove algolia and hot keys from landing pages

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-06-24 12:50:36 +03:00