Commit Graph

2181 Commits

Author SHA1 Message Date
Ahmad Abdolsaheb
6c97591ca6 feat(client): turn default layout to a functional component (#49289) 2023-02-08 15:28:26 -06:00
Sem Bauke
928dcbe08c feat: transfer The Odin Project to its own superblock (#49202)
* feat: the odin-project superblock

* feat: break everything

* fix: correct meta names

* fix: meta again

* fix: tests

* fix: help category and external curriculum test

* fix: file names again

* fix: help category

* fix: remove console log

---------

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2023-02-08 15:21:03 +01:00
@DiegoCascavita
0e538a926d fix(curriculum): renaming tabs for uniformity in responsive design (#49286)
renaming tabs for uniformity in responsive design
2023-02-08 08:08:06 +01:00
abe
4494b0c05b fix(UI): keep portal preview open (#48451)
* moved portal states to redux

stored a global window

open window if does not exist clear htmlif already exists

moved close window to desktop-layout

close portal if user navigates to route outside of challenges

naming conventions, specify url

dispatch setIsAdvancing and use in portal preview

* fix: close portal if main window closes

* fix: refactor it

* Revert "fix: refactor it"

This reverts commit 197a40a3a6.

* feat: add isAdvancing to hotkeys

* fix: revert to pane on first step of block

* fix: safari issues

* fix: revert to pane when not advancing

---------

Co-authored-by: kravmaguy <flex4lease@gmail.com>
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2023-02-06 08:18:46 +01:00
Oliver Eyton-Williams
3116e17c78 fix(client): handle edits without editable region (#49242)
fix: keep editable region as empty array

There's no need to make it undefined, since editors without editable
regions are initiated with [] and the editor knows that an empty array
means the editable region doesn't exist.
2023-02-03 22:39:30 +05:30
Shaun Hamilton
9771e0ad70 fix(client): cert project help post sans editable region (#49157)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2023-02-02 11:46:13 -06:00
Muhammed Mustafa
a1380b2873 feat(client): make the console RTL (#49210)
feat(client): make the console.log RTL

Co-authored-by: hbar1st hanaab@gmail.com
2023-02-02 20:20:49 +05:30
Kristofer Koishigawa
b00defc9c4 fix(client): move console in multi-file editor (#49228)
* fix: move the console in the multifile editor to below the preview

* fix: go back to single displayConsole, move project based / multifile
logic into the jsx

* revert: previewPane flex value

* feat: refactor to allow console to open up the preview panel and take up all the vertical space

* fix: simplify editor layout logic
2023-02-02 20:03:54 +05:30
Oliver Eyton-Williams
b16c62f631 feat: split odin project block in two (#49140)
* feat: split odin project block into two blocks

* refactor: remove redundant isOdinProject checks

* fix: revert checkbox outline changes

Keyboard users need a way to see what's currently in focus, so we can't
hide the outline

* fix: add help category

* fix: use HTML-CSS help category

---------

Co-authored-by: sembauke <semboot699@gmail.com>
2023-01-30 18:03:58 +09:00
Muhammed Mustafa
f62f04989b feat(client): change the delete email to support email (#49159)
Co-authored-by: Quincy Larson <QuincyLarson@users.noreply.github.com>
2023-01-27 13:16:29 +03:00
YMatsuda
ca91d93d7e fix(client): use translated cert name for Legacy Full Stack Certification (#49145)
fix(client): use translated cert name
2023-01-26 11:04:52 -08:00
Bruce Blaser
849e2c041d fix(a11y): Save buttons on Settings page (#49142)
* fix: make save buttons more accessible for screen reader users

* fix: associate username input with label
2023-01-26 19:28:01 +02:00
Muhammed Mustafa
57317a4a32 feat(client): full width component to carry key prop (#49082)
* feat(client): allow full width to carry key props

* fix: setting can't render the element error

* Remove the key prop from FullWidthRow

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* remove key form fullwidth

* Remove undefined type from children

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* add key to renderProfile

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2023-01-26 08:20:28 +01:00
Muhammed Mustafa
af5c610511 fix(client) broken donate button text alignment in RTL layout (#49123)
fix(client) broken donate button text alignment
2023-01-25 19:05:28 +05:30
Atir Nayab
0bcc611b91 feat(client): add jest snapshot for settings button and certification… (#48751)
* feat(client): add jest snapshot for settings button and certification page consistency

* feat(client): setting buttons consistency snapshot done

* feat(client): jest snapshot check consistency of ceritification page

* fix: snapshot test updated and mocking date fn

* fix(client): settings button snapshot updated

* fix(client): settings button snapshot updated

* fix(client): settings button snapshot updated

* fix(client): settings button snapshot updated

* fix(client): certification and timeline test updated as per feedback

* fix(Client): changed mock file name to kebab case

* fix(client): changed timeline and settings button tests directory

* fix(client): completedChallenge.js file removed

* fix(client): settings-button and timeline-buttons test dir updated

* fix(client): removed autogenerated lines from tsconfig.json

* fix: reverted settings-button and timeline-button test to js

* fix: settings-button and timeline-buttons test cleanup

* fix: settings-button test updated

Co-authored-by: Atir <atir@codebuddy.co>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2023-01-25 19:02:54 +05:30
Muhammed Mustafa
95c24d901f feat(client): remove bloating CSS from RTL file (#49122) 2023-01-25 19:01:41 +05:30
Sem Bauke
901ca9d9a2 fix(client): multiple issues the odin project (#49075)
* fix: multiple issues

* fix: show expand collaps button

* fix: make variable instead

* fix: console log
2023-01-25 18:59:26 +05:30
Muhammed Mustafa
f95a6261ba refactor(client): move margin and padding to inline values (#49100) 2023-01-23 21:17:12 +00:00
Bruce Blaser
412df3570a fix(a11y): add tabstop on info panel (#49096) 2023-01-23 23:19:17 +05:30
Muhammed Mustafa
0bfa2902dc refactor(client): cleanup right section of breadcrumbs (#49102)
* refactor(client): remove extra code with right section of breadcrumbs

* refactor: the breadcrumbs selectors for readiablity

* clear more extra css code

* clean change log

* Clean change log
2023-01-23 11:34:13 -06:00
Muhammed Mustafa
c0c0ed71da refactor(client): clear extra div around the delete and reset panel (#49083)
refactor(client): clear extra div
2023-01-23 20:41:57 +05:30
Muhammed Mustafa
4e093f2c28 feat(client): fix the position of flash message (#48911)
* feat(client): fix the position of flash message

* WIP: move the alert message to header

* fix: cypress

* remove the spacing effect

* Revert "WIP: move the alert message to header"

This reverts commit f5242d261a.

* feat: new feature!

* Revert "feat: new feature!"

This reverts commit f6c403cc80.

* Revert "fix: cypress"

This reverts commit c24c1d8440.

* feat: add reverted cypress test

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>

* center the close alert button

Co-authored-by: Sanjeev <sanjeevranjan.singh08@gmail.com>

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
Co-authored-by: Sanjeev <sanjeevranjan.singh08@gmail.com>
2023-01-23 15:36:22 +01:00
Bruce Blaser
03cedceb46 fix(a11y): remove tab stop on code panel (#49068)
fix: remove tabstop on code panel
2023-01-20 09:53:11 +01:00
Bruce Blaser
9a0d26fd64 fix: add personal information heading (#49060) 2023-01-19 14:28:17 +01:00
Sem Bauke
df53c7778c feat: integrate The Odin Project (#48617)
* feat: integrate the odin project

* feat: add assignment to markdown parser

* feat: add assignment logic

* fix: doe not always show assignment block

* fix: some other stuff

* fix: introdiction to html and css questions

* fix: remove assignments after first question

* fix: update snapshots and tests

* feat: create rest of HTML foundation course structure

* feat: meta file

* feat: add descriptions to 'html boiler plate' questions

* feat: add description for 'working with text and list items'

* fix: multiple logic issues

* fix: make linter happy

* feat: add description for 'links and images' questions

* fix: add assignments to Joi schema

* fix: tests

* fix: schema

* fix: add help category

* fix: change to possessive wording

* fix: set upcoming change to true in meta file

* fix: spell unordered and ordered correctly

* fix: switch order in meta

* fix: spell boilerplate correctly

* feat: add final project

* chore: add more tests to the final project

* fix: question spelling

* Apply suggestions from code review

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>

* Apply suggestions from code review

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>

* Apply suggestions from code review

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>

* Apply suggestions from code review

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>

* Apply suggestions from code review

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>

* Apply suggestions from code review

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>

* fix: translation

* Update client/i18n/locales/english/translations.json

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: create new challenge type

* fix: get the new challenge type working and remove ol css

* fix: translation location

* fix: add challenge type to epic

* fix: set correct video

* fix: max challengeType number

* fix: spelling/grammar errors in project

* fix: check if anchor tags is empty

* Apply suggestions from code review

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update tools/challenge-parser/parser/plugins/add-video-question.js

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* chore: multiple suggestions

* chore: separate assignments into different plugin

* Apply suggestions from code review

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

* fix: dubble answer header after review

* fix: issue with Gatsby hopefully

* fix: add assignments to Gatsby's Challenge schema

* Update curriculum/schema/challengeSchema.js

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>
2023-01-19 14:55:26 +02:00
Ahmad Abdolsaheb
5bc8c5d2d0 feat(client): add ES GTM id (#49057)
* feat(client): add ES GTM id

* Update client/src/analytics/index.ts

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2023-01-19 13:17:49 +02:00
Rahul Siloniya
099dee75bf fix(client): changed the reset button in JS course (#49034)
* Re-worded reset code button in js lessons

* Made suggested changes in translation.json and lower-jaw.tsx

* Updated 'reset-step' translation
2023-01-17 08:47:28 +00:00
Muhammed Mustafa
46d4591803 fix(client): wrong position of search bar components in RTL (#48905)
* fix(client/RTL) searchbar result and reset icon positions

* fix: menu alignment and icons rotation

* Align search hits to the right

* account for scroll bar

* Clear float property position searchbar to the right

* Make the media condition similar

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>
2023-01-11 18:57:22 +02:00
Muhammed Mustafa
1d1ab78957 feat(client): increase the line height in RTL (#48960)
feat(client): increate the line height in RTL

Co-authored-by: hbar1st <hanaab@gmail.com>

Co-authored-by: hbar1st <hanaab@gmail.com>
2023-01-10 15:49:24 +01:00
Manabu Matsumoto
4aa3b4d6ad fix(UI): refactor the searchbar from flex to grid (#48944)
* fix: refactor the searchbar from flex to grid

* fix: refactor the way of displaying searchbar input outline

* chore: remove unnecessary border settings

* fix: follow the RTL support best practice

* fix: follow the RTL support best practice

* fix: remove unnecessary grid gap and refactor for RTL

* fix: refactor the padding setting with padding block

Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>

* fix: refactor the padding setting with padding inline

Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>

* fix: refactor the positioning of reset button in searchbar

Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>
2023-01-10 16:19:55 +09:00
Muhammed Mustafa
d349e5345b feat(client): respect user color scheme in editor (#48974)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: auchynnikau <viachaslau_auchynnikau@epam.com>
2023-01-09 14:06:22 -08:00
Mrugesh Mohapatra
c087ad3dca fix: update formating per prettier 2023-01-08 21:24:01 +05:30
Ahmad Abdolsaheb
8b5838ef23 fix(client): GA to GTM Migration (#48811) 2023-01-07 11:36:45 +05:30
Oliver Eyton-Williams
0a20f8fd73 refactor: remove a lot of unused code (#48935)
Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
2023-01-07 10:33:35 +05:30
Bruce Blaser
2b2360d77f fix(a11y): accessible names for cert buttons/links in Settings (#48890) 2023-01-07 06:39:45 +02:00
YMatsuda
95aba7810b fix(i18n,client): translate view certificate button (#48949)
fix(i18n): translate view certificate button
2023-01-06 20:33:45 -08:00
Mrugesh Mohapatra
f2fcfe593d fix(client): add message to loader (#48934)
Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2023-01-06 19:03:52 -08:00
Bruce Blaser
f995809dd4 fix(a11y): donation faq (#48941)
* fix: headings for faq titles

* fix: add aria-expanded

* fix: header font
2023-01-06 08:25:18 +02:00
Atir Nayab
9ad2fedf39 fix(client): set fcc-sound value in local storage (#48762) 2023-01-05 12:40:09 +05:30
Mrugesh Mohapatra
3cc8e0485c revert(client): improve alert component (#48921)
Revert "fix(client): Improve alert component (#48861)"

This reverts commit 17b880020d.
2023-01-04 17:32:03 +05:30
Ahmad Abdolsaheb
a73996c174 Revert "fix(client): expose donate button on navigation bar" (#48902)
Revert "fix(client): expose donate button on navigation bar (#48820)"

This reverts commit 959d667aeb.
2023-01-03 18:26:15 +05:30
Ahmad Abdolsaheb
959d667aeb fix(client): expose donate button on navigation bar (#48820)
* feat: expose donate nav button

* feat: add the ignores

* fix: adjust tests

* feat: adjust nav button styles
2023-01-03 10:40:47 +01:00
Muhammed Mustafa
1d3786f653 fix: spacing issue in RTL layout (#48824) 2023-01-02 23:08:28 +05:30
Oliver Ullman
17b880020d fix(client): Improve alert component (#48861) 2023-01-02 23:07:50 +05:30
YMatsuda
2a473098b4 chore(i18n): small fixes in translations.json (#48894) 2023-01-02 22:32:52 +05:30
Manabu Matsumoto
95b724a3a2 feat(UI): visualize input clear button (#48702)
* feat: visualize search bar inputs clear button

* chore: remove redundant empty lines

* fix: make search bar input horizontally responsive

* fix: make search bar input width follow suggestion items

* fix: moving clear button to right of the searchbar

* feat: add search bar clear button in LP

* fix: add a bigger spacing between the icons and the text

* fix: make the clear button show visible focus indicator

* chore: refactor the css code to avoid redundancy

* fix: make the buttons in search bar accessible for screen reader

* fix: make the buttons and input in search bar more accessible
2022-12-23 17:00:38 -06:00
Mrugesh Mohapatra
25f0fc5d93 fix(client): add loader to default layouts (#48830) 2022-12-23 13:38:50 -06:00
abe
f3446daaae feat: mark user editable regions in help post (#48512)
Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: kravmaguy <flex4lease@gmail.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>

Closes https://github.com/freeCodeCamp/freeCodeCamp/issues/46411
2022-12-22 07:50:25 -08:00
Niraj Nandish
acd74472f8 fix(client): i18n project and certification titles in settings, profile and certification page (#48785)
Closes https://github.com/freeCodeCamp/freeCodeCamp/issues/40998
2022-12-22 10:54:46 +05:30
Muhammed Mustafa
8cc575c9b9 feat: swap to logical properties for spacing (#48769) 2022-12-22 10:51:19 +05:30