Commit Graph

578 Commits

Author SHA1 Message Date
tanmay thakral
35b607d2d8 fix(curriculum): falsy bouncer - do not mutate the original array (#47718)
Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
2022-10-02 01:57:53 +05:30
Maciej Bąba
533c0345e4 fix(learn): lack of block code declaration (#47506)
Fix lack of block code declaration
2022-09-12 15:46:20 -07:00
Tuukka Hastrup
14076cbde0 fix(curriculum): Clarify understand-string-immutability (#47448)
* Clarify understand-string-immutability

Remove some misleading explanation (immutability is orthogonal to literals).

* Remove extraneous whitespace

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>

* Improve explanation per review suggestion

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>
2022-09-07 19:35:41 +02:00
Santiago Miranda
a9d2198aba Better wording of exercise description (#47431)
Update mutate-an-array-declared-with-const.md

Fixed unclear part of the exercise description. As cited by user [in the forum](https://forum.freecodecamp.org/t/cannot-understand-the-following-line-in-question/549786/3)
2022-09-02 17:01:08 +00:00
Leah Thompson
c759d83cd3 fix: add comma to fix typo (#47378)
added a comma to fix typo
2022-08-25 11:36:35 +00:00
mjh
ab82857ab2 fix(curriculum): Made output for sample code in snippet clearer - Multidimensional Array Access (#47222)
* Made output for sample code in snippet clearer

* Made formatting more consistent

* Fixed names for formatting fix
2022-08-09 20:39:56 +00:00
hanswang123456
87f0f75d9e fix(curriculum): update test regex to allow whitespaces (#47150)
* Added spacing fix to catch end of line spaces

* allow for spaces before "("
2022-08-08 12:37:49 +01:00
Abhishek Sharma
9a9cef38bd fix(curriculum): updated JS debugging challenge run-test (#47139) 2022-08-03 18:29:04 +02:00
Sameer Supe
3cc300127e fix(curriculum): test case for arguments optional (#47059)
* added test case for curriculum

* Revert "added test case for curriculum"

This reverts commit a23ee9d3cd.

* added test case for curriculum
2022-07-28 15:11:06 +02:00
Jeremy L Thompson
d0e42982f0 fix(curriculum) - simplify example of property access (#46967)
minor - simplify challenge examples
2022-07-21 09:05:26 -07:00
Randell Dawson
2de9458c5b fix: added extra test to prevent incorrect solution from passing for the Wherefore art thou challenge (#46959)
fix: added extra test to stop incorrect solution
2022-07-20 08:58:42 -05:00
Jeremy L Thompson
de7dce41e6 fix(curriculum) Convert C to F function - more ideomatic name (#46875)
minor - more ideomatic name

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
2022-07-13 15:22:21 +05:30
Ilenia
237f11be8b chore: change type of challenges to type 1 js (#46826) 2022-07-11 11:06:08 +02:00
Randell Dawson
55b3fcef3b fix(curriculum): Add new tests to check for space between result strings for two JavaScript challenges involving string concatenation (#46833) 2022-07-10 19:39:52 +07:00
Dhruv Gajjar
a18639dc07 fix(curriculum): Dead code example in (#46825)
fix(curriculum): Dead code example in #46813
2022-07-10 09:06:12 +02:00
packagespace
eac6a1b9af Removed missing data from challenge text (#46832)
Removed false information from challenge text
2022-07-09 11:42:04 -07:00
Randell Dawson
c7c9a5492d fix: remove duplicate test and make small change to recently added test for Counting Cards challenge (#46790)
fix: remove duplicate test
2022-07-07 08:50:29 -07:00
Randell Dawson
eca650dc69 fix: add test to validate result format has space between count value and text - Counting Cards challenge (#46782)
fix: add test to validate result format
2022-07-06 21:57:18 -07:00
DanielRosa74
08114a2aba fix: misspelling of 'between' on line 11 (#46687)
This fixes a misspelling on line 11.
2022-06-27 21:35:58 +02:00
Muhammed Mustafa
3e3da4ec0f fix(curriculum): standardize links in curriculum (#46564)
* fix(curriculum): standradize links in curriculum

* Data analiysis links

* CIP links

* fixed links in s-expressions

* Update curriculum/challenges/english/01-responsive-web-design/basic-css/use-hex-code-for-specific-colors.md

Co-authored-by: Ilenia <nethleen@gmail.com>

* added space before target attribute

* standarize external and .rock example links

* wrap "check out the projects" around the links

Co-authored-by: Ilenia <nethleen@gmail.com>
2022-06-26 11:13:38 -05:00
Dario-DC
1bba1b15e7 fix(curriculum): inaccuracy in dna pairing challenge (#46647)
fix inaccuracy in dna pairing challenge
2022-06-24 17:20:58 +02:00
Ilenia
59abda3ff2 fix(curriculum, i18n): solve issues in crowdin comments (#46597) 2022-06-21 19:53:13 +05:30
Ivan Pavičić
258e9d0130 fix(curriculum): var keyword to global-scope-and-functions (#46553)
fix(curriculum): var to global-scope-and-functions

Added the `var` keyword in global-scope-and-functions challenge instructions to avoid confusion
2022-06-18 16:34:51 -07:00
Muhammed Mustafa
e474d4cd17 chore(curriculum): Front End catagories links standardized (#46418) 2022-06-13 20:18:23 -05:00
sidemt
6d7b49ffe0 fix(curriculum): remove reference to Mad Libs (#46490) 2022-06-13 20:56:38 +02:00
Muhammed Mustafa
5282994ad8 Chore(curriculum): removing copywriten wiki content (#46436)
* remove mad-labs link

* changed similar to wiki text in legacy JS

* let's go Sam got my back here as well

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>
2022-06-10 08:54:51 -05:00
Bill Cheng
8397129aaa fix(curriculum): Add test output to not change strings assigned to variables (#46353) 2022-06-05 10:51:36 -05:00
Titi
14bf77d3b8 chore: removed unneeded check for semicolon 2022-06-04 11:09:55 -05:00
L4rryFisherman
0562a41781 fix(curriculum): increase readability of the introduction (#46300)
* fix(curriculum): increase readability of the introduction

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/generate-an-array-of-all-object-keys-with-object.keys.md

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>
2022-06-03 16:15:25 -05:00
L4rryFisherman
3d143b6aaa fix(curriculum): clarify that 'g flag' signifies 'global flag' (#46277)
* Update find-more-than-the-first-match.md

* fix(curriculum): clarify that 'g flag' signifies 'global search flag'
2022-06-02 20:05:04 +02:00
Muhammed Mustafa
e15889a53e fix(curriculum): external orbital link in legacy JSA (#46266)
* fix(curriculum): external orbital link in legacy JSA

* Shaun for the rescue

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2022-06-01 07:53:44 -07:00
DanielRosa74
49d963b28b fix(curriculum): Typo on line 24 (#46175)
Changed 0 for 9
2022-05-27 18:22:53 +05:30
Muhammed Mustafa
d38a6d3e2e fix(curriculum): external roman numeral links in JS projects (#46171)
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2022-05-27 16:31:28 +05:30
Muhammed Mustafa
bfae58d2c0 fix(curriculum): external ROT13 link in JS projects (#46169) 2022-05-27 10:54:07 +02:00
Muhammed Mustafa
924fd04760 fix(curriculum): external golf wiki link in JS (#46170) 2022-05-27 10:51:40 +02:00
Muhammed Mustafa
864f4a199a fix(curriculum): removed link in JS basic-JavaScript (#46143)
* fix(curriculum): removed link in JS basic-javascript

* removed JSON and its example
2022-05-26 16:36:21 +02:00
Muhammed Mustafa
5b4dc4ab6d fix(curriculum): external Mad Libs link in JS steps (#46157) 2022-05-26 12:43:20 +05:30
Muhammed Mustafa
93f32b45e2 fix(curriculum): external card counting link in JS (#46158) 2022-05-26 12:42:39 +05:30
Muhammed Mustafa
f2592999f3 fix(curriculum): external floating link in JS (#46159)
Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>
2022-05-26 12:41:58 +05:30
Muhammed Mustafa
9f73059c03 fix(curriculum): external wiki link in JS A&DS (#46144)
* fix(curriculum): external wiki link in JS A&DS

* reorder the phrases
2022-05-25 10:50:19 -07:00
Muhammed Mustafa
ddc55af8de fix(curriculum): external link in words blank JS (#46145) 2022-05-26 00:14:37 +07:00
Benjamin Lu
2da688fbfe fix(curriculum): add switch statement spaces for consistency (#46141)
Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>
2022-05-25 22:37:00 +05:30
Naomi Carrigan
fe71a9cf25 feat: new js cert (#45873)
* chore: move files

* wip: i have no idea what i am doing

* feat: finish up the logic

* chore: use order from randy sheet

* chore: standardise titles

* feat: fix layout for new js projects

* fix: utils test

* fix: challenge tests

* fix: ignore show new curriculum on non-english tests

* chore: help category????

* fix: if these tests would fail locally that'd be great

* chore: duplicate ids
2022-05-16 11:53:45 +02:00
Luke Harrison
e4c6883a20 fix(curriculum): updated wording on understanding uninitialized variables (#45860)
* updated wording on understanding uninitialized variables

* updated wording for case b to match case a

* updated case c to match the wording of both case a and b
2022-05-05 19:05:30 +02:00
Karen Lowe
ccce74ed6a fix(curriculum): typo lets -> let's (#45867)
Co-authored-by: Karen Lowe <klowe@ancestry.com>
2022-05-05 11:42:28 +02:00
apvarghese19
84b4b2e7c2 fix(curriculum): allow spaces before opening parenthesis in .log call (#45748)
Co-authored-by: Andrew Varghese <andvarg@umich.edu>
2022-04-25 14:47:46 +01:00
Naomi Archibong
4ff9c2a6fc feat: update wording for string length (#45602) 2022-04-15 08:13:42 -07:00
Oliver Eyton-Williams
4cc20172c5 fix: fallback to english challenges (#45635)
* fix: fallback to english challenges

All challenges will use the english version if a translated file is not
available.  SHOW_NEW_CURRICULUM still gates what's shown in the client.

* refactor: use closures to simplify createChallenge

* refactor: remove messy destructure

* refactor: add meta via helper

* fix: fallback to [] for meta.required

* fix: repair challenge.block

* refactor: use CONST_CASE for meta + challenge dirs

* fix: catch empty superblocks immediately

* fix: clean up path.resolves

* fix: invalid syntax in JS project steps

* fix: default to english comments and relax tests

Instead of always throwing errors when a comment is not translated, the
tests now warn while SHOW_UPCOMING_CHANGES is true, so that tests will
pass while we're developing and allow translators time to work.

They still throw when SHOW_UPCOMING_CHANGES is false to catch issues
in production

* test: update createCommentMap test

* refactor: delete stale comment

* refactor: clarify validate with explanatory consts

* feat: throw if audited cert falls back to english

* fix: stop testing upcoming localized curriculum
2022-04-15 09:17:49 -05:00
JuumanBeing
c92a71e11e fix(curriculum): include note about counting spaces by .length property (#45641)
Added a sentence to bring attention to the fact that the JS string .length property counts space characters.
2022-04-09 12:27:50 +02:00
Lenin Kennedy
a6d2660c7c fix(curriculum): remove style note (#45625) 2022-04-05 13:49:27 -06:00