* feat(client): stop margin from pushing outline out of the container
* remove the parent because it was breaking the layout on mobile devices
* sort the mobile and laptop layout
* remove extra property
* Update client/src/components/Header/components/universal-nav.css
* center the logo and fix the extra pixel issue
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
* increase padding top
---------
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
* fix: description if characters is over 288 characters on portfolio
* feat: add tests
* Update client/src/components/helpers/form/block-save-button.tsx
* feat: npm -> pnpm
This resolves the issues with the gatsby client (gatsby-plugin-pnpm
deals with the fact that gatsby is relying on its own dependencies
being de-duped)
and challenge-editor (which doesn't seem to want to automatically install
codemirror and needed its own eslint config)
* fix: correct mocha path for curriculum tests
* fix: use select workspace with -F not -w
* fix: reorganise packages and restrict hoisting
pnpm works best if the workspaces keep their own dependencies, since
dependencies are not flattened and then what node resolves from a
require is predictable.
@types seem to be a special case and more care is required to prevent
them getting smushed together in the root (hence the .npmrc)
* fix: add types for tools + root
* fix: decouple challenge-auditor from client
* fix: add ui-components types
* fix(client): use the latest types for react 16
* fix: prettify
* fix: prettierignore pnpm-lock
* fix: relax hoisting
Turns out pnpm works just fine with types. I don't know what was going
wrong before, but there are no-longer any type conflicts.
* fix: add @redux-saga/core to fix eslint issue
It seems to only be redux-saga that import/named can't cope with, so it
is probably okay to work around this one.
* chore: add chai to tools/scripts/build
* fix: add store to root for cypress
* fix: allow cypress to download binaries
If we want to keep preventing cypress from downloading binaries, we can
figure out a workaround, but I'm allowing it to ease the transition to
pnpm.
My guess about why this is happening is that npm triggers Cypress's
postinstall script, but pnpm does not (because pnpm install only
installs if necessary, perferring to link)
* chore: re-enable pre/post scripts
* fix: update build scripts for client
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
* chore: update engines to use pnpm
* fix: enable choice of (super)block for tests
Only 'nix machines for now.
* chore: pin pnpm to version 7
* chore: remove last npms
Except web + curriculum-server. I'll update them when I start work on
them again.
* fix: lockfile check to catch any package-locks
* fix(action): install pnpm for upcoming tests
* chore: add nodemon to new api
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
* feat(client): change the buttons from disabled to aria-disabled
Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>
* stop the API call when the validation isn't true
* use aria disabled instead of disabled on the test?
* use have.attr to check for aria disabled
* hide the button when it's disabled
Co-authored-by: Bruce B <bbsmooth@gmail.com>
* update Privacy Settings save button
---------
Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>
* convert challenge-hot-keys to ts
* rename selector object in challenge-hot-keys
* convert challenges/output to ts
* update selector and location objects in challenges/output
* convert common-components/searchBar to ts
* add missing type and fix final url assertion
* convert searchBar to kebab-case and fix URL assertion
* convert donate-page-donor to ts
* convert donation-block-completion-modal to ts
* resolve compilation errors in donation-block-completion-modal.ts
* convert intro-page to ts
* resolve compiler errors in intro-page.ts
* convert settings/certifications to ts
* add cypress testing library types to tsconfig for settings/certifications.ts
* convert settings/image-picture-check to ts
* convert settings/settings to ts
* convert settings/user-token to ts
* convert settings/username-change to ts
* resolve compiler errors in settings/username-change.ts
* convert default/top-contributor to ts
* add ES2017 to compilerOptions.lib in cypress/tsconfig
* edit custom command interface
* convert challenge-hot-keys to ts
* rename selector object in challenge-hot-keys
* convert challenges/output to ts
* update selector and location objects in challenges/output
* convert common-components/searchBar to ts
* add missing type and fix final url assertion
* convert searchBar to kebab-case and fix URL assertion
* update URL assertion for non-local environments in search-bar.ts
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
* Update cypress/e2e/default/learn/common-components/search-bar.ts
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
* Feat: Convert landing page test to Typescript
* Chore: Remove Eslint issue with template.
* Fix: Remove dumb typo.
* Set the types for the parameters and set unique name to please TypeScript
Co-authored-by: Sboonny <muhammed@freecodecamp.org>
* feat: first draft of action and cypress spec
* feat: test all generated challenges
* fix: better identification of block
* action: update cypress config
* action: upload to dashboard
* action: testing js cert challenges
* fix: unnecessary after user code for Make a Person
* feat: capture console log output for assert test
* fix: remove after seed code
* fix: change const to let
* fix: test
* action: disable js certification
* action: stop checking out branch in action
* action: check out right mobile repo
Co-authored-by: sembauke <semboot699@gmail.com>
* feat: add skip-to-content button
* fix: remove content start ids from everywhere and add to default layout
* chore: format landing-top.tsx
* use single quotes in skip-to-content component
* include breadcrumbs in navigation
* linting fail fix
* use anchor tag instead of new component
* update challenge title snap
* fix(test): reliably move focus onto the editor
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: update jaw on all ctrl-enter presses
* fix: show running tests while hiding feedback
Screenreaders still announcing running tests and then the output, and
the display now stops showing a flash of the new feedback message
* refactor: camelCase
* refactor: clean up and reduce renders
previousHint isn't really state, insofar as it changing should not
trigger a new render - a ref does the trick.
* chore: remove log
* fix: use ref to track latest attempts prop
* fix: allow lower jaw to trigger viewzone updates
React.render's callback cannot be relied on. It does not necessarily
get called on every update to the rendered element.
updateContainer is called on every render, so the editor will be
updated.
* refactor: attemptsNumber -> attempts
* fix: do not render on attempt changes
* refactor: more camelCase
* fix: try to prevent previous hint rendering
Co-authored-by:
Manabu Matsumoto <mmatsumoto1026@gmail.com>
* test: resetting of lower jaw
* fix: reset lower jaw when step is reset
* test: check congrats message appears on completion
* fix: hide feedback after reset
* fix: leave focus in the editor after passing tests
This is an attempt to work around a JAWS issue whereby the submit
shortcut (ctrl+enter) is ignored after the user passes all tests.
* test: submit button receives focus when tests pass
* fix: focus submit button when tests pass
Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>
Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>
