Commit Graph

197 Commits

Author SHA1 Message Date
Anubhav Jain
88c54192b9 fix(client): remove unused files (#47974)
* removed unused files

Removed unused files as per comments for issue #47971

* fix: removed duplicate exports from 4 files

* Build fix

* made changes for build fix

* made changes for build fix
2022-10-14 18:54:09 +05:30
Danny Greenberg
93347ea285 fix(font): Replace Roboto Mono with Hack-ZeroSlash (#47767)
Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>
2022-10-06 15:57:40 +00:00
Divyansh Singh
6dd8c6241b feat: add hidden skip-to-content button (#47577)
* feat: add skip-to-content button

* fix: remove content start ids from everywhere and add to default layout

* chore: format landing-top.tsx

* use single quotes in skip-to-content component

* include breadcrumbs in navigation

* linting fail fix

* use anchor tag instead of new component

* update challenge title snap

* fix(test): reliably move focus onto the editor

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-10-05 20:43:00 +02:00
Niraj Nandish
53164e71f1 fix: circular dependencies (#46638)
* fix: circular dependency in formHelpers

* fix: circular dependency in Flash

* fix: circular dependency in helpers

* fix: circular dependency in current-challenge-saga (1/2)

* fix: circular dependency in code-lock-epic

* feat: eslint rule for circular dependencies

* fix: circular dependency in tools

* fix: import error and more circular dependencies in formHelpers

* fix prettier error

* fix: circular dependency in danger-zone-saga

* fix: circular dependency in update-email-saga

* fix: circular dependency in settings-saga

* fix: circular dependency in accept-terms-saga

* fix: circular dependency in codeally-saga

TODO: make a separate file for selectors

* fix: ci lint error

* fix: ci lint:prettier error

* fix: circular dependency in current-challenge-saga

* fix: cricular dependency in Challenges/redux

* fix: circular dependency in redux/settings

* fix: circular dependency in root redux

* fix: lint errors

* chore: remove unecessary comment

* chore: remove unused export

* fix: clear out actions and selectors

* revert changes to package.json

* test ci with maxDepth of 1

* fix: fallback to empty object

* test action if it will run for maxDepth of 2
2022-10-05 18:08:40 +01:00
Oliver Eyton-Williams
7d77a202ec feat(client): use updateMySocials not updateUserFlag (#46380)
* feat: use updateMySocials not updateUserFlag

* fix: replace updateUserFlag with updateMyTheme

* fix: show social icons

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: delete social booleans from client

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2022-09-30 16:18:23 +03:00
Muhammed Mustafa
afb861be9d fix(client): making misclicking sign out harder (#46644)
* added hover and focus effect on signout

* increase spacing by increasing the height

* I remembered why I hated react so much

* will come back after the meeting

* cleared 10 types error

* fix: make lang menu more keyboard accessible

* increased button specificity and switch to navlink to focus better

* added className for future style when the fuction is functional

* this is funny

* slowly comming together

* will create the function tomorrow morning

* signout is read only bug

* Removed the need for enlist

* Update client/src/components/Header/components/nav-links.tsx

* Update client/src/components/Header/components/nav-links.tsx

* Props fails, I am removing enlist errors and implementing types

* Update client/src/components/Header/components/nav-links.tsx

Co-authored-by: Moshe <shootermv@gmail.com>

* half of eslint no unsafe call

* No issue without this eslint as well

* Couldn't fix enlist issue

* same error

* Removed eslint error

* no-unsafe-member enlist error

* Clear enlist error

* cleared type errors

* remove eslint no unsafe memeber access

* no unsafe return eslint

* I have opened pandora box

* npm errors

* I am really lost

* Cleared some typescript errors, hopefully I can create the modal now

* added basic style and a plan

* modal show and hide functionality

Co-authored-by: wongwinnie198@gmail.com

* Revert "modal show and hide functionality"

This reverts commit 237e0b00c4.

* modal show and hide functionality

Co-authored-by: wongwinnie198 <wongwinnie198@gmail.com>

* clear type error

* interesting my first animation attempt failed

* removed the modal

* added color, it may be damaging accessiblity

* revert translation.json changes

* cleared unused types and type mistake I added before

* Revert key press naming changes

Co-authored-by: mmatsumoto1026 <mmatsumoto1026@gmail.com>

* changed hover effect to danger variables and fix change language hover

Co-authored-by: mmatsumoto1026 <mmatsumoto1026@gmail.com>

* add lang manu height to gerenic selector

* remove redundant code, make cansel change stay color stay blue

* Revert me mess around

* prettier format

* test cypress interaction and if it accounts for mobile design

* Revert "test cypress interaction and if it accounts for mobile design"

This reverts commit 9b01e78156.

* refactor search form

* add missing value units

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Bruce B <bbsmooth@gmail.com>
Co-authored-by: Moshe <shootermv@gmail.com>
Co-authored-by: wongwinnie198 <wongwinnie198@gmail.com>
Co-authored-by: mmatsumoto1026 <mmatsumoto1026@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-09-28 15:57:14 +02:00
kulraj chavda
acc966ac31 add visual separation in Change language menu UI (#47418)
add visual seperation in Change language menu UI
2022-09-08 13:16:27 +05:30
Manabu Matsumoto
145521b3d4 fix(UI): restore keyboard accessibility (#47427)
* fix: restore keyboard accessibility

* fix/ make code easier to maintain
2022-09-06 19:21:38 +02:00
Naomi Carrigan
5e402e6955 feat: allow languages to be hidden (#47362) 2022-08-23 20:53:47 +02:00
Moshe
8d4d4d79e8 fix(ui): "sign in" button hidden at small devices (#46561)
* fix(UI): missing sign-in button at small devices

* feat: replace menu and sign-in buttons text with images

* refactor: svg icons replaced by fortawesome ones

* test: fix e2e test of navigation menu button

* feat: display sign in button and hide all

* feat: display sign in icon on nav for small screens

* feat: add accessibility span for menu icon

* fix: lint errors

Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com>
2022-07-12 08:15:52 -05:00
Ahmad Abdolsaheb
aead146554 feat(client): center login button (#46287)
* feat(client): center login button

* feat: remove unused file
2022-06-02 17:34:29 +03:00
Shaun Hamilton
b2da57881c chore(client): remove console log (#46275) 2022-06-01 20:16:45 +02:00
Bruce Blaser
d2332093f6 fix(a11y): main menu a11y updates (#45137)
* fix: main menu a11y updates

* update font menu

* fix: sign in button text alignment

* fix: disabled button font

* fix: language menu font

* remove sign-in from main menu

* fix: add section dividers to menu

* fix: height on language selector menu

* fix: alignment of Menu button text

* fix: language globe icon

* refactor: remove dup selector

* update language menu colors

* refactor: clearer name for language menu display state

* fix: don't close onBlur if Menu button is clicked

* refactor: move globe icon styling to CSS

* refactor: get rid of switch statements

* refactor: remove try catch block

* fix: translate Change language button

* fix: move search into nav menu for mobile layout

* fix: forgot a merge

* refactor: updates for changes in i18n/all-langs

* fix: prevent menu from collapsing when focus is on change language button and user clicks into search

* fix: translate cancel change option in language picker

* feat: add cypress tests

* feat: display the complete language list

* fix: fix TS typing

* fix: force scrollbar on lang menu

* fix: remove scroll bar from lang menu

* fix: close menu when user tabs away from last menu item

* add list role to navigation list to appease Safari

* chore: capitalize Change Language/remove CSS comment

* fix: right side search box alignment in narrow view

* remove extraneous list role

* fix: cypress

Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com>
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2022-06-01 10:39:26 +03:00
Abdelmalek Ennani
d1fe6b3eaf fix(client): remove unexpected duplicate "height" (#45911)
I deleted an Unexpected duplicate "height" property
2022-05-12 11:13:21 +05:30
Benjamin Rio
1457c362c1 fix(client): remove duplicate css properties (#45902) 2022-05-10 10:03:53 -05:00
Sem Bauke
c3be968092 feat: migrate locale test to ts v2 (#45793)
* feat: migrate locale test to ts v2

* fix: langCodes

* fix: locale test

* fix: nav dropdown

* fix: header test

* fix: use type predicates

* refactor: DRY up all-langs

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-05-02 17:53:30 +02:00
sidemt
c681c33587 fix(a11y): use appropriate aria-label for fCC logo depending on its use (#45201) 2022-02-23 13:52:44 +05:30
Bruce B
7abb89326b fix(a11y): make breadcrumb nav more accessible (#45021)
* fix: make breadcrumb nav more accessible

* refactor: cypress test and jest snapshot

* slight adjustment to left breadcrumb focus outline

* feat: translate aria for nav

* chore(tools): update snapshot

Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com>
Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
2022-02-15 21:44:18 +03:00
Bruce B
361e7fc2e5 fix(a11y): FCC logo link (#45039)
* fix: fcc logo link

* fix: fcc svg label

* feat: use translated aria for logo

* clean up

Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com>
2022-02-10 17:02:26 -08:00
Mrugesh Mohapatra
685344ae45 refactor: apply fixed from codefactor (#3) (#44780)
Co-authored-by: codefactor-io <support@codefactor.io>

Co-authored-by: codefactor-io <support@codefactor.io>
2022-01-14 08:53:34 -08:00
Shaun Hamilton
23e241bbc0 chore(client): tidy Flash by tidying tone (#44320)
* chore(client): tidy Flash by tidying tone

* add store import

* fix enum, remove default switch case

Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>

* typo galore

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* rejig everything, because refactoring is fun 🙃

* refactor: DRY playTone

* fix url to foss library

Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>

* alphabetasize FlashMessage enum

* add all FlashMessages to tone/index.ts

* remove redundant type

* my code is correctnpm run develop:client

* fix: remove circular dependency

* fix: typo

* remove logs, play special tones for nightmode

* play sound on challengeComplete

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-12-01 10:45:17 -08:00
Nicolas Ramirez
c8ba3e9316 chore(client): rename test.tsx files to kebab-case (#44261) 2021-11-24 22:16:46 +00:00
Arun Et-008
1ca335794c fix(client): make language dropdown as wide as the nav (#43991)
Co-authored-by: arun elanthamil <arun.elanthamil@superops.ai>
2021-10-27 13:53:16 +03:00
Lim Shang Yi
3dbe40410c feat(client): language dropdown in the side menu is now a drop down (#43729)
* feat(UI): language in the side menu is now a drop down. navigation items are now text wrapped

* fix: use redux navigation to redirect links instead

* fix: fix to use clientLocale as curent language instead

* fix: tests to use clientLocale
2021-10-15 16:08:35 +03:00
RobertoMSousa
cb0a502d82 chore: tree shaking - unused / redundant code (#43867) 2021-10-15 13:13:43 +05:30
Noor Fakhry
8518079316 fix(client):make menu bar disappear after user chooses item from it on landing page (#43458)
* removed serachBarRef

* removed serachBarRef

* Revert "removed serachBarRef"

This reverts commit 6a5c2f4cb3.

* Revert "removed serachBarRef"

This reverts commit 67710b3d18.

* added innerRef as ref to SearchBarOptimized component

* Update client/src/components/Header/index.tsx

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update client/src/components/search/searchBar/search-bar-optimized.tsx

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update client/src/components/search/searchBar/search-bar-optimized.tsx

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-10-06 16:42:54 +02:00
Ismail Tlemcani
67ee31cbfc feat(client): ts-migration for layout index file, Intro Component and header test file (#43094) 2021-08-26 17:17:25 -05:00
Nicholas Carrigan (he/him)
c8ec196dbc fix: scrollable nav (#42600)
* fix: scrollable nav

Modify the drop down menu to be scrollable.

* fix: account for really small screens
2021-08-11 18:17:21 +01:00
Nicholas Carrigan (he/him)
28003256c3 fix: restore navatar class (#43176) 2021-08-11 09:38:31 +02:00
Oliver Eyton-Williams
e118dda13a fix: order imports and remove circular dependencies (#41824)
* fix: remove circular dependency

redux depended on templates/Challenges/redux and vice versa.  This
meant that import order mattered and confusing bugs could arise.

(cherry picked from commit 7d67a4e70922bbb3051f2f9982dcc69e240d43dc)

* feat: require imports to be in alphabetical order

Import order generally does not matter, but there are edge cases
(circular  imports and css imports, for example) where changing order
changes behaviour

(cherry picked from commit b8d1393a91ec6e068caf8e8498a5c95df68c2b2c)

* chore: order imports

* fix: lift up challenge description + title comps

This brings the classic Show closer to the others as they
now all create the description and title components

* fix: remove donation-saga/index circular import

(cherry picked from commit 51a44ca668a700786d2744feffeae4fdba5fd207)

* refactor: extract action-types from settings

(cherry picked from commit 25e26124d691c84a0d0827d41dafb761c686fadd)

* fix: lint errors

* feat: prevent useless renames
2021-08-02 08:39:40 -05:00
Shaun Hamilton
9731ea31b8 fix(client): fix i18n external locations in nav (#42995) 2021-07-28 07:31:07 +07:00
Victor Duarte
a4358fc56c fix(client): update display prop on element (#42912)
* fix: profile menu icon overlapping content

* refactor: profile icon usage
2021-07-27 12:27:32 +03:00
Anirudh Modi
ef3b7ec955 chore(eslint): enables recommended eslint rules for testing-library and jest-dom (#42817) 2021-07-20 21:21:16 +07:00
Oliver Eyton-Williams
90d5783870 chore: update Header test to handle more languages (#42894) 2021-07-19 12:39:51 -07:00
Shaun Hamilton
31486b368b fix(client): refactor to use correct i18n t type (#42865)
* fix(client): refactor to use correct i18n t type

* appease Oliver by importing directly from react-i18n

* fix: use default TFunction type variable

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-07-19 09:48:02 -07:00
Parth Parth
11d71adc6e feat(client): ts-migrate /client/src/components/ redirects (#42642)
* rename

* migrate

* migrate create language redirect

* fix type of redirects

* migrate test

Co-authored-by: Parth Parth <thecodingaviator@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2021-06-30 20:52:17 +05:30
Nicholas Carrigan (he/him)
592a2846d3 chore: pass CI (#42635)
* chore: eslint on icons

* chore: eslint spacer element

* chore: remove more eslint

* fix: existing lint issues

* fix: misnamed import

* fix: client now builds!

* fix: tsc errors

* fix: more linting issues
2021-06-30 20:52:17 +05:30
krishna-saurav
5ad374cc1a feat(client): ts-migrate for files under client/src/component/search folder (#42327)
* typescript migration for files under search folder

* fixing few more eslint errors and warnings

* reverting changes for redux/index.js

* fixing merge conflicts with next

* deleting redux/index.ts
2021-06-30 20:52:17 +05:30
Akshat Garg
ea4eeee49e feat(client): ts-migrate header components (#42287) 2021-06-30 20:50:57 +05:30
Parth Parth
0a3a5e7a53 feat(client): migrate icons to TS (#42453)
* migrate files and update tests

fix: use more memory for gatsby develop (#42433)

feat(client): remove whitespace from calculated values (#42400)

* feat(client?): remove whitespace for calculated values

* feat(client): remove whitespace from styledeclaration

* do not automatically strip

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: include all properties of CSSStyleDeclaration

* fix test for getPropVal

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

fix: get showUpcomingChange from env.json (#42440)

fix(client): display legacy certs like current ones (#42038)

* fix: display legacy certs like the current ones

* fix: link projects in legacy certs to project pages

* fix: update tests to changed legacy cert display

* fix: update tests for removed legacy certs forms

* fix: display legacy certs like the current ones

* fix: submit projects for cert on projects pages

* fix: remove legacy certs form submitting handling

* fix: move claiming cert setup before both tests

* fix: remove legacy cert update props and actions

* fix: remove legacy cert updates from api

* fix: correct merge conflict

fix(curriculum): rework Project Euler 98 (#42423)

* fix: rework challenge to use argument in function

* fix: add solution

* fix: use MathJax to improve math notation

fix(curriculum): rework Project Euler 56 (#42364)

* fix: rework challenge to use argument in function

* fix: add solution

* fix: use MathJax to improve look of math notation

fix(curriculum): correct small english typo (#42447)

chore: group together monaco-editor and plugin (#42443)

This should get renovate to create PRs where both are modified.

fix(deps): update dependency algoliasearch to v4.9.2 (#42432)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

migrate files and update tests

Algorithm moved to TSX

first ten files renamed to tsx

first 10 migration complete

first 20 files renamed

migrate some files. rename all

test

index.tsx forced to ignore ts issues

rename and migrate all files

update tests

* remove missed propType declarations

* kebab-caseify

* fi xlinting

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Parth Parth <thecodingaviator@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2021-06-30 20:50:56 +05:30
Ahmad Abdolsaheb
b3f2c64de8 fix(client): remove algolia and hot keys modules from landing pages (#42394)
* fix(client): remove algolia and hot keys from landing pages

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-06-24 12:50:36 +03:00
Huyen Nguyen
2c16234853 chore: add jest global variables (#42573) 2021-06-20 09:14:42 +02:00
Kristofer Koishigawa
94d4b2f553 fix: navbar avatar height, background colors (#42076)
* fix: navbar avatar height

* fix: prevent avatar background change when hovered or focused
2021-05-11 00:15:16 +05:30
Ahmad Abdolsaheb
27c8d564e4 fix(client): replace Stripe with PayPal (#41924)
* feat: remove stripe payment option from client

* feat: remove stripe completely

* fix: remove last Stripe remnants

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-05-03 11:45:23 +03:00
Oliver Eyton-Williams
740370eb60 refactor: explicit mocking for analytics (#41562)
The previous approach did avoid a fair number of jest.mock calls, but
made debugging the tests harder. If you don't know about the mapping
it's unclear why the imported module does not behave as normal.

By forcing the use of jest.mock it means that the answer to that
question is in the test you are working on.
2021-03-29 16:48:58 -07:00
Mrugesh Mohapatra
ad9b1f89d8 fix(api, client): update Gatsby, webpack & related things (#41452)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-03-25 12:13:43 -07:00
Oliver Eyton-Williams
92dfb3065c fix(tests): expand client testing for Espanol (#41574) 2021-03-25 21:25:13 +05:30
Oliver Eyton-Williams
963c3c5af5 fix(test): handle NavLinks for Chinese locale (#41566) 2021-03-24 08:11:19 -07:00
Mrugesh Mohapatra
6c91f81b0e chore(deps): upgrade eslint, prettier & related packages 2021-03-11 12:19:42 +05:30
Mrugesh Mohapatra
b5f4754e2a fix: re-revert the API decoupling (#41263)
* fix(api): decouple api from curriculum

This reverts commit 8f0e441644 and
introduces the implementations from #40703.

* fix(gitpod): add curriculum build to GitPod

This reverts commit 706d70f58d and
introduces implementations from #41234.

* docs: update DevOps manual for api change (#41259)

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-02-25 12:02:35 -08:00