Commit Graph

3712 Commits

Author SHA1 Message Date
a2937
a936806a22 Chore (settings) - Rename tabindex to tabIndex (#49519)
* Chore (settings) - Rename tabindex to tabIndex

* Update client/src/templates/Challenges/components/hotkeys.css

Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>

* Fix hotkeys.css

---------

Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>
2023-02-27 08:03:37 +02:00
Muhammed Mustafa
a64e732458 fix(client): default challengeFiles to array (#49474)
* refactor(client): check challengesfile length in the epic

* change the initial state of challenge files to array
2023-02-23 10:18:04 +00:00
Muhammed Mustafa
06fe9b6d16 refactor(client): stop the homepage image from changing the layout (#49476)
refactor(client): stop the homepage from changing the the layout
2023-02-23 14:53:53 +05:30
Muhammed Mustafa
0971b6a8a3 refactor(client): remove react lazy loader library (#49468)
* feat(client): remove react lazy loader library

* fix: use loading='lazy' to defer loading
2023-02-22 18:05:08 +01:00
Muhammed Mustafa
f56816d3e1 refactor(client): fix types in the nav-links file (#49291)
* refactor(client): clean some mistype errors in the nav-links file

* fix showLanguage prop type in the other files

* add-ts-ignore-comment

* swap to map for easier maintainablity

* Change the eslint naming comment

* fix: using the wrong handlekeydown function

Co-authored-by: Bruce B <bbsmooth@gmail.com>

* hide the menu when focus is on the userimage

* hide the menu only if camper didn't press shift key

---------

Co-authored-by: Bruce B <bbsmooth@gmail.com>
2023-02-22 05:36:05 +02:00
Oliver Eyton-Williams
424711fcad fix(client): provide return types for get-completion-percentage (#49458)
fix: provide return types

I also moved the undefined check closer to the source, so it's clearer
what is missing
2023-02-21 07:40:01 -08:00
Jeff
9f1562291c fix: remove unused className spacer from spacer helper (#49067)
* fix: remove unused className spacer from spacer helper

---------

Co-authored-by: jeff <jeff@vpmbp4.local>
2023-02-21 19:20:29 +05:30
Sem Bauke
8c8cf9afab fix: optional video ids the odin project (#49380)
* fix: optional video ids the odin project

* Update client/src/templates/Challenges/odin/Show.tsx

Co-authored-by: Niraj Nandish <nirajnandish@icloud.com>

---------

Co-authored-by: Niraj Nandish <nirajnandish@icloud.com>
2023-02-21 10:13:31 +00:00
Muhammed Mustafa
181e108418 fix(client): submit button size for external projects (#49448) 2023-02-21 07:40:56 +01:00
Shaun Hamilton
e8b010d7e2 fix(client): selector return, invalid prop val (#49447)
* fix(client): correctly return type from selector

* fix(client): remove incorrect prop [button-spacer]
2023-02-20 21:34:34 +02:00
Muhammed Mustafa
e5bf2ae97e feat(client): make skip to content button translatable (#49439) 2023-02-20 21:22:39 +05:30
Muhammed Mustafa
85e9fbb8df refactor(client): clean extra component and extra unneeded imports (#49391)
* feat: remove extra unnecessary code

* clean the unique way that component was handled

* make bsSize optional

* update snapshot to account for the other button styles

* add comment for our future selves

* clean the changes file
2023-02-19 17:16:53 +05:30
Ahmad Abdolsaheb
13aad8ca37 feat(client): move the block donation modal logic to an epic. (#49381)
feat(client): move percent calculation logic to epic
2023-02-19 09:04:04 +02:00
Muhammed Mustafa
e8f0145a08 feat(client) make pre in instruction ltr when the layout is rtl (#49431)
* feat(client) make pre in instruction ltr when the layout is rtl

* revert the changes in the markdown file
2023-02-18 22:00:44 +01:00
Muhammed Mustafa
45dc6aee9e feat(client): make portfolio section in profile support RTL layout (#49148)
* feat(client): make portfolio section in profile support RTL layout

* Revert "feat(client): make portfolio section in profile support RTL layout"

This reverts commit b4cf5f1ab4.

* make media component responsive

* fix the selector

* hook the media left through an id

* hook the media left through an id
2023-02-18 21:58:01 +01:00
Muhammed Mustafa
251aecc58f feat(client): change the save buttons from disabled to aria-disabled (#49216)
* feat(client): change the buttons from disabled to aria-disabled

Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>

* stop the API call when the validation isn't true

* use aria disabled instead of disabled on the test?

* use have.attr  to check for aria disabled

* hide the button when it's disabled

Co-authored-by: Bruce B <bbsmooth@gmail.com>

* update Privacy Settings save button

---------

Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>
2023-02-18 12:16:35 -08:00
Muhammed Mustafa
c027bce6de fix(client): pre code having extra spaces when code elements are stacked (#49343)
Co-authored-by: hbar1st <hanaab@gmail.com>
2023-02-18 10:18:54 -08:00
Muhammed Mustafa
df1eb8c8de fix(client): misaligned buttons in the RWD certification (#49404)
* fix(client): misalignedbuttons in the RWD certification

* Clean the css file
2023-02-17 21:55:47 -08:00
Muhammed Mustafa
4f357db02f refactor(client): clean extra code in donate form (#49276) 2023-02-17 17:32:41 +03:00
Tom
c29ecaf14f fix(client): site crashing when leaving rdb challenge (#49409)
fix: crashing when leaving rdb
2023-02-17 07:56:28 +02:00
Muhammed Mustafa
150d5cb0d3 feat(client): remove ltr direction from quotes in rtl layout (#49340) 2023-02-16 13:50:35 +01:00
Bruce Blaser
cb0da3bbf9 fix(client): console height in multi-file editor (#49372)
fix: allow console to take up entire height of panel
2023-02-16 12:22:57 +01:00
Muhammed Mustafa
5e4ba38309 refactor(client): delete block save wrapper (#49217)
* refactor(client): delete block save wrapper

* Clean bloating divs and extra css import

* remove the blocksave wrapper snapshot
2023-02-13 23:26:44 +05:30
Oliver Eyton-Williams
4ff00922da refactor: fix hidden eslint errors (#49365)
* refactor: explicit types for validate

* refactor: explicit return types for ui-components

* refactor: use exec instead of match

* refactor: add lots more boundary types

* refactor: more eslint warnings

* refactor: more explicit exports

* refactor: more explicit types

* refactor: even more explicit types

* fix: relax type contrainsts for superblock-order

* refactor: final boundaries

* refactor: avoid using 'object' type

* fix: use named import for captureException

This uses TypeScript (which works) instead of import/namespace
(which doesn't) to check if captureException exists in sentry/gatsby
(it does)
2023-02-13 07:13:50 -08:00
renovate[bot]
ea7df4fb9a fix(deps): update font awesome to v6.3.0 (#49357)
* fix(deps): update font awesome to v6.3.0

* update profile snapshot for the new icon

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Sboonny <muhammed@freecodecamp.org>
2023-02-13 11:23:33 +00:00
Muhammed Mustafa
a1ebe6dcd6 refactor(client): turn image validation component into subComponent (#49155)
* refactor(client): clean extra FormGroup component in personal info

* Revert "refactor(client): clean extra FormGroup component in personal info"

This reverts commit cc29df3033.

* refactor show image component into JSX

* Remove redundant text

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>

---------

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2023-02-10 17:13:27 +00:00
Ahmad Abdolsaheb
6e53c852de feat(client): pull percentage challenge data from redux (#49308)
* feat(client): pull percentage challenge data from redux

* Apply suggestions from code review

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* feat: update updateAllChallengesInfo name

---------

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2023-02-10 13:16:11 +00:00
Mrugesh Mohapatra
0f4fd9d57b chore: rename mockfiles in jest config (#49318) 2023-02-10 13:12:02 +00:00
Mrugesh Mohapatra
96a5699c39 chore: rename icons (#49319) 2023-02-10 13:11:16 +00:00
Mrugesh Mohapatra
eff2166262 chore: rename redux actions (#49320) 2023-02-10 12:04:17 +00:00
Muhammed Mustafa
77c8809b00 refactor(client): cleanup honesty policy section (#49003)
Co-authored-by: Bruce B <bbsmooth@gmail.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: sidemt <25644062+sidemt@users.noreply.github.com>
Co-authored-by: Mrugesh Mohapatra <hi@mrugesh.dev>
Co-authored-by: Quincy Larson <QuincyLarson@users.noreply.github.com>
2023-02-09 13:37:22 -06:00
Ahmad Abdolsaheb
6c97591ca6 feat(client): turn default layout to a functional component (#49289) 2023-02-08 15:28:26 -06:00
Sem Bauke
928dcbe08c feat: transfer The Odin Project to its own superblock (#49202)
* feat: the odin-project superblock

* feat: break everything

* fix: correct meta names

* fix: meta again

* fix: tests

* fix: help category and external curriculum test

* fix: file names again

* fix: help category

* fix: remove console log

---------

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2023-02-08 15:21:03 +01:00
@DiegoCascavita
0e538a926d fix(curriculum): renaming tabs for uniformity in responsive design (#49286)
renaming tabs for uniformity in responsive design
2023-02-08 08:08:06 +01:00
abe
4494b0c05b fix(UI): keep portal preview open (#48451)
* moved portal states to redux

stored a global window

open window if does not exist clear htmlif already exists

moved close window to desktop-layout

close portal if user navigates to route outside of challenges

naming conventions, specify url

dispatch setIsAdvancing and use in portal preview

* fix: close portal if main window closes

* fix: refactor it

* Revert "fix: refactor it"

This reverts commit 197a40a3a6.

* feat: add isAdvancing to hotkeys

* fix: revert to pane on first step of block

* fix: safari issues

* fix: revert to pane when not advancing

---------

Co-authored-by: kravmaguy <flex4lease@gmail.com>
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2023-02-06 08:18:46 +01:00
Oliver Eyton-Williams
3116e17c78 fix(client): handle edits without editable region (#49242)
fix: keep editable region as empty array

There's no need to make it undefined, since editors without editable
regions are initiated with [] and the editor knows that an empty array
means the editable region doesn't exist.
2023-02-03 22:39:30 +05:30
Shaun Hamilton
9771e0ad70 fix(client): cert project help post sans editable region (#49157)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2023-02-02 11:46:13 -06:00
Muhammed Mustafa
a1380b2873 feat(client): make the console RTL (#49210)
feat(client): make the console.log RTL

Co-authored-by: hbar1st hanaab@gmail.com
2023-02-02 20:20:49 +05:30
Kristofer Koishigawa
b00defc9c4 fix(client): move console in multi-file editor (#49228)
* fix: move the console in the multifile editor to below the preview

* fix: go back to single displayConsole, move project based / multifile
logic into the jsx

* revert: previewPane flex value

* feat: refactor to allow console to open up the preview panel and take up all the vertical space

* fix: simplify editor layout logic
2023-02-02 20:03:54 +05:30
Oliver Eyton-Williams
b16c62f631 feat: split odin project block in two (#49140)
* feat: split odin project block into two blocks

* refactor: remove redundant isOdinProject checks

* fix: revert checkbox outline changes

Keyboard users need a way to see what's currently in focus, so we can't
hide the outline

* fix: add help category

* fix: use HTML-CSS help category

---------

Co-authored-by: sembauke <semboot699@gmail.com>
2023-01-30 18:03:58 +09:00
Muhammed Mustafa
f62f04989b feat(client): change the delete email to support email (#49159)
Co-authored-by: Quincy Larson <QuincyLarson@users.noreply.github.com>
2023-01-27 13:16:29 +03:00
YMatsuda
ca91d93d7e fix(client): use translated cert name for Legacy Full Stack Certification (#49145)
fix(client): use translated cert name
2023-01-26 11:04:52 -08:00
Bruce Blaser
849e2c041d fix(a11y): Save buttons on Settings page (#49142)
* fix: make save buttons more accessible for screen reader users

* fix: associate username input with label
2023-01-26 19:28:01 +02:00
Muhammed Mustafa
57317a4a32 feat(client): full width component to carry key prop (#49082)
* feat(client): allow full width to carry key props

* fix: setting can't render the element error

* Remove the key prop from FullWidthRow

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* remove key form fullwidth

* Remove undefined type from children

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* add key to renderProfile

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2023-01-26 08:20:28 +01:00
Muhammed Mustafa
af5c610511 fix(client) broken donate button text alignment in RTL layout (#49123)
fix(client) broken donate button text alignment
2023-01-25 19:05:28 +05:30
Atir Nayab
0bcc611b91 feat(client): add jest snapshot for settings button and certification… (#48751)
* feat(client): add jest snapshot for settings button and certification page consistency

* feat(client): setting buttons consistency snapshot done

* feat(client): jest snapshot check consistency of ceritification page

* fix: snapshot test updated and mocking date fn

* fix(client): settings button snapshot updated

* fix(client): settings button snapshot updated

* fix(client): settings button snapshot updated

* fix(client): settings button snapshot updated

* fix(client): certification and timeline test updated as per feedback

* fix(Client): changed mock file name to kebab case

* fix(client): changed timeline and settings button tests directory

* fix(client): completedChallenge.js file removed

* fix(client): settings-button and timeline-buttons test dir updated

* fix(client): removed autogenerated lines from tsconfig.json

* fix: reverted settings-button and timeline-button test to js

* fix: settings-button and timeline-buttons test cleanup

* fix: settings-button test updated

Co-authored-by: Atir <atir@codebuddy.co>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2023-01-25 19:02:54 +05:30
Muhammed Mustafa
95c24d901f feat(client): remove bloating CSS from RTL file (#49122) 2023-01-25 19:01:41 +05:30
Sem Bauke
901ca9d9a2 fix(client): multiple issues the odin project (#49075)
* fix: multiple issues

* fix: show expand collaps button

* fix: make variable instead

* fix: console log
2023-01-25 18:59:26 +05:30
Muhammed Mustafa
f95a6261ba refactor(client): move margin and padding to inline values (#49100) 2023-01-23 21:17:12 +00:00
Bruce Blaser
412df3570a fix(a11y): add tabstop on info panel (#49096) 2023-01-23 23:19:17 +05:30