Commit Graph

2606 Commits

Author SHA1 Message Date
Shaun Hamilton
ec3ee856ec feat(tools): ignore no-unused-vars on underscore (#48386) 2022-11-04 10:43:46 +05:30
Muhammed Mustafa
5ef777973a feat(client): refactor the buttons leading to the certifcations intro (#48320) 2022-10-31 18:11:51 -05:00
Prince Mendiratta
deca35257b feat: disable find hotkey in editor (#48241)
Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>
2022-10-28 22:45:18 -07:00
Muhammed Mustafa
52953a5b95 feat(client): add rtl direction attribute to html element (#48245)
* feat(client): add rtl direction attribute to html element

* WIP: add LangDirection as base for direction attribute selection

* DRY rtlLanguages for easier future usage

Co-authored-by: Mrugesh Mohapatra <hi@mrugesh.dev>

* Remove urdu, to avoid unknown bugs

* Fix merge conflict, by clearing import values

Co-authored-by: Mrugesh Mohapatra <hi@mrugesh.dev>
2022-10-28 08:13:09 +02:00
Muhammed Mustafa
3279ab161e feat(client): refactor universal nav missing types (#48144)
* feat(client): refactor universal nav missing types

* extends link type from gatsby link types


Co-authored-by: auchynnikau <viachaslau_auchynnikau@epam.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-10-27 20:20:59 +05:30
Atir Nayab
f92a851a0a feat(client): add icon in setting page button (#48268) 2022-10-27 20:06:47 +05:30
Jagruti Tiwari
af156fdfe4 feat(client): add "completed x of y" in completion modal (#47022)
* feat: wrote a new function and updated the test case

* fix: lint errors

* fix: Fixed the changes not being reflected in the code. And undid unwanted commits from the last time

* fix: removing unwanted updates to the package-lock.json

* fix: Removing unwanted changes from package-lock.json

* fix: removing unwanted changes from package-lock.json

* fix: updating snapshots to fix the test case

* chore: update snapshot

* Update client/src/templates/Challenges/components/completion-modal.tsx

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update client/src/templates/Challenges/components/completion-modal.tsx

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update client/src/templates/Challenges/components/completion-modal.tsx

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: removed hard coded english words from translation text

* fix: only show output when id is cert project

* fix: correctly count completed challenges

* fix: update test and snapshot

[skip ci]

* fix: at least one challenge is always completed

When the modal pops-up, there is always at least one challenge counted as "complete"

* refactor: slightly improve readability

Co-authored-by: Ilenia <nethleen@gmail.com>
Co-authored-by: Mrugesh Mohapatra <hi@mrugesh.dev>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-10-27 14:26:45 +00:00
Vaibhav Gupta
e2da8dae3c chore(client): Don't re-create preview iframe from scratch on each test run (#48178)
* remove unnecessary call

* Remove unused variable: previewTask

* review comments
2022-10-27 09:41:47 +02:00
Mrugesh Mohapatra
b393d88b9e refactor: s/all-langs/i18n/g (#48258) 2022-10-26 10:08:27 -07:00
Muhammed Mustafa
6074cdf9c1 feat(client): clear ESLint comment in learn layout (#48154)
feat(client): clear enlist comment in learn layout
2022-10-24 11:00:02 +02:00
Sawjan Gurung
8ea0401c0a fix(client): preserve scroll position of preview iframe (#47870)
* fix(client): preserve scroll position of preview iframe

* use existing frameContext instead of getting element

* do not use type guard

* remove unused type, add es2022 to ts-lib

* move scroll functions into a class

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2022-10-21 22:52:15 +05:30
Prince Mendiratta
12828fa497 feat(client): replace preview icon with a clearer one (#48169) 2022-10-21 22:47:03 +05:30
Muhammed Mustafa
b05c99d720 feat(client): link Arabic new articles to freeCodeCamp searchbar (#48129)
* feat(client): link Arabic new articles to freeCodeCamp searchbar

* Point to english articles, instead of arabic articles

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>

* link the search bar to Arabic news

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
2022-10-21 19:30:49 +09:00
Mehdi Bouaziz
818568376d fix(UI): replace button with icons in challenge lower jaw (#48014)
* fix: replace button with icons in challenge lower jaw

* fix: update icon buttons to add data-cy, align right, and cleaner conditional display

* fix: update cypress test with correct selector, update conditional button syntax

* fix: add reset and help icon components, move lowerjaw.css to editor.css

* feat: adjust icon buttons order

Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com>
2022-10-20 14:08:56 +02:00
Oliver Eyton-Williams
129c110368 fix: only fetch growthbookUri in browser contexts (#48112) 2022-10-19 01:13:54 -07:00
Ahmad Abdolsaheb
0df7ee430d feat(client): add growthbook (#48003)
* feat: initial set up

* feat: useFeature setup

* feat: adjust attributes

* chore(client): remove ts-disables in growth-book-wrapper

* feat: pull growthbook uri from env

* feat: adjust the staff atribute

* feat: make linter happy

* feat: update recruitment message

* refactor: simplify types

* chore: delete unused config

* fix: update copy

* fix: add growthbookUri to expected env vars

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-10-17 14:53:25 +02:00
PakkuDon
e5f54cab5f chore(client): remove exports for unused types (#48004)
* chore(client): remove exports for unused types

* chore(client): remove unused type
2022-10-14 19:10:21 +05:30
Anubhav Jain
88c54192b9 fix(client): remove unused files (#47974)
* removed unused files

Removed unused files as per comments for issue #47971

* fix: removed duplicate exports from 4 files

* Build fix

* made changes for build fix

* made changes for build fix
2022-10-14 18:54:09 +05:30
Mrugesh Mohapatra
06765555c1 feat(client): add page for users blocked by okta (#47991) 2022-10-12 20:21:19 +05:30
Prince Mendiratta
567de3bedb fix: do not display breadcrumbs with iframe (#47989)
Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2022-10-12 12:36:01 +02:00
Prathamesh Gawas
e42907a40c fix(client): prevent submitting forms in iframe (#47799)
Co-authored-by: Muhammed Mustafa <MuhammedElruby@gmail.com>
2022-10-12 04:24:26 +05:30
Derryk Boyd
d380f13172 chore(client): ts migrate builders.js (#47813)
* Rename builders.js > builderst.ts

* Chore: Migrate builders.js to typescript

* Replace _concatHtml with concatHtml

Co-authored-by: Derryk Boyd <derryk@redmantech.com>
2022-10-11 11:42:08 -07:00
Mrugesh Mohapatra
0885f4f4e4 fix: update url and status in sd-markup (#47978) 2022-10-11 20:27:34 +05:30
Hdanzo
e935d75edc feat(client,seo): add structured data for courses (#47659)
Co-authored-by: HDAnzo <hdanzoategui@softwarenatura.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2022-10-11 16:51:23 +05:30
Prince Mendiratta
314f0e4ba6 fix: separate string to view code/project (#47890)
* fix: separate string to view code/project

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

* feat: add test for certification rendering

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

* chore(lint): trailing newline at EOF

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>
2022-10-08 10:11:21 +02:00
Danny Greenberg
93347ea285 fix(font): Replace Roboto Mono with Hack-ZeroSlash (#47767)
Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>
2022-10-06 15:57:40 +00:00
Bruce Blaser
15da8ffcb2 fix(a11y): make console pane output keyboard accessible (#47764) 2022-10-06 21:14:16 +05:30
Divyansh Singh
6dd8c6241b feat: add hidden skip-to-content button (#47577)
* feat: add skip-to-content button

* fix: remove content start ids from everywhere and add to default layout

* chore: format landing-top.tsx

* use single quotes in skip-to-content component

* include breadcrumbs in navigation

* linting fail fix

* use anchor tag instead of new component

* update challenge title snap

* fix(test): reliably move focus onto the editor

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-10-05 20:43:00 +02:00
Niraj Nandish
53164e71f1 fix: circular dependencies (#46638)
* fix: circular dependency in formHelpers

* fix: circular dependency in Flash

* fix: circular dependency in helpers

* fix: circular dependency in current-challenge-saga (1/2)

* fix: circular dependency in code-lock-epic

* feat: eslint rule for circular dependencies

* fix: circular dependency in tools

* fix: import error and more circular dependencies in formHelpers

* fix prettier error

* fix: circular dependency in danger-zone-saga

* fix: circular dependency in update-email-saga

* fix: circular dependency in settings-saga

* fix: circular dependency in accept-terms-saga

* fix: circular dependency in codeally-saga

TODO: make a separate file for selectors

* fix: ci lint error

* fix: ci lint:prettier error

* fix: circular dependency in current-challenge-saga

* fix: cricular dependency in Challenges/redux

* fix: circular dependency in redux/settings

* fix: circular dependency in root redux

* fix: lint errors

* chore: remove unecessary comment

* chore: remove unused export

* fix: clear out actions and selectors

* revert changes to package.json

* test ci with maxDepth of 1

* fix: fallback to empty object

* test action if it will run for maxDepth of 2
2022-10-05 18:08:40 +01:00
Oliver Eyton-Williams
7d77a202ec feat(client): use updateMySocials not updateUserFlag (#46380)
* feat: use updateMySocials not updateUserFlag

* fix: replace updateUserFlag with updateMyTheme

* fix: show social icons

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: delete social booleans from client

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2022-09-30 16:18:23 +03:00
Hdanzo
c4f7e45832 feat: standardize view button text (#47525)
* feat: standardize view button text

Add new translation keys Delete unused translation keys Fix tests broken with new functionalities

* Delete View variations in translations.json
Delete buttons tittle
Modify buttons text to be "View" or translated equivalent
Modify tests to query the buttons by role and name

Co-authored-by: HDAnzo <hdanzoategui@softwarenatura.com>
2022-09-30 10:39:33 +03:00
Oliver Eyton-Williams
d879e1df21 fix: stop mutating store when toggling settings (#47654) 2022-09-29 10:44:11 -05:00
Shaun Hamilton
73c3edb56a fix: certification to private on private timeline (#45562)
Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-09-29 00:00:22 +05:30
Muhammed Mustafa
afb861be9d fix(client): making misclicking sign out harder (#46644)
* added hover and focus effect on signout

* increase spacing by increasing the height

* I remembered why I hated react so much

* will come back after the meeting

* cleared 10 types error

* fix: make lang menu more keyboard accessible

* increased button specificity and switch to navlink to focus better

* added className for future style when the fuction is functional

* this is funny

* slowly comming together

* will create the function tomorrow morning

* signout is read only bug

* Removed the need for enlist

* Update client/src/components/Header/components/nav-links.tsx

* Update client/src/components/Header/components/nav-links.tsx

* Props fails, I am removing enlist errors and implementing types

* Update client/src/components/Header/components/nav-links.tsx

Co-authored-by: Moshe <shootermv@gmail.com>

* half of eslint no unsafe call

* No issue without this eslint as well

* Couldn't fix enlist issue

* same error

* Removed eslint error

* no-unsafe-member enlist error

* Clear enlist error

* cleared type errors

* remove eslint no unsafe memeber access

* no unsafe return eslint

* I have opened pandora box

* npm errors

* I am really lost

* Cleared some typescript errors, hopefully I can create the modal now

* added basic style and a plan

* modal show and hide functionality

Co-authored-by: wongwinnie198@gmail.com

* Revert "modal show and hide functionality"

This reverts commit 237e0b00c4.

* modal show and hide functionality

Co-authored-by: wongwinnie198 <wongwinnie198@gmail.com>

* clear type error

* interesting my first animation attempt failed

* removed the modal

* added color, it may be damaging accessiblity

* revert translation.json changes

* cleared unused types and type mistake I added before

* Revert key press naming changes

Co-authored-by: mmatsumoto1026 <mmatsumoto1026@gmail.com>

* changed hover effect to danger variables and fix change language hover

Co-authored-by: mmatsumoto1026 <mmatsumoto1026@gmail.com>

* add lang manu height to gerenic selector

* remove redundant code, make cansel change stay color stay blue

* Revert me mess around

* prettier format

* test cypress interaction and if it accounts for mobile design

* Revert "test cypress interaction and if it accounts for mobile design"

This reverts commit 9b01e78156.

* refactor search form

* add missing value units

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Bruce B <bbsmooth@gmail.com>
Co-authored-by: Moshe <shootermv@gmail.com>
Co-authored-by: wongwinnie198 <wongwinnie198@gmail.com>
Co-authored-by: mmatsumoto1026 <mmatsumoto1026@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-09-28 15:57:14 +02:00
Shaun Hamilton
79c232c586 fix(client): prevent sound on every render (#47640) 2022-09-28 15:15:49 +09:00
Oliver Eyton-Williams
a2790190b2 refactor: saving portfolio items (#47635) 2022-09-27 21:10:01 +05:30
Ilenia
8135980cbb fix: change keyword for code highlighting on forum (#47625) 2022-09-27 13:19:21 +05:30
abe
67217160f6 fix: allow user to add one unsaved item at a time (#47567)
Co-authored-by: kravmaguy <flex4lease@gmail.com>
2022-09-27 12:17:58 +05:30
Bruce Blaser
3394c8aad2 fix(a11y): improve keyboard accessibility in tablist (#45866)
* chore: resolve conflicts

* fix: focus outline on console pane

* refactor: focus indicator on console pane

* chore: remove commented code

* chore: resolve conflicts

* chore: add newline to end of file

* chore: fixed for prettier's sake
2022-09-23 22:00:20 +05:30
Shaun Hamilton
fba4d99ff4 fix(client): remove dedent to dedent forum posts (#47578) 2022-09-21 11:51:28 -07:00
Ilenia
7c96fee948 fix: forum post template correct html comment (#47529) 2022-09-16 09:36:06 -05:00
Oliver Eyton-Williams
15309a88d0 fix: update lower jaw on ctrl enter (#47463)
* fix: update jaw on all ctrl-enter presses

* fix: show running tests while hiding feedback

Screenreaders still announcing running tests and then the output, and
the display now stops showing a flash of the new feedback message

* refactor: camelCase

* refactor: clean up and reduce renders

previousHint isn't really state, insofar as it changing should not
trigger a new render - a ref does the trick.

* chore: remove log

* fix: use ref to track latest attempts prop

* fix: allow lower jaw to trigger viewzone updates

React.render's callback cannot be relied on. It does not necessarily
get called on every update to the rendered element.

updateContainer is called on every render, so the editor will be
updated.

* refactor: attemptsNumber -> attempts

* fix: do not render on attempt changes

* refactor: more camelCase

* fix: try to prevent previous hint rendering

Co-authored-by:
Manabu Matsumoto <mmatsumoto1026@gmail.com>

* test: resetting of lower jaw

* fix: reset lower jaw when step is reset

* test: check congrats message appears on completion

* fix: hide feedback after reset

* fix: leave focus in the editor after passing tests

This is an attempt to work around a JAWS issue whereby the submit
shortcut (ctrl+enter) is ignored after the user passes all tests.

* test: submit button receives focus when tests pass

* fix: focus submit button when tests pass

Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>

Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>
2022-09-15 12:44:06 -05:00
Sem Bauke
8c83a96e93 feat: volume slider campfire mode (#47259)
* feat: volume slider campire mode

* fix: set a play sound interval

* fix: set volume to 50% if there is no volume key

* fix: add correct colors to progress bar

* fix: remove IE support

* fix: get slide value working in Chrome

* fix: remove space

* fix: actually use volume in the editor

* fix: add aria-label

* fix: set volume if not present in store

* fix: use label instead

* Apply Naomi's review on Toms suggestion

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>

* fix: linting

* Update client/i18n/locales/english/translations.json

Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>

Co-authored-by: root <root@DESKTOP-EMNPVBP.localdomain>
Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>
2022-09-15 15:42:03 +03:00
Oliver Eyton-Williams
9355406aed refactor: add explanation of instruction width (#47504) 2022-09-12 13:42:56 -07:00
renovate[bot]
5ff719a4c8 fix(deps): update font awesome to v6.2.0 (#47443)
* fix(deps): update font awesome to v6.2.0

* fix: update snapshots

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2022-09-12 17:16:32 +05:30
kulraj chavda
acc966ac31 add visual separation in Change language menu UI (#47418)
add visual seperation in Change language menu UI
2022-09-08 13:16:27 +05:30
Manabu Matsumoto
145521b3d4 fix(UI): restore keyboard accessibility (#47427)
* fix: restore keyboard accessibility

* fix/ make code easier to maintain
2022-09-06 19:21:38 +02:00
Tom
c280e8a363 feat: add preview popout window (#46251)
* feat: add preview popout window

* fix: remove unused

* fix: add title to window

* fix: add preview to window title

* feat: it works

* chore: clean up

* chore: more clean up

* fix: add better screen reader messages
2022-09-04 13:15:54 +02:00
Sem Bauke
57695d7d88 feat: add lang code to iframe (#47365)
* feat: add lang code to iframe

* feat: apply Naomi's code review

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>

* fix: Iframe title test

* Apply suggestions from code review

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>

* fix: hopefully things make sense

* fix: steal sem's idea for DOMParser

* fix: make the solution work on the main frame

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2022-08-30 09:30:02 -07:00
Naomi Carrigan
406d47deb0 feat: add search link to help modal (#47385)
Co-authored-by: =?UTF-8?q?Lasse=20J=C3=B8rgensen?= <28780271+lasjorg@users.noreply.github.com>
2022-08-29 16:12:50 +02:00