Commit Graph

16 Commits

Author SHA1 Message Date
renovate[bot]
87e1ae21a5 chore: update TS and Fastify (#52157)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Sboonny <muhammedelruby@gmail.com>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2023-11-07 17:22:59 +05:30
Oliver Eyton-Williams
c772b9884a chore(deps): update Cypress to version 12 (#51622)
Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
2023-09-22 15:42:56 -05:00
Oliver Eyton-Williams
391fc2e34d refactor: create shared workspace (#51454) 2023-09-07 23:06:01 +05:30
Oliver Eyton-Williams
8d12376931 chore(cypress): speed up seeding when testing (#50825) 2023-06-29 23:18:10 +07:00
Naomi Carrigan
45082eea85 feat: better lang selector tests (#50294) 2023-05-06 02:36:20 +05:30
Naomi Carrigan
cf9972b362 feat(tools): add tests for language selector (#50284) 2023-05-05 10:54:14 +05:30
Muhammed Mustafa
f0aecf173d feat(client): expose the language button to the navbar (#50084)
* feat(client): expose the language button to the navbar

* clean extra logic

Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>

* show the language menu

* set keyboard navigation logic

* change the language icon

* sort float values

* fix the test

* remove the menu roles from the languagelist

Co-authored-by: Bruce B <bbsmooth@gmail.com>

* add id to button and polish the attributes

Co-authored-by: Co-authored-by: Bruce B <bbsmooth@gmail.com>

* revert to production focus events

Co-authored-by: Co-authored-by: Bruce B <bbsmooth@gmail.com>

* fix the menu not closing and fix the label

Co-authored-by: Co-authored-by: Bruce B <bbsmooth@gmail.com>

* make event passing more explicit

Co-authored-by: Co-authored-by: Bruce B <bbsmooth@gmail.com>

* Let screenreaders annouce that the expand is closed

Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>

* let screenreader annouce list is closed

Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>

* polish the logic around the styling

Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>

* add comment about accessiblity function

* oh right active doesn't work like that

* hide the menu if the click is outside it

Co-authored-by:  Bruce B <bbsmooth@gmail.com>

* fix the contrast in the check mark

Co-authored-by:  Bruce B <bbsmooth@gmail.com>

* Stop the menu closing when clicking on the searchbar

Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>

* make the list hover and focus consistent

Co-authored-by: Co-authored-by:  Bruce B <bbsmooth@gmail.com>

---------

Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>
Co-authored-by: Bruce B <bbsmooth@gmail.com>
2023-04-26 22:44:03 +02:00
Ahmad Abdolsaheb
d3396a2017 feat(client): expose nav donate button for non-donor (#49705)
Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>
2023-03-21 13:31:44 +05:30
Oliver Eyton-Williams
d7848ae01a feat: migrate to pnpm for better workspace DX (#49293)
* feat: npm -> pnpm 

This resolves the issues with the gatsby client (gatsby-plugin-pnpm
deals with the fact that gatsby is relying on its own dependencies
being de-duped)
and challenge-editor (which doesn't seem to want to automatically install
codemirror and needed its own eslint config)

* fix: correct mocha path for curriculum tests

* fix: use select workspace with -F not -w

* fix: reorganise packages and restrict hoisting

pnpm works best if the workspaces keep their own dependencies, since
dependencies are not flattened and then what node resolves from a
require is predictable.

@types seem to be a special case and more care is required to prevent
them getting smushed together in the root (hence the .npmrc)

* fix: add types for tools + root

* fix: decouple challenge-auditor from client

* fix: add ui-components types

* fix(client): use the latest types for react 16

* fix: prettify

* fix: prettierignore pnpm-lock

* fix: relax hoisting

Turns out pnpm works just fine with types. I don't know what was going
wrong before, but there are no-longer any type conflicts.

* fix: add @redux-saga/core to fix eslint issue

It seems to only be redux-saga that import/named can't cope with, so it
is probably okay to work around this one.

* chore: add chai to tools/scripts/build

* fix: add store to root for cypress

* fix: allow cypress to download binaries

If we want to keep preventing cypress from downloading binaries, we can
figure out a workaround, but I'm allowing it to ease the transition to
pnpm.

My guess about why this is happening is that npm triggers Cypress's
postinstall script, but pnpm does not (because pnpm install only
installs if necessary, perferring to link)

* chore: re-enable pre/post scripts

* fix: update build scripts for client

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* chore: update engines to use pnpm


* fix: enable choice of (super)block for tests

Only 'nix machines for now.

* chore: pin pnpm to version 7

* chore: remove last npms

Except web + curriculum-server. I'll update them when I start work on
them again.

* fix: lockfile check to catch any package-locks

* fix(action): install pnpm for upcoming tests

* chore: add nodemon to new api

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2023-03-02 18:17:44 +00:00
a2937
1cc6c55469 Chore : Migrate universal-navigation.js (#49337) 2023-02-11 07:57:47 +00:00
Ahmad Abdolsaheb
a73996c174 Revert "fix(client): expose donate button on navigation bar" (#48902)
Revert "fix(client): expose donate button on navigation bar (#48820)"

This reverts commit 959d667aeb.
2023-01-03 18:26:15 +05:30
Ahmad Abdolsaheb
959d667aeb fix(client): expose donate button on navigation bar (#48820)
* feat: expose donate nav button

* feat: add the ignores

* fix: adjust tests

* feat: adjust nav button styles
2023-01-03 10:40:47 +01:00
Mrugesh Mohapatra
75f4ff10d5 feat(client): add a confirmation modal on signout (#48385)
* feat(client): add a confirmation modal on signout

* test: add and update universal nav

* chore: remove extraneous action

* chore: apply suggestions from code review
2022-11-04 10:31:06 +01:00
Mrugesh Mohapatra
b393d88b9e refactor: s/all-langs/i18n/g (#48258) 2022-10-26 10:08:27 -07:00
Sawjan Gurung
7f1b136e40 test(e2e): add tests for navigating Menu with keyboard (#47791) 2022-10-21 22:51:43 +05:30
Niraj Nandish
0214eb2488 feat: cypress 10 (#47886)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-10-11 18:40:25 +05:30