Commit Graph

887 Commits

Author SHA1 Message Date
Muhammed Mustafa
06fe9b6d16 refactor(client): stop the homepage image from changing the layout (#49476)
refactor(client): stop the homepage from changing the the layout
2023-02-23 14:53:53 +05:30
Muhammed Mustafa
0971b6a8a3 refactor(client): remove react lazy loader library (#49468)
* feat(client): remove react lazy loader library

* fix: use loading='lazy' to defer loading
2023-02-22 18:05:08 +01:00
Muhammed Mustafa
f56816d3e1 refactor(client): fix types in the nav-links file (#49291)
* refactor(client): clean some mistype errors in the nav-links file

* fix showLanguage prop type in the other files

* add-ts-ignore-comment

* swap to map for easier maintainablity

* Change the eslint naming comment

* fix: using the wrong handlekeydown function

Co-authored-by: Bruce B <bbsmooth@gmail.com>

* hide the menu when focus is on the userimage

* hide the menu only if camper didn't press shift key

---------

Co-authored-by: Bruce B <bbsmooth@gmail.com>
2023-02-22 05:36:05 +02:00
Jeff
9f1562291c fix: remove unused className spacer from spacer helper (#49067)
* fix: remove unused className spacer from spacer helper

---------

Co-authored-by: jeff <jeff@vpmbp4.local>
2023-02-21 19:20:29 +05:30
Muhammed Mustafa
181e108418 fix(client): submit button size for external projects (#49448) 2023-02-21 07:40:56 +01:00
Shaun Hamilton
e8b010d7e2 fix(client): selector return, invalid prop val (#49447)
* fix(client): correctly return type from selector

* fix(client): remove incorrect prop [button-spacer]
2023-02-20 21:34:34 +02:00
Muhammed Mustafa
e5bf2ae97e feat(client): make skip to content button translatable (#49439) 2023-02-20 21:22:39 +05:30
Muhammed Mustafa
85e9fbb8df refactor(client): clean extra component and extra unneeded imports (#49391)
* feat: remove extra unnecessary code

* clean the unique way that component was handled

* make bsSize optional

* update snapshot to account for the other button styles

* add comment for our future selves

* clean the changes file
2023-02-19 17:16:53 +05:30
Ahmad Abdolsaheb
13aad8ca37 feat(client): move the block donation modal logic to an epic. (#49381)
feat(client): move percent calculation logic to epic
2023-02-19 09:04:04 +02:00
Muhammed Mustafa
e8f0145a08 feat(client) make pre in instruction ltr when the layout is rtl (#49431)
* feat(client) make pre in instruction ltr when the layout is rtl

* revert the changes in the markdown file
2023-02-18 22:00:44 +01:00
Muhammed Mustafa
45dc6aee9e feat(client): make portfolio section in profile support RTL layout (#49148)
* feat(client): make portfolio section in profile support RTL layout

* Revert "feat(client): make portfolio section in profile support RTL layout"

This reverts commit b4cf5f1ab4.

* make media component responsive

* fix the selector

* hook the media left through an id

* hook the media left through an id
2023-02-18 21:58:01 +01:00
Muhammed Mustafa
251aecc58f feat(client): change the save buttons from disabled to aria-disabled (#49216)
* feat(client): change the buttons from disabled to aria-disabled

Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>

* stop the API call when the validation isn't true

* use aria disabled instead of disabled on the test?

* use have.attr  to check for aria disabled

* hide the button when it's disabled

Co-authored-by: Bruce B <bbsmooth@gmail.com>

* update Privacy Settings save button

---------

Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>
2023-02-18 12:16:35 -08:00
Muhammed Mustafa
c027bce6de fix(client): pre code having extra spaces when code elements are stacked (#49343)
Co-authored-by: hbar1st <hanaab@gmail.com>
2023-02-18 10:18:54 -08:00
Muhammed Mustafa
4f357db02f refactor(client): clean extra code in donate form (#49276) 2023-02-17 17:32:41 +03:00
Tom
c29ecaf14f fix(client): site crashing when leaving rdb challenge (#49409)
fix: crashing when leaving rdb
2023-02-17 07:56:28 +02:00
Muhammed Mustafa
150d5cb0d3 feat(client): remove ltr direction from quotes in rtl layout (#49340) 2023-02-16 13:50:35 +01:00
Muhammed Mustafa
5e4ba38309 refactor(client): delete block save wrapper (#49217)
* refactor(client): delete block save wrapper

* Clean bloating divs and extra css import

* remove the blocksave wrapper snapshot
2023-02-13 23:26:44 +05:30
Oliver Eyton-Williams
4ff00922da refactor: fix hidden eslint errors (#49365)
* refactor: explicit types for validate

* refactor: explicit return types for ui-components

* refactor: use exec instead of match

* refactor: add lots more boundary types

* refactor: more eslint warnings

* refactor: more explicit exports

* refactor: more explicit types

* refactor: even more explicit types

* fix: relax type contrainsts for superblock-order

* refactor: final boundaries

* refactor: avoid using 'object' type

* fix: use named import for captureException

This uses TypeScript (which works) instead of import/namespace
(which doesn't) to check if captureException exists in sentry/gatsby
(it does)
2023-02-13 07:13:50 -08:00
renovate[bot]
ea7df4fb9a fix(deps): update font awesome to v6.3.0 (#49357)
* fix(deps): update font awesome to v6.3.0

* update profile snapshot for the new icon

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Sboonny <muhammed@freecodecamp.org>
2023-02-13 11:23:33 +00:00
Muhammed Mustafa
a1ebe6dcd6 refactor(client): turn image validation component into subComponent (#49155)
* refactor(client): clean extra FormGroup component in personal info

* Revert "refactor(client): clean extra FormGroup component in personal info"

This reverts commit cc29df3033.

* refactor show image component into JSX

* Remove redundant text

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>

---------

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2023-02-10 17:13:27 +00:00
Ahmad Abdolsaheb
6e53c852de feat(client): pull percentage challenge data from redux (#49308)
* feat(client): pull percentage challenge data from redux

* Apply suggestions from code review

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* feat: update updateAllChallengesInfo name

---------

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2023-02-10 13:16:11 +00:00
Mrugesh Mohapatra
96a5699c39 chore: rename icons (#49319) 2023-02-10 13:11:16 +00:00
Mrugesh Mohapatra
eff2166262 chore: rename redux actions (#49320) 2023-02-10 12:04:17 +00:00
Muhammed Mustafa
77c8809b00 refactor(client): cleanup honesty policy section (#49003)
Co-authored-by: Bruce B <bbsmooth@gmail.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: sidemt <25644062+sidemt@users.noreply.github.com>
Co-authored-by: Mrugesh Mohapatra <hi@mrugesh.dev>
Co-authored-by: Quincy Larson <QuincyLarson@users.noreply.github.com>
2023-02-09 13:37:22 -06:00
Ahmad Abdolsaheb
6c97591ca6 feat(client): turn default layout to a functional component (#49289) 2023-02-08 15:28:26 -06:00
Muhammed Mustafa
a1380b2873 feat(client): make the console RTL (#49210)
feat(client): make the console.log RTL

Co-authored-by: hbar1st hanaab@gmail.com
2023-02-02 20:20:49 +05:30
Muhammed Mustafa
f62f04989b feat(client): change the delete email to support email (#49159)
Co-authored-by: Quincy Larson <QuincyLarson@users.noreply.github.com>
2023-01-27 13:16:29 +03:00
YMatsuda
ca91d93d7e fix(client): use translated cert name for Legacy Full Stack Certification (#49145)
fix(client): use translated cert name
2023-01-26 11:04:52 -08:00
Bruce Blaser
849e2c041d fix(a11y): Save buttons on Settings page (#49142)
* fix: make save buttons more accessible for screen reader users

* fix: associate username input with label
2023-01-26 19:28:01 +02:00
Muhammed Mustafa
57317a4a32 feat(client): full width component to carry key prop (#49082)
* feat(client): allow full width to carry key props

* fix: setting can't render the element error

* Remove the key prop from FullWidthRow

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* remove key form fullwidth

* Remove undefined type from children

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* add key to renderProfile

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2023-01-26 08:20:28 +01:00
Muhammed Mustafa
af5c610511 fix(client) broken donate button text alignment in RTL layout (#49123)
fix(client) broken donate button text alignment
2023-01-25 19:05:28 +05:30
Atir Nayab
0bcc611b91 feat(client): add jest snapshot for settings button and certification… (#48751)
* feat(client): add jest snapshot for settings button and certification page consistency

* feat(client): setting buttons consistency snapshot done

* feat(client): jest snapshot check consistency of ceritification page

* fix: snapshot test updated and mocking date fn

* fix(client): settings button snapshot updated

* fix(client): settings button snapshot updated

* fix(client): settings button snapshot updated

* fix(client): settings button snapshot updated

* fix(client): certification and timeline test updated as per feedback

* fix(Client): changed mock file name to kebab case

* fix(client): changed timeline and settings button tests directory

* fix(client): completedChallenge.js file removed

* fix(client): settings-button and timeline-buttons test dir updated

* fix(client): removed autogenerated lines from tsconfig.json

* fix: reverted settings-button and timeline-button test to js

* fix: settings-button and timeline-buttons test cleanup

* fix: settings-button test updated

Co-authored-by: Atir <atir@codebuddy.co>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2023-01-25 19:02:54 +05:30
Muhammed Mustafa
95c24d901f feat(client): remove bloating CSS from RTL file (#49122) 2023-01-25 19:01:41 +05:30
Muhammed Mustafa
f95a6261ba refactor(client): move margin and padding to inline values (#49100) 2023-01-23 21:17:12 +00:00
Muhammed Mustafa
0bfa2902dc refactor(client): cleanup right section of breadcrumbs (#49102)
* refactor(client): remove extra code with right section of breadcrumbs

* refactor: the breadcrumbs selectors for readiablity

* clear more extra css code

* clean change log

* Clean change log
2023-01-23 11:34:13 -06:00
Muhammed Mustafa
c0c0ed71da refactor(client): clear extra div around the delete and reset panel (#49083)
refactor(client): clear extra div
2023-01-23 20:41:57 +05:30
Muhammed Mustafa
4e093f2c28 feat(client): fix the position of flash message (#48911)
* feat(client): fix the position of flash message

* WIP: move the alert message to header

* fix: cypress

* remove the spacing effect

* Revert "WIP: move the alert message to header"

This reverts commit f5242d261a.

* feat: new feature!

* Revert "feat: new feature!"

This reverts commit f6c403cc80.

* Revert "fix: cypress"

This reverts commit c24c1d8440.

* feat: add reverted cypress test

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>

* center the close alert button

Co-authored-by: Sanjeev <sanjeevranjan.singh08@gmail.com>

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
Co-authored-by: Sanjeev <sanjeevranjan.singh08@gmail.com>
2023-01-23 15:36:22 +01:00
Bruce Blaser
9a0d26fd64 fix: add personal information heading (#49060) 2023-01-19 14:28:17 +01:00
Muhammed Mustafa
46d4591803 fix(client): wrong position of search bar components in RTL (#48905)
* fix(client/RTL) searchbar result and reset icon positions

* fix: menu alignment and icons rotation

* Align search hits to the right

* account for scroll bar

* Clear float property position searchbar to the right

* Make the media condition similar

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>
2023-01-11 18:57:22 +02:00
Muhammed Mustafa
1d1ab78957 feat(client): increase the line height in RTL (#48960)
feat(client): increate the line height in RTL

Co-authored-by: hbar1st <hanaab@gmail.com>

Co-authored-by: hbar1st <hanaab@gmail.com>
2023-01-10 15:49:24 +01:00
Manabu Matsumoto
4aa3b4d6ad fix(UI): refactor the searchbar from flex to grid (#48944)
* fix: refactor the searchbar from flex to grid

* fix: refactor the way of displaying searchbar input outline

* chore: remove unnecessary border settings

* fix: follow the RTL support best practice

* fix: follow the RTL support best practice

* fix: remove unnecessary grid gap and refactor for RTL

* fix: refactor the padding setting with padding block

Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>

* fix: refactor the padding setting with padding inline

Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>

* fix: refactor the positioning of reset button in searchbar

Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>
2023-01-10 16:19:55 +09:00
Ahmad Abdolsaheb
8b5838ef23 fix(client): GA to GTM Migration (#48811) 2023-01-07 11:36:45 +05:30
Oliver Eyton-Williams
0a20f8fd73 refactor: remove a lot of unused code (#48935)
Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
2023-01-07 10:33:35 +05:30
Bruce Blaser
2b2360d77f fix(a11y): accessible names for cert buttons/links in Settings (#48890) 2023-01-07 06:39:45 +02:00
YMatsuda
95aba7810b fix(i18n,client): translate view certificate button (#48949)
fix(i18n): translate view certificate button
2023-01-06 20:33:45 -08:00
Mrugesh Mohapatra
f2fcfe593d fix(client): add message to loader (#48934)
Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2023-01-06 19:03:52 -08:00
Bruce Blaser
f995809dd4 fix(a11y): donation faq (#48941)
* fix: headings for faq titles

* fix: add aria-expanded

* fix: header font
2023-01-06 08:25:18 +02:00
Mrugesh Mohapatra
3cc8e0485c revert(client): improve alert component (#48921)
Revert "fix(client): Improve alert component (#48861)"

This reverts commit 17b880020d.
2023-01-04 17:32:03 +05:30
Ahmad Abdolsaheb
a73996c174 Revert "fix(client): expose donate button on navigation bar" (#48902)
Revert "fix(client): expose donate button on navigation bar (#48820)"

This reverts commit 959d667aeb.
2023-01-03 18:26:15 +05:30
Ahmad Abdolsaheb
959d667aeb fix(client): expose donate button on navigation bar (#48820)
* feat: expose donate nav button

* feat: add the ignores

* fix: adjust tests

* feat: adjust nav button styles
2023-01-03 10:40:47 +01:00