Commit Graph

9 Commits

Author SHA1 Message Date
Oliver Eyton-Williams
4ff00922da refactor: fix hidden eslint errors (#49365)
* refactor: explicit types for validate

* refactor: explicit return types for ui-components

* refactor: use exec instead of match

* refactor: add lots more boundary types

* refactor: more eslint warnings

* refactor: more explicit exports

* refactor: more explicit types

* refactor: even more explicit types

* fix: relax type contrainsts for superblock-order

* refactor: final boundaries

* refactor: avoid using 'object' type

* fix: use named import for captureException

This uses TypeScript (which works) instead of import/namespace
(which doesn't) to check if captureException exists in sentry/gatsby
(it does)
2023-02-13 07:13:50 -08:00
Bruce Blaser
2b2360d77f fix(a11y): accessible names for cert buttons/links in Settings (#48890) 2023-01-07 06:39:45 +02:00
Atir Nayab
0a0be525b2 fix(bug): Make table and button consistent in settings and certification page. (#48211)
* fix(bug): Make table and button consistent

Affected page
- certification page
- settings page

* fix(bug): changed certification button text to View

* fix(bug): Timeline table width increased

* Update client/src/client-only-routes/show-project-links.tsx

Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>

* Update client/src/client-only-routes/show-project-links.tsx

Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>

* fix(curriculum): remoeve stripe props from certification table

* fix(curriculum): time line table width reverted to original

* fix(client): use buttons.view from translation.json

* fix(client): use normal font weight for project title

* fix(client): certification page table button

* fix(client): remove child anchor tag from menuItem

* fix(client): updated cerification page button width

* feat: relocate the styles

* feat: clean up styles

Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>
Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com>
2022-12-09 12:08:52 +02:00
Atir Nayab
f92a851a0a feat(client): add icon in setting page button (#48268) 2022-10-27 20:06:47 +05:30
Prince Mendiratta
314f0e4ba6 fix: separate string to view code/project (#47890)
* fix: separate string to view code/project

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

* feat: add test for certification rendering

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

* chore(lint): trailing newline at EOF

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>
2022-10-08 10:11:21 +02:00
Hdanzo
c4f7e45832 feat: standardize view button text (#47525)
* feat: standardize view button text

Add new translation keys Delete unused translation keys Fix tests broken with new functionalities

* Delete View variations in translations.json
Delete buttons tittle
Modify buttons text to be "View" or translated equivalent
Modify tests to query the buttons by role and name

Co-authored-by: HDAnzo <hdanzoategui@softwarenatura.com>
2022-09-30 10:39:33 +03:00
Muhammed Mustafa
e7d7702e25 fix(client-UI): view button takes full width (#45964)
* added class to td so it takes full width

* added width 100% to dropbox components

* removed excessive code

* limit the max space dropdown takes

* `view` takes the same size as `show-solution`

* undo previous change

* view takes the same size as show-solution

* fix: static width for buttons on small screen

* fix: remove max-width cause iocd

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2022-06-06 08:43:48 +02:00
Oliver Eyton-Williams
c11bd163b2 feat: display multifile projects (#45220)
* refactor: DRY up certification and ProjectModal

* fix: use sensible keys for SolutionViewer

* refactor: handle legacy solutions like new ones

* refactor: correct CompletedChallenge type

* fix: store challengeType for multifile projects

* fix: use challengeType to set display type

* feat: use dropdown to display project + code

* refactor: isOpen -> showCode to avoid a clash

We need to be able both show the code and show the completed project

* refactor: remove redundant parts of projectPreview

* refactor: fix project preview types

* feat: wip, using existing modal to show project

* feat: show projects on timeline

* feat: display projects on time-line

* chore: use consistent case for GitHub

* fix(a11y): translate show solution/view

* refactor: rename showFilesSolution

* refactor: use self-closing tag

* fix: remove hardcoding (certification + timeline)

* fix: remove hardcoding (settings)

* test: supply store and mock ga

* fix: include challengeType for projects

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* refactor: remove space

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: key -> filekey on challenge submission

* fix: handle submissions without files

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2022-03-02 19:49:54 -06:00
Oliver Eyton-Williams
b223cdd255 refactor: display solutions (#45139)
* refactor: re-organise show-project-links

* refactor: update ChallengeFile's declared shape

* fix: handle missing challenge solution

* refactor: use display function for Certification

* refactor: use display function for TimeLine

* refactor: use common component for timeline + cert

* fix: handle legacy solutions

* refactor: use widget for certifications

* refactor: reorganise ShowDisplayWidget

* refactor: remove unused ids

* test: pass dataCy, not projectTitle, to widget

* chore: kebabify

* revert: add id back for dropdown

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* revert: add the ids back

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2022-02-16 13:48:22 -08:00