Commit Graph

800 Commits

Author SHA1 Message Date
Shaun Hamilton
73c3edb56a fix: certification to private on private timeline (#45562)
Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-09-29 00:00:22 +05:30
Muhammed Mustafa
afb861be9d fix(client): making misclicking sign out harder (#46644)
* added hover and focus effect on signout

* increase spacing by increasing the height

* I remembered why I hated react so much

* will come back after the meeting

* cleared 10 types error

* fix: make lang menu more keyboard accessible

* increased button specificity and switch to navlink to focus better

* added className for future style when the fuction is functional

* this is funny

* slowly comming together

* will create the function tomorrow morning

* signout is read only bug

* Removed the need for enlist

* Update client/src/components/Header/components/nav-links.tsx

* Update client/src/components/Header/components/nav-links.tsx

* Props fails, I am removing enlist errors and implementing types

* Update client/src/components/Header/components/nav-links.tsx

Co-authored-by: Moshe <shootermv@gmail.com>

* half of eslint no unsafe call

* No issue without this eslint as well

* Couldn't fix enlist issue

* same error

* Removed eslint error

* no-unsafe-member enlist error

* Clear enlist error

* cleared type errors

* remove eslint no unsafe memeber access

* no unsafe return eslint

* I have opened pandora box

* npm errors

* I am really lost

* Cleared some typescript errors, hopefully I can create the modal now

* added basic style and a plan

* modal show and hide functionality

Co-authored-by: wongwinnie198@gmail.com

* Revert "modal show and hide functionality"

This reverts commit 237e0b00c4.

* modal show and hide functionality

Co-authored-by: wongwinnie198 <wongwinnie198@gmail.com>

* clear type error

* interesting my first animation attempt failed

* removed the modal

* added color, it may be damaging accessiblity

* revert translation.json changes

* cleared unused types and type mistake I added before

* Revert key press naming changes

Co-authored-by: mmatsumoto1026 <mmatsumoto1026@gmail.com>

* changed hover effect to danger variables and fix change language hover

Co-authored-by: mmatsumoto1026 <mmatsumoto1026@gmail.com>

* add lang manu height to gerenic selector

* remove redundant code, make cansel change stay color stay blue

* Revert me mess around

* prettier format

* test cypress interaction and if it accounts for mobile design

* Revert "test cypress interaction and if it accounts for mobile design"

This reverts commit 9b01e78156.

* refactor search form

* add missing value units

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Bruce B <bbsmooth@gmail.com>
Co-authored-by: Moshe <shootermv@gmail.com>
Co-authored-by: wongwinnie198 <wongwinnie198@gmail.com>
Co-authored-by: mmatsumoto1026 <mmatsumoto1026@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-09-28 15:57:14 +02:00
Shaun Hamilton
79c232c586 fix(client): prevent sound on every render (#47640) 2022-09-28 15:15:49 +09:00
Oliver Eyton-Williams
a2790190b2 refactor: saving portfolio items (#47635) 2022-09-27 21:10:01 +05:30
abe
67217160f6 fix: allow user to add one unsaved item at a time (#47567)
Co-authored-by: kravmaguy <flex4lease@gmail.com>
2022-09-27 12:17:58 +05:30
Sem Bauke
8c83a96e93 feat: volume slider campfire mode (#47259)
* feat: volume slider campire mode

* fix: set a play sound interval

* fix: set volume to 50% if there is no volume key

* fix: add correct colors to progress bar

* fix: remove IE support

* fix: get slide value working in Chrome

* fix: remove space

* fix: actually use volume in the editor

* fix: add aria-label

* fix: set volume if not present in store

* fix: use label instead

* Apply Naomi's review on Toms suggestion

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>

* fix: linting

* Update client/i18n/locales/english/translations.json

Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>

Co-authored-by: root <root@DESKTOP-EMNPVBP.localdomain>
Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>
2022-09-15 15:42:03 +03:00
renovate[bot]
5ff719a4c8 fix(deps): update font awesome to v6.2.0 (#47443)
* fix(deps): update font awesome to v6.2.0

* fix: update snapshots

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2022-09-12 17:16:32 +05:30
kulraj chavda
acc966ac31 add visual separation in Change language menu UI (#47418)
add visual seperation in Change language menu UI
2022-09-08 13:16:27 +05:30
Manabu Matsumoto
145521b3d4 fix(UI): restore keyboard accessibility (#47427)
* fix: restore keyboard accessibility

* fix/ make code easier to maintain
2022-09-06 19:21:38 +02:00
Naomi Carrigan
5e402e6955 feat: allow languages to be hidden (#47362) 2022-08-23 20:53:47 +02:00
Tom
136f60bbef feat: move rdb order to middle of superblocks (#46138)
feat: move rdb out of beta
2022-08-10 18:48:39 +02:00
Naomi Carrigan
836ccb79b1 chore: resolve type coercion todo comment (#47036) 2022-07-28 09:18:08 +02:00
Bruce Blaser
0345244c43 fix(a11y): change headings in footer to h2 (#46932)
fix: change headings in footer to h2
2022-07-17 09:59:15 -07:00
renovate[bot]
f6f252eba8 chore(deps): update dependency eslint-plugin-react to v7.30.1 (#46664)
* chore(deps): update dependency eslint-plugin-react to v7.30.1

* fix: prettier

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2022-07-14 21:07:56 +05:30
Moshe
8d4d4d79e8 fix(ui): "sign in" button hidden at small devices (#46561)
* fix(UI): missing sign-in button at small devices

* feat: replace menu and sign-in buttons text with images

* refactor: svg icons replaced by fortawesome ones

* test: fix e2e test of navigation menu button

* feat: display sign in button and hide all

* feat: display sign in icon on nav for small screens

* feat: add accessibility span for menu icon

* fix: lint errors

Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com>
2022-07-12 08:15:52 -05:00
Oliver Eyton-Williams
9046d70b67 fix: use certification hours consistently (#46442)
* fix: use certification hours consistently

Since the value appearing on the /learn map was hardcoded, it could have
gone out of sync with the certifications, which were relying on
certification-settings.

Also, for simplicity (and because it's hard to estimate accurately), all
the certifications are set to 300 hours.  Fullstack being the exception,
as it is a set of certifications.

* feat: remove the hours from the map
2022-06-23 14:24:33 +03:00
Muhammed Mustafa
e7d7702e25 fix(client-UI): view button takes full width (#45964)
* added class to td so it takes full width

* added width 100% to dropbox components

* removed excessive code

* limit the max space dropdown takes

* `view` takes the same size as `show-solution`

* undo previous change

* view takes the same size as show-solution

* fix: static width for buttons on small screen

* fix: remove max-width cause iocd

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2022-06-06 08:43:48 +02:00
Radi Totev
e581bd9081 feat(client): shortcuts legend modal available on pressing the ? key (#45530)
* Add modal texts in translations.json file

* Add shortcuts modal state in redux

* Create shortcuts modal

* Integrate shortcuts modal

* Resolve codefactor.io issues

* Extend list of shortcuts

Based on this comment:
https://github.com/freeCodeCamp/freeCodeCamp/issues/36841#issuecomment-933310078

* Remove temporary placeholder for modal title

* Open modal fom Hotkeys instead of learn.tsx

As suggested in this comment:
https://github.com/freeCodeCamp/freeCodeCamp/pull/45530#issuecomment-1101224993

* Complete list in transaltions

* Change shortcut presentation fo better a11y

Use table instead of list items as suggestedin this comment:
https://github.com/freeCodeCamp/freeCodeCamp/pull/45530#issuecomment-1101796368

* Add aria-labelledby

* Remove GAnalytics

* Remove leftover style

* Remove table caption

* autofocus on modal close button

* Improve modal a11y

- Add requested changes from https://github.com/freeCodeCamp/freeCodeCamp/pull/45530#issuecomment-1104764766
- Leave autofocus and parent div role=dialog changes for later. (https://github.com/freeCodeCamp/freeCodeCamp/pull/45530#issuecomment-1107754148)

* [WIP] Alllow users to turn off keyboard shortcuts

* Add keyboard shortcuts switch in settings

* Disable shortcuts

* Remove toggle switch description

* Refactor and cleanup

* Remove close button from modal header

Suggested by bbsmooth:
https://github.com/freeCodeCamp/freeCodeCamp/pull/45530#issuecomment-1107861091

* Fix lint issues

* Disable shortcuts

* Disable shortcuts by default

* Update challenge output test

* Update challenge-hot-keys test

* Disable shortcuts from inside handlers

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2022-06-03 09:57:52 -07:00
Oliver Eyton-Williams
f55a4c48db test: tighten up two more cypress tests (#46273)
* test: tighten up user-token

This should be faster and a little more reliable.  before should have
worked, but beforeEach seems more reliable, so I'm trying it.

* test: use a single test for intro-page

Should be more robust as well as a lot faster.
2022-06-03 11:44:20 +03:00
Ahmad Abdolsaheb
aead146554 feat(client): center login button (#46287)
* feat(client): center login button

* feat: remove unused file
2022-06-02 17:34:29 +03:00
Shaun Hamilton
b2da57881c chore(client): remove console log (#46275) 2022-06-01 20:16:45 +02:00
Bruce Blaser
d2332093f6 fix(a11y): main menu a11y updates (#45137)
* fix: main menu a11y updates

* update font menu

* fix: sign in button text alignment

* fix: disabled button font

* fix: language menu font

* remove sign-in from main menu

* fix: add section dividers to menu

* fix: height on language selector menu

* fix: alignment of Menu button text

* fix: language globe icon

* refactor: remove dup selector

* update language menu colors

* refactor: clearer name for language menu display state

* fix: don't close onBlur if Menu button is clicked

* refactor: move globe icon styling to CSS

* refactor: get rid of switch statements

* refactor: remove try catch block

* fix: translate Change language button

* fix: move search into nav menu for mobile layout

* fix: forgot a merge

* refactor: updates for changes in i18n/all-langs

* fix: prevent menu from collapsing when focus is on change language button and user clicks into search

* fix: translate cancel change option in language picker

* feat: add cypress tests

* feat: display the complete language list

* fix: fix TS typing

* fix: force scrollbar on lang menu

* fix: remove scroll bar from lang menu

* fix: close menu when user tabs away from last menu item

* add list role to navigation list to appease Safari

* chore: capitalize Change Language/remove CSS comment

* fix: right side search box alignment in narrow view

* remove extraneous list role

* fix: cypress

Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com>
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2022-06-01 10:39:26 +03:00
Oliver Eyton-Williams
ed865269a6 test: fix donate page for existing donors (#46255) 2022-05-31 23:06:35 +01:00
Jordan Moore
5f7d87daf0 feat: add project name on timeline for challenges completed RWD (#46181) 2022-05-28 10:45:03 +05:30
Kristofer Koishigawa
739ee60995 fix: display certs on profile for username with upper chars (#46118) 2022-05-26 15:03:49 +05:30
Sem Bauke
cef1ef1db7 fix: update settings in batch (#46040)
* fix: update settings in batch

* fix: make buttons update

* fix: tests (hopefully)

* fix: cypress promise error

* fix: use submit instead of onclick

Co-authored-by: Niraj Nandish <nirajnandish@icloud.com>
2022-05-18 17:54:50 +03:00
Muhammed Mustafa
ac027b0447 fix(client): added .text-center to modal title (#46022) 2022-05-18 02:08:32 +05:30
Shaun Hamilton
bcbbf8ace4 chore(client): reorder and rename rwd changes (#45972)
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2022-05-16 19:40:18 +05:30
Ekansh Baweja
0dd9fc8d4f fix(client): Code solution modal on timeline (#45953) 2022-05-14 10:03:23 +05:30
Hassaan Pasha
fadd2b1d13 fix: code duplication in tests for create-language-redirect (#45925) 2022-05-12 20:13:40 +05:30
Abdelmalek Ennani
d1fe6b3eaf fix(client): remove unexpected duplicate "height" (#45911)
I deleted an Unexpected duplicate "height" property
2022-05-12 11:13:21 +05:30
Muhammed Mustafa
8da87f4d58 fix(client): duplicates and zero length units (#45909)
Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
2022-05-11 11:20:39 -07:00
ned-park
6fded30b51 fix(client): remove unneeded explicit padding-bottom (#45910) 2022-05-11 10:47:14 +05:30
Benjamin Rio
1457c362c1 fix(client): remove duplicate css properties (#45902) 2022-05-10 10:03:53 -05:00
Tahseen Islam
7ab15bd4ce fix(client): remove duplicate css properties (#45889) 2022-05-09 08:57:45 +02:00
Ahmad Abdolsaheb
0ef633c373 feat: a/b test lock icon button (#45868) 2022-05-06 15:06:48 +02:00
Sem Bauke
0895925520 chore: certification test to TypeScript (#45847)
* chore: cerfication test to TypeScript

* fix: add types
2022-05-03 15:51:04 +02:00
Sem Bauke
c3be968092 feat: migrate locale test to ts v2 (#45793)
* feat: migrate locale test to ts v2

* fix: langCodes

* fix: locale test

* fix: nav dropdown

* fix: header test

* fix: use type predicates

* refactor: DRY up all-langs

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-05-02 17:53:30 +02:00
Matheus Pormanhani
888c9ca75e chore: migrate client/components/formHelpers/Form.test.js to TS (#45726) 2022-04-20 14:37:54 +02:00
Bruce B
361a21e29f fix: remove alt text from icons (#45730) 2022-04-20 08:38:34 +02:00
Oliver Eyton-Williams
1017738090 fix: encode image urls (#45722) 2022-04-19 08:06:33 -07:00
Naomi Carrigan
58235a42c6 fix(a11y): wcag contrast issue on search icon (#45716)
* fix: hack the colours

* Revert "fix: hack the colours"

This reverts commit bd60d44c84.

* fix: global sr-only approach

* fix: motivation author colour
2022-04-18 22:47:48 -07:00
Matheus Pormanhani
be29e37a69 chore: typescript migration of components/settings/Honesty.test.js (#45713)
* chore: renamed file to .tsx

* chore: migrate components/settings/Honesty.test.js to .tsx

* fix: update Honesty.test.tsx snapshot
2022-04-18 09:03:44 -07:00
Tom
e0a5fcdb8e fix: add message about third-party cookies (#45672) 2022-04-13 20:56:16 +05:30
Ahmad Abdolsaheb
4034c59ba2 feat(client): add secure donation border to donation form (#45637)
* feat: add secure donation border to donation form

* feat: add string to translations

* Apply suggestions from code review

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* feat: cleanup and reorder logic

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-04-07 13:24:42 +01:00
Tiffanie Alcaide
5b0250241a chore(client): migrate i18n/configForTest.js to TS (#45624) 2022-04-04 19:44:17 +00:00
Bruce B
31cbbc3501 fix: update light theme code example color contrast ratios (#45603) 2022-04-04 16:27:38 +03:00
Tom
3d242179b2 fix: make crtl+s save to appropriate location (#45406)
* fix: crtl+s for multifile cert projects

* fix: remove unused code

* feat: add limit on save frequency
2022-04-04 15:32:43 +03:00
Tom
9f753a5662 feat: let users save cert project code to db (#44700)
* feat: let users save cert project code to db

fix: move getChallenges call out of request function so it only runs once

fix: use FlashMessages enum

fix: transform challengeFiles earlier

test: make tribute page use multifile editor

stuff I was playing with - revert this to get it to a working state

refactor: allow undefined editableRegionBoundaries

fix: save history

history is not necessarily ["name.ext"] and using the incorrect history
could cause weird bugs

fix: replace files -> challengeFiles on the client

refactor: DRY out ajax

fix: use file -> challengefile map

refactor: rename ajax types

fix: alphatize flash-messages.ts

revert: tribute page project

fix: remove logs

fix: prettier

fix: cypress

fix: prettier

fix: remove submitComplete action

fix: block UI for new projects

fix: handle code size

* fix: catch undefined files

* fix: don't default to undefined when it's already the default

* fix: only update savedChallenges if applicable

* fix: dehumidify backend + fine tune nearby stuff

* fix: prop-types

* fix: dehumidify sagas

* fix: variable name

* fix: types

* Apply suggestions from code review

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: typo

* fix: prettier

* fix: props types

* fix: flash messages

* Update client/src/utils/challenge-request-helpers.ts

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* chore: rename function uniformize -> standardize

* fix: flash message

* fix: add link to forum on flash messages

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-03-31 10:34:40 -05:00
renovate[bot]
6fc99192f4 fix(deps): update font awesome (#45479)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com>
2022-03-25 18:23:45 +05:30