Commit Graph

2066 Commits

Author SHA1 Message Date
Ilenia
7c96fee948 fix: forum post template correct html comment (#47529) 2022-09-16 09:36:06 -05:00
Oliver Eyton-Williams
15309a88d0 fix: update lower jaw on ctrl enter (#47463)
* fix: update jaw on all ctrl-enter presses

* fix: show running tests while hiding feedback

Screenreaders still announcing running tests and then the output, and
the display now stops showing a flash of the new feedback message

* refactor: camelCase

* refactor: clean up and reduce renders

previousHint isn't really state, insofar as it changing should not
trigger a new render - a ref does the trick.

* chore: remove log

* fix: use ref to track latest attempts prop

* fix: allow lower jaw to trigger viewzone updates

React.render's callback cannot be relied on. It does not necessarily
get called on every update to the rendered element.

updateContainer is called on every render, so the editor will be
updated.

* refactor: attemptsNumber -> attempts

* fix: do not render on attempt changes

* refactor: more camelCase

* fix: try to prevent previous hint rendering

Co-authored-by:
Manabu Matsumoto <mmatsumoto1026@gmail.com>

* test: resetting of lower jaw

* fix: reset lower jaw when step is reset

* test: check congrats message appears on completion

* fix: hide feedback after reset

* fix: leave focus in the editor after passing tests

This is an attempt to work around a JAWS issue whereby the submit
shortcut (ctrl+enter) is ignored after the user passes all tests.

* test: submit button receives focus when tests pass

* fix: focus submit button when tests pass

Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>

Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>
2022-09-15 12:44:06 -05:00
Sem Bauke
8c83a96e93 feat: volume slider campfire mode (#47259)
* feat: volume slider campire mode

* fix: set a play sound interval

* fix: set volume to 50% if there is no volume key

* fix: add correct colors to progress bar

* fix: remove IE support

* fix: get slide value working in Chrome

* fix: remove space

* fix: actually use volume in the editor

* fix: add aria-label

* fix: set volume if not present in store

* fix: use label instead

* Apply Naomi's review on Toms suggestion

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>

* fix: linting

* Update client/i18n/locales/english/translations.json

Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>

Co-authored-by: root <root@DESKTOP-EMNPVBP.localdomain>
Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>
2022-09-15 15:42:03 +03:00
Oliver Eyton-Williams
9355406aed refactor: add explanation of instruction width (#47504) 2022-09-12 13:42:56 -07:00
renovate[bot]
5ff719a4c8 fix(deps): update font awesome to v6.2.0 (#47443)
* fix(deps): update font awesome to v6.2.0

* fix: update snapshots

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2022-09-12 17:16:32 +05:30
kulraj chavda
acc966ac31 add visual separation in Change language menu UI (#47418)
add visual seperation in Change language menu UI
2022-09-08 13:16:27 +05:30
Manabu Matsumoto
145521b3d4 fix(UI): restore keyboard accessibility (#47427)
* fix: restore keyboard accessibility

* fix/ make code easier to maintain
2022-09-06 19:21:38 +02:00
Tom
c280e8a363 feat: add preview popout window (#46251)
* feat: add preview popout window

* fix: remove unused

* fix: add title to window

* fix: add preview to window title

* feat: it works

* chore: clean up

* chore: more clean up

* fix: add better screen reader messages
2022-09-04 13:15:54 +02:00
Sem Bauke
57695d7d88 feat: add lang code to iframe (#47365)
* feat: add lang code to iframe

* feat: apply Naomi's code review

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>

* fix: Iframe title test

* Apply suggestions from code review

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>

* fix: hopefully things make sense

* fix: steal sem's idea for DOMParser

* fix: make the solution work on the main frame

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2022-08-30 09:30:02 -07:00
Naomi Carrigan
406d47deb0 feat: add search link to help modal (#47385)
Co-authored-by: =?UTF-8?q?Lasse=20J=C3=B8rgensen?= <28780271+lasjorg@users.noreply.github.com>
2022-08-29 16:12:50 +02:00
SadmanSyfe
ec3d6deb35 chore(client): Typescript migration of __mocks__/gatsby.js (#47334)
* chore(client): Typescript migration of __mocks__/gatsby.js

* chore(client): Typescript migration of __mocks__/gatsby.js
2022-08-26 17:27:08 -05:00
Shaun Hamilton
d66786d481 chore(client): clean-up lower-jaw logic (#47352)
* chore(client): clean-up lower-jaw logic

* fix: linter required node_modules
2022-08-26 16:06:14 -05:00
Naomi Carrigan
5e402e6955 feat: allow languages to be hidden (#47362) 2022-08-23 20:53:47 +02:00
Manabu Matsumoto
a3bc36cd48 fix(UI): make possible to reset challenge after tests pass (#47326) 2022-08-22 11:18:21 +02:00
Naomi Carrigan
ccad7f02ea feat: enable german (#47312)
* chore: set up lang config

* chore: migrate the manually translated files

Co-authored-by: Sem Bauke <semboot699@gmail.com>
Co-authored-by: Ilenia <nethleen@gmail.com>
2022-08-22 08:54:55 +02:00
Tom
404a14ce03 fix: make ctrl+enter work on mac (#47303) 2022-08-19 13:34:06 +02:00
Raquel Amorim
d96bff4428 fix(client): Fix print media queries for certificate (#46969)
* fix: add print media queries for certificate

* adjustments to printable certificate

* adjustments on margins and landscape printing

* adjustments
2022-08-15 16:46:46 +03:00
Manabu Matsumoto
41397df125 fix(ui): update a link for new campers (#47267)
* fix: update start at the beginning link

* fix: change the query's filter argument
2022-08-15 08:00:30 -05:00
Tom
136f60bbef feat: move rdb order to middle of superblocks (#46138)
feat: move rdb out of beta
2022-08-10 18:48:39 +02:00
renovate[bot]
1f8c08efbb fix(deps): update dependency @freecodecamp/loop-protect to v3 (#46801)
* fix(deps): update dependency @freecodecamp/loop-protect to v3

* refactor: preset definition to getBabelOptions

* refactor: pass in presets

* refactor: simplify getBabelOptions

* fix: use getBabelOptions

* refactor: use simpler names

* chore: update comment

* fix: destructure properly

* fix: remove default object

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-08-10 16:12:59 +01:00
Naomi Carrigan
b6115b9880 fix: adjust grid map css (#47159)
* fix: adjust grid map css

* feat: use grid instead

Co-authored-by: Bruce B <bbsmooth@gmail.com>

Co-authored-by: Bruce B <bbsmooth@gmail.com>
2022-08-10 11:00:30 +09:00
Muhammed Mustafa
e605233d3a feat(client): i18n link alert (#46755)
attach i18next to window, give window alerts access to i18next.t

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-08-09 11:58:36 +02:00
Hankai Xia
bc369e97d8 fix(client): worker executor task once (#46951) 2022-08-08 11:20:15 -05:00
Jagruti Tiwari
4e55be35bd feat: show reset button after submitting the code once (#47126)
* feat: shows reset after checking code once

* fix: changed conditions to hide and show help button
2022-08-04 17:13:34 +03:00
Naomi Carrigan
836ccb79b1 chore: resolve type coercion todo comment (#47036) 2022-07-28 09:18:08 +02:00
Sem Bauke
2440d3f43f chore(client): make curriculum helpers external (#46906)
* chore: make curriculum helpers external

* feat: add curriculum helpers as a package

* fix: use right preset?

* fix: update version with babel transpiled files

* fix: re-add fixture

* fix: declare as module

* fix: add declaration files in curriculum helpers

* fix: nothing with version 1.0.4

* fix: missing functions in package

* fix: remove old babel

* fix: linting
2022-07-27 19:00:37 +02:00
Oliver Eyton-Williams
167b94b223 fix(client): handle empty editor contents (#46986) 2022-07-25 15:18:53 +02:00
Ahmad Abdolsaheb
72a9e76ce5 feat: remove the mention of recurring donations. (#46948)
feat: remove the mention of ongoing donations
2022-07-19 08:39:45 -05:00
Radi Totev
8f19b1926b chore(client): typescript migration - utils/build.js (#46761)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Luke Steinmann <92131626+lulululu12345@users.noreply.github.com>
Co-authored-by: Mrugesh Mohapatra <hi@mrugesh.dev>
2022-07-19 11:54:38 +05:30
Oliver Eyton-Williams
0e8113b4af fix: allow users to submit after editing (#46939)
If a user runs the tests and they pass, the multifile editor will show a
submit button.  If the user then edited the page, it would no longer be
possible to submit.

This ensures the redux store keeps the original, passing, tests and lets
the user submit
2022-07-18 14:57:53 +02:00
Oliver Eyton-Williams
9421aa6041 fix: expand projects on map (#46937) 2022-07-18 11:34:19 +02:00
Bruce Blaser
0345244c43 fix(a11y): change headings in footer to h2 (#46932)
fix: change headings in footer to h2
2022-07-17 09:59:15 -07:00
renovate[bot]
f6f252eba8 chore(deps): update dependency eslint-plugin-react to v7.30.1 (#46664)
* chore(deps): update dependency eslint-plugin-react to v7.30.1

* fix: prettier

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2022-07-14 21:07:56 +05:30
Ilenia
0a2d0733a2 feat: simplify client logic (#46870)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-07-14 14:11:20 +05:30
sidemt
eea6f5195c fix(i18n): configure search Japanese publication (#46888) 2022-07-14 14:02:01 +05:30
Oliver Eyton-Williams
2f6eef61d4 fix: save project to redux on submit (#46791) 2022-07-13 15:20:02 +05:30
Ilenia
1a8899bfb8 feat: remove random id from forum topic title (#46869)
feat/remove random id from forum topic title

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
2022-07-12 16:46:11 -07:00
Moshe
67cf5d63f2 fix(client): prevent navigating on failed submissions (#46734)
* fix(37615): avoid navigate to next challenge api fails

* fix: elsint errors

* fix: more elsint errors

* fix: make 'navigate' call conditional

* chore: removed async prefix from naigateTo method

* refactor: compare types with constants

* chore: remove unused closeChallengeModal

* fix: restore call to closeModal

* refactor: use setTimeout inside map block

* fix: requested changes according the comments

* fix:remove !request.ok block
2022-07-12 10:17:08 -05:00
Moshe
8d4d4d79e8 fix(ui): "sign in" button hidden at small devices (#46561)
* fix(UI): missing sign-in button at small devices

* feat: replace menu and sign-in buttons text with images

* refactor: svg icons replaced by fortawesome ones

* test: fix e2e test of navigation menu button

* feat: display sign in button and hide all

* feat: display sign in icon on nav for small screens

* feat: add accessibility span for menu icon

* fix: lint errors

Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com>
2022-07-12 08:15:52 -05:00
Ilenia
f61b227665 chore: rename project type from bonfire to jsProject (#46823)
* change bonfire in index.js

* change bonfire in build.js

* change bonfire in challenge-types.js

* change bonfire in test-challenges.js

* add jsProject to constants.js
2022-07-11 07:28:29 -05:00
alpox
e3fe5d0a9b feat: add title to "ask for help" forum requests (#46777)
* feat: add title to "ask for help" forum requests

* fix: remove need for translation

* fix: remove dangling comma

* fix: no email-fallback but remove user part if no username is available

* fix: fallback to username if no name is set

* Use nanoid instead of username

* Add block title to challenge description
2022-07-08 13:48:09 -07:00
Radi Totev
e17e57aba5 feat: update keyboard shortcuts client endpoint (#46378)
* feat: update keyboard shortcuts client endpoint

* Update client/src/redux/settings/settings-sagas.js

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update putUpdateMyKeyboardShortcuts return type

* Use new saga in shortcuts-modal

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-07-01 11:38:06 -07:00
Tom
a02db52800 fix: caching issues (#46716) 2022-07-01 15:24:29 +02:00
Ilenia
ac6f9fc95d fix: collapse rosetta (#46714) 2022-07-01 12:32:01 +02:00
Caden Parker
85f3ecbb0a Change Link Regex Tests to DOM queries (#45890)
* Change link regex tests to DOM queries

* Keep injection of style tag

Co-authored-by: Florencia <sicref001@gmail.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-06-27 10:37:23 +02:00
Oliver Eyton-Williams
8bc5b0a310 fix: show completion modal (#46589)
* fix: make ctrl/cmd + enter trigger modal

Multifile projects should be handled like legacy challenges in this
regard.

* test: check modal appears

* refactor: ignore additional solutions

* test: fix ctrl + enter tests

* fix: only run on electron

* fix: remove log

* fix: show completion modal if instructions focused

* fix: handle undefined challengeType
2022-06-26 12:23:46 -05:00
Naomi Carrigan
74a03ce0e5 feat: only 3 attempts before showing buttons (#46641)
* feat: only 3 attempts before showing buttons

* fix: linter
2022-06-24 08:27:18 +03:00
Oliver Eyton-Williams
44b1a3dab5 fix(client): inject user's script.js contents correctly (#46627)
With this change the preview should function as if the user had written
a script with script.js's contents.  <script src="script.js"> is
replaced, so the script element's position in the html matters.
2022-06-23 16:34:29 +01:00
Oliver Eyton-Williams
9046d70b67 fix: use certification hours consistently (#46442)
* fix: use certification hours consistently

Since the value appearing on the /learn map was hardcoded, it could have
gone out of sync with the certifications, which were relying on
certification-settings.

Also, for simplicity (and because it's hard to estimate accurately), all
the certifications are set to 300 hours.  Fullstack being the exception,
as it is a set of certifications.

* feat: remove the hours from the map
2022-06-23 14:24:33 +03:00
Shaun Hamilton
7a91407184 fix(client): handle verification of full-stack cert once (#46588) 2022-06-20 13:14:22 -07:00