Commit Graph

442 Commits

Author SHA1 Message Date
Chad Kreutzer
8d5820e24b improve challengeSeed for clarity and uniformity in Write Reusable JavaScript with Functions, Passing Values to Functions with Arguments, and Return a Value from a Function with Return
removed comma

Changed to reflect ourUniqueName()/uniqueName() pattern throughout

removed debugging artifact

change ourFunction(1, 9); to ourRandomRange(1, 9);

Remove second function calls where appropriate.
2016-07-02 04:43:20 +00:00
Jonathan
6722e2278e Merge pull request #9158 from QuincyLarson/remove-simply
remove the word simply from a couple challenges
2016-06-29 21:51:34 +01:00
Arun
86749c58d4 Fix tests to allow switch of operands for !== operator 2016-06-28 18:18:20 +05:30
JamesWorsnop
187d4249fd Fixing if/if else text in replacing if else chains with switch challenge 2016-06-27 22:02:37 +09:00
qdr
31619e8111 Fix broken link to Introducing JavaScript Object Notation (JSON) (#9331)
This commit fixes the broken link to the correct challenge.
2016-06-24 12:05:18 +00:00
Mrugesh Mohapatra
08154b82bf Merge pull request #9204 from vreynolds/fix/8979-record-collection
Add Test Case to Record Collection
2016-06-24 05:09:00 +00:00
Jonathan
53e92aa922 Merge pull request #9308 from sthodup1/fix/test-clarity
basicJavascript.json - Clarify testing criteria
2016-06-23 15:49:33 +01:00
Arun
a3b3334f1f Fix redundancy in description 2016-06-23 15:11:12 +05:30
sthodup1
bf485ddc34 basicJavascript.json - Clarify testing criteria 2016-06-22 22:14:46 -05:00
Manish-Giri
951a24fe63 Fixed quotations in Record Collection 2016-06-22 21:54:22 -04:00
Jonathan
c9695867bf Merge pull request #9264 from okputus/fix/camelCase-desc-fix
Improved instructions for understanding camelCase in variables challenge
2016-06-22 08:27:49 +01:00
Oscar
224495ae87 Edited basic-javscript.json to improve camelCase task description
Edited clarification statement with consideration to 'DRY'
2016-06-22 02:33:56 +00:00
BKinahan
e0ace83573 Correct stringify to JSON.stringify 2016-06-21 16:04:35 +00:00
Matthew Hargraves
aae79060f1 fixed word blank instructions are unclear [challenge] 2016-06-20 18:12:30 +01:00
Eric Leung
1c54ab471a Clarify Escape Sequences in Strings challenge
- Add code tags into table
- Rewrite instructions for more applicable coding test
- Add more tests to be more specific on what you need to pass
2016-06-19 14:56:54 -07:00
LindsayBrown81
3fa86377f8 fix/disambiguate-property-meaning, make JSON valid in basic-javascript.json #9096
Lines 4322-4323: made links HTML tags instead of markdown in the definitions I added for JSON and property.
Line 4324: added booleans and numbers back into the Data Structures and overall reduced number of words used in explanations.
Lines 4338 and 4343: removed quotes from integer value and boolean value because the JSON is valid without them.
Line 4502: specified what part of property the ID number is to reinforce that a property consists of a key (or name) and a value.
Lines 4505-4508: reworded the conditions to be more consistent and comprehensible, changed their order.
Line 4510: retitled Note to Hints and added two more hints.
Line 4543: changed from my first PR's suggestion of var collectionCopy = JSON.stringify(collection) back to var collectionCopy = JSON.parse(JSON.stringify(collection)).
2016-06-18 14:08:14 -04:00
Vera Reynolds
0e654eb6bd added a check to record collection about pre-existing elements 2016-06-17 14:48:37 -05:00
Jonathan
f2ca20d006 Merge pull request #9183 from sahilkhurana19/fix/array-challenge-description
Modified the description to make it a bit more clear.
2016-06-17 19:51:49 +01:00
sahilkhurana02
f347c5fbaf Fixed challenge description.
Modified the description to make it a bit more clear.

Fixed challenge description and moved the example code to its own independent line.
2016-06-17 23:53:00 +05:30
Arun Kumar
25e6d4293b Fix pop arrays challenge tests (#8959)
* Fix tests for pop arrays challenge
* Fix the first test
2016-06-17 17:30:57 +01:00
Stuart Taylor
0a21880b86 Merge pull request #9144 from DealPete/fix/JSON
remove references to JSON.
2016-06-17 16:58:30 +01:00
DealPete
2a07c52e78 remove references to JSON.
change 'allows' to 'allow'
2016-06-17 11:03:26 -02:30
Stuart Taylor
396c4b5372 Merge pull request #9098 from DealPete/fix/incorrectOutputChallenge
Fixed 'Write Reusable JavaScript with Functions' head and tail
2016-06-17 13:20:55 +01:00
Jonathan
57bb224aa6 Merge pull request #9174 from sahilkhurana19/fix/golf-code-description
Edited the basic challenge description in order to make the challenge easier t…
2016-06-16 18:21:56 +01:00
Jonathan
ad701a8e49 Merge pull request #9076 from robjloranger/fix__using-array-indices
fix for access array data with indices
2016-06-16 17:10:36 +01:00
sahilkhurana02
c7c2690848 Edited the basic challenge description to make the challenge easier to understand. 2016-06-16 18:06:33 +05:30
Quincy Larson
332ea5f76c remove the word simply from a couple challenges 2016-06-15 13:15:31 -07:00
robjloranger
6df576df6b adjusted test 2016-06-14 16:41:55 -07:00
Eric Leung
cd4f17564d Merge pull request #8896 from Bouncey/FIX-Comparison-with-the-Equality-Operator
FIX Comparison with the Equality Operator
2016-06-12 16:19:49 -07:00
Stuart
1641b25523 FIX Comparison with the Equality Operator 2016-06-12 09:26:13 +01:00
Brandon Kish
f3761e86e5 Fix missing apostrophe in Basic JavaScript conditional challenge 2016-06-11 22:30:26 -04:00
Pasayadaan
e4381b7c9d Fix for access array data with indices
This is a buggy challange (#8843)

Updated description in
seed/challenges/01-front-end-development-certification/html5-and-css.json
to instruct "Create second <p> element after the existing <p> element"

fix for access array data with indices

use deep not-equal in first assertion
2016-06-11 11:05:11 -07:00
DealPete
78bbf1e767 Fixed 'Write Reusable JavaScript with Functions' head and tail 2016-06-10 19:30:04 -02:30
Junaid Ahmed
42023aec92 replaced comparison with strict equality operator 2016-06-09 16:26:39 +05:30
Eric Leung
e1b987676b Merge pull request #8890 from Bouncey/FIX/Comparison-with-the-Inequality-Operator
FIX/Comparison-with-the-Inequality-Operator
2016-06-08 21:54:33 -07:00
Priya Ranjan Singh
b29432e26d add challenge instruction for valid array operations 2016-06-08 22:16:47 +05:30
Stuart
06b928fbc8 Fix/Comparison with the Inequality Operator. 2016-06-08 16:30:05 +01:00
nicolaferracin
511b47c09b Introducing Else Statement excercise - write clearer instructions 2016-06-08 14:18:28 +02:00
Eric Leung
bb9b2f85ec Merge pull request #8982 from daniel-chung/fix/assert-message
Clarify error message in basic-javascript challenge
2016-06-07 22:32:58 -07:00
daniel-chung
882404025d Clarify error message in basic-javascript challenge
Removes the enclosing parentheses in the second assert error message for the basic-javascript challenge 'Escaping Literal Quotes'.

Previous error message was:
Variable myStr should equal to (I am a "double quoted" string inside "double quotes").

The new error message is now:
Variable myStr should contain the string: I am a "double quoted" string inside "double quotes".
2016-06-07 21:16:05 -04:00
Jackson Kearl
f187512cd0 Decrease whitespace dependencies in checkoffs
Change most `\s?` to `\s*\` in tests, to allow for multiple whitespace characters in places where whitespace does not matter.
2016-06-07 15:25:19 -07:00
Arun
53026c6609 Fix tests for finding remainder in javascript challenge 2016-06-05 00:28:13 +05:30
Jacob Bearden
aaab1cd218 fix small typo 2016-06-03 18:29:56 -06:00
Russ Otto
c8ce78112c Fixed issue #7015: Access Multi-Dimensional Arrays with Indexes
This commit clarifies the explanation and example for the Basic Javascript challenge "Access Multi-Dimensional Arrays with Indexes." The implemented fix was proposed by @erictleung in https://github.com/FreeCodeCamp/FreeCodeCamp/issues/7015#issuecomment-222345491
2016-06-01 12:24:29 -05:00
Eric Leung
0e10970198 Merge pull request #8857 from pranayberry/fix/remainder-challenge
Updated test case for the remainder challenge
2016-05-30 17:01:37 -07:00
Eric Leung
9282ab5d3a Merge pull request #8691 from nishant-tomer/fix/tests-challenge-record-collection
add one more test to Record Collection
2016-05-30 16:11:48 -07:00
Pranay Berry
1de8664451 Updated test case 2016-05-31 01:59:22 +05:30
Daksh Shah
93b2b1b541 Fix test in Accessing Obj Properties with Vars 2016-05-29 12:47:11 +03:00
DealPete
650f214c4f add period to "Escaping Literal Quotes in Strings". 2016-05-27 22:57:25 -02:30
Mrugesh Mohapatra
a2dbb61062 Merge pull request #8746 from drewbs/fix/profile-lookup
Remove unnecessary line in Profile Lookup
2016-05-21 22:17:11 +05:30