Commit Graph

209 Commits

Author SHA1 Message Date
Dhruv Gajjar
a18639dc07 fix(curriculum): Dead code example in (#46825)
fix(curriculum): Dead code example in #46813
2022-07-10 09:06:12 +02:00
Randell Dawson
c7c9a5492d fix: remove duplicate test and make small change to recently added test for Counting Cards challenge (#46790)
fix: remove duplicate test
2022-07-07 08:50:29 -07:00
Randell Dawson
eca650dc69 fix: add test to validate result format has space between count value and text - Counting Cards challenge (#46782)
fix: add test to validate result format
2022-07-06 21:57:18 -07:00
Muhammed Mustafa
3e3da4ec0f fix(curriculum): standardize links in curriculum (#46564)
* fix(curriculum): standradize links in curriculum

* Data analiysis links

* CIP links

* fixed links in s-expressions

* Update curriculum/challenges/english/01-responsive-web-design/basic-css/use-hex-code-for-specific-colors.md

Co-authored-by: Ilenia <nethleen@gmail.com>

* added space before target attribute

* standarize external and .rock example links

* wrap "check out the projects" around the links

Co-authored-by: Ilenia <nethleen@gmail.com>
2022-06-26 11:13:38 -05:00
Ilenia
59abda3ff2 fix(curriculum, i18n): solve issues in crowdin comments (#46597) 2022-06-21 19:53:13 +05:30
Ivan Pavičić
258e9d0130 fix(curriculum): var keyword to global-scope-and-functions (#46553)
fix(curriculum): var to global-scope-and-functions

Added the `var` keyword in global-scope-and-functions challenge instructions to avoid confusion
2022-06-18 16:34:51 -07:00
Muhammed Mustafa
e474d4cd17 chore(curriculum): Front End catagories links standardized (#46418) 2022-06-13 20:18:23 -05:00
sidemt
6d7b49ffe0 fix(curriculum): remove reference to Mad Libs (#46490) 2022-06-13 20:56:38 +02:00
Muhammed Mustafa
5282994ad8 Chore(curriculum): removing copywriten wiki content (#46436)
* remove mad-labs link

* changed similar to wiki text in legacy JS

* let's go Sam got my back here as well

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>
2022-06-10 08:54:51 -05:00
Bill Cheng
8397129aaa fix(curriculum): Add test output to not change strings assigned to variables (#46353) 2022-06-05 10:51:36 -05:00
Titi
14bf77d3b8 chore: removed unneeded check for semicolon 2022-06-04 11:09:55 -05:00
Muhammed Mustafa
924fd04760 fix(curriculum): external golf wiki link in JS (#46170) 2022-05-27 10:51:40 +02:00
Muhammed Mustafa
864f4a199a fix(curriculum): removed link in JS basic-JavaScript (#46143)
* fix(curriculum): removed link in JS basic-javascript

* removed JSON and its example
2022-05-26 16:36:21 +02:00
Muhammed Mustafa
5b4dc4ab6d fix(curriculum): external Mad Libs link in JS steps (#46157) 2022-05-26 12:43:20 +05:30
Muhammed Mustafa
93f32b45e2 fix(curriculum): external card counting link in JS (#46158) 2022-05-26 12:42:39 +05:30
Muhammed Mustafa
f2592999f3 fix(curriculum): external floating link in JS (#46159)
Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>
2022-05-26 12:41:58 +05:30
Muhammed Mustafa
ddc55af8de fix(curriculum): external link in words blank JS (#46145) 2022-05-26 00:14:37 +07:00
Benjamin Lu
2da688fbfe fix(curriculum): add switch statement spaces for consistency (#46141)
Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>
2022-05-25 22:37:00 +05:30
Luke Harrison
e4c6883a20 fix(curriculum): updated wording on understanding uninitialized variables (#45860)
* updated wording on understanding uninitialized variables

* updated wording for case b to match case a

* updated case c to match the wording of both case a and b
2022-05-05 19:05:30 +02:00
Naomi Archibong
4ff9c2a6fc feat: update wording for string length (#45602) 2022-04-15 08:13:42 -07:00
JuumanBeing
c92a71e11e fix(curriculum): include note about counting spaces by .length property (#45641)
Added a sentence to bring attention to the fact that the JS string .length property counts space characters.
2022-04-09 12:27:50 +02:00
Lenin Kennedy
a6d2660c7c fix(curriculum): remove style note (#45625) 2022-04-05 13:49:27 -06:00
Suph
405675261d fix(curriculum): clear up confusion of array index (#45576) 2022-03-30 20:45:20 +02:00
Radi Totev
4d620dea1a fix(curriculum): allow spaces before brackets (#45494)
* chore(curriculum): update regex in use-braket-notation-* tests

Update regex used in tests, so that tests are more forgiving and spaces tolerant.

* Allow for spaces within brackets
2022-03-22 13:52:13 +01:00
Naomi Carrigan
d781c63fdf chore: resolve flagged Crowdin issues (#45442)
* chore: resolve bengali issues

* chore: resolve french issues

* chore: resolve hebrew issues

* chore: resolve persian issues

* chore: resolve portuguese brazilian issues

* chore: resolve russian issues

* chore: resolve spanish issues

* chore: resolve japanese issues
2022-03-19 13:26:57 +05:30
Kai Wei Mo
ce5b9b8aba fix(curriculum): augment test for adding tracks property (#45424)
* Only English

* Consitent quotation marks
2022-03-17 19:13:16 +00:00
HenMoshe
d3304276ca fix(curriculum) : Make tests stricter for challenge "Decrement a number with javascript" (#45242)
* Make tests stricter for challenge "Decrement a number with javascript" #44648

* Update decrement-a-number-with-javascript.md
2022-03-09 22:47:02 -06:00
Naomi Carrigan
1c65d5d34a fix(curriculum): remove callback thereby stripping js comments (#45133)
* fix: strip js comments

* fix: revert helper export, better test approach

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2022-02-24 16:29:56 +05:30
HenMoshe
ea416b6dc2 fix(curriculum): add result of comparison expression evaluation to the inline comment (#45224)
* Add result of comparison expression evaluation in the inline comment #45183

* Apply suggestions from code review

thanks!

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
2022-02-23 18:58:42 +01:00
zelf0
3668422083 fix: add divider to stand in line challenge in basic javascript section (#45180)
* Fix: Update grammar in PR documnetation

* fix: add divider to stand in line challenge in basic javascript section

* Undo change outside of scope
2022-02-21 22:44:27 +05:30
Jagruti Tiwari
9b7d7ba716 fix(curriculum): inconsistancy on const Naming cases (#45149) 2022-02-17 11:35:16 -08:00
Madhu Sudhan Reddy Vinta
0a895dad47 fix(curriculum): make example less confusing (#45088)
* Local scope and functions: Make the example less confusing

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/local-scope-and-functions.md

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
2022-02-11 12:08:46 -08:00
sanberkzulfikar
50b554470d fix(curriculum): wording consistency in counting-cards.md (#44390) 2021-12-08 07:32:56 -08:00
Michał Urbanek
9920b7c83c fix(curriculum): point to all lines requiring change (#44056)
* fix comments for which place to edit

 solution should be placed in this line, previous comments was missleading.
as discussed in https://github.com/freeCodeCamp/freeCodeCamp/issues/44049

* shorter comments

clear of not needed ward Only

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/declare-a-read-only-variable-with-the-const-keyword.md

letter fixes

Co-authored-by: Ilenia <nethleen@gmail.com>

* fix for spelling of Change

only letter change

* fix for italian language

all other languages

* revert

revert of changes that will be done in other place

* revert

Co-authored-by: Ilenia <nethleen@gmail.com>
2021-10-29 12:37:01 +02:00
Oliver Eyton-Williams
da9e6ad0c1 fix(curriculum): consts must be initialized 2021-10-27 19:42:45 +05:30
Kristofer Koishigawa
bcc9beff1f feat(curriculum): introduce let and const earlier (#43133)
* fix: move "Explore Differences Between..." to basic JS, update seed and tests

* fix: resequence "Declare String Variables"

* fix: move "Declare a Read-Only Variable..." to basic JS, update seed and tests

* fix: revert changes to non-English "Explore Differences Between..." test text

* fix: revert test strings, solutions, and seeds for non-English challenges

* fix: update "Declare String Variables" description

* fix: sync quotation marks in description and seed

* fix: modify note in "Declare a Read-Only..." challenge

* fix: update operator and compound assignment challenges

* fix: update string challenges

* fix: update array and array method challenges

* fix: update function and scope challenges, resequence slightly

* fix: "Word Blanks" solution

* fix: add spacing to seed

* fix: concatenating += challenge spacing

* fix: appending variables to strings spacing

* fix: find the length of a string spacing

* fix: removed instances of removedFromMyArray = 0

* fix: switch challenges

* fix: function argument and param spacing

* fix: update counting cards, object challenges, and record collection

* fix: finish rest of Basic JS section

* fix: introducing else statements solution

* fix: update spacing and wording

* fix: update wording for const challenge

* fix: update functional programming challenges

* fix: intermediate algorithms and cert challenges

* fix: revert some spacing and remove comments for fp challenge solutions

* feat: add notes with links to moved let and const challenges in first two es6 challenges

* fix: update es6 intro text

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/concatenating-strings-with-the-plus-equals-operator.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/finding-a-remainder-in-javascript.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/global-scope-and-functions.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-through-an-array-with-a-for-loop.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-through-an-array-with-a-for-loop.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/functional-programming/implement-map-on-a-prototype.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/declare-a-read-only-variable-with-the-const-keyword.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: concatenating strings with plus operator seed

* fix: add comments back to Declare a Read-Only Variable... seed

* feat: add es6 to basic javascript redirect tests for let and const challenges

* fix: revert "Concatenating Strings with Plus Operator" seed

* fix: move test file to cypress/integration/learn/redirects, separate redirect tests

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2021-10-25 17:55:58 +01:00
Riadh Laabidi
304f245cd2 fix(curriculum): Remove outdated video (#43685)
* Remove outdated video from testing objects for properties challenge

* Remove outdated video from testing objects for properties challenge
2021-10-02 18:51:15 +02:00
Aaron McCollum
badeb6e2df fix(curriculum): reworded grammar to do without hyphen (#43487)
Suggesting the removal of "-" on line 29 in the description, as the comma before "such" is sufficient to separate the examples from the rest of the sentence.
2021-09-18 13:13:05 +01:00
Patrick Lehmann
5371af7767 fix(learn): removed space from first sentence and added instruction to basic javascript challenges (#43198)
* sheesh

* added markdown formatting to challenge

* added formatting to keep space in concatenating strings with the plus equals operator

* Delete husky.sh

* added back in italian dictionary

* removed code formatting

* updating text formatting for challenges, removed space and added instruction

Co-authored-by: Pat Lehmann <patrick.lehmann@homes.com>
2021-08-24 10:26:45 -07:00
abfipes
db1a92611a fix(curriculum): repair of a small logical underdevelopment (#43116)
* repair of a small logical underdevelopment 

a> b is false if a == b

* Apply suggestions (fix small typo )

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
2021-08-05 14:54:32 +02:00
Innocent V.I
ac2fe62eef fixed create-decimal-numbers-with-javascript challenge external link (#42801) 2021-07-09 09:02:47 -05:00
dogfood654
e5505cbe7b fix(curriculum): minor indentation for readability (#42451)
* Fixed minor indentation for readability

* amended to 2 indentation
2021-06-16 14:35:34 +01:00
Ilenia
ce3ccc47d4 fix(curriculum): remove unnecessary backticks (#42458) 2021-06-12 20:53:45 +02:00
zoembrown
ca2f024aec fix(curriculum): fixed typo in challenge (#42456) 2021-06-12 17:37:17 +02:00
Ilenia
28add4712a Remove backticks from around data types to ease translations (#42403) 2021-06-08 14:03:16 +05:30
Rebekah Koon
5a3d22e76b fix(curriculum): changing Charles -> Ada in JavaScript challenge descriptions (#42280)
* changing Charles -> Ada in JavaScript challenge descriptions

* fix: changing Charles -> Ada in JavaScript challenge descriptions

* fix: changing firstName value from Ada to Augusta in javascript lesson
2021-05-29 21:33:21 +05:30
alirezaghey
cbb7afd5b8 fix(curriculum): correct link text (#42143)
* Small language improvement

The correct term is assignment operator.

* Small language improvement

Co-authored-by: Niraj Nandish <nirajnandish@icloud.com>

Co-authored-by: Niraj Nandish <nirajnandish@icloud.com>
2021-05-15 17:10:19 +02:00
alirezaghey
79e799feb5 fix(curriculum): scoping variables language improvement (#42135) 2021-05-14 09:02:54 -07:00
Evgeny Klimenchenko
db369fbed1 fix(client): remove JS comments from user code for tests (#41873)
* Removes comments in js challanges by default

* fix local-scope-and-functions test regex

* fix all languages

* revert language changes

* removed unnecessary removeJSComments from challenges

* fix challanges in other languages

* removed removeJSComments from all challanges
2021-04-28 10:18:54 -05:00
Jeremy L Thompson
6ae186a8cf fix(curriculum): record collection challenge - variable names shouldn't be keywords (#41904)
* style - update record collection challenge, variables shouldn't be name after keywords

* minor - typo fix

* Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-04-23 21:51:41 +02:00