Commit Graph

56 Commits

Author SHA1 Message Date
Moshe
002212c437 fix(client): allow ipv6 urls for localhost (#54043)
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2024-04-03 21:53:49 +07:00
Huyen Nguyen
138a80f6ca refactor(client): migrate buttons on the settings page to ui-components (#53739) 2024-03-08 08:15:03 +01:00
Shaun Hamilton
4a0519e7a6 feat(client): adjust solution-form for gitpod (#53511)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2024-02-05 10:17:33 -06:00
Shaun Hamilton
3243a3852d revert: b1fc2dbc34 (#53447) 2024-01-30 10:36:46 +01:00
Huyen Nguyen
b1fc2dbc34 refactor(client): replace Bootstrap button component on settings page (#52525)
Co-authored-by: Sboonny <muhammedelruby@gmail.com>
Co-authored-by: sembauke <semboot699@gmail.com>
2024-01-22 12:36:59 +01:00
Shabeeb Khalid
c1a09c2154 test(e2e,playwright): form-helper component (#51974)
Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
2023-10-18 16:35:30 -05:00
Muhammed Mustafa
2ccf52e6bc feat: replace form components (#51204)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>
2023-10-15 19:33:39 -07:00
Pankil
2558156282 feat: replace alert component (#51738)
Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com>
Co-authored-by: Sboonny <MuhammedElruby@gmail.com>
2023-10-06 15:40:30 +00:00
Tom
9a1895d2e3 feat(client/api): validate ms users (#51372)
Co-authored-by: Muhammed Mustafa <MuhammedElruby@gmail.com>
2023-08-26 07:57:02 -05:00
Muhammed Mustafa
2243f1e064 feat: remove abstraction in formFields (#51316) 2023-08-23 08:23:48 +02:00
Oliver Eyton-Williams
984208f2a5 feat(api): check ms trophy urls exist (#51016)
Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2023-08-02 14:10:25 -05:00
Oliver Eyton-Williams
ae164d7ca8 feat(client): validate ms learn submissions (#51008)
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2023-07-26 10:34:58 +02:00
Naomi Carrigan
81fec04b60 chore: clean up form validator type defs (#51022) 2023-07-20 11:00:37 +02:00
Shaun Hamilton
3dab4261fb fix(client): allow endpoint on projects (#49656)
* fix(client): allow endpoint on projects

* refactor: structure form.tsx code similarly 

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2023-03-21 09:47:04 +01:00
Shaun Hamilton
f45d8b06dc feat(client): warn endpoint url submission (#49560)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2023-03-06 16:24:48 +05:30
Shaun Hamilton
e8b010d7e2 fix(client): selector return, invalid prop val (#49447)
* fix(client): correctly return type from selector

* fix(client): remove incorrect prop [button-spacer]
2023-02-20 21:34:34 +02:00
Muhammed Mustafa
85e9fbb8df refactor(client): clean extra component and extra unneeded imports (#49391)
* feat: remove extra unnecessary code

* clean the unique way that component was handled

* make bsSize optional

* update snapshot to account for the other button styles

* add comment for our future selves

* clean the changes file
2023-02-19 17:16:53 +05:30
Muhammed Mustafa
5e4ba38309 refactor(client): delete block save wrapper (#49217)
* refactor(client): delete block save wrapper

* Clean bloating divs and extra css import

* remove the blocksave wrapper snapshot
2023-02-13 23:26:44 +05:30
PakkuDon
e5f54cab5f chore(client): remove exports for unused types (#48004)
* chore(client): remove exports for unused types

* chore(client): remove unused type
2022-10-14 19:10:21 +05:30
Niraj Nandish
53164e71f1 fix: circular dependencies (#46638)
* fix: circular dependency in formHelpers

* fix: circular dependency in Flash

* fix: circular dependency in helpers

* fix: circular dependency in current-challenge-saga (1/2)

* fix: circular dependency in code-lock-epic

* feat: eslint rule for circular dependencies

* fix: circular dependency in tools

* fix: import error and more circular dependencies in formHelpers

* fix prettier error

* fix: circular dependency in danger-zone-saga

* fix: circular dependency in update-email-saga

* fix: circular dependency in settings-saga

* fix: circular dependency in accept-terms-saga

* fix: circular dependency in codeally-saga

TODO: make a separate file for selectors

* fix: ci lint error

* fix: ci lint:prettier error

* fix: circular dependency in current-challenge-saga

* fix: cricular dependency in Challenges/redux

* fix: circular dependency in redux/settings

* fix: circular dependency in root redux

* fix: lint errors

* chore: remove unecessary comment

* chore: remove unused export

* fix: clear out actions and selectors

* revert changes to package.json

* test ci with maxDepth of 1

* fix: fallback to empty object

* test action if it will run for maxDepth of 2
2022-10-05 18:08:40 +01:00
Matheus Pormanhani
888c9ca75e chore: migrate client/components/formHelpers/Form.test.js to TS (#45726) 2022-04-20 14:37:54 +02:00
Shaun Hamilton
8b3f3251b4 feat(client): match .freecodecamp.org for submissions (#45386) 2022-03-09 09:56:09 +01:00
renovate[bot]
bec2deb3c0 chore(deps): update typescript-eslint monorepo to v5.13.0 (#45294)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-03-02 11:00:55 +01:00
Oliver Eyton-Williams
7fe4695794 refactor: ignore eslint less (#45082)
* refactor: remove and fix some eslint disables

* refactor: drop max-line disables
2022-02-11 10:28:13 -08:00
Oliver Eyton-Williams
01b354f0d1 refactor: mollify TypeScript 2021-12-02 19:57:47 +05:30
Vishwasa Navada K
9abc5f66ba feat(client): ts-migrate multiple files (#43262)
* feat(client): ts-migrate rename files

* feat(client): ts-migrate client/src/templates/Introduction/*

* feat(client): ts-migrate client/src/components/formHelpers/form*

* fix: import

* Update client/src/components/formHelpers/form-validators.tsx

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update client/src/components/formHelpers/form-fields.tsx

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update client/src/components/formHelpers/form-fields.tsx

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: types in client/src/components/formHelpers/index.tsx

* fix: types in client/src/templates/Introduction/super-block-intro.tsx

* fix: types in client/src/components/formHelpers/*

* fix: signInLoading and value types

* Update client/src/templates/Introduction/super-block-intro.tsx

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update client/src/components/formHelpers/index.tsx

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update client/src/components/formHelpers/index.tsx

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update client/src/components/formHelpers/index.tsx

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* chore(deps): update dependency rollup to v2.58.1

* fix: rename variables and fix imports for ts-migrate

* fix: remove `Type` suffix from the type definition.

* Update client/src/components/formHelpers/form.tsx

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-10-25 18:45:36 +01:00
Maciek Sitkowski
3eae0645ab fix: add translated close button label in alert messages (#43810) 2021-10-13 11:07:29 +02:00
Oliver Eyton-Williams
e118dda13a fix: order imports and remove circular dependencies (#41824)
* fix: remove circular dependency

redux depended on templates/Challenges/redux and vice versa.  This
meant that import order mattered and confusing bugs could arise.

(cherry picked from commit 7d67a4e70922bbb3051f2f9982dcc69e240d43dc)

* feat: require imports to be in alphabetical order

Import order generally does not matter, but there are edge cases
(circular  imports and css imports, for example) where changing order
changes behaviour

(cherry picked from commit b8d1393a91ec6e068caf8e8498a5c95df68c2b2c)

* chore: order imports

* fix: lift up challenge description + title comps

This brings the classic Show closer to the others as they
now all create the description and title components

* fix: remove donation-saga/index circular import

(cherry picked from commit 51a44ca668a700786d2744feffeae4fdba5fd207)

* refactor: extract action-types from settings

(cherry picked from commit 25e26124d691c84a0d0827d41dafb761c686fadd)

* fix: lint errors

* feat: prevent useless renames
2021-08-02 08:39:40 -05:00
Anirudh Modi
ef3b7ec955 chore(eslint): enables recommended eslint rules for testing-library and jest-dom (#42817) 2021-07-20 21:21:16 +07:00
Sem Bauke
d23b86f77b feat: convert solutionForm to ts (#42766)
* feat: convert solutionForm to ts

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-07-07 10:38:58 +02:00
Parth Parth
8c1084a97b feat(client): ts-migrate client/src/components/helpers/form and client/src/components/formHelpers (#42476)
* client(feat): migrate client/src/components/helpers/form

* compete migration

* migrate formHelpers

* migrate BlockSaveButton and BlockSaveWrapper

* finish migration

* kebab-caseify

* Update client/src/components/formHelpers/block-save-button.tsx

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix linting errors

* make props optional

Co-authored-by: Parth Parth <thecodingaviator@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-06-30 20:50:57 +05:30
Huyen Nguyen
2c16234853 chore: add jest global variables (#42573) 2021-06-20 09:14:42 +02:00
renovate[bot]
21dd80c47a chore(deps): update dependency prettier to v2.3.0 (#42074)
* chore(deps): update dependency prettier to v2.3.0

* chore: apply formating per prettier

* fix: correctly disable import/no-unresolved

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Mrugesh Mohapatra <hi@mrugesh.dev>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-05-10 08:48:49 -07:00
Oliver Eyton-Williams
9be2fb9a10 fix: use lodash-es in the client (#41931) 2021-04-28 16:11:20 -05:00
Shaun Hamilton
cd722a0e7f fix(client): change repl.it validation to replit for migration (#41457) 2021-03-15 19:37:43 +05:30
Shaun Hamilton
36f58bcfdf fix(client): update store after any submission (#41329) 2021-03-05 02:31:18 +05:30
Shaun Hamilton
d70e33c1d2 feat(i18n): url validation translations (#41190) 2021-02-20 10:32:44 +05:30
Shaun Hamilton
b2ec1a3ef4 feat(client): add common links to formValidators regex (#41094)
* feat(client): add repl join link to formValidators regex

* add fCCRegex to validators
2021-02-19 12:43:54 +01:00
Shaun Hamilton
f157eda1af fix(client): allow editor links for Py submissions (#41036)
* fix(client): allow editor links for Py submissions

* add isEditorLinkAllowed to PropTypes
2021-02-10 17:01:08 +05:30
Shaun Hamilton
ea1c132868 feat(client): add github to validation list (#40894) 2021-02-04 12:14:35 +05:30
Shaun Hamilton
ab83d698f9 fix(client): give useful error in solutionform (#40225) 2021-02-01 19:04:04 +05:30
Tom
3978c6be28 feat: i18n user interface (#40306)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-01-31 12:15:32 +05:30
Oliver Eyton-Williams
b9db30f7a1 refactor(client): move jest-dom into setup file 2020-10-12 14:11:52 +02:00
Sky020
dea4e51371 fix(client): remove unused formHelper functions 2020-09-15 17:07:54 +03:00
Sky020
c4240cdf2f fix: allow form label and name to differ
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-09-15 17:07:54 +03:00
Abdelrahman Ashraf
94532f98db refactor(tests): enzyme => react-testing-library (#37712)
* refactor: 💡 rewrite enzyme tests in react-testing-library

* fix: 🐛 remove enzyme imports from frame-runner.js

* chore: 🤖 install and add enzyme imports to frame-runner.js back
2019-11-08 16:50:25 +05:30
mrugesh
5d92b3c668 fix: project views and icons for intros (#36811) 2019-09-19 10:14:58 +03:00
Valeriy
d85425fd1b feat(client): use React Final Form instead of Redux Form (#36742) 2019-09-04 18:18:58 +05:30
Mrugesh Mohapatra
298e263f74 chore(client): resolve linting errors in client 2019-07-22 17:10:54 +05:30
Valeriy
fbb8311af7 fix(client):format url values on form submit 2019-06-19 20:08:57 +05:30