Oliver Eyton-Williams
adfb87e898
feat: only remove comments when specified in the test ( #54372 )
2024-04-25 18:03:43 -07:00
Lasse Jørgensen
13f32175db
fix(curriculum): better explanation of then callback ( #52665 )
...
Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com >
2023-12-21 10:19:44 +01:00
surajkewat
59fc6dd186
fix(curriculum): improved sentence framing ( #51658 )
...
Co-authored-by: Suraj Kewat <suraj.kewat@getastra.com >
2023-09-26 20:52:26 +07:00
Naomi Carrigan
f286dd0bd6
fix(curriculum): update tests for spread challenge ( #51274 )
...
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com >
2023-08-23 08:58:33 +02:00
Oliver Eyton-Williams
918cabed2d
fix: remove comments again ( #50718 )
...
Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com >
2023-06-17 23:19:55 +07:00
Naomi Carrigan
2abd929426
fix(curriculum): rounding issue in getter/setter challenge ( #50560 )
2023-05-31 17:56:47 +05:30
Rabin Osti
129f629e10
fix(curriculum): array spread syntax example ( #50416 )
...
array literal spread syntax #50414 fixed
2023-05-18 11:05:06 -07:00
Walid Mouaaouia
aab4c2e132
fix(curriculum): Changed the paragraph about map/filter/reduce in ES6 JS ( #49629 )
2023-03-11 06:44:12 +02:00
sumit shinde ( Roni )
123b2d54da
fix: replaced reduce method with for loop ( #49525 )
...
add: reaplaced reduce method to for loop
2023-02-27 11:44:42 +02:00
a2937
8d8a4d172e
chore(curriculum): Remove an incorrect sentence ( #49134 )
...
Chore: Remove an incorrect sentence
2023-01-25 15:04:38 +00:00
Roy Gavrielov
2d15e768ff
fix(curriculum): Update title and text of rest elements challenge ( #48793 )
...
Update title and text of rest elements challenge
2022-12-20 12:22:36 +01:00
Lasse Jørgensen
25c257f4c8
fix(curriculum): switch from getUserInput to code ( #48676 )
2022-12-07 11:39:57 +04:00
Rebecca Burch
53d6ea90fd
fix(curriculum): remove an extra space in a hint ( #48584 )
...
removed extra space between should and be in md
2022-11-24 19:43:19 +01:00
Jeremy L Thompson
00f047728b
fix(curriculum): update code order to help with confusion ( #48366 )
...
* minor - update order to help with confusion
* update variable names, remove source from tests
* minor - wording
* missing variable rename
2022-11-03 09:09:30 +01:00
Jeremy L Thompson
fd34202188
fix(curriculum) - more commas in destructuring ( #48176 )
...
fix - support extra commas
2022-10-23 23:03:43 +09:00
Niraj Nandish
441f11db38
feat: mobile curriculum testing ( #47586 )
...
* feat: first draft of action and cypress spec
* feat: test all generated challenges
* fix: better identification of block
* action: update cypress config
* action: upload to dashboard
* action: testing js cert challenges
* fix: unnecessary after user code for Make a Person
* feat: capture console log output for assert test
* fix: remove after seed code
* fix: change const to let
* fix: test
* action: disable js certification
* action: stop checking out branch in action
* action: check out right mobile repo
Co-authored-by: sembauke <semboot699@gmail.com >
2022-10-14 16:57:34 -07:00
Atir Nayab
fdaa149758
fix(curriculum): updated ES5 and ES6 class description ( #47935 )
...
* fix(curriculum): updated ES5 and ES6 class description
* fix: es5 example removed
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.md
Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org >
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.md
Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org >
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.md
Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org >
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.md
Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org >
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.md
Co-authored-by: Sem Bauke <semboot699@gmail.com >
Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org >
Co-authored-by: Sem Bauke <semboot699@gmail.com >
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com >
2022-10-12 16:20:15 +02:00
Santiago Miranda
a9d2198aba
Better wording of exercise description ( #47431 )
...
Update mutate-an-array-declared-with-const.md
Fixed unclear part of the exercise description. As cited by user [in the forum](https://forum.freecodecamp.org/t/cannot-understand-the-following-line-in-question/549786/3 )
2022-09-02 17:01:08 +00:00
hanswang123456
87f0f75d9e
fix(curriculum): update test regex to allow whitespaces ( #47150 )
...
* Added spacing fix to catch end of line spaces
* allow for spaces before "("
2022-08-08 12:37:49 +01:00
DanielRosa74
08114a2aba
fix: misspelling of 'between' on line 11 ( #46687 )
...
This fixes a misspelling on line 11.
2022-06-27 21:35:58 +02:00
Muhammed Mustafa
3e3da4ec0f
fix(curriculum): standardize links in curriculum ( #46564 )
...
* fix(curriculum): standradize links in curriculum
* Data analiysis links
* CIP links
* fixed links in s-expressions
* Update curriculum/challenges/english/01-responsive-web-design/basic-css/use-hex-code-for-specific-colors.md
Co-authored-by: Ilenia <nethleen@gmail.com >
* added space before target attribute
* standarize external and .rock example links
* wrap "check out the projects" around the links
Co-authored-by: Ilenia <nethleen@gmail.com >
2022-06-26 11:13:38 -05:00
Radi Totev
0a3690572c
fix: failing challenge test because of commented out code ( #45492 )
...
id: 587d7b87367417b2b2512b43
title: Use Arrow Functions to Write Concise Anonymous Functions
forumTopicId: 301211
dashedName: use-arrow-functions-to-write-concise-anonymous-functions
User code tests fail when seed code is left and commented out.
2022-03-29 08:36:13 -07:00
Kristofer Koishigawa
bcc9beff1f
feat(curriculum): introduce let and const earlier ( #43133 )
...
* fix: move "Explore Differences Between..." to basic JS, update seed and tests
* fix: resequence "Declare String Variables"
* fix: move "Declare a Read-Only Variable..." to basic JS, update seed and tests
* fix: revert changes to non-English "Explore Differences Between..." test text
* fix: revert test strings, solutions, and seeds for non-English challenges
* fix: update "Declare String Variables" description
* fix: sync quotation marks in description and seed
* fix: modify note in "Declare a Read-Only..." challenge
* fix: update operator and compound assignment challenges
* fix: update string challenges
* fix: update array and array method challenges
* fix: update function and scope challenges, resequence slightly
* fix: "Word Blanks" solution
* fix: add spacing to seed
* fix: concatenating += challenge spacing
* fix: appending variables to strings spacing
* fix: find the length of a string spacing
* fix: removed instances of removedFromMyArray = 0
* fix: switch challenges
* fix: function argument and param spacing
* fix: update counting cards, object challenges, and record collection
* fix: finish rest of Basic JS section
* fix: introducing else statements solution
* fix: update spacing and wording
* fix: update wording for const challenge
* fix: update functional programming challenges
* fix: intermediate algorithms and cert challenges
* fix: revert some spacing and remove comments for fp challenge solutions
* feat: add notes with links to moved let and const challenges in first two es6 challenges
* fix: update es6 intro text
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/concatenating-strings-with-the-plus-equals-operator.md
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com >
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/finding-a-remainder-in-javascript.md
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com >
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/global-scope-and-functions.md
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com >
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-through-an-array-with-a-for-loop.md
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com >
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-through-an-array-with-a-for-loop.md
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com >
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/functional-programming/implement-map-on-a-prototype.md
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com >
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/declare-a-read-only-variable-with-the-const-keyword.md
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com >
* fix: concatenating strings with plus operator seed
* fix: add comments back to Declare a Read-Only Variable... seed
* feat: add es6 to basic javascript redirect tests for let and const challenges
* fix: revert "Concatenating Strings with Plus Operator" seed
* fix: move test file to cypress/integration/learn/redirects, separate redirect tests
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com >
2021-10-25 17:55:58 +01:00
prashantaghoshal
e4e74aa4f2
fix(curriculum): strip comments from code when testing ( #43597 )
...
* fix: update ES6-Compare Scopes of var and let
Fixes Issue: Adding a comment causes a valid answer to be wrong in ES6 > Compare Scopes of the var and let keywords
Fixes : #43578
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/compare-scopes-of-the-var-and-let-keywords.md
Co-authored-by: Krzysztof <60067306+gikf@users.noreply.github.com >
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/compare-scopes-of-the-var-and-let-keywords.md
Co-authored-by: Krzysztof <60067306+gikf@users.noreply.github.com >
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/compare-scopes-of-the-var-and-let-keywords.md
Co-authored-by: Krzysztof <60067306+gikf@users.noreply.github.com >
Co-authored-by: Krzysztof <60067306+gikf@users.noreply.github.com >
2021-09-29 11:13:41 +02:00
EhEhRon91
9aea61d0df
fix: conflicting info updated ( #43394 )
2021-09-10 15:40:39 +05:30
Evgeny Klimenchenko
db369fbed1
fix(client): remove JS comments from user code for tests ( #41873 )
...
* Removes comments in js challanges by default
* fix local-scope-and-functions test regex
* fix all languages
* revert language changes
* removed unnecessary removeJSComments from challenges
* fix challanges in other languages
* removed removeJSComments from all challanges
2021-04-28 10:18:54 -05:00
CoolBlueDesigns
fd5e6eebfb
fix(curriculum): add blank like to seed code
2021-03-22 16:18:15 +00:00
Andrew Cen
65cc800689
fix: add blank lines on empty seeds ( #41348 )
2021-03-03 13:14:28 -08:00
Nicholas Carrigan (he/him)
7117919d36
chore(learn): audit javascript algorithms and data structures ( #41092 )
...
* chore(learn): audit basic algorithm scripting
* chore(learn): audit basic data structures
* chore(learn): audit basic javascript
* chore(learn): audit debugging
* chore(learn): audit es6
* chore(learn): audit functional programming
* chore(learn): audit intermidate algorithms
* chore(learn): audit js projects
* chore(learn): audit object oriented programming
* chore(learn): audit regex
* fix(learn): remove stray .
* fix(learn): string to code
* fix(learn): missed some
* fix(learn): clarify strings
Based on Randy's feedback, clarifies string instances where quotes
were removed in favour of back ticks.
* fix: apply suggestions - thanks Randy! :)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* fix: non-suggestion comments
* chore(learn): remove comments from codes
Removes the comments from the description and instruction code
blocks to ensure that all relevant information is translatable.
* fix: Apply suggestions from code review
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
* fix: revert crowdin fix
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-algorithm-scripting/mutations.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* fix: Apply suggestions from code review
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-arrays.md
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
* fix: Apply suggestions from code review
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
* chore: change voice
* fix: Christopher Nolan
* fix: expressions would evaluate
* fix: will -> would
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* fix: to work to push
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-with-javascript-for-loops.md
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
2021-03-02 17:12:12 -07:00
gikf
d41630ee19
fix(learn): clarify test description for Use Rest Parameter with Function Parameter ( #40725 )
...
* fix: clarify test description
* fix: improve wording regarding rest parameters syntax
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* fix: improve with better sounding wording
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
2021-01-24 08:30:13 -08:00
Oliver Eyton-Williams
ee1e8abd87
feat(curriculum): restore seed + solution to Chinese ( #40683 )
...
* feat(tools): add seed/solution restore script
* chore(curriculum): remove empty sections' markers
* chore(curriculum): add seed + solution to Chinese
* chore: remove old formatter
* fix: update getChallenges
parse translated challenges separately, without reference to the source
* chore(curriculum): add dashedName to English
* chore(curriculum): add dashedName to Chinese
* refactor: remove unused challenge property 'name'
* fix: relax dashedName requirement
* fix: stray tag
Remove stray `pre` tag from challenge file.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
Co-authored-by: nhcarrigan <nhcarrigan@gmail.com >
2021-01-12 19:31:00 -07:00
Oliver Eyton-Williams
0bd52f8bd1
Feat: add new Markdown parser ( #39800 )
...
and change all the challenges to new `md` format.
2020-11-27 10:02:05 -08:00
Ilenia
f294d9cacc
fix(learn): removed use strict from various challenges ( #40321 )
2020-11-25 15:59:04 -08:00
Timo Köhler
7ce8c58709
Put value into quotes ( #40172 )
...
* Put value into quotes
It can be missunderstanding that "value" is a string!
* fix: remove quotes from inside code tags
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
2020-11-25 16:32:14 -06:00
Nicholas Carrigan (he/him)
49f6875db5
fix(learn): ES6 Getters + Setters tests ( #40238 )
...
* Strengthen tests
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* Improve verbiage
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* Add second check to setter test
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
2020-11-25 14:22:44 -08:00
Shai
8ceae38730
fix(learn): modified usage of words from argument to parameter based on the title ( #40130 )
2020-10-31 19:59:43 +01:00
nick-w-nick
10d3126383
fix(learn): correct minor grammar mistake ( #39915 )
2020-10-13 12:14:49 +01:00
Oliver Eyton-Williams
2b9e38a17b
fix: replace .english.md extension with .md
2020-09-29 22:09:04 +02:00
Walter Palagi
104a8068e3
fix(learn): in ES6 spread operator challenge test for arr2 length > 0 ( #39680 )
...
* fix(learn): in ES6 spread operator challenge test for arr2 length > 0 too
Fixes #39662
* Accept correction
Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com >
Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com >
2020-09-24 16:14:44 -07:00
Joseph Mawa
d5000b5d0f
Removed note about promise chaining as suggested in issue #39487 ( #39609 )
2020-09-18 10:30:37 -05:00
Hassaan Pasha
80438cac3e
feat(client, learn): add helper functions for common validation operations ( #38605 )
...
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2020-09-17 19:38:01 +05:30
Lasse Jørgensen
2743ac2e84
fix(challenge): update variable names, assign empty array, update solution code, remove "use strict" ( #39525 )
...
* fix(challenge): update variable names, assign empty array, update solution code, remove "use strict"
* fix(challenge): update solution code
* fix:(challenge) update instructions and variable name
* fix:(challenge) update instructions
2020-09-09 19:58:27 -05:00
Mrugesh Mohapatra
c23c4ef8e4
fix: negative sentiment → neutral language ( #39522 )
...
The existing terminology carries negative sentiment that can be
interpreted in a racial or sense. Updating the name to have no
potential for such a connection.
Co-authored-by: Justin Rogers <justrog@gmail.com >
2020-09-07 11:04:44 +05:30
Oliver Eyton-Williams
bd68b70f3d
Feat: hide blocks not challenges ( #39504 )
...
* fix: remove isHidden flag from frontmatter
* fix: add isUpcomingChange
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com >
* feat: hide blocks not challenges
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com >
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com >
2020-09-03 15:07:40 -07:00
Ishu Singhal
56469d1c5c
fix(learn): update tests to allow more valid solutions ( #39054 )
...
* fix(curriculum): updated tests: fixed #39049
It won't pass something like this now:
const myConcat = () => {};
console.log(3);
* fix: add suggested change
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com >
2020-09-03 15:28:35 +01:00
bhagerty
046137891e
fix(learn): clarify how object names are associated with destructured fields ( #39485 )
...
* Clarify how object names are associated with destructured fields
* fix: make description more concise
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-pass-an-object-as-a-functions-parameters.english.md
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com >
Co-authored-by: Manish Giri <manish.giri.me@gmail.com >
2020-09-02 19:06:27 +01:00
Tom
9cd4b93601
fix(learn): getter setter instructions ( #39512 )
...
* Update use-getters-and-setters-to-control-access-to-an-object.english.md
* fix: revert changes, keep example
Co-authored-by: Daniel Sing <danielsingsong@gmail.com >
2020-09-02 18:07:17 +01:00
Oliver Eyton-Williams
f1c9b08cf3
fix(curriculum): add isHidden: false to challenges
...
This includes certificates (where it does nothing), but does not
include any translations.
2020-05-25 16:25:19 +05:30
Josh Queen
23ca15241c
fix:(curriculum): Moved code tag to include new keyword ( #38780 )
...
* Moved code tag to include new keyword
The new keyword hasn't been explained in the curriculum yet, so have moved the <code> tag to include the new keyword to give a prompt that it needs to be used in the solution.
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-arrow-functions-to-write-concise-anonymous-functions.english.md
Added comma.
Co-authored-by: Lasse Jørgensen <28780271+lasjorg@users.noreply.github.com >
2020-05-20 10:09:35 +02:00
Paul Gamble
54d59ffc37
Fix/curriculum en es6 complete a promise - modified test messages to be more clearer ( #38836 )
...
* Changed tests messages to indicate string
* minor tweak with wording of message
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
2020-05-19 12:44:59 +02:00