Commit Graph

663 Commits

Author SHA1 Message Date
Surya Kanta Ghosh
83cae1d78e fix(curriculum): ensure left alignment of output in translations (#49524)
* feat: change quotes into pre

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>


Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>

---------

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
2023-02-27 08:10:18 +02:00
Azar
d6bad55e6d fix(curriculum): remove grammatical mistakes (#49426)
fixes #49408

fixes the grammar of sentence 'will call the sum function, ....'. so it is clear who is doing the calling.
2023-02-23 18:37:50 +01:00
Santiago Pereyra Vázquez
f25c89fa68 fix(curriculum): fix Fibonacci sequence text (#49452)
Fixed sum-all-odd-fibonacci-numbers.md text
2023-02-21 08:47:23 +01:00
Rudi Colombi
b4cb4bf947 fix(curriculum): replace blockquotes with pre blocks (#49384)
* fix: replace blockquotes with code blocks

* fix: replace code blocks with pre elements as suggested

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>

---------

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
2023-02-18 10:39:54 -08:00
javrrr
e69d78e51d fix(curriculum): add test cases to ensure single whitespace (#49417)
* fix: update solutions regex to reflect test cases

---------

Co-authored-by: javrrr <javrrr@gmail>
2023-02-18 16:14:07 +02:00
hbar1st
f975728c63 fix(curriculum): remove instruction about run button click (#49415) 2023-02-18 00:19:08 +00:00
Sriparno Roy
b5fcc389f0 fix(curriculum): Fix awkward phrasing (#49358)
* Fix awkward phrasing

* Remove sentence
2023-02-13 21:38:27 +01:00
a2937
8d8a4d172e chore(curriculum): Remove an incorrect sentence (#49134)
Chore: Remove an incorrect sentence
2023-01-25 15:04:38 +00:00
MhemedAbderrahmen
33c5bc9406 fix: removed special characters from RTL titles (english) (#48998)
fix: removed special characters from RTL titles
2023-01-24 11:43:41 +02:00
mdnavarro21
0126389f18 fix(curriculum): update javascript challenge description (#48989)
Closes https://github.com/freeCodeCamp/freeCodeCamp/issues/48928
2023-01-11 10:39:12 +01:00
Oliver Eyton-Williams
4054cf8d06 fix: update comment to match dictionary (#48900) 2023-01-03 16:13:56 +05:30
Roy Gavrielov
2d15e768ff fix(curriculum): Update title and text of rest elements challenge (#48793)
Update title and text of rest elements challenge
2022-12-20 12:22:36 +01:00
Lasse Jørgensen
25c257f4c8 fix(curriculum): switch from getUserInput to code (#48676) 2022-12-07 11:39:57 +04:00
Jeremy L Thompson
bafcaaa17d fix(curriculum): Typo in map test description (#48681)
fix - typo in test description
2022-12-06 11:28:06 -08:00
Lasse Jørgensen
60189fb119 fix(curriculum): typo in test output (#48677) 2022-12-06 17:36:41 +01:00
Naomi Carrigan
2325cc5ee9 feat: add additional test cases (#48628) 2022-11-30 18:52:38 +00:00
ctbaird
7d90b9a179 fix(curriculum): replace instance of var with let (#48610)
fix(curriculum): replace var with let in scope challege english only

Co-authored-by: Catherine Baird <bairdc@cua.edu>
2022-11-28 13:46:50 +00:00
Rebecca Burch
53d6ea90fd fix(curriculum): remove an extra space in a hint (#48584)
removed extra space between should and be in md
2022-11-24 19:43:19 +01:00
Jeremy L Thompson
cab8ecd8ba fix(curriculum): More Open Ended Instructions (#48575)
reword - less is more
2022-11-24 19:42:10 +01:00
Jeremy L Thompson
8a01079b7a fix(curriculum): typo in example (#48534)
fix - typo in example
2022-11-17 17:24:47 -08:00
Bryan Moore
d268822fe4 fix(curriculum): remove comments and extra code (#48531) 2022-11-17 15:15:12 -08:00
sivalaxman7
aedcfa2d05 fix(curriculum): changed filter description (#48524)
* changed filter description

* review change

* build

* file
2022-11-17 18:35:31 +00:00
Naomi Carrigan
1474aa588c fix: remove pre-filled test case and comment (#48519) 2022-11-15 18:20:10 +00:00
Jeremy L Thompson
9609e3a19b fix(curriculum): Fixing global variable abuse in functional JS challenges (#48483) 2022-11-14 12:48:21 +05:30
Atir Nayab
9b95c2d95e fix(curriculum): update object example in Using Objects for Lookups (#48422)
* fix(curriculum): update object example in Using Objects for Lookups

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/using-objects-for-lookups.md

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>

* fix(curriculum): description update in Using Objects for Lookups

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2022-11-09 01:37:22 +05:30
Jeremy L Thompson
00f047728b fix(curriculum): update code order to help with confusion (#48366)
* minor - update order to help with confusion

* update variable names, remove source from tests

* minor - wording

* missing variable rename
2022-11-03 09:09:30 +01:00
Atir Nayab
ace378bff1 fix(curriculum): improve testing in regex challenge (#48266)
* fix(curriculum): add 2 test cases and updated solution

* fix(curriculum): solution regex updated

* fix(curriculum): regex expression updated in regex challenge

* fix(curriculum): solution regex expression updated in regex challenge
2022-11-01 12:41:31 -07:00
Andrew Dawes
95561b0cb4 fix(curriculum): several typos and grammar errors (#48210)
* Fixed several typos and grammar errors

* Revert to an because the context is english US

* Fixed some weird wording

* Switch a to an

Co-authored-by: Ilenia <nethleen@gmail.com>

Co-authored-by: Ilenia <nethleen@gmail.com>
2022-10-25 13:38:21 +02:00
Jeremy L Thompson
fd34202188 fix(curriculum) - more commas in destructuring (#48176)
fix - support extra commas
2022-10-23 23:03:43 +09:00
Niraj Nandish
441f11db38 feat: mobile curriculum testing (#47586)
* feat: first draft of action and cypress spec

* feat: test all generated challenges

* fix: better identification of block

* action: update cypress config

* action: upload to dashboard

* action: testing js cert challenges

* fix: unnecessary after user code for Make a Person

* feat: capture console log output for assert test

* fix: remove after seed code

* fix: change const to let

* fix: test

* action: disable js certification

* action: stop checking out branch in action

* action: check out right mobile repo

Co-authored-by: sembauke <semboot699@gmail.com>
2022-10-14 16:57:34 -07:00
abe
4ab1dd8926 fix(curriculum): recursion challenges that abuse global space (#47680)
* fix: recursion challenges that abuse global space #43516

* fix challenge phrasing and create separate test

* fix: challenges which pollute/impure functions should not pass

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/javascript-algorithms-and-data-structures-projects/cash-register.md

allow users to ab(use) global space in cash register

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/build-a-roman-numeral-converter-project/roman-numeral-converter.md

allow users to abuse global space in roman numeral converter

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: kravmaguy <flex4lease@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2022-10-12 15:00:24 -05:00
Atir Nayab
fdaa149758 fix(curriculum): updated ES5 and ES6 class description (#47935)
* fix(curriculum): updated ES5 and ES6 class description

* fix: es5 example removed

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.md

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.md

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.md

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.md

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.md

Co-authored-by: Sem Bauke <semboot699@gmail.com>

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>
Co-authored-by: Sem Bauke <semboot699@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2022-10-12 16:20:15 +02:00
Jeremy L Thompson
d1e65cfafa fix(curriculum): faster solution for primes (#47990) 2022-10-12 09:05:43 +02:00
Alekzandriia
a02cd6448c fix(learn): update verbiage to emphasize on \n instead of \r (#47841)
Co-authored-by: Ilenia <nethleen@gmail.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2022-10-11 20:02:47 +02:00
Derryk Boyd
f0ebb337e2 fix: update challenge description for array concat (#47786)
Co-authored-by: Derryk Boyd <derryk@redmantech.com>
2022-10-03 10:23:00 +02:00
tanmay thakral
35b607d2d8 fix(curriculum): falsy bouncer - do not mutate the original array (#47718)
Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
2022-10-02 01:57:53 +05:30
Maciej Bąba
533c0345e4 fix(learn): lack of block code declaration (#47506)
Fix lack of block code declaration
2022-09-12 15:46:20 -07:00
Tuukka Hastrup
14076cbde0 fix(curriculum): Clarify understand-string-immutability (#47448)
* Clarify understand-string-immutability

Remove some misleading explanation (immutability is orthogonal to literals).

* Remove extraneous whitespace

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>

* Improve explanation per review suggestion

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>
2022-09-07 19:35:41 +02:00
Santiago Miranda
a9d2198aba Better wording of exercise description (#47431)
Update mutate-an-array-declared-with-const.md

Fixed unclear part of the exercise description. As cited by user [in the forum](https://forum.freecodecamp.org/t/cannot-understand-the-following-line-in-question/549786/3)
2022-09-02 17:01:08 +00:00
Leah Thompson
c759d83cd3 fix: add comma to fix typo (#47378)
added a comma to fix typo
2022-08-25 11:36:35 +00:00
mjh
ab82857ab2 fix(curriculum): Made output for sample code in snippet clearer - Multidimensional Array Access (#47222)
* Made output for sample code in snippet clearer

* Made formatting more consistent

* Fixed names for formatting fix
2022-08-09 20:39:56 +00:00
hanswang123456
87f0f75d9e fix(curriculum): update test regex to allow whitespaces (#47150)
* Added spacing fix to catch end of line spaces

* allow for spaces before "("
2022-08-08 12:37:49 +01:00
Abhishek Sharma
9a9cef38bd fix(curriculum): updated JS debugging challenge run-test (#47139) 2022-08-03 18:29:04 +02:00
Sameer Supe
3cc300127e fix(curriculum): test case for arguments optional (#47059)
* added test case for curriculum

* Revert "added test case for curriculum"

This reverts commit a23ee9d3cd.

* added test case for curriculum
2022-07-28 15:11:06 +02:00
Jeremy L Thompson
d0e42982f0 fix(curriculum) - simplify example of property access (#46967)
minor - simplify challenge examples
2022-07-21 09:05:26 -07:00
Randell Dawson
2de9458c5b fix: added extra test to prevent incorrect solution from passing for the Wherefore art thou challenge (#46959)
fix: added extra test to stop incorrect solution
2022-07-20 08:58:42 -05:00
Jeremy L Thompson
de7dce41e6 fix(curriculum) Convert C to F function - more ideomatic name (#46875)
minor - more ideomatic name

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
2022-07-13 15:22:21 +05:30
Ilenia
237f11be8b chore: change type of challenges to type 1 js (#46826) 2022-07-11 11:06:08 +02:00
Randell Dawson
55b3fcef3b fix(curriculum): Add new tests to check for space between result strings for two JavaScript challenges involving string concatenation (#46833) 2022-07-10 19:39:52 +07:00
Dhruv Gajjar
a18639dc07 fix(curriculum): Dead code example in (#46825)
fix(curriculum): Dead code example in #46813
2022-07-10 09:06:12 +02:00