Oliver Eyton-Williams
51bb887a28
test: fix multifile tests ( #46384 )
...
cy.viewport should not be chainable, hence the failure in CI. Also, the
tests need to check for the absence of (Ctrl + Enter), not the presence
Check Your Code since that's present for all viewports.
2022-06-07 22:35:34 +05:30
camperbot
ecfac5733c
chore(i18n,client): processed translations ( #46381 )
2022-06-07 14:00:36 -03:00
Abhinav Srinivas
87b092de61
fix: improved the instructions for RWD challenges ( #46112 )
...
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com >
2022-06-07 22:14:59 +05:30
Oliver Eyton-Williams
f0f44ca315
feat(client): re-enable failed update re-submission ( #46064 )
...
* refactor: return response with data from ajax
Because we still need to manipulate the data coming back from the server
(files -> challengeFiles) and we want to keep ajax.ts as the interface
between client and server we need to return the manipulated data with
the response.
* feat: re-enable failed updates flushing
* test: failed updates get resubmitted and flushed
* fix: convert settings requests to use { data }
* refactor: use preserveSession
2022-06-07 17:52:23 +03:00
Jordan Moore
fcf2dd7254
fix(UI): Remove 'CTRL + Enter' on CTA for mobile ( #46239 )
...
Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com >
2022-06-07 18:20:16 +05:30
Muhammed Mustafa
db33f49b7b
fix(curriculum): external fibanocci lucas links in CIP ( #46373 )
2022-06-07 19:43:30 +09:00
Muhammed Mustafa
44aeba3d7c
fix(curriculum): external Paul Graham link in CIP ( #46374 )
2022-06-07 19:40:47 +09:00
Muhammed Mustafa
73cdd8a129
fix(curriculum): external y-combinator links in CIP ( #46360 )
...
* fix(curriculum): external y-combinator links in CIP
* broke the paragraph into two
* Grammar typo
Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com >
Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com >
2022-06-07 19:15:22 +09:00
Muhammed Mustafa
05c690e1e6
fix(curriculum): external sum of the series link in CIP ( #46375 )
2022-06-07 10:54:18 +02:00
Muhammed Mustafa
93269eb0c2
fix(curriculum): external USA link in CIP ( #46376 )
2022-06-07 10:53:05 +02:00
Muhammed Mustafa
be7c663bda
fix(curriculum): external sudoku links in CIP ( #46377 )
2022-06-07 10:52:03 +02:00
Muhammed Mustafa
04c7a6109a
fix(curriculum): external soundex links in CIP ( #46344 )
...
Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com >
2022-06-07 13:49:20 +05:30
camperbot
76321e5acb
chore(i18n,learn): processed translations ( #46369 )
2022-06-06 07:55:35 -07:00
camperbot
44b47e9e87
chore(i18n,client): processed translations ( #46368 )
2022-06-06 20:18:18 +05:30
Muhammed Mustafa
ea0f2d6e52
fix(curriculum): external bogsort link in CIP ( #46364 )
2022-06-06 13:03:00 +02:00
Muhammed Mustafa
83a48a9efd
fix(curriculum): external subleq link in CIP ( #46365 )
2022-06-06 13:02:33 +02:00
Muhammed Mustafa
190159d57d
fix(curriculum): external kaprekar link in CIP ( #46329 )
2022-06-06 11:28:14 +03:00
Muhammed Mustafa
f842bc04a1
fix(curriculum): external dot product link in CIP ( #46322 )
2022-06-06 11:15:10 +03:00
Muhammed Mustafa
cd63d6401b
fix(curriculum): external heronian link in CIP ( #46363 )
2022-06-06 11:14:06 +03:00
Muhammed Mustafa
8b8a5545d6
fix(curriculum): external luhn test link in CIP ( #46362 )
2022-06-06 11:13:27 +03:00
Muhammed Mustafa
e7d7702e25
fix(client-UI): view button takes full width ( #45964 )
...
* added class to td so it takes full width
* added width 100% to dropbox components
* removed excessive code
* limit the max space dropdown takes
* `view` takes the same size as `show-solution`
* undo previous change
* view takes the same size as show-solution
* fix: static width for buttons on small screen
* fix: remove max-width cause iocd
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com >
2022-06-06 08:43:48 +02:00
Muhammed Mustafa
09d66c5e95
fix(curriculum): external longest subsequence link in CIP ( #46348 )
...
* removed the link
* made the arrays look like array instead of object
* subsequence doesn't need to look like an array
2022-06-06 08:29:30 +02:00
Renovate Bot
e5ed578541
fix(deps): update dependency react-i18next to v11.17.0
2022-06-06 00:45:41 +00:00
Renovate Bot
f05262b823
chore(deps): update dependency @types/validator to v13.7.3
2022-06-05 21:20:00 +00:00
Muhammed Mustafa
ef9e115050
fix(curriculum): external jsconf youtube link in CIP ( #46328 )
2022-06-06 00:03:05 +07:00
Alan Luo
095cf332fe
fix(curriculum): fix mismatch description ( #46342 )
2022-06-05 23:58:24 +07:00
Muhammed Mustafa
12e3b8a40c
fix(curriculum): external dealCards link in CIP ( #46345 )
2022-06-05 23:57:11 +07:00
Muhammed Mustafa
2fd8c6047a
fix(curriculum): external taxicab links in CIP ( #46346 )
2022-06-05 23:55:49 +07:00
Muhammed Mustafa
aab98a1211
fix(curriculum): external long multiplication link in CIP ( #46327 )
2022-06-05 23:42:06 +07:00
Muhammed Mustafa
a10f9039b2
fix(curriculum): external pancake sorting link in CIP ( #46326 )
2022-06-05 23:41:03 +07:00
Bill Cheng
8397129aaa
fix(curriculum): Add test output to not change strings assigned to variables ( #46353 )
2022-06-05 10:51:36 -05:00
Renovate Bot
9ad8bf5435
chore(deps): update dependency webpack to v5.73.0
2022-06-05 15:30:20 +00:00
Renovate Bot
c5e1cbbbab
chore(deps): update dependency lint-staged to v12.5.0
2022-06-05 12:56:35 +00:00
Dario-DC
a83b8414d7
fix(curriculum): typo in step 18 of piano project ( #46343 )
2022-06-05 09:34:15 +02:00
Renovate Bot
4ff5d480c0
chore(deps): update codesee to v0.276.0
2022-06-05 05:48:10 +00:00
Renovate Bot
902ca385ee
fix(deps): update dependency typescript to v4.7.3
2022-06-05 03:43:47 +00:00
Renovate Bot
366e18e339
fix(deps): update babel monorepo to v7.18.4
2022-06-05 01:42:33 +00:00
Renovate Bot
48bfe48dc8
chore(deps): update storybook monorepo to v6.5.6
2022-06-04 22:39:57 +00:00
Renovate Bot
b3ed01b226
chore(deps): update dependency ts-node to v10.8.1
2022-06-04 19:54:43 +00:00
Titi
14bf77d3b8
chore: removed unneeded check for semicolon
2022-06-04 11:09:55 -05:00
Renovate Bot
ece0bfd3c2
chore(deps): update dependency rollup to v2.75.5
2022-06-04 15:35:16 +00:00
Renovate Bot
839cea7811
chore(deps): update dependency @types/node to v16.11.38
2022-06-04 13:38:53 +00:00
Muhammed Mustafa
07a5f5cf48
fix(curriculum): external stooge sort link in CIP ( #46303 )
2022-06-04 11:57:30 +05:30
renovate[bot]
9623cd7b46
chore(deps): update github/codeql-action digest to a6611b8 ( #46317 )
...
Co-authored-by: Renovate Bot <bot@renovateapp.com >
2022-06-04 11:56:51 +05:30
Renovate Bot
0de86d9b3d
chore(deps): update dependency @types/jest to v27.5.2
2022-06-04 05:17:33 +00:00
Renovate Bot
e9574c4f67
chore(deps): update dependency @testing-library/cypress to v8.0.3
2022-06-04 02:45:26 +00:00
L4rryFisherman
0562a41781
fix(curriculum): increase readability of the introduction ( #46300 )
...
* fix(curriculum): increase readability of the introduction
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/generate-an-array-of-all-object-keys-with-object.keys.md
Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org >
Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org >
2022-06-03 16:15:25 -05:00
casem725
e627b5e0ad
Added quotations around 'Question #' ( #46302 )
...
* Added quotations around 'Question #'
* fix: remove double quotes in assert
Co-authored-by: Casey <casay725@gmail.com >
Co-authored-by: Bruce B <bbsmooth@gmail.com >
2022-06-03 15:35:45 -05:00
Radi Totev
e581bd9081
feat(client): shortcuts legend modal available on pressing the ? key ( #45530 )
...
* Add modal texts in translations.json file
* Add shortcuts modal state in redux
* Create shortcuts modal
* Integrate shortcuts modal
* Resolve codefactor.io issues
* Extend list of shortcuts
Based on this comment:
https://github.com/freeCodeCamp/freeCodeCamp/issues/36841#issuecomment-933310078
* Remove temporary placeholder for modal title
* Open modal fom Hotkeys instead of learn.tsx
As suggested in this comment:
https://github.com/freeCodeCamp/freeCodeCamp/pull/45530#issuecomment-1101224993
* Complete list in transaltions
* Change shortcut presentation fo better a11y
Use table instead of list items as suggestedin this comment:
https://github.com/freeCodeCamp/freeCodeCamp/pull/45530#issuecomment-1101796368
* Add aria-labelledby
* Remove GAnalytics
* Remove leftover style
* Remove table caption
* autofocus on modal close button
* Improve modal a11y
- Add requested changes from https://github.com/freeCodeCamp/freeCodeCamp/pull/45530#issuecomment-1104764766
- Leave autofocus and parent div role=dialog changes for later. (https://github.com/freeCodeCamp/freeCodeCamp/pull/45530#issuecomment-1107754148 )
* [WIP] Alllow users to turn off keyboard shortcuts
* Add keyboard shortcuts switch in settings
* Disable shortcuts
* Remove toggle switch description
* Refactor and cleanup
* Remove close button from modal header
Suggested by bbsmooth:
https://github.com/freeCodeCamp/freeCodeCamp/pull/45530#issuecomment-1107861091
* Fix lint issues
* Disable shortcuts
* Disable shortcuts by default
* Update challenge output test
* Update challenge-hot-keys test
* Disable shortcuts from inside handlers
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com >
2022-06-03 09:57:52 -07:00
Oliver Eyton-Williams
42ec3e2ecb
test: reduce flake on multifileCertProject ( #46313 )
2022-06-03 09:36:46 -07:00