Commit Graph

70 Commits

Author SHA1 Message Date
Muhammed Mustafa
2123b447bc feat(client): hide the outline instead of removing it (#49716)
* feat(client): hide the outline instead of removing it

* remove the old :focus outline values

Co-authored-by: Bruce B <bbsmooth@gmail.com>

---------

Co-authored-by: Bruce B <bbsmooth@gmail.com>
2023-04-20 10:02:15 -05:00
Muhammed Mustafa
47944110b0 refactor(client): wrong TFunction type in searchBar (#49859)
refactor(client): mis aligned types in searchbar
2023-03-30 14:01:33 -05:00
Muhammed Mustafa
b67a82ff0a fix(client): import TFunction from i18next in profile componenets (#49814)
* fix(client): import TFunction from i18next

* Import Tfunction as type

* swap tFuntion with the hook when possilbe
2023-03-30 10:28:14 -05:00
Slieptsov Denys
e64bac9a3f fix(learn): progress bar label alignment (#49659)
Co-authored-by: Denys Slieptsov <denys.slieptsov@leaseplan.com>
2023-03-15 13:15:39 +00:00
Mrugesh Mohapatra
96a5699c39 chore: rename icons (#49319) 2023-02-10 13:11:16 +00:00
Manabu Matsumoto
4aa3b4d6ad fix(UI): refactor the searchbar from flex to grid (#48944)
* fix: refactor the searchbar from flex to grid

* fix: refactor the way of displaying searchbar input outline

* chore: remove unnecessary border settings

* fix: follow the RTL support best practice

* fix: follow the RTL support best practice

* fix: remove unnecessary grid gap and refactor for RTL

* fix: refactor the padding setting with padding block

Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>

* fix: refactor the padding setting with padding inline

Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>

* fix: refactor the positioning of reset button in searchbar

Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>
2023-01-10 16:19:55 +09:00
YMatsuda
2a473098b4 chore(i18n): small fixes in translations.json (#48894) 2023-01-02 22:32:52 +05:30
Manabu Matsumoto
95b724a3a2 feat(UI): visualize input clear button (#48702)
* feat: visualize search bar inputs clear button

* chore: remove redundant empty lines

* fix: make search bar input horizontally responsive

* fix: make search bar input width follow suggestion items

* fix: moving clear button to right of the searchbar

* feat: add search bar clear button in LP

* fix: add a bigger spacing between the icons and the text

* fix: make the clear button show visible focus indicator

* chore: refactor the css code to avoid redundancy

* fix: make the buttons in search bar accessible for screen reader

* fix: make the buttons and input in search bar more accessible
2022-12-23 17:00:38 -06:00
Muhammed Mustafa
8cc575c9b9 feat: swap to logical properties for spacing (#48769) 2022-12-22 10:51:19 +05:30
Muhammed Mustafa
b5371f56ce refactor(client): searchbar - remove float values (#48292)
* feat(client): refactor searchbar by removing float values

* polish the style by adding border radius and removing padding

* Polish the style and account for donation text

* WIP: remove float values

* Revert "WIP: remove float values"

This reverts commit c1c32aa9d1.

* adjust magic numbers

* Adjust spacing to account and add position absolute

* revert the deletion of ais hits values

* move the padding value to searchbar file

* Remove RTL Values

* feat: allow for hint expansions

* Remove the left value on submit icon

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

* add display none and remove their values

Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com>
2022-12-08 14:31:05 +01:00
Anubhav Jain
88c54192b9 fix(client): remove unused files (#47974)
* removed unused files

Removed unused files as per comments for issue #47971

* fix: removed duplicate exports from 4 files

* Build fix

* made changes for build fix

* made changes for build fix
2022-10-14 18:54:09 +05:30
Oliver Eyton-Williams
01b354f0d1 refactor: mollify TypeScript 2021-12-02 19:57:47 +05:30
Oliver Eyton-Williams
efba2e777d chore: simplify eslint configuration (#44347)
* chore: extend import/recommended

* chore: use recommended lint rules

* refactor: apply lint rules

* chore: drop used config
2021-12-02 00:01:12 +00:00
Nicolas Ramirez
c8ba3e9316 chore(client): rename test.tsx files to kebab-case (#44261) 2021-11-24 22:16:46 +00:00
Oliver Eyton-Williams
89c94e54e7 chore(client): add and apply naming convention (#44110)
* refactor: remove unused types

* chore: add naming-convention lint rule

* refactor: rename redux proptypes

* chore: remove Type suffix from prop-types

* chore: apply conventions to ajax

* chore: apply convention to create-types

* chore: apply convention to show-project-links

* chore: search-bar

* chore: Hotkeys

* chore: privacy

* chore: portfolio

* chore: search-page-hits

* chore: search-suggestion

* chore: search-hits

* chore: no-hits-suggestion

* chore: timeline-pagination

* chore: various profile files

* chore: heat-map

* chore: portfolio

* chore: certifications

* chore: landing-top

* chore: certifications

* chore: campers-image

* chore: big-call-to-action

* chore: paypal related files

* chore: show-user

* chore: show-settings

* chore: show-certification

* test: rename profile snap

* fix: ignore snake case for stripe card form

* refactor: remove duplicate type declarations

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: handle null solutions in Timeline

* test: add remaining Profile props

* refactor: revert accidental rename

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2021-11-11 10:09:50 -08:00
Noor Fakhry
8518079316 fix(client):make menu bar disappear after user chooses item from it on landing page (#43458)
* removed serachBarRef

* removed serachBarRef

* Revert "removed serachBarRef"

This reverts commit 6a5c2f4cb3.

* Revert "removed serachBarRef"

This reverts commit 67710b3d18.

* added innerRef as ref to SearchBarOptimized component

* Update client/src/components/Header/index.tsx

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update client/src/components/search/searchBar/search-bar-optimized.tsx

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update client/src/components/search/searchBar/search-bar-optimized.tsx

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-10-06 16:42:54 +02:00
awu43
4134404bfd feat(client): ts-migrate WithInstantSearch.js (#42923)
* rename to TS

* update import

* migrate with-instant-search

* change falsy values to empty string

* update import order

Finish resolving conflict from #41824

* update import order for search-bar

* update setTimeout() type
2021-08-05 21:00:30 +01:00
Oliver Eyton-Williams
e118dda13a fix: order imports and remove circular dependencies (#41824)
* fix: remove circular dependency

redux depended on templates/Challenges/redux and vice versa.  This
meant that import order mattered and confusing bugs could arise.

(cherry picked from commit 7d67a4e70922bbb3051f2f9982dcc69e240d43dc)

* feat: require imports to be in alphabetical order

Import order generally does not matter, but there are edge cases
(circular  imports and css imports, for example) where changing order
changes behaviour

(cherry picked from commit b8d1393a91ec6e068caf8e8498a5c95df68c2b2c)

* chore: order imports

* fix: lift up challenge description + title comps

This brings the classic Show closer to the others as they
now all create the description and title components

* fix: remove donation-saga/index circular import

(cherry picked from commit 51a44ca668a700786d2744feffeae4fdba5fd207)

* refactor: extract action-types from settings

(cherry picked from commit 25e26124d691c84a0d0827d41dafb761c686fadd)

* fix: lint errors

* feat: prevent useless renames
2021-08-02 08:39:40 -05:00
Anirudh Modi
ef3b7ec955 chore(eslint): enables recommended eslint rules for testing-library and jest-dom (#42817) 2021-07-20 21:21:16 +07:00
awu43
e1d8f4be3a feat(client): ts-migrate client/src/utils (#42666)
* rename js files to ts

* start migrating ajax

* finish migrating ajax

* migrate algolia-locale-setup

* migrate format

* migrate format.test

* migrate get-words

* install axios for types in handled-error

* migrate handled-error

* migrate handled-error.test

* migrate report-error

* migrate script-loaders

* migrate to-learn-path

* correct renamed imports

* remove unnecessary type assertions in searchBar

* remove unnecessary global comment

* remove unnecessary max-len enable/disable

* change axios imports to type imports

* revert to .then() from await

* use UserType from redux/prop-types

* replace assertion with generic type

* revert format to JS

* remove unused getArticleById()

* update putUpdateUserFlag() to use Record

* remove unnecessary envData cast

* update algolia-locale-setup types

* remove invalid key property
2021-07-12 11:17:58 +02:00
Moshe
63f26db336 refactor(client): Replace <Fragment> tags to <> (#42796)
* refactor(40115): Replace <Fragment> tags to <>
2021-07-09 09:50:11 +02:00
Nicholas Carrigan (he/him)
592a2846d3 chore: pass CI (#42635)
* chore: eslint on icons

* chore: eslint spacer element

* chore: remove more eslint

* fix: existing lint issues

* fix: misnamed import

* fix: client now builds!

* fix: tsc errors

* fix: more linting issues
2021-06-30 20:52:17 +05:30
krishna-saurav
5ad374cc1a feat(client): ts-migrate for files under client/src/component/search folder (#42327)
* typescript migration for files under search folder

* fixing few more eslint errors and warnings

* reverting changes for redux/index.js

* fixing merge conflicts with next

* deleting redux/index.ts
2021-06-30 20:52:17 +05:30
Ahmad Abdolsaheb
b3f2c64de8 fix(client): remove algolia and hot keys modules from landing pages (#42394)
* fix(client): remove algolia and hot keys from landing pages

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-06-24 12:50:36 +03:00
Huyen Nguyen
2c16234853 chore: add jest global variables (#42573) 2021-06-20 09:14:42 +02:00
Shaun Hamilton
24be225fa4 feat(client): refactor propTypes to TS types (#42278) 2021-06-03 14:23:46 +03:00
Oliver Eyton-Williams
9be2fb9a10 fix: use lodash-es in the client (#41931) 2021-04-28 16:11:20 -05:00
Michael Parkadze
081f79060d fix(client): update search results links to open in new tab (#41734) 2021-04-12 15:29:01 +07:00
Mrugesh Mohapatra
ad9b1f89d8 fix(api, client): update Gatsby, webpack & related things (#41452)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-03-25 12:13:43 -07:00
Kristofer Koishigawa
1e9dc8cea5 fix: remove algolia indices and urls from translations (#41043) 2021-02-11 00:11:51 +05:30
Oliver Eyton-Williams
fffc0e51ec chore(client): refactor & organise config (#40875) 2021-02-03 15:22:07 +05:30
Kristofer Koishigawa
187e3ec973 feat: update footer links and search indices (#40818) 2021-01-31 12:15:40 +05:30
Nicholas Carrigan (he/him)
58c6c54c67 feat(client): redesigned navigation (#40709)
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2021-01-31 12:15:40 +05:30
Tom
3978c6be28 feat: i18n user interface (#40306)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-01-31 12:15:32 +05:30
Ahmad Abdolsaheb
b2a11dcb72 feat: add back the forum nav item (#40060) 2020-10-22 21:57:41 +05:30
Oliver Eyton-Williams
b9db30f7a1 refactor(client): move jest-dom into setup file 2020-10-12 14:11:52 +02:00
Kristofer Koishigawa
0a0fe2bae5 fix: suppress algolia errors (#39703) 2020-09-27 16:25:11 +05:30
Kristofer Koishigawa
0ccb140f71 fix: up and down hotkeys in search bar (#39529)
This fix prevents whitespace from breaking the up and down hotkeys in the search bar.
2020-09-08 23:43:45 +05:30
Kristofer Koishigawa
75e926810f fix: search bar width (#38693) 2020-04-30 17:40:34 +05:30
Kristofer Koishigawa
54c93aabbb fix: bump number of tutorials to 6,000+ (#38694) 2020-04-30 17:39:41 +05:30
Ashraf Nazar
66cbabda22 fix(search): add borders for list items (#38425)
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
2020-03-26 22:35:34 +05:30
Oliver Eyton-Williams
58bd0b5ce4 chore(tools): add jsx-a11y Eslint plugin (#38438)
* chore(tools): add a11y eslint plugin

* fix: use Gatsby's a11y eslint rules

* fix(search): remove unnecessary mouse listeners
2020-03-26 10:25:47 +05:30
Ashraf Nazar
88e1952478 fix: ESLint warnings in logs 2020-03-21 03:09:38 +05:30
Oliver Eyton-Williams
992ee98cc1 fix: make no-hits result seem non-interactive 2020-02-04 10:56:34 +05:30
Oliver Eyton-Williams
00e0f574df refactor: move no hits case into own component 2020-02-04 10:56:34 +05:30
Kristofer Koishigawa
d29bfcd1e9 fix: adjust styles and search behavior when there are no hits (#38073)
fix search bar to show "No tutorials found" and not redirect to search page without hits. 
change styles to match news.
2020-01-20 10:47:06 +03:00
Kristofer Koishigawa
978bae6716 fix: news search redirects and loading indicator (#38048)
Disable loading indicator and redirect to full news search page url so NGINX no longer redirects to ../news/news/search?query=...
2020-01-13 04:22:27 +05:30
Kristofer Koishigawa
2b5268305a chore(client): add tests for search bar (#37012)
* feat(client): Tests for search bar

* Switched out Enzyme for react-test-renderer, but had to remove a lot of the incompatible tests
2019-10-22 17:01:00 +05:30
Ahmad Abdolsaheb
31d3e5eb3b fix: add nav items (#37339)
* fix: add nav items

* fix: clean up
2019-10-16 23:09:31 +09:00
Ahmad Abdolsaheb
8e07bbb7a0 fix: adjust nav focus (#37318)
* fix: adjust nav focus

* fix: clean up
2019-10-16 03:56:19 +05:30